Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2218752/?format=api
{ "id": 2218752, "url": "http://patchwork.ozlabs.org/api/patches/2218752/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260401202844.673494-7-peterx@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260401202844.673494-7-peterx@redhat.com>", "list_archive_url": null, "date": "2026-04-01T20:28:39", "name": "[06/11] vmstate: Introduce vmstate_save_field_with_vmdesc()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "7a6c5061a88ed85561e9309ab42c43b5243267ac", "submitter": { "id": 67717, "url": "http://patchwork.ozlabs.org/api/people/67717/?format=api", "name": "Peter Xu", "email": "peterx@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260401202844.673494-7-peterx@redhat.com/mbox/", "series": [ { "id": 498385, "url": "http://patchwork.ozlabs.org/api/series/498385/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=498385", "date": "2026-04-01T20:28:34", "name": "vmstate: Implement VMS_ARRAY_OF_POINTER_AUTO_ALLOC", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/498385/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2218752/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2218752/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=HV20oK5O;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=HLNAUBqV;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fmGnr13pFz1yGY\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 02 Apr 2026 07:30:24 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w82BT-0004MF-CX; Wed, 01 Apr 2026 16:29:03 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <peterx@redhat.com>) id 1w82BQ-0004K5-IK\n for qemu-devel@nongnu.org; Wed, 01 Apr 2026 16:29:00 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <peterx@redhat.com>) id 1w82BO-00038x-Nm\n for qemu-devel@nongnu.org; Wed, 01 Apr 2026 16:29:00 -0400", "from mail-qk1-f200.google.com (mail-qk1-f200.google.com\n [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-416-7Iw-8tYtO8ykW3sjTHufqw-1; Wed, 01 Apr 2026 16:28:56 -0400", "by mail-qk1-f200.google.com with SMTP id\n af79cd13be357-8cb6291d95aso87043485a.1\n for <qemu-devel@nongnu.org>; Wed, 01 Apr 2026 13:28:56 -0700 (PDT)", "from x1.com ([142.189.10.167]) by smtp.gmail.com with ESMTPSA id\n af79cd13be357-8d2a548a4efsm68194085a.8.2026.04.01.13.28.53\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 01 Apr 2026 13:28:54 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775075337;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=m4SNb/+dNBoUUecfjmeqDkL3BXGCT5Hf5mgRlSOyVOQ=;\n b=HV20oK5Ohk+iW0gXyIZClyp0mPOfIN2k7GQY06e47cYNO3T4WS+k9UqeU2xuTh1GBCTtV8\n EmSc8tQU/wCZp9XJpIHRdYQv+l9UDoZPC2yMpyuBZWGqLmapUby4Sk+mdS9UvbeIOxFXhU\n uNDfPLoE0dbRbS36VmlXeWwuyl4zOC4=", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1775075335; x=1775680135; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=m4SNb/+dNBoUUecfjmeqDkL3BXGCT5Hf5mgRlSOyVOQ=;\n b=HLNAUBqVUGvq+cNlyCt6ffTxd+0/jFkJc00gYz5J8UaPHFk3/AfwgfKBXV1ErYjH4o\n NjxNOggOqtIErw8bTvfFNBMuaikT8HrrlPfYY4uFiHN+hijXlymxFswO/28Zg5y4+2PT\n MA5HTF4x7yuZ+tvdlBOQRzx/ZzqnJo3JWt6DHR35Aks4M0GACCIu/jg+j6hMD+RQImjg\n R4hem7k1m9l8I7qqx5A0hGfmgGsvLdZHpb15T1/RM4mhOvmikvw95DCUzESA68GBnYz+\n aulMOklp3IHDUOnYfMTTLeh4h8JnbnWUwWjTPZMb1rah0q4hIzNjrSIK8a2V1fA/nhdb\n rQvQ==" ], "X-MC-Unique": "7Iw-8tYtO8ykW3sjTHufqw-1", "X-Mimecast-MFC-AGG-ID": "7Iw-8tYtO8ykW3sjTHufqw_1775075336", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775075335; x=1775680135;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=m4SNb/+dNBoUUecfjmeqDkL3BXGCT5Hf5mgRlSOyVOQ=;\n b=LwFyqVQMvZtRlxLh/SeMPkgl9Fg9hca1XjalBN/UrOOmnn1fYdJwEkWqLFFNw5ZW3u\n 1CIi6P+vKGsxSjTNyCYftnHdsRzCK04JnnkwPJqm36EBbNa2Jp/7DD1MI2Xfmp5SiYG1\n C9INZoaw/4NOXP0gEJ36vPzsEwDyfyRdrEUUdx259duXFPoKrydGGkaGgda8KFcdndsR\n rtOnECFCJiQZ/OCFb21JLhpFSeHORwWp7Mqn++uZO7GCD7tIzGt8R9GO7wMYd6aDKCEq\n Mi1z2+JAPbt3UxAYUtKQNP4fB8WD+UKFlJGnA1shCx1rvrQJkC2WNPzD1SSyTpV0kXiu\n WZ3Q==", "X-Gm-Message-State": "AOJu0Yw295ha5WkkNgr+/HU026UOQ/Zerj4ipMiwcB8gsnfHmOSu+0Gu\n H+b1gM3mmCwYpdnGoUhZvt3uU64U8DCXgczH4oGyEHMRy0UQl5PkWmMp2BBKX1KEq+ynMGk2uwz\n RLv9KcjrXrgxAIXxal5LkG1SfN7nWVxC6S+WlFtW32kKdohHDh8teD7fbxuvFU9XBWtjCtw0c3Z\n t/wVZzazPS/6G9uCSehEJMNG2L8nLzFYPWhrQaQQ==", "X-Gm-Gg": "ATEYQzwMR0xWnudQH0Ey054ay83cuICu35RnAiEgohipQtMs2kiqoH+BcGz+SBkP/iJ\n ChAJp2xhDbSJgzgaqH45Lbb1EsGQN6WpDdxZWw337OKUmmSTzHHWTEPlq6yX3I+wtn28TCrWJQg\n KUBavVxpLLWEuGCoFoifPocEfFImd0JgSv/cEhB/Q2UT+wa/uQsF2gTolMBkXmE+q20jzfhWHPv\n p99gnlcaIbN5c8NW4FL0S80Icpdni5piz14nwswC2Ut8U6tT+2w9MDrxFhACrY3+zzYYl6JNdro\n D2xo5wqlc5yMnU/wI4pNQrj6cRE3kWYMlkZTIMME8a/t5/D4TEBtOwqkOMgCLmlPH83qKaitVno\n 6A+CggwZqioWkG/7N/YauzMWRb+reppEpEyjeG4HPqrI=", "X-Received": [ "by 2002:a05:620a:4441:b0:8cf:c75d:2a07 with SMTP id\n af79cd13be357-8d1b5ae65c1mr786478185a.16.1775075335414;\n Wed, 01 Apr 2026 13:28:55 -0700 (PDT)", "by 2002:a05:620a:4441:b0:8cf:c75d:2a07 with SMTP id\n af79cd13be357-8d1b5ae65c1mr786473485a.16.1775075334738;\n Wed, 01 Apr 2026 13:28:54 -0700 (PDT)" ], "From": "Peter Xu <peterx@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "Juraj Marcin <jmarcin@redhat.com>,\n Alexander Mikhalitsyn <alexander@mihalicyn.com>,\n Fabiano Rosas <farosas@suse.de>, Peter Xu <peterx@redhat.com>,\n Alexander Mikhalitsyn <aleksandr.mikhalitsyn@futurfusion.io>", "Subject": "[PATCH 06/11] vmstate: Introduce vmstate_save_field_with_vmdesc()", "Date": "Wed, 1 Apr 2026 16:28:39 -0400", "Message-ID": "<20260401202844.673494-7-peterx@redhat.com>", "X-Mailer": "git-send-email 2.50.1", "In-Reply-To": "<20260401202844.673494-1-peterx@redhat.com>", "References": "<20260401202844.673494-1-peterx@redhat.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=170.10.133.124; envelope-from=peterx@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-6", "X-Spam_score": "-0.7", "X-Spam_bar": "/", "X-Spam_report": "(-0.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.01,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=1, RCVD_IN_VALIDITY_RPBL_BLOCKED=1,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Introduce a helper to do both the JSON blob generations and save vmstate.\nThis further shrinks the function a bit. More importantly, we'll need to\nsave two fields in one loop very soon in the future with the JSON blob.\n\nReviewed-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@futurfusion.io>\nReviewed-by: Fabiano Rosas <farosas@suse.de>\nSigned-off-by: Peter Xu <peterx@redhat.com>\n---\n migration/vmstate.c | 45 ++++++++++++++++++++++++++++++++-------------\n 1 file changed, 32 insertions(+), 13 deletions(-)", "diff": "diff --git a/migration/vmstate.c b/migration/vmstate.c\nindex 05badef42f..b274204e66 100644\n--- a/migration/vmstate.c\n+++ b/migration/vmstate.c\n@@ -514,6 +514,35 @@ static bool vmstate_save_field(QEMUFile *f, void *pv, size_t size,\n return true;\n }\n \n+/*\n+ * Save a whole VMSD field, including its JSON blob separately when @vmdesc\n+ * is specified.\n+ */\n+static inline bool\n+vmstate_save_field_with_vmdesc(QEMUFile *f, void *pv, size_t size,\n+ const VMStateDescription *vmsd,\n+ const VMStateField *field, JSONWriter *vmdesc,\n+ int i, int max, Error **errp)\n+{\n+ uint64_t old_offset, written_bytes;\n+ bool ok;\n+\n+ vmsd_desc_field_start(vmsd, vmdesc, field, i, max);\n+\n+ old_offset = qemu_file_transferred(f);\n+ ok = vmstate_save_field(f, pv, size, field, vmdesc, errp);\n+ written_bytes = qemu_file_transferred(f) - old_offset;\n+\n+ vmsd_desc_field_end(vmsd, vmdesc, field, written_bytes);\n+\n+ if (!ok) {\n+ error_prepend(errp, \"Save of field %s/%s failed: \",\n+ vmsd->name, field->name);\n+ }\n+\n+ return ok;\n+}\n+\n static bool vmstate_save_vmsd_v(QEMUFile *f, const VMStateDescription *vmsd,\n void *opaque, JSONWriter *vmdesc,\n int version_id, Error **errp)\n@@ -542,7 +571,6 @@ static bool vmstate_save_vmsd_v(QEMUFile *f, const VMStateDescription *vmsd,\n void *first_elem = opaque + field->offset;\n int i, n_elems = vmstate_n_elems(opaque, field);\n int size = vmstate_size(opaque, field);\n- uint64_t old_offset, written_bytes;\n JSONWriter *vmdesc_loop = vmdesc;\n bool is_prev_null = false;\n \n@@ -559,7 +587,6 @@ static bool vmstate_save_vmsd_v(QEMUFile *f, const VMStateDescription *vmsd,\n /* maximum number of elements to compress in the JSON blob */\n int max_elems = vmsd_can_compress(field) ? (n_elems - i) : 1;\n \n- old_offset = qemu_file_transferred(f);\n if (field->flags & VMS_ARRAY_OF_POINTER) {\n assert(curr_elem);\n curr_elem = *(void **)curr_elem;\n@@ -606,15 +633,9 @@ static bool vmstate_save_vmsd_v(QEMUFile *f, const VMStateDescription *vmsd,\n }\n }\n \n- vmsd_desc_field_start(vmsd, vmdesc_loop, inner_field,\n- i, max_elems);\n-\n- ok = vmstate_save_field(f, curr_elem, size, inner_field,\n- vmdesc_loop, errp);\n-\n- written_bytes = qemu_file_transferred(f) - old_offset;\n- vmsd_desc_field_end(vmsd, vmdesc_loop, inner_field,\n- written_bytes);\n+ ok = vmstate_save_field_with_vmdesc(f, curr_elem, size, vmsd,\n+ inner_field, vmdesc_loop,\n+ i, max_elems, errp);\n \n /* If we used a fake temp field.. free it now */\n if (is_null) {\n@@ -622,8 +643,6 @@ static bool vmstate_save_vmsd_v(QEMUFile *f, const VMStateDescription *vmsd,\n }\n \n if (!ok) {\n- error_prepend(errp, \"Save of field %s/%s failed: \",\n- vmsd->name, field->name);\n goto out;\n }\n \n", "prefixes": [ "06/11" ] }