Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2218750/?format=api
{ "id": 2218750, "url": "http://patchwork.ozlabs.org/api/patches/2218750/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260401202844.673494-12-peterx@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260401202844.673494-12-peterx@redhat.com>", "list_archive_url": null, "date": "2026-04-01T20:28:44", "name": "[11/11] tests/unit/test-vmstate: add tests for VMS_ARRAY_OF_POINTER_AUTO_ALLOC", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "89bcfc78366e09990fcb9c2e4850a62762436102", "submitter": { "id": 67717, "url": "http://patchwork.ozlabs.org/api/people/67717/?format=api", "name": "Peter Xu", "email": "peterx@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260401202844.673494-12-peterx@redhat.com/mbox/", "series": [ { "id": 498385, "url": "http://patchwork.ozlabs.org/api/series/498385/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=498385", "date": "2026-04-01T20:28:34", "name": "vmstate: Implement VMS_ARRAY_OF_POINTER_AUTO_ALLOC", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/498385/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2218750/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2218750/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=cJNdBuz3;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=aUa9Rn6G;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fmGnp1hFTz1yHK\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 02 Apr 2026 07:30:22 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w82BX-0004OC-0k; Wed, 01 Apr 2026 16:29:07 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <peterx@redhat.com>) id 1w82BV-0004NB-1v\n for qemu-devel@nongnu.org; Wed, 01 Apr 2026 16:29:05 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <peterx@redhat.com>) id 1w82BT-00039z-FA\n for qemu-devel@nongnu.org; Wed, 01 Apr 2026 16:29:04 -0400", "from mail-qk1-f200.google.com (mail-qk1-f200.google.com\n [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-582-N5Uq9oryMmeXIIPKhyAFlg-1; Wed, 01 Apr 2026 16:29:01 -0400", "by mail-qk1-f200.google.com with SMTP id\n af79cd13be357-8cd7ea0bb20so59896285a.3\n for <qemu-devel@nongnu.org>; Wed, 01 Apr 2026 13:29:01 -0700 (PDT)", "from x1.com ([142.189.10.167]) by smtp.gmail.com with ESMTPSA id\n af79cd13be357-8d2a548a4efsm68194085a.8.2026.04.01.13.28.59\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 01 Apr 2026 13:28:59 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775075342;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=BTcRRki4RVI+IH0q3dAynZQWyxZQTTE18znN3ItjLD4=;\n b=cJNdBuz3S6is0ruPjvt0Pn+XtAJ72jBZJxFTphrkxe3AnzdPsl6dWLq4qDHKK4h4aW2Ctr\n b+/FIbVah2bG4MTCFPE5qfMVY78Q4y4+o2Cksi9RlhGNj3p6/6MFuXXLUgZu0IYoYp/Vqa\n d4SFxuXdfgX1K2K73LOEc943LFLJ7SI=", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1775075341; x=1775680141; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=BTcRRki4RVI+IH0q3dAynZQWyxZQTTE18znN3ItjLD4=;\n b=aUa9Rn6GgEB9uo7STWAZeliH2WTJUD4MuOu3KtoRlS5dGhz9szVwCeqOqz1U6vH0X9\n 4o582ZHnJtQpZqfzbn6qgXlApwbz9GvhNv8vIVGOgtYzqcdnmd6weVgnWEmYc9RVSmpj\n WatHwSR/iD9OPr8jh0Oc2n7OqSdryvUZPTOXoyXgOMS5evpruCV4siAM4/NL0dMQlcXC\n p5NA4Nu0ViCPp8YA2/MOmUJb8IUvoULZyzQLPa/TZyr5ltwnXDzwdOHSBa69OpxBSm5X\n dcUHulVrK1hDjPSEakDTJg4gue9PjGoqKnpL2ofIW7+Mc87fxEMtacoosKufKJLe3ZAi\n oXSA==" ], "X-MC-Unique": "N5Uq9oryMmeXIIPKhyAFlg-1", "X-Mimecast-MFC-AGG-ID": "N5Uq9oryMmeXIIPKhyAFlg_1775075341", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775075341; x=1775680141;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=BTcRRki4RVI+IH0q3dAynZQWyxZQTTE18znN3ItjLD4=;\n b=pXSfS1JYVbwADf5/5ee8pAXyReJF9CnMUQl/wBlniLz48bZWRt2tNgZ6a1IGgSU0bw\n 5ettbzEivDrAcNJ/pi2ft4yCxVwYQ9hUMZ1qAKWF6kGsqDd6rfeUSjM1I8aWsNaxyI/l\n iRH6Lh5jGpbn7rn4rksutnRAMIfdoqK3ZNml6F8I1Xonekf58gvrl9L+X96qZHS9ZxhF\n 1okExlfLqgQlKtrbeJ3250R8HAQTDZCn0+EElZbAdcZkDiRhPsIoKTy5Ki6cQzPV9LHt\n 8YHl1YcetC2tybEeCtTNq+9OUw7z1wmFr8FZpcnccLdFRLw3Oopt2tIOahbgfsh5jJhF\n /SkQ==", "X-Gm-Message-State": "AOJu0Yw9emVwOb0JwYQFYiod+zJtKkMaXNe6yybF7mSgvleUI4G1cxHJ\n 67FRc8VxJo/56+VZxu9o/gufume5/1Wehi7GCOKGvhjBdAEhjjLH5PemP0PSQBXcif14HMGygLH\n Mb9Ph9Z8y48rQyBGsBV1ztr6NkdRkfQvPvvEGZDX3xNcW3u1dPpOvfTRFLYnzUAwdwspQSrFMXp\n QaFqM7WDG3aHlVZ1P9VteqkZ2jk4JRZPoEUBOJNQ==", "X-Gm-Gg": "ATEYQzzL6s9dlHJBmI8YMBa4rGxWbCnOYfqhYMX/7NO9qwJNm1X/NgghPL3yAOT58q3\n 9S+pqNhsMy2q/yYqh2t/s+bdVsEqWfKWCCwvZb30BVNnE1aavb/kzoj9Kc4zPBdkj7cIg5Wjiba\n 6jPLw3+A1UP2wZiRY2ToMLshAu71mn8g/GsLNEqZV2c4/ZP30UZhCdgp+VrphtPQybmvAr2VOrV\n Nhc/OChdODzeULLRR5gUY7K8Ho1G55RhBJMal8omBA0mRJztbZPPpMS0VIapJYHYZ4ZpacryRZ4\n AwqbD8dsw/Fhd22zHyl9Ih1uSDZ3bPzD9cE2jN0RXvuKxNtETYFlXtuCyKCAKVfrzEF5jPEKNos\n bqhoo3TOAFw/x39UFsObNj6iU8ndTAZVVMZJ0fMl45Uc=", "X-Received": [ "by 2002:a05:620a:4103:b0:8cd:8f94:259b with SMTP id\n af79cd13be357-8d1b5b876f6mr760034185a.33.1775075340676;\n Wed, 01 Apr 2026 13:29:00 -0700 (PDT)", "by 2002:a05:620a:4103:b0:8cd:8f94:259b with SMTP id\n af79cd13be357-8d1b5b876f6mr760027585a.33.1775075339906;\n Wed, 01 Apr 2026 13:28:59 -0700 (PDT)" ], "From": "Peter Xu <peterx@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "Juraj Marcin <jmarcin@redhat.com>,\n Alexander Mikhalitsyn <alexander@mihalicyn.com>,\n Fabiano Rosas <farosas@suse.de>, Peter Xu <peterx@redhat.com>,\n Alexander Mikhalitsyn <aleksandr.mikhalitsyn@futurfusion.io>", "Subject": "[PATCH 11/11] tests/unit/test-vmstate: add tests for\n VMS_ARRAY_OF_POINTER_AUTO_ALLOC", "Date": "Wed, 1 Apr 2026 16:28:44 -0400", "Message-ID": "<20260401202844.673494-12-peterx@redhat.com>", "X-Mailer": "git-send-email 2.50.1", "In-Reply-To": "<20260401202844.673494-1-peterx@redhat.com>", "References": "<20260401202844.673494-1-peterx@redhat.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=170.10.133.124; envelope-from=peterx@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-6", "X-Spam_score": "-0.7", "X-Spam_bar": "/", "X-Spam_report": "(-0.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.01,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=1, RCVD_IN_VALIDITY_RPBL_BLOCKED=1,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@futurfusion.io>\n\nAdd tests for VMSTATE_VARRAY_OF_POINTER_TO_STRUCT_UINT32_ALLOC.\n\nSigned-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@futurfusion.io>\n[peterx: Removed two tests due to macro not used, rebase, fix warning]\nSigned-off-by: Peter Xu <peterx@redhat.com>\n---\n tests/unit/test-vmstate.c | 86 +++++++++++++++++++++++++++++++++++++++\n 1 file changed, 86 insertions(+)", "diff": "diff --git a/tests/unit/test-vmstate.c b/tests/unit/test-vmstate.c\nindex dae15786aa..df1fb4c778 100644\n--- a/tests/unit/test-vmstate.c\n+++ b/tests/unit/test-vmstate.c\n@@ -702,6 +702,88 @@ static void test_arr_ptr_prim_0_load(void)\n }\n }\n \n+static uint8_t wire_arr_ptr_with_nulls[] = {\n+ VMS_MARKER_PTR_VALID,\n+ 0x00, 0x00, 0x00, 0x00,\n+ VMS_MARKER_PTR_NULL,\n+ VMS_MARKER_PTR_VALID,\n+ 0x00, 0x00, 0x00, 0x02,\n+ VMS_MARKER_PTR_VALID,\n+ 0x00, 0x00, 0x00, 0x03,\n+ QEMU_VM_EOF\n+};\n+\n+typedef struct {\n+ uint32_t ar_items_num;\n+ TestStructTriv **ar;\n+} TestVArrayOfPtrToStuctWithNULLs;\n+\n+const VMStateDescription vmsd_arps_with_nulls = {\n+ .name = \"test/arps_with_nulls\",\n+ .version_id = 1,\n+ .minimum_version_id = 1,\n+ .fields = (const VMStateField[]) {\n+ VMSTATE_VARRAY_OF_POINTER_TO_STRUCT_UINT32_ALLOC(\n+ ar, TestVArrayOfPtrToStuctWithNULLs, ar_items_num,\n+ 0, vmsd_tst, TestStructTriv),\n+ VMSTATE_END_OF_LIST()\n+ }\n+};\n+\n+static void test_arr_ptr_nulls_str_save(void)\n+{\n+ TestStructTriv ar[AR_SIZE] = { {.i = 0}, {.i = 1}, {.i = 2}, {.i = 3} };\n+ TestVArrayOfPtrToStuctWithNULLs sample = {};\n+ int idx;\n+\n+ sample.ar_items_num = AR_SIZE;\n+ sample.ar = g_new0(TestStructTriv*, sample.ar_items_num);\n+ sample.ar[0] = g_new0(TestStructTriv, 1);\n+ *sample.ar[0] = ar[0];\n+ /* note, sample.ar[1] remains NULL */\n+ sample.ar[2] = g_new0(TestStructTriv, 1);\n+ *sample.ar[2] = ar[2];\n+ sample.ar[3] = g_new0(TestStructTriv, 1);\n+ *sample.ar[3] = ar[3];\n+\n+ save_vmstate(&vmsd_arps_with_nulls, &sample);\n+ compare_vmstate(wire_arr_ptr_with_nulls, sizeof(wire_arr_ptr_with_nulls));\n+\n+ for (idx = 0; idx < AR_SIZE; ++idx) {\n+ g_free(sample.ar[idx]);\n+ }\n+ g_free(sample.ar);\n+}\n+\n+static void test_arr_ptr_nulls_str_load(void)\n+{\n+ TestStructTriv ar_gt[AR_SIZE] = {{.i = 0}, {.i = 0}, {.i = 2}, {.i = 3} };\n+ TestVArrayOfPtrToStuctWithNULLs obj = {};\n+ int idx;\n+\n+ obj.ar_items_num = AR_SIZE;\n+ obj.ar = g_new0(TestStructTriv*, obj.ar_items_num);\n+\n+ save_buffer(wire_arr_ptr_with_nulls, sizeof(wire_arr_ptr_with_nulls));\n+ SUCCESS(load_vmstate_one(\n+ &vmsd_arps_with_nulls, &obj, 1,\n+ wire_arr_ptr_with_nulls, sizeof(wire_arr_ptr_with_nulls)));\n+\n+ for (idx = 0; idx < AR_SIZE; ++idx) {\n+ if (idx == 1) {\n+ g_assert_cmpint((uintptr_t)(obj.ar[idx]), ==, 0);\n+ } else {\n+ /* compare the target array ar with the ground truth array ar_gt */\n+ g_assert_cmpint(ar_gt[idx].i, ==, obj.ar[idx]->i);\n+ }\n+ }\n+\n+ for (idx = 0; idx < AR_SIZE; ++idx) {\n+ g_free(obj.ar[idx]);\n+ }\n+ g_free(obj.ar);\n+}\n+\n /* test QTAILQ migration */\n typedef struct TestQtailqElement TestQtailqElement;\n \n@@ -1568,6 +1650,10 @@ int main(int argc, char **argv)\n test_arr_ptr_prim_0_save);\n g_test_add_func(\"/vmstate/array/ptr/prim/0/load\",\n test_arr_ptr_prim_0_load);\n+ g_test_add_func(\"/vmstate/array/ptr-nulls/str/save\",\n+ test_arr_ptr_nulls_str_save);\n+ g_test_add_func(\"/vmstate/array/ptr-nulls/str/load\",\n+ test_arr_ptr_nulls_str_load);\n g_test_add_func(\"/vmstate/qtailq/save/saveq\", test_save_q);\n g_test_add_func(\"/vmstate/qtailq/load/loadq\", test_load_q);\n g_test_add_func(\"/vmstate/gtree/save/savedomain\", test_gtree_save_domain);\n", "prefixes": [ "11/11" ] }