Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2218745/?format=api
{ "id": 2218745, "url": "http://patchwork.ozlabs.org/api/patches/2218745/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260401202844.673494-5-peterx@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260401202844.673494-5-peterx@redhat.com>", "list_archive_url": null, "date": "2026-04-01T20:28:37", "name": "[04/11] vmstate: Update max_elems early and check field compressable once", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "9d2e2d8f978c730cd92652a0eed658edc0a02cf0", "submitter": { "id": 67717, "url": "http://patchwork.ozlabs.org/api/people/67717/?format=api", "name": "Peter Xu", "email": "peterx@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260401202844.673494-5-peterx@redhat.com/mbox/", "series": [ { "id": 498385, "url": "http://patchwork.ozlabs.org/api/series/498385/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=498385", "date": "2026-04-01T20:28:34", "name": "vmstate: Implement VMS_ARRAY_OF_POINTER_AUTO_ALLOC", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/498385/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2218745/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2218745/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=BrglIskr;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=nVniMVfh;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fmGnP0Gjkz1xtJ\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 02 Apr 2026 07:30:00 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w82BS-0004LW-EX; Wed, 01 Apr 2026 16:29:02 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <peterx@redhat.com>) id 1w82BN-0004Iq-7n\n for qemu-devel@nongnu.org; Wed, 01 Apr 2026 16:28:58 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <peterx@redhat.com>) id 1w82BL-00038L-L3\n for qemu-devel@nongnu.org; Wed, 01 Apr 2026 16:28:56 -0400", "from mail-qk1-f197.google.com (mail-qk1-f197.google.com\n [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-561-v5t523EJNPyF4FZnUh1riw-1; Wed, 01 Apr 2026 16:28:53 -0400", "by mail-qk1-f197.google.com with SMTP id\n af79cd13be357-8cd7c4ab845so46079685a.1\n for <qemu-devel@nongnu.org>; Wed, 01 Apr 2026 13:28:53 -0700 (PDT)", "from x1.com ([142.189.10.167]) by smtp.gmail.com with ESMTPSA id\n af79cd13be357-8d2a548a4efsm68194085a.8.2026.04.01.13.28.50\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 01 Apr 2026 13:28:51 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775075334;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=IOjsPMjPyjOOz0u/cqBKLuI7wgBm8OXlBH7YynEYGUs=;\n b=BrglIskrPlem+KXA7YI8Z5hB7vqkedFQxk4EkUViWRXTkLPRAqsjNve9s9glti0IeGDNtD\n r0wZGmM1ZX68KhK2X5b8KA5CNQH5QbqA9UAMYtEzM/gqESgbyCov/b0QZqkWA7Izw846dN\n q1VxQJfB7siL/hWXSX+NHfB67l6QEo4=", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1775075332; x=1775680132; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=IOjsPMjPyjOOz0u/cqBKLuI7wgBm8OXlBH7YynEYGUs=;\n b=nVniMVfhIEW+OlLuxUfRc5GDXv8FRi6KmO51EoBibumEeAoCui2wGyokv2KLa1SGm3\n IJlphZ9zbq6CrwHPETkcDfSBRGmnEjQYCxqYCTv+nh40LgpwVaR6Gj3sgweq6FFrIWyQ\n 2I8ENmhqHzwarrb1IT/VwxqkFDKwE0g74cHRInxNpzEN1zqjdot0ktZk5z9q1ZZ2y4d5\n xOtq4MVs/RZu/8jDB48IXlZAOIxhfgqYiO23Mf5ot7eT3xlLpvEGLrIMwJ7I7T5kxPk4\n f+Uf8C9L2FE29Jwe5pOrMtjZE02EZdZPcyTHm7OlOaVD6mJ4OsVdDX/ozTHswMurReCX\n BJmg==" ], "X-MC-Unique": "v5t523EJNPyF4FZnUh1riw-1", "X-Mimecast-MFC-AGG-ID": "v5t523EJNPyF4FZnUh1riw_1775075333", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775075332; x=1775680132;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=IOjsPMjPyjOOz0u/cqBKLuI7wgBm8OXlBH7YynEYGUs=;\n b=FjYChUxmePp0642ch49Fl+64r4rFfHvsyWDY0ur1EArDnlXHB7rDYH9HC4ss3wS8+L\n 2wzHoLaM6Woaqc5EpuTF61dZVtU5NI5M9j/NgezbYqqNZH4XHbP4eW2vL/S32n36ZjYz\n cQyXhQGmM/cmfDagtXKWCguppg8yxIXtv2pk2US5DvRFBc8udj/fER3yTvLWYdMLmbHc\n CgBI4LjRZU1iYshkLnVtU5JP7QsG3Uv7eiQHLKoOb+O1vLdkkdmeTC2QHX/KLLh1yaQW\n w/N34QXMX6Ts6uCYTgEYrIV3db1bHXvx+bH7AFhBVA9VnsB8OHdXA6C1rEN+pi5F91WK\n d3gw==", "X-Gm-Message-State": "AOJu0YxOLWlwWTAUO5wDObADPuqI3kD4SFY8xaGb7c8VVeFoQma9oLni\n 8cOuucTw4OCAAgLR9iq1W4sLtBey2WUDtea296xv9kQxNVrdxkpqQvlWSxKRuKw12S7ueuOx5To\n 14FXmoXi7voguzvNt0GpHGGAu3dIfFGsyfRRUOycUCEFm43gfZsJdX1LrUTSzcLjco1BW3VuUjT\n QKfNoyAS+tRgMPVyr+ZaFSIUHl1OnouFThgLiVLw==", "X-Gm-Gg": "ATEYQzxlv4GCemclOiRxUUAdRygDtnC0sZ0wy3JbJZ9igNH7wwou9Gu9P3dFI/0cLyk\n fBYlQv7ZpppLIBgZ9Fnav0GJ5Q6p577n3yamDlVGPZAdy8Ql4H7wHnshmviqLFfCivj5KTzSQLL\n m2MbaVQLRI7hY+kn8u3N991B+9uNEy0482tApV/qbu5g4knb7kwd3LZphjapK1P7ph2S+jPzqLL\n 7MX3fXayoscItalvdpQGq1yeUpBSsVhM6PINyIsECo5o0b76K61L9Oi5gGNjKsa4K4BFixfOIVx\n ewXOSSKORpXRAwhfiIHjJAk1sIn8AxFbk4l+NXFI5irY961sfZDUlB832sxpQ+0ctjr3bPE6SGN\n czpeItyCx6mXBWk5wXnYzxdEpeFHAxFzc4jYIEfdCqbw=", "X-Received": [ "by 2002:a05:620a:2844:b0:8cf:e0fe:f227 with SMTP id\n af79cd13be357-8d2aa3b805fmr145170285a.26.1775075332419;\n Wed, 01 Apr 2026 13:28:52 -0700 (PDT)", "by 2002:a05:620a:2844:b0:8cf:e0fe:f227 with SMTP id\n af79cd13be357-8d2aa3b805fmr145165085a.26.1775075331771;\n Wed, 01 Apr 2026 13:28:51 -0700 (PDT)" ], "From": "Peter Xu <peterx@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "Juraj Marcin <jmarcin@redhat.com>,\n Alexander Mikhalitsyn <alexander@mihalicyn.com>,\n Fabiano Rosas <farosas@suse.de>, Peter Xu <peterx@redhat.com>,\n Alexander Mikhalitsyn <aleksandr.mikhalitsyn@futurfusion.io>", "Subject": "[PATCH 04/11] vmstate: Update max_elems early and check field\n compressable once", "Date": "Wed, 1 Apr 2026 16:28:37 -0400", "Message-ID": "<20260401202844.673494-5-peterx@redhat.com>", "X-Mailer": "git-send-email 2.50.1", "In-Reply-To": "<20260401202844.673494-1-peterx@redhat.com>", "References": "<20260401202844.673494-1-peterx@redhat.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=170.10.129.124; envelope-from=peterx@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-6", "X-Spam_score": "-0.7", "X-Spam_bar": "/", "X-Spam_report": "(-0.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=1, RCVD_IN_VALIDITY_RPBL_BLOCKED=1,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "QEMU has a trick in vmstate_save_vmsd_v(), where it will try to compress\nmultiple JSON entries into one with a count to avoid duplicated entries.\n\nThat only applies to the cases where vmsd_can_compress() should return\ntrue. For example, vmsd_desc_field_start() later (who will take the\nupdated max_elems as the last parameter) will ignore the value passed in\nwhen vmsd_can_compress() returns false.\n\nDo that check once at the start of loop, and use it to update max_elems, so\nthat max_elems keeps 1 for uncompressable VMSD fields, which is more\nstraightforward.\n\nThis also paves way to make this counter work for ptr marker VMSD fields\ntoo.\n\nNo functional change intended in this patch alone.\n\nReviewed-by: Fabiano Rosas <farosas@suse.de>\nReviewed-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@futurfusion.io>\nSigned-off-by: Peter Xu <peterx@redhat.com>\n---\n migration/vmstate.c | 8 +++++---\n 1 file changed, 5 insertions(+), 3 deletions(-)", "diff": "diff --git a/migration/vmstate.c b/migration/vmstate.c\nindex e29a8c3f49..05badef42f 100644\n--- a/migration/vmstate.c\n+++ b/migration/vmstate.c\n@@ -556,7 +556,8 @@ static bool vmstate_save_vmsd_v(QEMUFile *f, const VMStateDescription *vmsd,\n void *curr_elem = first_elem + size * i;\n const VMStateField *inner_field;\n bool is_null;\n- int max_elems = n_elems - i;\n+ /* maximum number of elements to compress in the JSON blob */\n+ int max_elems = vmsd_can_compress(field) ? (n_elems - i) : 1;\n \n old_offset = qemu_file_transferred(f);\n if (field->flags & VMS_ARRAY_OF_POINTER) {\n@@ -587,7 +588,8 @@ static bool vmstate_save_vmsd_v(QEMUFile *f, const VMStateDescription *vmsd,\n * vs. nullptr). Search ahead for the next null/non-null element\n * and start a new compressed array if found.\n */\n- if (vmdesc && (field->flags & VMS_ARRAY_OF_POINTER) &&\n+ if (vmdesc && max_elems > 1 &&\n+ (field->flags & VMS_ARRAY_OF_POINTER) &&\n is_null != is_prev_null) {\n \n is_prev_null = is_null;\n@@ -626,7 +628,7 @@ static bool vmstate_save_vmsd_v(QEMUFile *f, const VMStateDescription *vmsd,\n }\n \n /* Compressed arrays only care about the first element */\n- if (vmdesc_loop && vmsd_can_compress(field)) {\n+ if (vmdesc_loop && max_elems > 1) {\n vmdesc_loop = NULL;\n }\n }\n", "prefixes": [ "04/11" ] }