Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2218742/?format=api
{ "id": 2218742, "url": "http://patchwork.ozlabs.org/api/patches/2218742/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260401202844.673494-2-peterx@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260401202844.673494-2-peterx@redhat.com>", "list_archive_url": null, "date": "2026-04-01T20:28:34", "name": "[01/11] vmstate: Pass in struct itself for VMSTATE_ARRAY_OF_POINTER", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "e1d3cd2ffb0146005bb869c6e17387c0d0bf2642", "submitter": { "id": 67717, "url": "http://patchwork.ozlabs.org/api/people/67717/?format=api", "name": "Peter Xu", "email": "peterx@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260401202844.673494-2-peterx@redhat.com/mbox/", "series": [ { "id": 498385, "url": "http://patchwork.ozlabs.org/api/series/498385/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=498385", "date": "2026-04-01T20:28:34", "name": "vmstate: Implement VMS_ARRAY_OF_POINTER_AUTO_ALLOC", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/498385/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2218742/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2218742/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=WAXYEqfx;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=LzIQOCW0;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fmGmq4m14z1xtJ\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 02 Apr 2026 07:29:31 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w82BM-0004Ij-SU; Wed, 01 Apr 2026 16:28:57 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <peterx@redhat.com>) id 1w82BL-0004IF-8x\n for qemu-devel@nongnu.org; Wed, 01 Apr 2026 16:28:55 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <peterx@redhat.com>) id 1w82BI-00037d-SX\n for qemu-devel@nongnu.org; Wed, 01 Apr 2026 16:28:55 -0400", "from mail-qk1-f198.google.com (mail-qk1-f198.google.com\n [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-369-r6_3a1X9MvCFWx1yetxmMQ-1; Wed, 01 Apr 2026 16:28:49 -0400", "by mail-qk1-f198.google.com with SMTP id\n af79cd13be357-8cfc575fa15so81095785a.2\n for <qemu-devel@nongnu.org>; Wed, 01 Apr 2026 13:28:49 -0700 (PDT)", "from x1.com ([142.189.10.167]) by smtp.gmail.com with ESMTPSA id\n af79cd13be357-8d2a548a4efsm68194085a.8.2026.04.01.13.28.46\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 01 Apr 2026 13:28:46 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775075330;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=kb2EMKRNvdGGvafy+iD9MxCie+cNqjcod0U6cR8fsMU=;\n b=WAXYEqfxt+fXMFD5e7Qbuy2WTbBpawK9CFixg/NP2cwYiC50y9Hc/lh0zr86C8IaHT8mFm\n LFKtinuonJ9KKKojYnlij3W+JiormaUJmwTibzux5Tt8LMMN5xLJwWq0+nW/Pnlu0UEkT2\n mK/i+y3nQkO/9I5xpxgPPsT3Ml7OgN8=", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1775075328; x=1775680128; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=kb2EMKRNvdGGvafy+iD9MxCie+cNqjcod0U6cR8fsMU=;\n b=LzIQOCW0SuWXVoljHadEzaXPLnn4rYYvI2VeNK9mJiB/NJ1Uru3K6iNqQ1Inn54pW1\n /SBb6h+1ii/hgqTEdVSO1mJoRJGJgJEoCXsqlcAgL2YnEFuqAvnUch6oKlx0WYfOh+iE\n EZ3fi8pCoUDfb4+xsg2c0B5j7uE2liv2NgEYt9RQ1NVS1tVqVIPWB05536qlZAInyQ9v\n 1tegFsC5Z/c5VD6qWksSl3Wd0Byb5OxwrRCYfqzCTWAcu+VYNUwV7lGbw1Facz0xGcZT\n 28hwH3CBOZGPh8IMVCP09IZCBTcPbC9evzKIzIHUp1raBJJaaVRA44NB+HvBzskdrI9Y\n +l1g==" ], "X-MC-Unique": "r6_3a1X9MvCFWx1yetxmMQ-1", "X-Mimecast-MFC-AGG-ID": "r6_3a1X9MvCFWx1yetxmMQ_1775075329", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775075328; x=1775680128;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=kb2EMKRNvdGGvafy+iD9MxCie+cNqjcod0U6cR8fsMU=;\n b=igHT8pPcb+rg1KgQMCWD4CbfAMCBLFX7TJabMAO+oSFbdYNAQHrycAw9jwfBLfpie4\n HCmErjJU8xe0iPXJfnQufPWLOxuGGdgD76Rd79eCVcYTYaqQgbsddxYGfa0zfJzpW/Rx\n 7gRN4Ks31+NWnKd2gsC8dM7f14Sx8hfrfygd49Sm5tBxYb9+8qi9bCixxHWadmaix5Xh\n kMYPgFWYe7uMsz6Ebtu8KCe0ifrhs8LzKqMVDHRWmURHyXfeKf6CqT2BlmfxHgYgVbvd\n 7PCOaPw4RmGKCzrB1pBT3TeDFQqhhmo8p3Gzb4klNBSosmP7qMqu7dWza0LcEhO8JQM3\n ZvJw==", "X-Gm-Message-State": "AOJu0YxZCVrZ8Bwbw9Ziuac0NG2QUNFxcYFcqEmIc8KSO3HfiB3Vx7S1\n XXG4qq3MQ9VQivpb30crEGb3m18WbHbkcnVtZdu8po7KDvvGxpLDeZUUdlC+Lhs10ew+sPHOMi6\n 4iUe+b90/55vud9oHxnTXkmTkC3LzZEgtVg+tNHyX/1Cb6dHRCmxgh7bruna5kluXNVtXg4fWqY\n zPAI5kGemcvEVy0A+gQhB5AHViLeVYnw/I1bViRw==", "X-Gm-Gg": "ATEYQzyby4+cbEIS2gBZfGo1KN4ExBVaKmKElm+Zjdxzsm5Z7EhJgHKr+p1fysl85x2\n wMx7BKDWCqclYuBvEHeJz9hC4h9dB2TWu903729ncFuu6ckTBlodaZw2mtEPactLJHIMJSg7Nb1\n xFU9/2+L9KQkcEKOADFJyLliRMM60c1QAvwR3rH1+w5O9PWubjalPcsumhUSBhygzuVe7UGtoWU\n N/faJX3EJ2ahsSQEmJK63h9K4sIccr7VhstFzBVfdlC3v/pijqfln1+f3MtKcE+oigxnKeRO3tb\n 3YoMVNyZ7MDOjcDAGy/wl9Px0izu/vhU1uibsHPDOHjNvMFE8S1v74Tw45JkfyfLfGE8v+jKW2Z\n m1VNtpAzCNvvPI1iVcGnZr3fYvUU2LsVcvYoiOBFRN+I=", "X-Received": [ "by 2002:a05:620a:2845:b0:8cf:b7c2:fd20 with SMTP id\n af79cd13be357-8d1b5aac057mr736321285a.11.1775075327841;\n Wed, 01 Apr 2026 13:28:47 -0700 (PDT)", "by 2002:a05:620a:2845:b0:8cf:b7c2:fd20 with SMTP id\n af79cd13be357-8d1b5aac057mr736317485a.11.1775075327295;\n Wed, 01 Apr 2026 13:28:47 -0700 (PDT)" ], "From": "Peter Xu <peterx@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "Juraj Marcin <jmarcin@redhat.com>,\n Alexander Mikhalitsyn <alexander@mihalicyn.com>,\n Fabiano Rosas <farosas@suse.de>, Peter Xu <peterx@redhat.com>,\n Alexander Mikhalitsyn <aleksandr.mikhalitsyn@futurfusion.io>, =?utf-8?q?Phi?=\n\t=?utf-8?q?lippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>", "Subject": "[PATCH 01/11] vmstate: Pass in struct itself for\n VMSTATE_ARRAY_OF_POINTER", "Date": "Wed, 1 Apr 2026 16:28:34 -0400", "Message-ID": "<20260401202844.673494-2-peterx@redhat.com>", "X-Mailer": "git-send-email 2.50.1", "In-Reply-To": "<20260401202844.673494-1-peterx@redhat.com>", "References": "<20260401202844.673494-1-peterx@redhat.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=170.10.129.124; envelope-from=peterx@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-6", "X-Spam_score": "-0.7", "X-Spam_bar": "/", "X-Spam_report": "(-0.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=1, RCVD_IN_VALIDITY_RPBL_BLOCKED=1,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Passing in a pointer almost never helps. Convert it to pass in struct for\nfurther refactoring on VMS_ARRAY_OF_POINTER.\n\nReviewed-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@futurfusion.io>\nReviewed-by: Fabiano Rosas <farosas@suse.de>\nReviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>\nSigned-off-by: Peter Xu <peterx@redhat.com>\n---\n include/migration/vmstate.h | 6 +++---\n tests/unit/test-vmstate.c | 2 +-\n roms/seabios-hppa | 2 +-\n 3 files changed, 5 insertions(+), 5 deletions(-)", "diff": "diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h\nindex d4a39aa794..d4880e75c2 100644\n--- a/include/migration/vmstate.h\n+++ b/include/migration/vmstate.h\n@@ -547,9 +547,9 @@ extern const VMStateInfo vmstate_info_qlist;\n .version_id = (_version), \\\n .num = (_num), \\\n .info = &(_info), \\\n- .size = sizeof(_type), \\\n+ .size = sizeof(_type *), \\\n .flags = VMS_ARRAY|VMS_ARRAY_OF_POINTER, \\\n- .offset = vmstate_offset_array(_state, _field, _type, _num), \\\n+ .offset = vmstate_offset_array(_state, _field, _type *, _num), \\\n }\n \n #define VMSTATE_ARRAY_OF_POINTER_TO_STRUCT(_f, _s, _n, _v, _vmsd, _type) { \\\n@@ -1093,7 +1093,7 @@ extern const VMStateInfo vmstate_info_qlist;\n VMSTATE_TIMER_PTR_V(_f, _s, 0)\n \n #define VMSTATE_TIMER_PTR_ARRAY(_f, _s, _n) \\\n- VMSTATE_ARRAY_OF_POINTER(_f, _s, _n, 0, vmstate_info_timer, QEMUTimer *)\n+ VMSTATE_ARRAY_OF_POINTER(_f, _s, _n, 0, vmstate_info_timer, QEMUTimer)\n \n #define VMSTATE_TIMER_TEST(_f, _s, _test) \\\n VMSTATE_SINGLE_TEST(_f, _s, _test, 0, vmstate_info_timer, QEMUTimer)\ndiff --git a/tests/unit/test-vmstate.c b/tests/unit/test-vmstate.c\nindex cadbab3c5e..6a42cc1a4e 100644\n--- a/tests/unit/test-vmstate.c\n+++ b/tests/unit/test-vmstate.c\n@@ -668,7 +668,7 @@ const VMStateDescription vmsd_arpp = {\n .minimum_version_id = 1,\n .fields = (const VMStateField[]) {\n VMSTATE_ARRAY_OF_POINTER(ar, TestArrayOfPtrToInt,\n- AR_SIZE, 0, vmstate_info_int32, int32_t*),\n+ AR_SIZE, 0, vmstate_info_int32, int32_t),\n VMSTATE_END_OF_LIST()\n }\n };\ndiff --git a/roms/seabios-hppa b/roms/seabios-hppa\nindex cf3a472f4d..1a8ada1fb7 160000\n--- a/roms/seabios-hppa\n+++ b/roms/seabios-hppa\n@@ -1 +1 @@\n-Subproject commit cf3a472f4ddea30d2d483a8ba4b005505f0dabb3\n+Subproject commit 1a8ada1fb70643172e251aacbac673c9ecda99e9\n", "prefixes": [ "01/11" ] }