Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2218545/?format=api
{ "id": 2218545, "url": "http://patchwork.ozlabs.org/api/patches/2218545/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openvswitch/patch/f718486b7f0108a965c96c6a3b56d502a5248603.1775044381.git.echaudro@redhat.com/", "project": { "id": 47, "url": "http://patchwork.ozlabs.org/api/projects/47/?format=api", "name": "Open vSwitch", "link_name": "openvswitch", "list_id": "ovs-dev.openvswitch.org", "list_email": "ovs-dev@openvswitch.org", "web_url": "http://openvswitch.org/", "scm_url": "git@github.com:openvswitch/ovs.git", "webscm_url": "https://github.com/openvswitch/ovs", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<f718486b7f0108a965c96c6a3b56d502a5248603.1775044381.git.echaudro@redhat.com>", "list_archive_url": null, "date": "2026-04-01T11:57:22", "name": "[ovs-dev,v2,2/2] dummy-offload: Use pmd_thread_lifecycle APIs for HW simulator.", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "b4b5927d4cd821ce53271d7af7921010a8bc3c0d", "submitter": { "id": 70613, "url": "http://patchwork.ozlabs.org/api/people/70613/?format=api", "name": "Eelco Chaudron", "email": "echaudro@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/openvswitch/patch/f718486b7f0108a965c96c6a3b56d502a5248603.1775044381.git.echaudro@redhat.com/mbox/", "series": [ { "id": 498324, "url": "http://patchwork.ozlabs.org/api/series/498324/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openvswitch/list/?series=498324", "date": "2026-04-01T11:57:20", "name": "dpif-offload: Add PMD thread helpers and hardware offload simulation", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/498324/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2218545/comments/", "check": "fail", "checks": "http://patchwork.ozlabs.org/api/patches/2218545/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<ovs-dev-bounces@openvswitch.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "dev@openvswitch.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "ovs-dev@lists.linuxfoundation.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=H60rU77N;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org)", "smtp4.osuosl.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=H60rU77N", "smtp3.osuosl.org; dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com", "smtp3.osuosl.org;\n dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.a=rsa-sha256 header.s=mimecast20190719 header.b=H60rU77N" ], "Received": [ "from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fm3Qh6QpMz1yFv\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 01 Apr 2026 22:58:04 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 354E54111D;\n\tWed, 1 Apr 2026 11:58:03 +0000 (UTC)", "from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 1MOJpU9PsXUU; Wed, 1 Apr 2026 11:57:59 +0000 (UTC)", "from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56])\n\tby smtp4.osuosl.org (Postfix) with ESMTPS id BC79B41100;\n\tWed, 1 Apr 2026 11:57:58 +0000 (UTC)", "from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id A1EB6C0551;\n\tWed, 1 Apr 2026 11:57:58 +0000 (UTC)", "from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n by lists.linuxfoundation.org (Postfix) with ESMTP id 4AB79C003D\n for <dev@openvswitch.org>; Wed, 1 Apr 2026 11:57:57 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id 3109561109\n for <dev@openvswitch.org>; Wed, 1 Apr 2026 11:57:57 +0000 (UTC)", "from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id oXVuCgYaYAZd for <dev@openvswitch.org>;\n Wed, 1 Apr 2026 11:57:56 +0000 (UTC)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by smtp3.osuosl.org (Postfix) with ESMTPS id 6357F61128\n for <dev@openvswitch.org>; Wed, 1 Apr 2026 11:57:56 +0000 (UTC)", "from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-359-DAhVpMIgPfG4wfvwflvW9A-1; Wed,\n 01 Apr 2026 07:57:52 -0400", "from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id C47F018002D6; Wed, 1 Apr 2026 11:57:50 +0000 (UTC)", "from ebuild.chome (unknown [10.44.50.103])\n by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 573031954102; Wed, 1 Apr 2026 11:57:49 +0000 (UTC)" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.9.56;\n helo=lists.linuxfoundation.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp4.osuosl.org BC79B41100", "OpenDKIM Filter v2.11.0 smtp3.osuosl.org 6357F61128" ], "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=170.10.129.124;\n helo=us-smtp-delivery-124.mimecast.com; envelope-from=echaudro@redhat.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp3.osuosl.org 6357F61128", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775044675;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=Zyov+xf9t+U2+eDO2co4ZpSyIg0IIQdKodhKHVxNLvs=;\n b=H60rU77Na/u9Sqk1Pm80yvBx4g5JZblnWJbOPqJq9+IgGAgozI1A7kLZdb2MbCnyRJtiMh\n 3qkAIYl6o6GATx7QTb9P60g9r8F+MCWX+N9fI4iitZR9scCMTU01hrDOhp24om8c/kjB6V\n xwybQdg4cHFOu7ccyCmygMlOk9bWrjk=", "X-MC-Unique": "DAhVpMIgPfG4wfvwflvW9A-1", "X-Mimecast-MFC-AGG-ID": "DAhVpMIgPfG4wfvwflvW9A_1775044671", "To": "dev@openvswitch.org", "Date": "Wed, 1 Apr 2026 13:57:22 +0200", "Message-ID": "\n <f718486b7f0108a965c96c6a3b56d502a5248603.1775044381.git.echaudro@redhat.com>", "In-Reply-To": "<cover.1775044381.git.echaudro@redhat.com>", "References": "<cover.1775044381.git.echaudro@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.17", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "-EPLANeAc7HL_HxjergGtOTpvJrmVyJfRc9QCRPDu5w_1775044671", "X-Mimecast-Originator": "redhat.com", "Subject": "[ovs-dev] [PATCH v2 2/2] dummy-offload: Use pmd_thread_lifecycle\n APIs for HW simulator.", "X-BeenThere": "ovs-dev@openvswitch.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "<ovs-dev.openvswitch.org>", "List-Unsubscribe": "<https://mail.openvswitch.org/mailman/options/ovs-dev>,\n <mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe>", "List-Archive": "<http://mail.openvswitch.org/pipermail/ovs-dev/>", "List-Post": "<mailto:ovs-dev@openvswitch.org>", "List-Help": "<mailto:ovs-dev-request@openvswitch.org?subject=help>", "List-Subscribe": "<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>,\n <mailto:ovs-dev-request@openvswitch.org?subject=subscribe>", "From": "Eelco Chaudron via dev <ovs-dev@openvswitch.org>", "Reply-To": "Eelco Chaudron <echaudro@redhat.com>", "Cc": "elibr@nvidia.com, i.maximets@ovn.org", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "ovs-dev-bounces@openvswitch.org", "Sender": "\"dev\" <ovs-dev-bounces@openvswitch.org>" }, "content": "Replace per-netdev dummy_netdev_hw_offload_run() callback with\nPMD thread infrastructure. Move offload work processing into\ndummy_pmd_thread_work_cb().\n\nSigned-off-by: Eelco Chaudron <echaudro@redhat.com>\n---\n lib/dpif-offload-dummy.c | 24 +++++++++---------------\n lib/dummy.h | 1 -\n lib/netdev-dummy.c | 1 -\n 3 files changed, 9 insertions(+), 17 deletions(-)", "diff": "diff --git a/lib/dpif-offload-dummy.c b/lib/dpif-offload-dummy.c\nindex 80d6ce67c3..4335b199b9 100644\n--- a/lib/dpif-offload-dummy.c\n+++ b/lib/dpif-offload-dummy.c\n@@ -972,15 +972,16 @@ dummy_netdev_simulate_offload(struct netdev *netdev, struct dp_packet *packet,\n return packet_stolen;\n }\n \n-void\n-dummy_netdev_hw_offload_run(struct netdev *netdev)\n+static void\n+dummy_pmd_thread_work_cb(unsigned core_id OVS_UNUSED, int numa_id OVS_UNUSED,\n+ void *ctx)\n {\n- const struct dpif_offload *offload = ovsrcu_get(\n- const struct dpif_offload *, &netdev->dpif_offload);\n+ const struct dpif_offload *offload = ctx;\n struct dpif_offload_port *port_;\n \n- if (!dpif_offload_enabled() || !offload\n- || strcmp(dpif_offload_type(offload), \"dummy\")) {\n+ COVERAGE_INC(dummy_offload_do_work);\n+\n+ if (!offload) {\n return;\n }\n \n@@ -1023,13 +1024,6 @@ dummy_netdev_hw_offload_run(struct netdev *netdev)\n }\n }\n \n-static void\n-dummy_pmd_thread_work_cb(unsigned core_id OVS_UNUSED, int numa_id OVS_UNUSED,\n- void *ctx OVS_UNUSED)\n-{\n- COVERAGE_INC(dummy_offload_do_work);\n-}\n-\n static void\n dummy_pmd_thread_lifecycle(const struct dpif_offload *dpif_offload,\n bool exit, unsigned core_id, int numa_id,\n@@ -1050,9 +1044,9 @@ dummy_pmd_thread_lifecycle(const struct dpif_offload *dpif_offload,\n ovs_assert(!*callback || *callback == dummy_pmd_thread_work_cb);\n \n if (exit) {\n- free(*ctx);\n+ *ctx = NULL;\n } else {\n- *ctx = *ctx ? *ctx : xstrdup(\"DUMMY_OFFLOAD_WORK\");\n+ *ctx = (void *) dpif_offload;\n *callback = dummy_pmd_thread_work_cb;\n }\n }\ndiff --git a/lib/dummy.h b/lib/dummy.h\nindex f250ae5933..312fbed17c 100644\n--- a/lib/dummy.h\n+++ b/lib/dummy.h\n@@ -49,6 +49,5 @@ void ofpact_dummy_enable(void);\n bool is_dummy_netdev_class(const struct netdev_class *);\n bool dummy_netdev_simulate_offload(struct netdev *, struct dp_packet *,\n int queue_id, struct flow *);\n-void dummy_netdev_hw_offload_run(struct netdev *);\n \n #endif /* dummy.h */\ndiff --git a/lib/netdev-dummy.c b/lib/netdev-dummy.c\nindex d5e8599349..17ff436290 100644\n--- a/lib/netdev-dummy.c\n+++ b/lib/netdev-dummy.c\n@@ -695,7 +695,6 @@ netdev_dummy_run(const struct netdev_class *netdev_class)\n ovs_mutex_lock(&dev->mutex);\n dummy_packet_conn_run(dev);\n ovs_mutex_unlock(&dev->mutex);\n- dummy_netdev_hw_offload_run(&dev->up);\n }\n ovs_mutex_unlock(&dummy_list_mutex);\n }\n", "prefixes": [ "ovs-dev", "v2", "2/2" ] }