Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2218535/?format=api
{ "id": 2218535, "url": "http://patchwork.ozlabs.org/api/patches/2218535/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-tegra/patch/20260401112500.4076861-3-sheetal@nvidia.com/", "project": { "id": 21, "url": "http://patchwork.ozlabs.org/api/projects/21/?format=api", "name": "Linux Tegra Development", "link_name": "linux-tegra", "list_id": "linux-tegra.vger.kernel.org", "list_email": "linux-tegra@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260401112500.4076861-3-sheetal@nvidia.com>", "list_archive_url": null, "date": "2026-04-01T11:24:58", "name": "[v4,2/4] ASoC: tegra: Use dev_err_probe() in OPE, PEQ and MBDRC drivers", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "e50a2729c5c8cbf307be971e80315d8a88ee5226", "submitter": { "id": 87986, "url": "http://patchwork.ozlabs.org/api/people/87986/?format=api", "name": "Sheetal", "email": "sheetal@nvidia.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-tegra/patch/20260401112500.4076861-3-sheetal@nvidia.com/mbox/", "series": [ { "id": 498319, "url": "http://patchwork.ozlabs.org/api/series/498319/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-tegra/list/?series=498319", "date": "2026-04-01T11:24:59", "name": "ASoC: tegra: Add error logging for probe and callback failures", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/498319/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2218535/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2218535/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-tegra+bounces-13512-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-tegra@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256\n header.s=selector2 header.b=GsyS/k1x;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-tegra+bounces-13512-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com\n header.b=\"GsyS/k1x\"", "smtp.subspace.kernel.org;\n arc=fail smtp.client-ip=52.101.85.0", "smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=nvidia.com", "smtp.subspace.kernel.org;\n spf=fail smtp.mailfrom=nvidia.com" ], "Received": [ "from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fm2vy2F55z1yCp\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 01 Apr 2026 22:34:54 +1100 (AEDT)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 9D7C0313A232\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 1 Apr 2026 11:25:48 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 6B5463F7E78;\n\tWed, 1 Apr 2026 11:25:48 +0000 (UTC)", "from BYAPR05CU005.outbound.protection.outlook.com\n (mail-westusazon11010000.outbound.protection.outlook.com [52.101.85.0])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 1651D3F7A8E;\n\tWed, 1 Apr 2026 11:25:45 +0000 (UTC)", "from PH7P222CA0027.NAMP222.PROD.OUTLOOK.COM (2603:10b6:510:33a::10)\n by LV3PR12MB9265.namprd12.prod.outlook.com (2603:10b6:408:215::14) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.17; Wed, 1 Apr\n 2026 11:25:42 +0000", "from SN1PEPF0002BA50.namprd03.prod.outlook.com\n (2603:10b6:510:33a:cafe::ca) by PH7P222CA0027.outlook.office365.com\n (2603:10b6:510:33a::10) with Microsoft SMTP Server (version=TLS1_3,\n cipher=TLS_AES_256_GCM_SHA384) id 15.20.9745.29 via Frontend Transport; Wed,\n 1 Apr 2026 11:25:38 +0000", "from mail.nvidia.com (216.228.117.160) by\n SN1PEPF0002BA50.mail.protection.outlook.com (10.167.242.73) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.9769.17 via Frontend Transport; Wed, 1 Apr 2026 11:25:41 +0000", "from rnnvmail204.nvidia.com (10.129.68.6) by mail.nvidia.com\n (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Wed, 1 Apr\n 2026 04:25:23 -0700", "from rnnvmail202.nvidia.com (10.129.68.7) by rnnvmail204.nvidia.com\n (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Wed, 1 Apr\n 2026 04:25:22 -0700", "from build-sheetal-bionic-20251202.nvidia.com (10.127.8.14) by\n mail.nvidia.com (10.129.68.7) with Microsoft SMTP Server id 15.2.2562.20 via\n Frontend Transport; Wed, 1 Apr 2026 04:25:21 -0700" ], "ARC-Seal": [ "i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775042748; cv=fail;\n b=KrCniwuxqiQXPyI6yzjDf2e0umBGo+cexFVdzHfNX/pkShBtg1v85n8IGC3Oi2i23dSZFR4tvA/XHRJP+gpLXIeg5BNNGd5s5tbUSogatu7a/E/PIrVAYql+TY3b+10ZCjbALk+IQnRFeF4ySR7/HkeLn2NhxsrHD0MQZ2yr1+I=", "i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=XXzhCreVqXNX4QkFSdOBjkVOg95EJGfy45I6uRBUMyE2jSLjrRDxHVEpWEaQzGnSW9f8ACQEY0WaX2LBnRmaQeSilMD6aTXXXxGqRWvIOcezIeHCcFDCEDAefM6d5cif+Tt9hWt8Ht5W4DATG/tpZLl1QBgwZWov8CAs4Hp15mJkoun7XOPAGROBpIB8Z0URyJRh2FXDTzX19OTfV3OApVUTeSIFflgVF6yaYWvXuvXg85kMLLr6ij4FXkklmSoyptVi1vVg8KV5WoMzOYqk3i0cY828O8i/7K26J1TXNYjpZISp4UF/Q++qc6P8JQikVihlEBALVIOQedaxruI34g==" ], "ARC-Message-Signature": [ "i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775042748; c=relaxed/simple;\n\tbh=c1FwFPi38nkFh/0Lbbg9UBofAs7X+Jch4qx+TZE+a+M=;\n\th=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=KshAFZ8D3MBG0FuYQ7G/Xantl47gHKA6h9NMD9pudj4HWtmnE/jRXnmcwotvEf73pJZ8kWWtDS9BDxtCMsEKJcxBAD7jgqnPH7bSLJkywnV9zj5Ktx6X8Rzed5ia1pDh5LbgE2p3gY6VtnwlIr+0k6XsIgoJ92YVV/G4BawRn6c=", "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=K1Oid8xl+AzPC0WVnPtFZQgnKBbYiGoGmsOkz48Jv/s=;\n b=neKNAZ99HbOpZR5hrUuAQAQqTslGHbLgHYS2S515GlkaShybzigMkg60dQXsXzN10qeP7b/qBZD9mKfbxZvOby5Dq3gGoIdQmBnBY4WVZ6p6SLYLF8kssQ8XQGl2UF+kb+sm+jUwhgUn5X5sF93Sv3TE9PjLlaNjTKB6dMBoRoN0pLxyV3/Kt5T6JbqNdT+dnIwvGVBTtKoJ+WHnS2B3mB7Hn8jP4JlxsZShiPvlBGCdI6IXU69EGFlMTee8WDIKVfFtvD8j6ulqFUqcCR0JzezCGiCZL2WE2qhsCqFmfsWkH8VMXeQ6fV32DyVXXw9SZX5mqcDXvO3Le2IMjeCqWg==" ], "ARC-Authentication-Results": [ "i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=nvidia.com;\n spf=fail smtp.mailfrom=nvidia.com;\n dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com\n header.b=GsyS/k1x; arc=fail smtp.client-ip=52.101.85.0", "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.117.160) smtp.rcpttodomain=gmail.com smtp.mailfrom=nvidia.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none (0)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=K1Oid8xl+AzPC0WVnPtFZQgnKBbYiGoGmsOkz48Jv/s=;\n b=GsyS/k1xhpRpCsNefTj//UishpiaBYrfrf+oMBAsd1rvvWUj3JTxipnF1lRIlx2TGPNBQfo1EzVRC4F+3OWhRbIxNCGfryt8mIbtERUuaxMMMy7esf1UneFeO6aEvPW5q6aS8wOGcNsw/2OnB+HSEb/2mOfIAWLfZtdJ8cEJtMlwQgrUT3ZS5mBqWyq8Pi29ACikbSPmxXqnyAswNDvRrASCiSobrV7u4nWwFK6ELx4jLA/7iNWIL89/VB/Bk1DjYpgc2G+XLsHFGf/KyQej1WDQxBuCeQEDlPC9++LNkHGXHe6+LGHzcuS2NUl9lLo6/OFQGGdbdRbjNVNFiII47Q==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.117.160)\n smtp.mailfrom=nvidia.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.117.160 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C", "From": "Sheetal <sheetal@nvidia.com>", "To": "Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,\n\tThierry Reding <thierry.reding@kernel.org>, Jonathan Hunter\n\t<jonathanh@nvidia.com>", "CC": "Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>, \"Mohan\n Kumar\" <mkumard@nvidia.com>, Kuninori Morimoto\n\t<kuninori.morimoto.gx@renesas.com>, <linux-sound@vger.kernel.org>,\n\t<linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>, Sheetal\n\t<sheetal@nvidia.com>", "Subject": "[PATCH v4 2/4] ASoC: tegra: Use dev_err_probe() in OPE,\n PEQ and MBDRC drivers", "Date": "Wed, 1 Apr 2026 11:24:58 +0000", "Message-ID": "<20260401112500.4076861-3-sheetal@nvidia.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20260401112500.4076861-1-sheetal@nvidia.com>", "References": "<20260401112500.4076861-1-sheetal@nvidia.com>", "Precedence": "bulk", "X-Mailing-List": "linux-tegra@vger.kernel.org", "List-Id": "<linux-tegra.vger.kernel.org>", "List-Subscribe": "<mailto:linux-tegra+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-tegra+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-NV-OnPremToCloud": "ExternallySecured", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "SN1PEPF0002BA50:EE_|LV3PR12MB9265:EE_", "X-MS-Office365-Filtering-Correlation-Id": "f01a7eae-9ee6-499b-95cd-08de8fe16891", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "\n\tBCL:0;ARA:13230040|1800799024|36860700016|376014|82310400026|56012099003|22082099003|18002099003;", "X-Microsoft-Antispam-Message-Info": "\n\tQ4s++ViANzS5Ya7y+aLIpwK7+8oNvfZzzB6/DUARRogid/NS2CSEnQHqTRTWXL6I3TtV1hf3HxxmHdDVbfU3uvH1njVPbia6S1hyF+wWLLrRd34hfQFF+XUg9QmZ2SmqdmiF4OTPiF0Rrbjm++q7Xmla8nKvqdnp0mpE/eSHJGqfefcHnNavKacgDd9H3xGks+uBAiz+OcRmoAejJpHSqZ0z2gyAClj35Z5Ij+YDz5dxFLyD8jNLlUEiaFEvJilkkWniJwKDRXZUbuREkuTtHlvLT8+AO/jxXgxpjbqs05iet8vgvGpKrpX1ahZmLcfiN8OQOuvcSvXUf8p908DdERBhRi8w/eCTVsJPLsUSqWkXhplPdDA5hKWbflqtMIXMGZl+FMNh1zKehRvMGej8E617B9R4Gd9JYe+lyaMj2jJv3IJM1bHXkI5YDFJrsYkcc+dy8P8mgADI5zgZ31YyjI9ZqjWrAGg1ad0FHXxlI1PngKOUdNVrq/FtuAw+Ex3crTI4dWLstdoTPimpC8msz4+UreFCzv39gSwXSQ4F5Om8rcD/93S+S2JTICsPO/8XGNRnsncgUhw6w+2HFqy+kHenf5CzcPUp8IAz1HREi2OW8PKCqgvp6LOWUDnqK/NjJkUBzTB9XBccLjGIUGdxIq/ByloWeRKCzbAM2lvEW+mrrM5Mpdv/QvTQzKpmybYd/cB+AxwHVuBUVqeHWn7nevG4X+NdJsPqWMDQMykAshiLiWZP611wtBO22Mq6/6GxycH6N2pA0CFBlJULU0St9Q==", "X-Forefront-Antispam-Report": "\n\tCIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(1800799024)(36860700016)(376014)(82310400026)(56012099003)(22082099003)(18002099003);DIR:OUT;SFP:1101;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "\n\tuCnX6AZmiSFC+XUmT/GGJoR2pm48Qo9fCx8bLuc2+kM3ZR8R4o29Y51yQX87WGGGWblEtbYLaRJh8mBGPX8tlqkPl0mgnwJTHni/58PNsDIRJJGtsxx6bcWF/lkf2ejH6wx+kXsisPdmd6HK0buZ1ffcP6fDW4gngJLKJN4hOoEefgL3jxBokj5naFgVay2BhJh6qFJ0Yu8FfnKM5iLDYF3wXRYoMUjNsgJpxUD7Q/xeaCAj6bpwMM/HWoRFzhp1JW5wD1ckA2c+ICyelG+UZJhXAsikNqUFzdQ/covfaprC5ERc0wzriX9nhU158rLljYrFamiwhf3XvhDdHZmmomgp8pHW6fuquV6sqxH849X4pj2Gis5EwsqnCwhldn/rZ4Z3A1Ne/TNcliE02ARXQ6Cowh4UvpTnBBo/6/q8TZ0dAQBY8Ue6IuRYTutE4yy+", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "01 Apr 2026 11:25:41.6824\n (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n f01a7eae-9ee6-499b-95cd-08de8fe16891", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n\tSN1PEPF0002BA50.namprd03.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "LV3PR12MB9265" }, "content": "Log errors in the Tegra210 OPE, PEQ and MBDRC probe paths using\ndev_err_probe(). Drop redundant dev_err() at tegra210_peq_regmap_init()\nand tegra210_mbdrc_regmap_init() call sites in ope_probe() since\nthese functions already log errors internally.\n\nSigned-off-by: Sheetal <sheetal@nvidia.com>\n---\n sound/soc/tegra/tegra210_mbdrc.c | 19 ++++++++++---------\n sound/soc/tegra/tegra210_ope.c | 26 ++++++++++----------------\n sound/soc/tegra/tegra210_peq.c | 19 ++++++++++---------\n 3 files changed, 30 insertions(+), 34 deletions(-)", "diff": "diff --git a/sound/soc/tegra/tegra210_mbdrc.c b/sound/soc/tegra/tegra210_mbdrc.c\nindex 6a268dbb7197..b1c2d3e4f5a6 100644\n--- a/sound/soc/tegra/tegra210_mbdrc.c\n+++ b/sound/soc/tegra/tegra210_mbdrc.c\n@@ -988,14 +988,14 @@ int tegra210_mbdrc_regmap_init(struct platform_device *pdev)\n \n \tchild = of_get_child_by_name(dev->of_node, \"dynamic-range-compressor\");\n \tif (!child)\n-\t\treturn -ENODEV;\n+\t\treturn dev_err_probe(dev, -ENODEV,\n+\t\t\t\t \"missing 'dynamic-range-compressor' DT child node\\n\");\n \n \terr = of_address_to_resource(child, 0, &mem);\n \tof_node_put(child);\n-\tif (err < 0) {\n-\t\tdev_err(dev, \"fail to get MBDRC resource\\n\");\n-\t\treturn err;\n-\t}\n+\tif (err < 0)\n+\t\treturn dev_err_probe(dev, err,\n+\t\t\t\t \"failed to get MBDRC resource\\n\");\n \n \tmem.flags = IORESOURCE_MEM;\n \tregs = devm_ioremap_resource(dev, &mem);\n@@ -1004,10 +1004,9 @@ int tegra210_mbdrc_regmap_init(struct platform_device *pdev)\n \n \tope->mbdrc_regmap = devm_regmap_init_mmio(dev, regs,\n \t\t\t\t\t\t &tegra210_mbdrc_regmap_cfg);\n-\tif (IS_ERR(ope->mbdrc_regmap)) {\n-\t\tdev_err(dev, \"regmap init failed\\n\");\n-\t\treturn PTR_ERR(ope->mbdrc_regmap);\n-\t}\n+\tif (IS_ERR(ope->mbdrc_regmap))\n+\t\treturn dev_err_probe(dev, PTR_ERR(ope->mbdrc_regmap),\n+\t\t\t\t \"MBDRC regmap init failed\\n\");\n \n \tregcache_cache_only(ope->mbdrc_regmap, true);\n \ndiff --git a/sound/soc/tegra/tegra210_ope.c b/sound/soc/tegra/tegra210_ope.c\nindex a440888dcdbd..c1d2e3f4a5b6 100644\n--- a/sound/soc/tegra/tegra210_ope.c\n+++ b/sound/soc/tegra/tegra210_ope.c\n@@ -318,10 +318,9 @@ static int tegra210_ope_probe(struct platform_device *pdev)\n \n \tope->regmap = devm_regmap_init_mmio(dev, regs,\n \t\t\t\t\t &tegra210_ope_regmap_config);\n-\tif (IS_ERR(ope->regmap)) {\n-\t\tdev_err(dev, \"regmap init failed\\n\");\n-\t\treturn PTR_ERR(ope->regmap);\n-\t}\n+\tif (IS_ERR(ope->regmap))\n+\t\treturn dev_err_probe(dev, PTR_ERR(ope->regmap),\n+\t\t\t\t \"regmap init failed\\n\");\n \n \tregcache_cache_only(ope->regmap, true);\n \n@@ -328,14 +327,10 @@ static int tegra210_ope_probe(struct platform_device *pdev)\n \tdev_set_drvdata(dev, ope);\n \n \terr = tegra210_peq_regmap_init(pdev);\n-\tif (err < 0) {\n-\t\tdev_err(dev, \"PEQ init failed\\n\");\n-\t\treturn err;\n-\t}\n+\tif (err < 0)\n+\t\treturn err;\n \n \terr = tegra210_mbdrc_regmap_init(pdev);\n-\tif (err < 0) {\n-\t\tdev_err(dev, \"MBDRC init failed\\n\");\n-\t\treturn err;\n-\t}\n+\tif (err < 0)\n+\t\treturn err;\n \n@@ -342,10 +337,9 @@ static int tegra210_ope_probe(struct platform_device *pdev)\n \terr = devm_snd_soc_register_component(dev, &tegra210_ope_cmpnt,\n \t\t\t\t\t tegra210_ope_dais,\n \t\t\t\t\t ARRAY_SIZE(tegra210_ope_dais));\n-\tif (err) {\n-\t\tdev_err(dev, \"can't register OPE component, err: %d\\n\", err);\n-\t\treturn err;\n-\t}\n+\tif (err)\n+\t\treturn dev_err_probe(dev, err,\n+\t\t\t\t \"can't register OPE component\\n\");\n \n \tpm_runtime_enable(dev);\n \ndiff --git a/sound/soc/tegra/tegra210_peq.c b/sound/soc/tegra/tegra210_peq.c\nindex 2f72e9d541dc..d1e2f3a4b5c6 100644\n--- a/sound/soc/tegra/tegra210_peq.c\n+++ b/sound/soc/tegra/tegra210_peq.c\n@@ -408,14 +408,14 @@ int tegra210_peq_regmap_init(struct platform_device *pdev)\n \n \tchild = of_get_child_by_name(dev->of_node, \"equalizer\");\n \tif (!child)\n-\t\treturn -ENODEV;\n+\t\treturn dev_err_probe(dev, -ENODEV,\n+\t\t\t\t \"missing 'equalizer' DT child node\\n\");\n \n \terr = of_address_to_resource(child, 0, &mem);\n \tof_node_put(child);\n-\tif (err < 0) {\n-\t\tdev_err(dev, \"fail to get PEQ resource\\n\");\n-\t\treturn err;\n-\t}\n+\tif (err < 0)\n+\t\treturn dev_err_probe(dev, err,\n+\t\t\t\t \"failed to get PEQ resource\\n\");\n \n \tmem.flags = IORESOURCE_MEM;\n \tregs = devm_ioremap_resource(dev, &mem);\n@@ -423,10 +423,9 @@ int tegra210_peq_regmap_init(struct platform_device *pdev)\n \t\treturn PTR_ERR(regs);\n \tope->peq_regmap = devm_regmap_init_mmio(dev, regs,\n \t\t\t\t\t\t&tegra210_peq_regmap_config);\n-\tif (IS_ERR(ope->peq_regmap)) {\n-\t\tdev_err(dev, \"regmap init failed\\n\");\n-\t\treturn PTR_ERR(ope->peq_regmap);\n-\t}\n+\tif (IS_ERR(ope->peq_regmap))\n+\t\treturn dev_err_probe(dev, PTR_ERR(ope->peq_regmap),\n+\t\t\t\t \"PEQ regmap init failed\\n\");\n \n \tregcache_cache_only(ope->peq_regmap, true);\n \n", "prefixes": [ "v4", "2/4" ] }