Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2218529/?format=api
{ "id": 2218529, "url": "http://patchwork.ozlabs.org/api/patches/2218529/?format=api", "web_url": "http://patchwork.ozlabs.org/project/glibc/patch/20260401112522.1785194-1-lucas.chollet@free.fr/", "project": { "id": 41, "url": "http://patchwork.ozlabs.org/api/projects/41/?format=api", "name": "GNU C Library", "link_name": "glibc", "list_id": "libc-alpha.sourceware.org", "list_email": "libc-alpha@sourceware.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260401112522.1785194-1-lucas.chollet@free.fr>", "list_archive_url": null, "date": "2026-04-01T11:25:20", "name": "[v2] posix: Add POSIX aliases to some spawn functions", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "0383d1a36fdc1ae91b8c7fb410046eb4489dbf84", "submitter": { "id": 86596, "url": "http://patchwork.ozlabs.org/api/people/86596/?format=api", "name": "Lucas Chollet", "email": "lucas.chollet@free.fr" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/glibc/patch/20260401112522.1785194-1-lucas.chollet@free.fr/mbox/", "series": [ { "id": 498318, "url": "http://patchwork.ozlabs.org/api/series/498318/?format=api", "web_url": "http://patchwork.ozlabs.org/project/glibc/list/?series=498318", "date": "2026-04-01T11:25:20", "name": "[v2] posix: Add POSIX aliases to some spawn functions", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/498318/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2218529/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2218529/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<libc-alpha-bounces~incoming=patchwork.ozlabs.org@sourceware.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "libc-alpha@sourceware.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "libc-alpha@sourceware.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=free.fr header.i=@free.fr header.a=rsa-sha256\n header.s=smtp-20201208 header.b=cJIVswCu;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=sourceware.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=libc-alpha-bounces~incoming=patchwork.ozlabs.org@sourceware.org;\n receiver=patchwork.ozlabs.org)", "sourceware.org;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=free.fr header.i=@free.fr header.a=rsa-sha256\n header.s=smtp-20201208 header.b=cJIVswCu", "sourceware.org;\n dmarc=pass (p=quarantine dis=none) header.from=free.fr", "sourceware.org; spf=pass smtp.mailfrom=free.fr", "server2.sourceware.org;\n arc=none smtp.remote-ip=212.27.42.4" ], "Received": [ "from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fm2jZ5dK6z1yFv\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 01 Apr 2026 22:25:54 +1100 (AEDT)", "from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id C6B784BA902D\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 1 Apr 2026 11:25:52 +0000 (GMT)", "from smtp4-g21.free.fr (smtp4-g21.free.fr [212.27.42.4])\n by sourceware.org (Postfix) with ESMTPS id CB2FD4BA23E1\n for <libc-alpha@sourceware.org>; Wed, 1 Apr 2026 11:25:31 +0000 (GMT)", "from itxub.fritz.box (unknown [84.254.90.136])\n (Authenticated sender: lucas.chollet@free.fr)\n by smtp4-g21.free.fr (Postfix) with ESMTPSA id B5E1319F5C3;\n Wed, 1 Apr 2026 13:25:29 +0200 (CEST)" ], "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 sourceware.org C6B784BA902D", "OpenDKIM Filter v2.11.0 sourceware.org CB2FD4BA23E1" ], "DMARC-Filter": "OpenDMARC Filter v1.4.2 sourceware.org CB2FD4BA23E1", "ARC-Filter": "OpenARC Filter v1.0.0 sourceware.org CB2FD4BA23E1", "ARC-Seal": "i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1775042731; cv=none;\n b=so0Unp4Oz3/O59scWgWC+lbJUEb1Yt4YDH3r/DV92F21xzzWAvcGWb6t+9qzGEmY4VGOsAsOlqwsfBiWRgJmZXLbAYKWlSiLKkZivkrmx3ZnH7UAug46K+Id3dcNJAX2tTApTdrzIfNKybQfufLTXIJzxles337rEYsAGz5dEmI=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1775042731; c=relaxed/simple;\n bh=O51/OP+NAHQIc+XmD2zYkbKMGPdg2DiARRVLwgMkiEU=;\n h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version;\n b=BlSaswuNHDEpthkp4fE0tR24ESLtTTFV5WjHwB4cGX9MfvJNlBv4LGtpG2oWKN4e0vd3XgORCgt69XThDh1bznjEQmaIAJZRXYUJV6VTR/Deb8BTd0tOooLH0of9c0iq0IUmlWB4nEwzImkQn0A30QGYmB2lN04/8NFnIL0XaIs=", "ARC-Authentication-Results": "i=1; server2.sourceware.org", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=free.fr;\n s=smtp-20201208; t=1775042731;\n bh=O51/OP+NAHQIc+XmD2zYkbKMGPdg2DiARRVLwgMkiEU=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=cJIVswCuxrUaCASv7vedl9NsjHzfz9nlN9OFQ3jakvCrcO3bP8TqRS+MjdYl/Qqq4\n NHTR5TblVoHhWRchH+zzPcn6sWjd8ZjHuxno/dW/fluna9mlnIht/FrkmEDw/GBSWD\n yc02Mn8FqPqiCcwdyQkBCKnxHqqqktqybEPCFjOVwBNbb2mKA8CU3yOs2NUm/FAwOW\n 10zzZ/QziPq4HvEE+EKuCqW/wu5V9lLAegSdbSdVpWo6ho5uZApiwnZNDv4ic8D4XE\n G1loSJSi8khU9hTA8yaoSsXQfHem/gQUXSbNPISS1RgX0rpelcwuZoDFV8ANkRTM0Y\n qybL7A2LUSjxQ==", "From": "Lucas Chollet <lucas.chollet@free.fr>", "To": "libc-alpha@sourceware.org", "Cc": "Lucas Chollet <lucas.chollet@free.fr>", "Subject": "[PATCH v2] posix: Add POSIX aliases to some spawn functions", "Date": "Wed, 1 Apr 2026 13:25:20 +0200", "Message-ID": "<20260401112522.1785194-1-lucas.chollet@free.fr>", "X-Mailer": "git-send-email 2.51.0", "In-Reply-To": "<20260330081840.878377-2-lucas.chollet@free.fr>", "References": "<20260330081840.878377-2-lucas.chollet@free.fr>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libc-alpha@sourceware.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Libc-alpha mailing list <libc-alpha.sourceware.org>", "List-Unsubscribe": "<https://sourceware.org/mailman/options/libc-alpha>,\n <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>", "List-Archive": "<https://sourceware.org/pipermail/libc-alpha/>", "List-Post": "<mailto:libc-alpha@sourceware.org>", "List-Help": "<mailto:libc-alpha-request@sourceware.org?subject=help>", "List-Subscribe": "<https://sourceware.org/mailman/listinfo/libc-alpha>,\n <mailto:libc-alpha-request@sourceware.org?subject=subscribe>", "Errors-To": "libc-alpha-bounces~incoming=patchwork.ozlabs.org@sourceware.org" }, "content": "Both `posix_spawn_file_actions_add{,f}chdir` functions are now fully\ndefined by POSIX-2024, this patch adds both functions as aliases of the\nalready existing `posix_spawn_file_actions_add{,f}chdir_np` GNU\nextensions.\n\nThis makes glibc more compliant in regards to POSIX-2024.\n\nSigned-off-by: Lucas Chollet <lucas.chollet@free.fr>\n---\nv2:\n - Use asm aliases instead of adding new symbols\n - Add a new test instead of modifying the logic inside\n tst-spawn-chdir.c\n conform/data/spawn.h-data | 4 ++++\n posix/Makefile | 1 +\n posix/spawn.h | 20 ++++++++++++++++++++\n posix/tst-spawn-chdir-posix.c | 2 ++\n posix/tst-spawn-chdir.c | 18 ++++++++++++++++--\n 5 files changed, 43 insertions(+), 2 deletions(-)\n create mode 100644 posix/tst-spawn-chdir-posix.c", "diff": "diff --git a/conform/data/spawn.h-data b/conform/data/spawn.h-data\nindex 43aa9cb8ae..1f332324c2 100644\n--- a/conform/data/spawn.h-data\n+++ b/conform/data/spawn.h-data\n@@ -29,6 +29,10 @@ function int posix_spawnattr_setpgroup (posix_spawnattr_t*, pid_t)\n function int posix_spawnattr_setschedparam (posix_spawnattr_t*, const struct sched_param*)\n function int posix_spawnattr_setschedpolicy (posix_spawnattr_t*, int)\n function int posix_spawnattr_setsigmask (posix_spawnattr_t*, const sigset_t*)\n+#if defined XOPEN2K24 || defined POSIX2024\n+function int posix_spawn_file_actions_addchdir (posix_spawn_file_actions_t*, const char *)\n+function int posix_spawn_file_actions_addfchdir (posix_spawn_file_actions_t*, int)\n+#endif\n function int posix_spawn_file_actions_addclose (posix_spawn_file_actions_t*, int)\n function int posix_spawn_file_actions_adddup2 (posix_spawn_file_actions_t*, int, int)\n function int posix_spawn_file_actions_addopen (posix_spawn_file_actions_t*, int, const char *, int, mode_t)\ndiff --git a/posix/Makefile b/posix/Makefile\nindex ec28b9e1da..a5e5162c61 100644\n--- a/posix/Makefile\n+++ b/posix/Makefile\n@@ -315,6 +315,7 @@ tests := \\\n tst-rxspencer-no-utf8 \\\n tst-sched_getaffinity \\\n tst-spawn-chdir \\\n+ tst-spawn-chdir-posix \\\n tst-spawn4 \\\n tst-spawn5 \\\n tst-spawn6 \\\ndiff --git a/posix/spawn.h b/posix/spawn.h\nindex 5e68752a66..0aabf5ebef 100644\n--- a/posix/spawn.h\n+++ b/posix/spawn.h\n@@ -200,6 +200,26 @@ extern int posix_spawn_file_actions_adddup2 (posix_spawn_file_actions_t *\n \t\t\t\t\t int __fd, int __newfd)\n __THROW __nonnull ((1));\n \n+#ifdef __USE_XOPEN2K24XSI\n+\n+/* Add an action changing the directory to PATH during spawn. This\n+ affects the subsequent file actions.\n+ Alias of posix_spawn_file_actions_addchdir_np. */\n+extern int __REDIRECT_NTH (posix_spawn_file_actions_addchdir,\n+ (posix_spawn_file_actions_t * __restrict __actions,\n+ const char *__restrict __path),\n+ posix_spawn_file_actions_addchdir_np);\n+\n+/* Add an action changing the directory to FD during spawn. This\n+ affects the subsequent file actions. FD is not duplicated and must\n+ be open when the file action is executed.\n+ Alias of posix_spawn_file_actions_addfchdir_np. */\n+extern int __REDIRECT_NTH (posix_spawn_file_actions_addfchdir,\n+ (posix_spawn_file_actions_t *, int __fd),\n+ posix_spawn_file_actions_addfchdir_np);\n+\n+#endif /* __USE_XOPEN2K24XSI */\n+\n #ifdef __USE_MISC\n /* Add an action changing the directory to PATH during spawn. This\n affects the subsequent file actions. */\ndiff --git a/posix/tst-spawn-chdir-posix.c b/posix/tst-spawn-chdir-posix.c\nnew file mode 100644\nindex 0000000000..3f8d8952bb\n--- /dev/null\n+++ b/posix/tst-spawn-chdir-posix.c\n@@ -0,0 +1,2 @@\n+#define USE_POSIX_ALIASES\n+#include \"tst-spawn-chdir.c\"\ndiff --git a/posix/tst-spawn-chdir.c b/posix/tst-spawn-chdir.c\nindex a3478d61f6..2c889d52dd 100644\n--- a/posix/tst-spawn-chdir.c\n+++ b/posix/tst-spawn-chdir.c\n@@ -78,12 +78,26 @@ add_chdir (posix_spawn_file_actions_t *actions, const char *path,\n {\n TEST_COMPARE (posix_spawn_file_actions_addopen\n (actions, tmpfd, path, O_DIRECTORY | O_RDONLY, 0), 0);\n- TEST_COMPARE (posix_spawn_file_actions_addfchdir_np\n+ TEST_COMPARE (\n+#ifdef USE_POSIX_ALIASES\n+ posix_spawn_file_actions_addfchdir\n+#else\n+ posix_spawn_file_actions_addfchdir_np\n+#endif\n (actions, tmpfd), 0);\n+\n TEST_COMPARE (posix_spawn_file_actions_addclose (actions, tmpfd), 0);\n }\n else\n- TEST_COMPARE (posix_spawn_file_actions_addchdir_np (actions, path), 0);\n+ {\n+ TEST_COMPARE (\n+#ifdef USE_POSIX_ALIASES\n+ posix_spawn_file_actions_addchdir\n+#else\n+ posix_spawn_file_actions_addchdir_np\n+#endif\n+ (actions, path), 0);\n+ }\n }\n \n static int\n", "prefixes": [ "v2" ] }