Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2218463/?format=api
{ "id": 2218463, "url": "http://patchwork.ozlabs.org/api/patches/2218463/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260401092013epcms2p83c7820868e2df41be226ab178e816983@epcms2p8/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260401092013epcms2p83c7820868e2df41be226ab178e816983@epcms2p8>", "list_archive_url": null, "date": "2026-04-01T09:20:13", "name": "[RESEND,5/5] tests/qtest: Add UFS Write Booster QTest", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "ff764bbc8a2bf60571234c3b8978c71569a63bc7", "submitter": { "id": 93006, "url": "http://patchwork.ozlabs.org/api/people/93006/?format=api", "name": "Jaemyung Lee", "email": "jaemyung.lee@samsung.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260401092013epcms2p83c7820868e2df41be226ab178e816983@epcms2p8/mbox/", "series": [ { "id": 498296, "url": "http://patchwork.ozlabs.org/api/series/498296/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=498296", "date": "2026-04-01T09:04:57", "name": "hw/ufs: Add Write Booster Support on UFS", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/498296/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2218463/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2218463/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=samsung.com header.i=@samsung.com header.a=rsa-sha256\n header.s=mail20170921 header.b=kJOGGGdH;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4flzx54MH8z1yCp\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 01 Apr 2026 20:20:41 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w7rkR-0005zt-QF; Wed, 01 Apr 2026 05:20:27 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <jaemyung.lee@samsung.com>)\n id 1w7rkP-0005wI-8t\n for qemu-devel@nongnu.org; Wed, 01 Apr 2026 05:20:25 -0400", "from mailout3.samsung.com ([203.254.224.33])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <jaemyung.lee@samsung.com>)\n id 1w7rkJ-0004rv-Qg\n for qemu-devel@nongnu.org; Wed, 01 Apr 2026 05:20:24 -0400", "from epcas2p1.samsung.com (unknown [182.195.41.53])\n by mailout3.samsung.com (KnoxPortal) with ESMTP id\n 20260401092014epoutp033aa98ed576346b848bdbb5ed8303daf1~iMR_cpjx_0485804858epoutp03y\n for <qemu-devel@nongnu.org>; Wed, 1 Apr 2026 09:20:14 +0000 (GMT)", "from epsnrtp03.localdomain (unknown [182.195.42.155]) by\n epcas2p1.samsung.com (KnoxPortal) with ESMTPS id\n 20260401092014epcas2p18ed47e7c19bf3d04404a09291c58ab10~iMR_NyrL_1453114531epcas2p1u;\n Wed, 1 Apr 2026 09:20:14 +0000 (GMT)", "from epcas2p4.samsung.com (unknown [182.195.38.205]) by\n epsnrtp03.localdomain (Postfix) with ESMTP id 4flzwZ2XT8z3hhTC; Wed, 1 Apr\n 2026 09:20:14 +0000 (GMT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 mailout3.samsung.com\n 20260401092014epoutp033aa98ed576346b848bdbb5ed8303daf1~iMR_cpjx_0485804858epoutp03y", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com;\n s=mail20170921; t=1775035215;\n bh=B75BLcgvRrKM1gn8sfp4y4sUbZ0axLtCq/4bo35zC94=;\n h=Subject:Reply-To:From:To:CC:In-Reply-To:Date:References:From;\n b=kJOGGGdHI5b6skgVkANQG3XWyP+848z9m6QBJ1Lxp9VyFRBs0LefmmDwIfKdtN9KZ\n dsmE1WGJle0vfz3xRDr9YsUEZ+2M+y55Yo16Ml4zXKm7TR1zeNjaPVtN+ou3uqTHRS\n 8EN2ZlZQgUwyj7SBqpzQbGLb++CkbCuuJWxagIZ4=", "Mime-Version": "1.0", "Subject": "[PATCH RESEND 5/5] tests/qtest: Add UFS Write Booster QTest", "From": "Jaemyung Lee <jaemyung.lee@samsung.com>", "To": "\"qemu-devel@nongnu.org\" <qemu-devel@nongnu.org>", "CC": "Jeuk Kim <jeuk20.kim@samsung.com>, \"kwolf@redhat.com\"\n <kwolf@redhat.com>, \"hreitz@redhat.com\" <hreitz@redhat.com>,\n \"qemu-block@nongnu.org\" <qemu-block@nongnu.org>, \"farosas@suse.de\"\n <farosas@suse.de>, \"lvivier@redhat.com\" <lvivier@redhat.com>,\n \"pbonzini@redhat.com\" <pbonzini@redhat.com>", "X-Priority": "3", "X-Content-Kind-Code": "NORMAL", "In-Reply-To": "<20260401090457epcms2p2368a82c8b794d8591aa62a421db9e8f7@epcms2p2>", "X-CPGS-Detection": "blocking_info_exchange", "X-Drm-Type": "N,general", "X-Msg-Generator": "Mail", "X-Msg-Type": "PERSONAL", "X-Reply-Demand": "N", "Message-ID": "<20260401092013epcms2p83c7820868e2df41be226ab178e816983@epcms2p8>", "Date": "Wed, 01 Apr 2026 18:20:13 +0900", "X-CMS-MailID": "20260401092013epcms2p83c7820868e2df41be226ab178e816983", "Content-Transfer-Encoding": "7bit", "Content-Type": "text/plain; charset=\"utf-8\"", "X-Sendblock-Type": "AUTO_CONFIDENTIAL", "CMS-TYPE": "102P", "cpgsPolicy": "CPGSC10-223,Y", "X-CFilter-Loop": "Reflected", "X-CMS-RootMailID": "20260330112748epcms2p1717e93009f7fb87a8156ee07a9400502", "References": "<20260401090457epcms2p2368a82c8b794d8591aa62a421db9e8f7@epcms2p2>\n <CGME20260330112748epcms2p1717e93009f7fb87a8156ee07a9400502@epcms2p8>", "Received-SPF": "pass client-ip=203.254.224.33;\n envelope-from=jaemyung.lee@samsung.com; helo=mailout3.samsung.com", "X-Spam_score_int": "-6", "X-Spam_score": "-0.7", "X-Spam_bar": "/", "X-Spam_report": "(-0.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=1, RCVD_IN_VALIDITY_RPBL_BLOCKED=1,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Reply-To": "jaemyung.lee@samsung.com", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "It adds 'wb-init' and 'wb-read-write' TCs into tests/qtest/ufs-test.c.\n'wb-init' tests that the WB support is properly initialized with UFS\ndevice and 'wb-read-write' tests that WB can be enabled and WRITE I/O\ncan be handled/buffered as a WB command.\n\nSigned-off-by: Jaemyung Lee <jaemyung.lee@samsung.com>\n---\n tests/qtest/ufs-test.c | 176 +++++++++++++++++++++++++++++++++++++++++\n 1 file changed, 176 insertions(+)\n\n--\n2.34.1", "diff": "diff --git a/tests/qtest/ufs-test.c b/tests/qtest/ufs-test.c\nindex 7f99944155..253fea27a5 100644\n--- a/tests/qtest/ufs-test.c\n+++ b/tests/qtest/ufs-test.c\n@@ -1182,6 +1182,173 @@ static void ufstest_query_desc_request(void *obj, void *data,\n ufs_exit(ufs, alloc);\n }\n\n+static void ufstest_wb_init(void *obj, void *data, QGuestAllocator *alloc)\n+{\n+ QUfs *ufs = obj;\n+ enum UtpOcsCodes ocs;\n+ UtpUpiuRsp rsp_upiu;\n+ uint8_t *desc;\n+ uint32_t value;\n+\n+ ufs_init(ufs, alloc);\n+\n+ /* Read Device Descriptor */\n+ ocs = ufs_send_query(ufs, UFS_UPIU_QUERY_FUNC_STANDARD_READ_REQUEST,\n+ UFS_UPIU_QUERY_OPCODE_READ_DESC,\n+ UFS_QUERY_DESC_IDN_DEVICE, 0, 0, 0, &rsp_upiu);\n+ g_assert_cmpuint(ocs, ==, UFS_OCS_SUCCESS);\n+ g_assert_cmpuint(rsp_upiu.header.response, ==, UFS_COMMAND_RESULT_SUCCESS);\n+ g_assert_cmpuint(rsp_upiu.qr.opcode, ==, UFS_UPIU_QUERY_OPCODE_READ_DESC);\n+ g_assert_cmpuint(rsp_upiu.qr.idn, ==, UFS_QUERY_DESC_IDN_DEVICE);\n+ g_assert_cmpuint(rsp_upiu.qr.data[0], ==, sizeof(DeviceDescriptor));\n+ g_assert_cmpuint(rsp_upiu.qr.data[1], ==, UFS_QUERY_DESC_IDN_DEVICE);\n+\n+ /* Check Write Booster Supportability */\n+ desc = rsp_upiu.qr.data;\n+\n+ value = *(uint16_t *)(desc + UFS_DEVICE_DESC_PARAM_EXT_WB_SUP);\n+ value = be16_to_cpu(value);\n+ g_assert_cmpuint(value, ==, WB_RESIZE | WB_FIFO | WB_PINNED);\n+\n+ value = *(uint32_t *)(desc + UFS_DEVICE_DESC_PARAM_EXT_UFS_FEATURE_SUP);\n+ value = be32_to_cpu(value);\n+ g_assert_cmpuint(value & UFS_DEV_WB_SUPPORT, ==, UFS_DEV_WB_SUPPORT);\n+\n+ /* Read Geometry Descriptor */\n+ ocs = ufs_send_query(ufs, UFS_UPIU_QUERY_FUNC_STANDARD_READ_REQUEST,\n+ UFS_UPIU_QUERY_OPCODE_READ_DESC,\n+ UFS_QUERY_DESC_IDN_GEOMETRY, 0, 0, 0, &rsp_upiu);\n+ g_assert_cmpuint(ocs, ==, UFS_OCS_SUCCESS);\n+ g_assert_cmpuint(rsp_upiu.header.response, ==, UFS_COMMAND_RESULT_SUCCESS);\n+ g_assert_cmpuint(rsp_upiu.qr.data[0], ==, sizeof(GeometryDescriptor));\n+ g_assert_cmpuint(rsp_upiu.qr.data[1], ==, UFS_QUERY_DESC_IDN_GEOMETRY);\n+\n+ /* Check Write Booster Configuration */\n+ desc = rsp_upiu.qr.data;\n+\n+ value = *(uint32_t *)(desc + UFS_GEOMETRY_DESC_PARAM_WB_MAX_ALLOC_UNITS);\n+ value = be32_to_cpu(value);\n+ g_assert_cmpuint(value, ==, 1024);\n+\n+ value = desc[UFS_GEOMETRY_DESC_PARAM_WB_MAX_WB_LUNS];\n+ g_assert_cmpuint(value, ==, 1);\n+\n+ value = desc[UFS_GEOMETRY_DESC_PARAM_WB_BUFF_CAP_ADJ];\n+ g_assert_cmpuint(value, ==, 3);\n+\n+ value = desc[UFS_GEOMETRY_DESC_PARAM_WB_SUP_RED_TYPE];\n+ g_assert_cmpuint(value, ==, 1);\n+\n+ value = desc[UFS_GEOMETRY_DESC_PARAM_WB_SUP_WB_TYPE];\n+ g_assert_cmpuint(value, ==, 1);\n+\n+ ufs_exit(ufs, alloc);\n+}\n+\n+static void ufstest_wb_read_write(void *obj, void *data, QGuestAllocator *alloc)\n+{\n+ QUfs *ufs = obj;\n+ uint8_t read_buf[4096] = { 0 };\n+ uint8_t write_buf[4096] = { 0 };\n+ const uint8_t read_capacity_cdb[UFS_CDB_SIZE] = {\n+ /* allocation length 4096 */\n+ SERVICE_ACTION_IN_16,\n+ SAI_READ_CAPACITY_16,\n+ 0x00,\n+ 0x00,\n+ 0x00,\n+ 0x00,\n+ 0x00,\n+ 0x00,\n+ 0x00,\n+ 0x00,\n+ 0x00,\n+ 0x00,\n+ 0x10,\n+ 0x00,\n+ 0x00,\n+ 0x00\n+ };\n+ const uint8_t request_sense_cdb[UFS_CDB_SIZE] = {\n+ REQUEST_SENSE,\n+ };\n+ const uint8_t write_cdb[UFS_CDB_SIZE] = {\n+ /* WRITE(10) to LBA 0, transfer length 1 */\n+ WRITE_10, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x01, 0x00\n+ };\n+ uint32_t block_size;\n+ enum UtpOcsCodes ocs;\n+ UtpUpiuRsp rsp_upiu;\n+ const int test_lun = 1;\n+ uint64_t end_time;\n+\n+ ufs_init(ufs, alloc);\n+\n+ /* Clear Unit Attention */\n+ ocs = ufs_send_scsi_command(ufs, test_lun, request_sense_cdb, NULL, 0,\n+ read_buf, sizeof(read_buf), &rsp_upiu);\n+ g_assert_cmpuint(ocs, ==, UFS_OCS_SUCCESS);\n+ g_assert_cmpuint(rsp_upiu.header.scsi_status, ==, CHECK_CONDITION);\n+\n+ /* Read capacity */\n+ ocs = ufs_send_scsi_command(ufs, test_lun, read_capacity_cdb, NULL, 0,\n+ read_buf, sizeof(read_buf), &rsp_upiu);\n+ g_assert_cmpuint(ocs, ==, UFS_OCS_SUCCESS);\n+ g_assert_cmpuint(rsp_upiu.header.scsi_status, ==,\n+ UFS_COMMAND_RESULT_SUCCESS);\n+ block_size = ldl_be_p(&read_buf[8]);\n+ g_assert_cmpuint(block_size, ==, 4096);\n+\n+ /* Check available buffer size */\n+ ocs = ufs_send_query(ufs, UFS_UPIU_QUERY_FUNC_STANDARD_READ_REQUEST,\n+ UFS_UPIU_QUERY_OPCODE_READ_ATTR,\n+ UFS_QUERY_ATTR_IDN_AVAIL_WB_BUFF_SIZE, 0, 0, 0, &rsp_upiu);\n+ g_assert_cmpuint(ocs, ==, UFS_OCS_SUCCESS);\n+ g_assert_cmpuint(rsp_upiu.header.response, ==, UFS_COMMAND_RESULT_SUCCESS);\n+ g_assert_cmpuint(rsp_upiu.qr.opcode, ==, UFS_UPIU_QUERY_OPCODE_READ_ATTR);\n+ g_assert_cmpuint(rsp_upiu.qr.idn, ==, UFS_QUERY_ATTR_IDN_AVAIL_WB_BUFF_SIZE);\n+ g_assert_cmpuint(rsp_upiu.qr.value, ==, cpu_to_be32(0xA));\n+\n+ /* Enable WB */\n+ ocs = ufs_send_query(ufs, UFS_UPIU_QUERY_FUNC_STANDARD_WRITE_REQUEST,\n+ UFS_UPIU_QUERY_OPCODE_SET_FLAG,\n+ UFS_QUERY_FLAG_IDN_WB_EN, 0, 0, 0,\n+ &rsp_upiu);\n+ g_assert_cmpuint(ocs, ==, UFS_OCS_SUCCESS);\n+ g_assert_cmpuint(rsp_upiu.header.response, ==, UFS_COMMAND_RESULT_SUCCESS);\n+ g_assert_cmpuint(rsp_upiu.qr.value, ==, be32_to_cpu(1));\n+\n+ /* Write data */\n+ for (int i = 0; i < 256; i++) {\n+ memset(write_buf, 0xab, block_size);\n+ ocs = ufs_send_scsi_command(ufs, test_lun, write_cdb, write_buf,\n+ block_size, NULL, 0, &rsp_upiu);\n+ g_assert_cmpuint(ocs, ==, UFS_OCS_SUCCESS);\n+ g_assert_cmpuint(rsp_upiu.header.scsi_status, ==,\n+ UFS_COMMAND_RESULT_SUCCESS);\n+ }\n+\n+ end_time = g_get_monotonic_time() + TIMEOUT_SECONDS * G_TIME_SPAN_SECOND;\n+ do {\n+ qtest_clock_step(ufs->dev.bus->qts, 100);\n+\n+ /* Check available buffer size */\n+ ocs = ufs_send_query(ufs, UFS_UPIU_QUERY_FUNC_STANDARD_READ_REQUEST,\n+ UFS_UPIU_QUERY_OPCODE_READ_ATTR,\n+ UFS_QUERY_ATTR_IDN_AVAIL_WB_BUFF_SIZE, 0, 0, 0,\n+ &rsp_upiu);\n+ g_assert_cmpuint(ocs, ==, UFS_OCS_SUCCESS);\n+ g_assert_cmpuint(rsp_upiu.header.response, ==, UFS_COMMAND_RESULT_SUCCESS);\n+ g_assert_cmpuint(rsp_upiu.qr.opcode, ==, UFS_UPIU_QUERY_OPCODE_READ_ATTR);\n+ g_assert_cmpuint(rsp_upiu.qr.idn, ==, UFS_QUERY_ATTR_IDN_AVAIL_WB_BUFF_SIZE);\n+ } while (rsp_upiu.qr.value == cpu_to_be32(0xA) && g_get_monotonic_time() < end_time);\n+\n+ /* Check available buffer size */\n+ g_assert_cmpuint(rsp_upiu.qr.value, ==, cpu_to_be32(0x9));\n+\n+ ufs_exit(ufs, alloc);\n+}\n+\n static void drive_destroy(void *path)\n {\n unlink(path);\n@@ -1234,6 +1401,13 @@ static void ufs_register_nodes(void)\n .edge.extra_device_opts =\n \"mcq=true,mcq-maxq=1\" };\n\n+ QOSGraphTestOptions wb_test_opts = { .before = ufs_blk_test_setup,\n+ .edge.extra_device_opts =\n+ \"mcq=false,nutrs=32,nutmrs=8,\"\n+ \"wb-max-size=1024,wb-min-size=256,\"\n+ \"wb-max-lus=1,wb-cap-adj-fac=3,\"\n+ \"wb-reduction=1\" };\n+\n add_qpci_address(&edge_opts, &(QPCIAddress){ .devfn = QPCI_DEVFN(4, 0) });\n\n qos_node_create_driver(\"ufs\", ufs_create);\n@@ -1262,6 +1436,8 @@ static void ufs_register_nodes(void)\n &io_test_opts);\n qos_add_test(\"query-desciptor\", \"ufs\", ufstest_query_desc_request,\n &io_test_opts);\n+ qos_add_test(\"wb-init\", \"ufs\", ufstest_wb_init, &wb_test_opts);\n+ qos_add_test(\"wb-read-write\", \"ufs\", ufstest_wb_read_write, &wb_test_opts);\n }\n\n libqos_init(ufs_register_nodes);\n", "prefixes": [ "RESEND", "5/5" ] }