Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2218294/?format=api
{ "id": 2218294, "url": "http://patchwork.ozlabs.org/api/patches/2218294/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-ext4/patch/20260331212827.2631020-22-aalbersh@kernel.org/", "project": { "id": 8, "url": "http://patchwork.ozlabs.org/api/projects/8/?format=api", "name": "Linux ext4 filesystem development", "link_name": "linux-ext4", "list_id": "linux-ext4.vger.kernel.org", "list_email": "linux-ext4@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260331212827.2631020-22-aalbersh@kernel.org>", "list_archive_url": null, "date": "2026-03-31T21:28:22", "name": "[v6,21/22] xfs: add fsverity traces", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "a2c122574313d4bbb3529ca41ee44a7c3f305f1f", "submitter": { "id": 92821, "url": "http://patchwork.ozlabs.org/api/people/92821/?format=api", "name": "Andrey Albershteyn", "email": "aalbersh@kernel.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-ext4/patch/20260331212827.2631020-22-aalbersh@kernel.org/mbox/", "series": [ { "id": 498255, "url": "http://patchwork.ozlabs.org/api/series/498255/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-ext4/list/?series=498255", "date": "2026-03-31T21:28:01", "name": "fs-verity support for XFS with post EOF merkle tree", "version": 6, "mbox": "http://patchwork.ozlabs.org/series/498255/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2218294/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2218294/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <SRS0=S4Sy=B7=vger.kernel.org=linux-ext4+bounces-15568-patchwork-incoming=ozlabs.org@ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-ext4@vger.kernel.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "patchwork-incoming@ozlabs.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=u4rU3/l2;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=ozlabs.org\n (client-ip=150.107.74.76; helo=mail.ozlabs.org;\n envelope-from=srs0=s4sy=b7=vger.kernel.org=linux-ext4+bounces-15568-patchwork-incoming=ozlabs.org@ozlabs.org;\n receiver=patchwork.ozlabs.org)", "gandalf.ozlabs.org;\n arc=pass smtp.remote-ip=\"2600:3c04:e001:36c::12fc:5321\"\n arc.chain=subspace.kernel.org", "gandalf.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org", "gandalf.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=u4rU3/l2;\n\tdkim-atps=neutral", "gandalf.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-ext4+bounces-15568-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"u4rU3/l2\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201" ], "Received": [ "from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4flhMT6Ryxz1yGH\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 01 Apr 2026 08:39:01 +1100 (AEDT)", "from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\tby gandalf.ozlabs.org (Postfix) with ESMTP id 4flhMT60tdz4xnL\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 01 Apr 2026 08:39:01 +1100 (AEDT)", "by gandalf.ozlabs.org (Postfix)\n\tid 4flhMT5yBFz58bC; Wed, 01 Apr 2026 08:39:01 +1100 (AEDT)", "from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby gandalf.ozlabs.org (Postfix) with ESMTPS id 4flhMQ2Vvzz4xnL\n\tfor <patchwork-incoming@ozlabs.org>; Wed, 01 Apr 2026 08:38:58 +1100 (AEDT)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 0FCC83188099\n\tfor <patchwork-incoming@ozlabs.org>; Tue, 31 Mar 2026 21:31:45 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id F21B8466B5F;\n\tTue, 31 Mar 2026 21:29:38 +0000 (UTC)", "from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id B21B945BD7A;\n\tTue, 31 Mar 2026 21:29:38 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPSA id E4023C2BC9E;\n\tTue, 31 Mar 2026 21:29:35 +0000 (UTC)" ], "ARC-Seal": [ "i=2; a=rsa-sha256; d=ozlabs.org; s=201707; t=1774993141; cv=pass;\n\tb=ceTNVpZvVg9DG22WqFnn0lQmKaE7zAFjscF6tQaW6mtFcYcRW1c8/FegqYYE8g+Mi57trpNRh727xN5xvUANQl+iw0NC6H9aAyGZFFBLGKWtrRqjxIpCLO539HrQDh2eLomyBimvkdbsieFNz7UvDHvPjLOjchNAW9i3bsIi8oNlS4JoEkkOE1PASNEtBKGMYGAqafvKKcc5NC5WSYEdEdZ+dEH2NuphdqKEC/mcVzJnzfm27SMvX9s6GdAUlxSQf7atogzZ65Kt2evdRE0xZIneMEJlAp7RMUMwaCevQccRYiQsMNoD3ZDr0h+XqhixblJ3MXMlKjHefMm9C+0PqQ==", "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774992578; cv=none;\n b=HquLDwUi154v3FxzXkcFax1RjiPKePRyTH+4Gvf+zsZz2pP63lz8bOS5ThB/NKfvssrKCH/7X1uzIqIGa1J14H5dVU6/QnKDib8vMwaOv1KA+clnaMddysN5kgCQTVIYxKwz/UeOwDxYHSMYKONXLpxGp7AiX8isQnPTvdnC1tI=" ], "ARC-Message-Signature": [ "i=2; a=rsa-sha256; d=ozlabs.org; s=201707;\n\tt=1774993141; c=relaxed/relaxed;\n\tbh=6UeMIH2sG7EWBuSaTAaE36si3YF2Xq+2W9cLdjGxMTo=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=gomwCG71DDJrptsr1FrtAmaOxNcJ5a20z3kVFovExxRwoA2cXmYcegLWYxg5jAiKupn07xxkPqP0xgfrKg3epYNLWb3XHPugYC1tcZGhxroEBvMoN3/YWT3NFQd296fR7rZNMTcUjJRWfTD/CwMa5fs1pDCwnAtMtdkWb59dylwXcusrKnqY6qjifekoijeAv3mnaEXUsy6IipFAfl3RlYIKU7wlUiaoIrsLkhLYLG0PFtEN2gvmpBF3U4gwFT/RbSLj7/gB8NJIhXFvQLBjEiKJOLSGCEmEpZamntyn4aIvl31UhV6f2lDUuHlpO8BJCCKKgOSTlsm9X/UnuS2zKA==", "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774992578; c=relaxed/simple;\n\tbh=jU8tUIfyDbVmI340bc16qdopl8bEAtAs/sdw4PSwkzA=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=d3HMgEzf5WJZk9Lsd2Bte9/63Qp+cRBQbB/VNvNWq/JGJkgF6Trd6K3ucEc7Lf4wuCzRrwf3U1xXzYfvbY08my5f+MabtlWe66Q78Xzo9qzDwF4AsbyHsFoHiVXEugPNcosIauZVwXx1ukxXcJUogYJqL2QmMAWesdH77/BkX2w=" ], "ARC-Authentication-Results": [ "i=2; gandalf.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=u4rU3/l2; dkim-atps=neutral;\n spf=pass (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-ext4+bounces-15568-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org) smtp.mailfrom=vger.kernel.org", "i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=u4rU3/l2; arc=none smtp.client-ip=10.30.226.201" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1774992578;\n\tbh=jU8tUIfyDbVmI340bc16qdopl8bEAtAs/sdw4PSwkzA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=u4rU3/l2AYG2PYxbh58mennpg25Nh9feBtGxyxWzlLyBFNVOe++xtB9d1y+f9wlNI\n\t RDJieKNlxnpIMIjHVlsZnu7IG7HzHfR2cjL25DlQfXzAF3Kl+Jh+XKOnHHalsi3/De\n\t 0lLcF23GHcr1YBmwDCMCa01Sj/Hpbqr1t7g++a+WtJvX31x8IVo0vq4da4uCTihtED\n\t Wwg7WjJ1Q5kDiDDoWTOlUTMJ2Z+vBDL8zwokUieiNkBc1RPGjm+oMAi7xyVCXM6peW\n\t 2pxdui60fS5q9dMsuKrr2cSF+bKXjrupVzpBzSJzF7+O1+kh6uzrp2jQf16cYbZQLh\n\t l47tNKHURyhkw==", "From": "Andrey Albershteyn <aalbersh@kernel.org>", "To": "linux-xfs@vger.kernel.org,\n\tfsverity@lists.linux.dev,\n\tlinux-fsdevel@vger.kernel.org,\n\tebiggers@kernel.org", "Cc": "Andrey Albershteyn <aalbersh@kernel.org>,\n\thch@lst.de,\n\tlinux-ext4@vger.kernel.org,\n\tlinux-f2fs-devel@lists.sourceforge.net,\n\tlinux-btrfs@vger.kernel.org,\n\tdjwong@kernel.org", "Subject": "[PATCH v6 21/22] xfs: add fsverity traces", "Date": "Tue, 31 Mar 2026 23:28:22 +0200", "Message-ID": "<20260331212827.2631020-22-aalbersh@kernel.org>", "X-Mailer": "git-send-email 2.51.2", "In-Reply-To": "<20260331212827.2631020-1-aalbersh@kernel.org>", "References": "<20260331212827.2631020-1-aalbersh@kernel.org>", "Precedence": "bulk", "X-Mailing-List": "linux-ext4@vger.kernel.org", "List-Id": "<linux-ext4.vger.kernel.org>", "List-Subscribe": "<mailto:linux-ext4+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-ext4+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Spam-Status": "No, score=-1.2 required=5.0 tests=ARC_SIGNED,ARC_VALID,\n\tDKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DMARC_PASS,\n\tMAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=disabled\n\tversion=4.0.1", "X-Spam-Checker-Version": "SpamAssassin 4.0.1 (2024-03-25) on gandalf.ozlabs.org" }, "content": "Even though fsverity has traces, debugging issues with varying block\nsizes could be a bit less transparent without read/write traces.\n\nSigned-off-by: Andrey Albershteyn <aalbersh@kernel.org>\nReviewed-by: \"Darrick J. Wong\" <djwong@kernel.org>\n---\n fs/xfs/xfs_fsverity.c | 6 ++++++\n fs/xfs/xfs_trace.h | 46 +++++++++++++++++++++++++++++++++++++++++++\n 2 files changed, 52 insertions(+)", "diff": "diff --git a/fs/xfs/xfs_fsverity.c b/fs/xfs/xfs_fsverity.c\nindex ecc66ee8bac5..6db8113da52f 100644\n--- a/fs/xfs/xfs_fsverity.c\n+++ b/fs/xfs/xfs_fsverity.c\n@@ -64,6 +64,8 @@ xfs_fsverity_get_descriptor(\n \tuint32_t\t\tblocksize = i_blocksize(VFS_I(ip));\n \txfs_fileoff_t\t\tlast_block_offset;\n \n+\ttrace_xfs_fsverity_get_descriptor(ip);\n+\n \tASSERT(inode->i_flags & S_VERITY);\n \terror = xfs_bmap_last_extent(NULL, ip, XFS_DATA_FORK, &rec, &is_empty);\n \tif (error)\n@@ -377,6 +379,7 @@ xfs_fsverity_read_merkle(\n \tpgoff_t\t\t\tindex)\n {\n \tindex += xfs_fsverity_metadata_offset(XFS_I(inode)) >> PAGE_SHIFT;\n+\ttrace_xfs_fsverity_read_merkle(XFS_I(inode), index, PAGE_SIZE);\n \n \treturn generic_read_merkle_tree_page(inode, index);\n }\n@@ -391,6 +394,7 @@ xfs_fsverity_readahead_merkle_tree(\n \tunsigned long\t\tnr_pages)\n {\n \tindex += xfs_fsverity_metadata_offset(XFS_I(inode)) >> PAGE_SHIFT;\n+\ttrace_xfs_fsverity_read_merkle(XFS_I(inode), index, PAGE_SIZE);\n \n \tgeneric_readahead_merkle_tree(inode, index, nr_pages);\n }\n@@ -414,6 +418,8 @@ xfs_fsverity_write_merkle(\n \tconst char\t\t*p;\n \tunsigned int\t\ti;\n \n+\ttrace_xfs_fsverity_write_merkle(XFS_I(inode), position, size);\n+\n \tif (position + size > inode->i_sb->s_maxbytes)\n \t\treturn -EFBIG;\n \ndiff --git a/fs/xfs/xfs_trace.h b/fs/xfs/xfs_trace.h\nindex 5e8190fe2be9..d05f79ec92db 100644\n--- a/fs/xfs/xfs_trace.h\n+++ b/fs/xfs/xfs_trace.h\n@@ -6440,6 +6440,52 @@ TRACE_EVENT(xfs_verify_media_error,\n \t\t __entry->error)\n );\n \n+TRACE_EVENT(xfs_fsverity_get_descriptor,\n+\tTP_PROTO(struct xfs_inode *ip),\n+\tTP_ARGS(ip),\n+\tTP_STRUCT__entry(\n+\t\t__field(dev_t, dev)\n+\t\t__field(xfs_ino_t, ino)\n+\t),\n+\tTP_fast_assign(\n+\t\t__entry->dev = VFS_I(ip)->i_sb->s_dev;\n+\t\t__entry->ino = ip->i_ino;\n+\t),\n+\tTP_printk(\"dev %d:%d ino 0x%llx\",\n+\t\t MAJOR(__entry->dev), MINOR(__entry->dev),\n+\t\t __entry->ino)\n+);\n+\n+DECLARE_EVENT_CLASS(xfs_fsverity_class,\n+\tTP_PROTO(struct xfs_inode *ip, u64 pos, size_t length),\n+\tTP_ARGS(ip, pos, length),\n+\tTP_STRUCT__entry(\n+\t\t__field(dev_t, dev)\n+\t\t__field(xfs_ino_t, ino)\n+\t\t__field(u64, pos)\n+\t\t__field(size_t, length)\n+\t),\n+\tTP_fast_assign(\n+\t\t__entry->dev = VFS_I(ip)->i_sb->s_dev;\n+\t\t__entry->ino = ip->i_ino;\n+\t\t__entry->pos = pos;\n+\t\t__entry->length = length;\n+\t),\n+\tTP_printk(\"dev %d:%d ino 0x%llx pos 0x%llx length 0x%zx\",\n+\t\t MAJOR(__entry->dev), MINOR(__entry->dev),\n+\t\t __entry->ino,\n+\t\t __entry->pos,\n+\t\t __entry->length)\n+)\n+\n+#define DEFINE_FSVERITY_EVENT(name) \\\n+DEFINE_EVENT(xfs_fsverity_class, name, \\\n+\tTP_PROTO(struct xfs_inode *ip, u64 pos, size_t length), \\\n+\tTP_ARGS(ip, pos, length))\n+DEFINE_FSVERITY_EVENT(xfs_fsverity_read_merkle);\n+DEFINE_FSVERITY_EVENT(xfs_fsverity_write_merkle);\n+DEFINE_FSVERITY_EVENT(xfs_fsverity_file_corrupt);\n+\n #endif /* _TRACE_XFS_H */\n \n #undef TRACE_INCLUDE_PATH\n", "prefixes": [ "v6", "21/22" ] }