Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2218276/?format=api
{ "id": 2218276, "url": "http://patchwork.ozlabs.org/api/patches/2218276/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260331211338.15995-1-fw@strlen.de/", "project": { "id": 26, "url": "http://patchwork.ozlabs.org/api/projects/26/?format=api", "name": "Netfilter Development", "link_name": "netfilter-devel", "list_id": "netfilter-devel.vger.kernel.org", "list_email": "netfilter-devel@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260331211338.15995-1-fw@strlen.de>", "list_archive_url": null, "date": "2026-03-31T21:13:36", "name": "[v2,nf] netfilter: x_tables: ensure names are nul-terminated", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "9fabbd60eca40c12955ef3497dfa824041cdac2c", "submitter": { "id": 1025, "url": "http://patchwork.ozlabs.org/api/people/1025/?format=api", "name": "Florian Westphal", "email": "fw@strlen.de" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260331211338.15995-1-fw@strlen.de/mbox/", "series": [ { "id": 498253, "url": "http://patchwork.ozlabs.org/api/series/498253/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netfilter-devel/list/?series=498253", "date": "2026-03-31T21:13:36", "name": "[v2,nf] netfilter: x_tables: ensure names are nul-terminated", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/498253/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2218276/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2218276/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <netfilter-devel+bounces-11523-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "netfilter-devel@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.232.135.74; helo=sto.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-11523-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=91.216.245.30", "smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=strlen.de", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=Chamillionaire.breakpoint.cc" ], "Received": [ "from sto.lore.kernel.org (sto.lore.kernel.org [172.232.135.74])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4flgs75Gg0z1yFv\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 01 Apr 2026 08:16:11 +1100 (AEDT)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 551BB303FEA4\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 31 Mar 2026 21:13:50 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 48C11402B8E;\n\tTue, 31 Mar 2026 21:13:47 +0000 (UTC)", "from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc\n [91.216.245.30])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BE643D6CBE\n\tfor <netfilter-devel@vger.kernel.org>; Tue, 31 Mar 2026 21:13:45 +0000 (UTC)", "by Chamillionaire.breakpoint.cc (Postfix, from userid 1003)\n\tid 63D226078E; Tue, 31 Mar 2026 23:13:43 +0200 (CEST)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774991627; cv=none;\n b=nobO1MJ37fOtNg6LMMSMHGZh/L9yclPj0a3Wi9WVpzUDDHzjARVsiGAVq9AZMixvD0zHZg5c5+hSgozD7qiZsTs88sBjzy+v6BCABSl8tQvSuC6SfGOy6uVdHhkMX4nYeSvMau/ptZ33eCokl9Eyny5eBw+HLlNkA8qdWTvcCoU=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774991627; c=relaxed/simple;\n\tbh=ONI0eIM/MQUr55TFlQd/wY01Vj3g/Xo+o7+2ZFpM4zE=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=uOL8jiZvLKmr+858r2XqXr7N1r5vSm15eDJGOsJU07PskT+aAnzl6prSUGDv8HL1/gyKcCnnljMjyymQP9awADIaEivPc9F07yzQIE1UVxnpD1NiYvZ6i/EKWVTXapEaYhZJLWHHRc70OTEVPuhruouSXCS8ig8Tt31vf/NIk1w=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=strlen.de;\n spf=pass smtp.mailfrom=Chamillionaire.breakpoint.cc;\n arc=none smtp.client-ip=91.216.245.30", "From": "Florian Westphal <fw@strlen.de>", "To": "<netfilter-devel@vger.kernel.org>", "Cc": "Florian Westphal <fw@strlen.de>", "Subject": "[PATCH v2 nf] netfilter: x_tables: ensure names are nul-terminated", "Date": "Tue, 31 Mar 2026 23:13:36 +0200", "Message-ID": "<20260331211338.15995-1-fw@strlen.de>", "X-Mailer": "git-send-email 2.52.0", "Precedence": "bulk", "X-Mailing-List": "netfilter-devel@vger.kernel.org", "List-Id": "<netfilter-devel.vger.kernel.org>", "List-Subscribe": "<mailto:netfilter-devel+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:netfilter-devel+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit" }, "content": "Reject names that lack a \\0 character before feeding them\nto functions that expect c-strings.\n\nFixes tag is the most recent commit that needs this change.\n\nFixes: c38c4597e4bf (\"netfilter: implement xt_cgroup cgroup2 path match\")\nSigned-off-by: Florian Westphal <fw@strlen.de>\n---\n v2: drop physdev hunk, its not strictly needed, ifname_compare_aligned()\n doesn't reply on '\\0'.\n I'll followup in nf-next to also reject empty strings in physdev.\n\n net/netfilter/xt_cgroup.c | 6 ++++++\n net/netfilter/xt_rateest.c | 5 +++++\n 2 files changed, 11 insertions(+)", "diff": "diff --git a/net/netfilter/xt_cgroup.c b/net/netfilter/xt_cgroup.c\nindex c437fbd59ec1..43d2ae2be628 100644\n--- a/net/netfilter/xt_cgroup.c\n+++ b/net/netfilter/xt_cgroup.c\n@@ -65,6 +65,9 @@ static int cgroup_mt_check_v1(const struct xt_mtchk_param *par)\n \n \tinfo->priv = NULL;\n \tif (info->has_path) {\n+\t\tif (strnlen(info->path, sizeof(info->path)) >= sizeof(info->path))\n+\t\t\treturn -ENAMETOOLONG;\n+\n \t\tcgrp = cgroup_get_from_path(info->path);\n \t\tif (IS_ERR(cgrp)) {\n \t\t\tpr_info_ratelimited(\"invalid path, errno=%ld\\n\",\n@@ -102,6 +105,9 @@ static int cgroup_mt_check_v2(const struct xt_mtchk_param *par)\n \n \tinfo->priv = NULL;\n \tif (info->has_path) {\n+\t\tif (strnlen(info->path, sizeof(info->path)) >= sizeof(info->path))\n+\t\t\treturn -ENAMETOOLONG;\n+\n \t\tcgrp = cgroup_get_from_path(info->path);\n \t\tif (IS_ERR(cgrp)) {\n \t\t\tpr_info_ratelimited(\"invalid path, errno=%ld\\n\",\ndiff --git a/net/netfilter/xt_rateest.c b/net/netfilter/xt_rateest.c\nindex 72324bd976af..b1d736c15fcb 100644\n--- a/net/netfilter/xt_rateest.c\n+++ b/net/netfilter/xt_rateest.c\n@@ -91,6 +91,11 @@ static int xt_rateest_mt_checkentry(const struct xt_mtchk_param *par)\n \t\tgoto err1;\n \t}\n \n+\tif (strnlen(info->name1, sizeof(info->name1)) >= sizeof(info->name1))\n+\t\treturn -ENAMETOOLONG;\n+\tif (strnlen(info->name2, sizeof(info->name2)) >= sizeof(info->name2))\n+\t\treturn -ENAMETOOLONG;\n+\n \tret = -ENOENT;\n \test1 = xt_rateest_lookup(par->net, info->name1);\n \tif (!est1)\n", "prefixes": [ "v2", "nf" ] }