Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2218204/?format=api
{ "id": 2218204, "url": "http://patchwork.ozlabs.org/api/patches/2218204/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/patch/20260331161027.747628-1-hjl.tools@gmail.com/", "project": { "id": 17, "url": "http://patchwork.ozlabs.org/api/projects/17/?format=api", "name": "GNU Compiler Collection", "link_name": "gcc", "list_id": "gcc-patches.gcc.gnu.org", "list_email": "gcc-patches@gcc.gnu.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260331161027.747628-1-hjl.tools@gmail.com>", "list_archive_url": null, "date": "2026-03-31T16:10:27", "name": "Check BIGGEST_ALIGNMENT when forcing a local copy", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "c2f7730eb549c18e1b9ab1ffb7a6c5c735d2baa9", "submitter": { "id": 4387, "url": "http://patchwork.ozlabs.org/api/people/4387/?format=api", "name": "H.J. Lu", "email": "hjl.tools@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/gcc/patch/20260331161027.747628-1-hjl.tools@gmail.com/mbox/", "series": [ { "id": 498227, "url": "http://patchwork.ozlabs.org/api/series/498227/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/list/?series=498227", "date": "2026-03-31T16:10:27", "name": "Check BIGGEST_ALIGNMENT when forcing a local copy", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/498227/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2218204/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2218204/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=X6ep/bDL;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)", "sourceware.org;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=X6ep/bDL", "sourceware.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com", "sourceware.org; spf=pass smtp.mailfrom=gmail.com", "server2.sourceware.org;\n arc=none smtp.remote-ip=74.125.82.53" ], "Received": [ "from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4flY6X5HGHz1yCp\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 01 Apr 2026 03:12:20 +1100 (AEDT)", "from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id AC51A4BA543C\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 31 Mar 2026 16:12:18 +0000 (GMT)", "from mail-dl1-f53.google.com (mail-dl1-f53.google.com\n [74.125.82.53])\n by sourceware.org (Postfix) with ESMTPS id CBEA94B7A1EA\n for <gcc-patches@gcc.gnu.org>; Tue, 31 Mar 2026 16:10:35 +0000 (GMT)", "by mail-dl1-f53.google.com with SMTP id\n a92af1059eb24-128ebee22caso201757c88.0\n for <gcc-patches@gcc.gnu.org>; Tue, 31 Mar 2026 09:10:35 -0700 (PDT)", "from gnu-tgl-3.localdomain ([172.59.163.89])\n by smtp.gmail.com with ESMTPSA id\n 5a478bee46e88-2c3c747e410sm10414193eec.25.2026.03.31.09.10.33\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 31 Mar 2026 09:10:33 -0700 (PDT)", "from gnu-tgl-3.localdomain (localhost [127.0.0.1])\n by gnu-tgl-3.localdomain (Postfix) with ESMTP id 9A555C0280;\n Tue, 31 Mar 2026 09:10:32 -0700 (PDT)" ], "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 sourceware.org AC51A4BA543C", "OpenDKIM Filter v2.11.0 sourceware.org CBEA94B7A1EA" ], "DMARC-Filter": "OpenDMARC Filter v1.4.2 sourceware.org CBEA94B7A1EA", "ARC-Filter": "OpenARC Filter v1.0.0 sourceware.org CBEA94B7A1EA", "ARC-Seal": "i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1774973436; cv=none;\n b=VeKdvmXiz2v2MF8xSp3q7AzORK/DZ5GnJR5cRX0njvYzBFbdRuiQsV4qu/7ifzBXhkTV6DbNwtvYKWnKdmsys6boDQvm2gc63MUxgp45zCfymrp/tSNfJBSgihCXz2FHM4/cfVIzMQEfO/pR5wl+JI/yVbxjWhvboqrBFp3YVk0=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1774973436; c=relaxed/simple;\n bh=7AbILJjMLcM/3L74niRudDEoA23+70XdUE2PvqnS3Yc=;\n h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version;\n b=wv16ynmbAE03OZP0uy8lMOu+VccIDeaRg0/8IBPSlM1VMU+Kgk15vNgMY6lrfTgOEQOTDToP/HF7C8+ITw/iy6DYI+wfXShFrLt04d5YvWLcDEskez/bP3idy83z0V9SPPgTW8KXidyCKtpoXfPw9zxeXVEQOn6YAcxH0/XDpKI=", "ARC-Authentication-Results": "i=1; server2.sourceware.org", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1774973434; x=1775578234; darn=gcc.gnu.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=fd/HXhFuiP5c905fX7PKBYx3Fx6T5eU/fKzncKWsfUo=;\n b=X6ep/bDLDMPqLNvrHh6pKy/zzCCTdY+sdvCg0maLQY2/5zpYqoS8ZqkJ3i7xa3BbdJ\n a3wpl4Cw10tf24BBirvbIL1n52ClcCv+k8utHsx20c1LwL3tMWyAtXIh53SJmAhHBGNI\n PNagbr1vPGLMe9BFRhTSiRwjI6/eUw67YD4IbAVV38oci9IGvhEyrhDL8rmhSOtZsG/X\n k/UeNrtj6Ag+KmYOqK0FNB0zedTsd8YMgy0cHA2/YLuwpzqvtqUHydhTxaDG6ie9y6ke\n RIC9zVUlXRoPrl+271ubMJdM8Db70FkQtQi7Mlbd9SCVY4vg1mWF6h+EZ9tjmqToctyn\n YEdQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774973434; x=1775578234;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=fd/HXhFuiP5c905fX7PKBYx3Fx6T5eU/fKzncKWsfUo=;\n b=DIfrozRlILrm7YNZgW9h3SG1AdwvyGZ//P2GNTHT9VIyFEWZQZJWTPn0eFcCxO3B5t\n WLpkgBaF24dOM36e+4aRjGIdjzE1mpPObRbefWL+dJB73lxYAAb+qxYVO+/TxBkmHPPU\n g7LWCcrAY1PA815f5nxetiQEjaFJtqiRg1c+WVa5Yu+Ozo884qJ/u3aeK8p5hNaWjuj/\n yO2ul1gyi8wkkZn8r8vN96AOAQBPclAwAS8D6I/sxIpFnsaaiFcvaSi23z6st0MY8lxG\n 4MLsPorozZm0eeS9oMEqAIXsqytaBINrOjfgjRQwvToK+YZuasXLCYKzhOqmB/yluHjr\n yc5Q==", "X-Gm-Message-State": "AOJu0YzdbMQy0clmxOOreqI1lJLjMC+r5CgSjyCKQ1+gUMVqcPs+4ojJ\n 2ErQ5NyCj2xPwUcB3GIxLn9HkChcBu8n6cTSY3SnajTViGUrlz+4yJadCXVaMQ==", "X-Gm-Gg": "ATEYQzxZtN12ja9jmiKqiAsxJbp/+ul/razktbbOnvx85muXrrNtadd/kdwYj5qB4vs\n mHb3NXR/RyTwJrv8ooO5bVj8MDi5pTdCxAQ915wM4M9ulN4piVlJgeKKkDK9sNNw5jOxzZwgwDR\n HI9xh/KIY1i1pBPxtMtjcJayG0879ECsDmJa0ovHGttTwKzaanhAPdB0Bu5aPMSEd3YwnaA+lfy\n 8M4ZAvWT2tC9CDTWg58kiVj8ZkitPxzywtqA8pSR9q4geZDUknXoj3IaOmACr6Um0vGScr0vQUi\n l5OflGe1B7BnehUg3hK5al0nGm9rWlQY5sw7yByvb5ZN7oUDuhnUqUr67dSK6duFKIDJh2PAJG6\n 7n5P/F6kg3GT4gKILSXNg097lvpzQ41R+BJmlRhN6znJRFpOnIbSbSriVHxoU0x436NMLZzud48\n J9Lyfm8SdVkLafLM5C3+8xERbUXCr1HQ5c82TQU1k=", "X-Received": "by 2002:a05:7301:fd83:b0:2c4:d01f:6ef7 with SMTP id\n 5a478bee46e88-2c4d01f7147mr4945774eec.13.1774973434123;\n Tue, 31 Mar 2026 09:10:34 -0700 (PDT)", "From": "\"H.J. Lu\" <hjl.tools@gmail.com>", "To": "gcc-patches@gcc.gnu.org", "Cc": "rguenther@suse.de", "Subject": "[PATCH] Check BIGGEST_ALIGNMENT when forcing a local copy", "Date": "Tue, 31 Mar 2026 09:10:27 -0700", "Message-ID": "<20260331161027.747628-1-hjl.tools@gmail.com>", "X-Mailer": "git-send-email 2.53.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "gcc-patches@gcc.gnu.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Gcc-patches mailing list <gcc-patches.gcc.gnu.org>", "List-Unsubscribe": "<https://gcc.gnu.org/mailman/options/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>", "List-Archive": "<https://gcc.gnu.org/pipermail/gcc-patches/>", "List-Post": "<mailto:gcc-patches@gcc.gnu.org>", "List-Help": "<mailto:gcc-patches-request@gcc.gnu.org?subject=help>", "List-Subscribe": "<https://gcc.gnu.org/mailman/listinfo/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>", "Errors-To": "gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org" }, "content": "BIGGEST_ALIGNMENT is the biggest alignment that any data type can require\non the target machine. It is not the biggest alignment that is supported,\njust the biggest alignment that, when violated, may cause a fault.\n\nMAX_SUPPORTED_STACK_ALIGNMENT is the maximum stack alignment guaranteed by\nthe backend. If SUPPORTS_STACK_ALIGNMENT is false, it is defined as\nPREFERRED_STACK_BOUNDARY.\n\nAdjust alignment check forcing a local copy if the argument on stack is\nnot aligned to its type and the current alignment is less than the\nminimum of BIGGEST_ALIGNMENT and MAX_SUPPORTED_STACK_ALIGNMENT.\n\ngcc/\n\n\tPR middle-end/124697\n\t* function.cc (assign_parm_adjust_stack_rtl): Force a local copy\n\tif the current alignment is less than the minimum of\n\tBIGGEST_ALIGNMENT and MAX_SUPPORTED_STACK_ALIGNMENT.\n\ngcc/testsuite/\n\n\tPR middle-end/124697\n\t* gcc.target/i386/pr124697-1a.c: New test.\n\t* gcc.target/i386/pr124697-1b.c: Likewise.\n\t* gcc.target/i386/pr124697-2a.c: Likewise.\n\t* gcc.target/i386/pr124697-2b.c: Likewise.\n\t* gcc.target/i386/pr124697-3a.c: Likewise.\n\t* gcc.target/i386/pr124697-3b.c: Likewise.\n\nSigned-off-by: H.J. Lu <hjl.tools@gmail.com>\n---\n gcc/function.cc | 3 +-\n gcc/testsuite/gcc.target/i386/pr124697-1a.c | 31 +++++++++++++++++++++\n gcc/testsuite/gcc.target/i386/pr124697-1b.c | 19 +++++++++++++\n gcc/testsuite/gcc.target/i386/pr124697-2a.c | 30 ++++++++++++++++++++\n gcc/testsuite/gcc.target/i386/pr124697-2b.c | 18 ++++++++++++\n gcc/testsuite/gcc.target/i386/pr124697-3a.c | 31 +++++++++++++++++++++\n gcc/testsuite/gcc.target/i386/pr124697-3b.c | 19 +++++++++++++\n 7 files changed, 150 insertions(+), 1 deletion(-)\n create mode 100644 gcc/testsuite/gcc.target/i386/pr124697-1a.c\n create mode 100644 gcc/testsuite/gcc.target/i386/pr124697-1b.c\n create mode 100644 gcc/testsuite/gcc.target/i386/pr124697-2a.c\n create mode 100644 gcc/testsuite/gcc.target/i386/pr124697-2b.c\n create mode 100644 gcc/testsuite/gcc.target/i386/pr124697-3a.c\n create mode 100644 gcc/testsuite/gcc.target/i386/pr124697-3b.c", "diff": "diff --git a/gcc/function.cc b/gcc/function.cc\nindex 46c0d8b54c2..109821c16fc 100644\n--- a/gcc/function.cc\n+++ b/gcc/function.cc\n@@ -2840,7 +2840,8 @@ assign_parm_adjust_stack_rtl (tree parm, struct assign_parm_data_one *data)\n \t\t\t\t\t\t MEM_ALIGN (stack_parm))))\n \t || (data->nominal_type\n \t && TYPE_ALIGN (data->nominal_type) > MEM_ALIGN (stack_parm)\n-\t && (MEM_ALIGN (stack_parm) < PREFERRED_STACK_BOUNDARY\n+\t && ((MEM_ALIGN (stack_parm)\n+\t\t < MIN (BIGGEST_ALIGNMENT, MAX_SUPPORTED_STACK_ALIGNMENT))\n \t\t /* If its address is taken, make a local copy whose\n \t\t maximum alignment is MAX_SUPPORTED_STACK_ALIGNMENT.\n \t\t */\ndiff --git a/gcc/testsuite/gcc.target/i386/pr124697-1a.c b/gcc/testsuite/gcc.target/i386/pr124697-1a.c\nnew file mode 100644\nindex 00000000000..63d5cc7862c\n--- /dev/null\n+++ b/gcc/testsuite/gcc.target/i386/pr124697-1a.c\n@@ -0,0 +1,31 @@\n+/* { dg-do run { target avx2_runtime } } */\n+/* { dg-options \"-O2 -mavx2\" } */\n+\n+typedef double v4df __attribute__((vector_size(32)));\n+typedef double v2df __attribute__((vector_size(16)));\n+typedef struct {\n+ v2df a[2];\n+} c __attribute__((aligned(32)));\n+v4df d;\n+c v;\n+\n+__attribute__ ((noipa))\n+void\n+foo (float a1, float a2, float a3, float a4, float a5, float a6, c f)\n+{\n+ d = *(v4df *) &f;\n+}\n+\n+__attribute__ ((noipa))\n+void\n+bar (void)\n+{\n+ foo (0, 0, 0, 0, 0, 0, v);\n+}\n+\n+int\n+main ()\n+{\n+ bar ();\n+ return 0;\n+}\ndiff --git a/gcc/testsuite/gcc.target/i386/pr124697-1b.c b/gcc/testsuite/gcc.target/i386/pr124697-1b.c\nnew file mode 100644\nindex 00000000000..3b74f62b508\n--- /dev/null\n+++ b/gcc/testsuite/gcc.target/i386/pr124697-1b.c\n@@ -0,0 +1,19 @@\n+/* { dg-do compile } */\n+/* { dg-options \"-O2 -mno-avx512f -mavx2\" } */\n+/* { dg-final { scan-assembler-times \"vmovupd.*, %ymm0\" 1 } } */\n+/* { dg-final { scan-assembler \"and\\[lq\\]?\\[\\\\t \\]*\\\\$-32,\\[\\\\t \\]*%\\[re\\]?sp\" } } */\n+/* { dg-final { scan-assembler-not \"vmovapd.*, %ymm0\" } } */\n+\n+typedef double v4df __attribute__((vector_size(32)));\n+typedef double v2df __attribute__((vector_size(16)));\n+typedef struct {\n+ v2df a[2];\n+} c __attribute__((aligned(32)));\n+v4df d;\n+c v;\n+\n+void\n+foo (float a1, float a2, float a3, float a4, float a5, float a6, c f)\n+{\n+ d = *(v4df *) &f;\n+}\ndiff --git a/gcc/testsuite/gcc.target/i386/pr124697-2a.c b/gcc/testsuite/gcc.target/i386/pr124697-2a.c\nnew file mode 100644\nindex 00000000000..46a1f953290\n--- /dev/null\n+++ b/gcc/testsuite/gcc.target/i386/pr124697-2a.c\n@@ -0,0 +1,30 @@\n+/* { dg-do run { target avx2_runtime } } */\n+/* { dg-options \"-O2 -mavx2\" } */\n+\n+typedef double v4df __attribute__((vector_size(32)));\n+typedef struct {\n+ v4df a[2];\n+} c __attribute__((aligned(64)));\n+v4df d;\n+c v;\n+\n+__attribute__ ((noipa))\n+void\n+foo (float a1, float a2, float a3, float a4, float a5, float a6, c f)\n+{\n+ d = *(v4df *) &f;\n+}\n+\n+__attribute__ ((noipa))\n+void\n+bar (void)\n+{\n+ foo (0, 0, 0, 0, 0, 0, v);\n+}\n+\n+int\n+main ()\n+{\n+ bar ();\n+ return 0;\n+}\ndiff --git a/gcc/testsuite/gcc.target/i386/pr124697-2b.c b/gcc/testsuite/gcc.target/i386/pr124697-2b.c\nnew file mode 100644\nindex 00000000000..1c2256df9b9\n--- /dev/null\n+++ b/gcc/testsuite/gcc.target/i386/pr124697-2b.c\n@@ -0,0 +1,18 @@\n+/* { dg-do compile } */\n+/* { dg-options \"-O2 -mno-avx512f -mavx2\" } */\n+/* { dg-final { scan-assembler-times \"vmovapd.*, %ymm0\" 1 } } */\n+/* { dg-final { scan-assembler-not \"vmovupd.*, %ymm0\" } } */\n+/* { dg-final { scan-assembler-not \"and\\[lq\\]?\\[\\\\t \\]*\\\\$-64,\\[\\\\t \\]*%\\[re\\]?sp\" } } */\n+\n+typedef double v4df __attribute__((vector_size(32)));\n+typedef struct {\n+ v4df a[2];\n+} c __attribute__((aligned(64)));\n+v4df d;\n+c v;\n+\n+void\n+foo (float a1, float a2, float a3, float a4, float a5, float a6, c f)\n+{\n+ d = *(v4df *) &f;\n+}\ndiff --git a/gcc/testsuite/gcc.target/i386/pr124697-3a.c b/gcc/testsuite/gcc.target/i386/pr124697-3a.c\nnew file mode 100644\nindex 00000000000..87e6f6f7520\n--- /dev/null\n+++ b/gcc/testsuite/gcc.target/i386/pr124697-3a.c\n@@ -0,0 +1,31 @@\n+/* { dg-do run { target avx512f_runtime } } */\n+/* { dg-options \"-O2 -mavx512f\" } */\n+\n+typedef double v4df __attribute__((vector_size(32)));\n+typedef double v8df __attribute__((vector_size(64)));\n+typedef struct {\n+ v4df a[2];\n+} c __attribute__((aligned(64)));\n+v8df d;\n+c v;\n+\n+__attribute__ ((noipa))\n+void\n+foo (float a1, float a2, float a3, float a4, float a5, float a6, c f)\n+{\n+ d = *(v8df *) &f;\n+}\n+\n+__attribute__ ((noipa))\n+void\n+bar (void)\n+{\n+ foo (0, 0, 0, 0, 0, 0, v);\n+}\n+\n+int\n+main ()\n+{\n+ bar ();\n+ return 0;\n+}\ndiff --git a/gcc/testsuite/gcc.target/i386/pr124697-3b.c b/gcc/testsuite/gcc.target/i386/pr124697-3b.c\nnew file mode 100644\nindex 00000000000..31d52f83ad5\n--- /dev/null\n+++ b/gcc/testsuite/gcc.target/i386/pr124697-3b.c\n@@ -0,0 +1,19 @@\n+/* { dg-do compile } */\n+/* { dg-options \"-O2 -mavx512f\" } */\n+/* { dg-final { scan-assembler-times \"vmovupd.*, %zmm0\" 1 } } */\n+/* { dg-final { scan-assembler \"and\\[lq\\]?\\[\\\\t \\]*\\\\$-64,\\[\\\\t \\]*%\\[re\\]?sp\" } } */\n+/* { dg-final { scan-assembler-not \"vmovapd.*, %zmm0\" } } */\n+\n+typedef double v4df __attribute__((vector_size(32)));\n+typedef double v8df __attribute__((vector_size(64)));\n+typedef struct {\n+ v4df a[2];\n+} c __attribute__((aligned(64)));\n+v8df d;\n+c v;\n+\n+void\n+foo (float a1, float a2, float a3, float a4, float a5, float a6, c f)\n+{\n+ d = *(v8df *) &f;\n+}\n", "prefixes": [] }