Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2218182/?format=api
{ "id": 2218182, "url": "http://patchwork.ozlabs.org/api/patches/2218182/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260331150146.958012-1-pablo@netfilter.org/", "project": { "id": 26, "url": "http://patchwork.ozlabs.org/api/projects/26/?format=api", "name": "Netfilter Development", "link_name": "netfilter-devel", "list_id": "netfilter-devel.vger.kernel.org", "list_email": "netfilter-devel@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260331150146.958012-1-pablo@netfilter.org>", "list_archive_url": null, "date": "2026-03-31T15:01:46", "name": "[nf] netfilter: x_tables: restrict xt_check_match/xt_check_target extensions for NFPROTO_ARP", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "ce2eb7d146f8286e3e2124915e7ad21c9f3c31ca", "submitter": { "id": 1315, "url": "http://patchwork.ozlabs.org/api/people/1315/?format=api", "name": "Pablo Neira Ayuso", "email": "pablo@netfilter.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260331150146.958012-1-pablo@netfilter.org/mbox/", "series": [ { "id": 498216, "url": "http://patchwork.ozlabs.org/api/series/498216/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netfilter-devel/list/?series=498216", "date": "2026-03-31T15:01:46", "name": "[nf] netfilter: x_tables: restrict xt_check_match/xt_check_target extensions for NFPROTO_ARP", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/498216/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2218182/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2218182/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <netfilter-devel+bounces-11518-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "netfilter-devel@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=netfilter.org header.i=@netfilter.org\n header.a=rsa-sha256 header.s=2025 header.b=HcbCkZa2;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.105.105.114; helo=tor.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-11518-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=netfilter.org header.i=@netfilter.org\n header.b=\"HcbCkZa2\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=217.70.190.124", "smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=netfilter.org", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=netfilter.org" ], "Received": [ "from tor.lore.kernel.org (tor.lore.kernel.org [172.105.105.114])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4flWg86svTz1y1q\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 01 Apr 2026 02:07:00 +1100 (AEDT)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id C1B253093C16\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 31 Mar 2026 15:02:03 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id ECFAA3E8698;\n\tTue, 31 Mar 2026 15:02:02 +0000 (UTC)", "from mail.netfilter.org (mail.netfilter.org [217.70.190.124])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C3403E4C7F\n\tfor <netfilter-devel@vger.kernel.org>; Tue, 31 Mar 2026 15:01:58 +0000 (UTC)", "from localhost.localdomain (mail-agni [217.70.190.124])\n\tby mail.netfilter.org (Postfix) with ESMTPSA id B9F5D6017A;\n\tTue, 31 Mar 2026 17:01:50 +0200 (CEST)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774969322; cv=none;\n b=N93MYkyyh+t/TSUql6VQ+V/GiJ53On47OJlJoIxIlf8eiPmtU5y8POrivfZ6UwtG9GgtfbJ68PFggGhPjn7hU6iFzww9FrfXxKLPrHnKGkTCNczC39SHZ/3ZrIL+7G80CA2G9U96H5evWN/QY9dQPxhcXRd9SwC7Hj6anNlYjP0=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774969322; c=relaxed/simple;\n\tbh=uqiLxyIL8AMkbwebZdpSbYp7otyM19oP1Uw1ByBFFjs=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=L/vSG8Pi/V7fAY3tMsxeXq5uauCAsxwxEy0vOB7Jzc4td9yRyos63KrQ398z1j8g+BLYMFQn5kvHZqZXQl1B+O9Ub0Co5l63f4inPyyq4cP8zpWAxskGREuxZRMdLuDe78N2kfA4FTSuJfCQEVnVVkM45NykKEnlEteWeQhZscc=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=netfilter.org;\n spf=pass smtp.mailfrom=netfilter.org;\n dkim=pass (2048-bit key) header.d=netfilter.org header.i=@netfilter.org\n header.b=HcbCkZa2; arc=none smtp.client-ip=217.70.190.124", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=netfilter.org;\n\ts=2025; t=1774969311;\n\tbh=YKqoKW/VuukbjvzzahFZIHnVh4mXrAGZvDNR95Nw5wY=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=HcbCkZa2Om3S4wnLlJ6/qirkqLNrS49LZjUPrEBLs096QEI2Qs91QTKUyaI/kc91f\n\t j8s0pID5AzatJeSv378vlY217+F4djG3gO0jkWOGQT7ohdIaXQhjHg/3bQw4t+lYTL\n\t 8vP0muZL//0AXFg7bL8dTIQhJu/e2sHrkwuBmROOyxcDH1R6K3ytDjMq98yRQJ5umi\n\t oFZ/u6QMUYyIHZqhP6N5YdmHR5toTUIWkjULqQ9LtdAs21h+o9am0az0972v2Y2crH\n\t SZpAzEynDHJnhV+jEq8QY+97GsBflPtUhMUnA5mvO3D2gjm/HL1tvy+/rZcj//8HmI\n\t twOC6Sb2fL6Fw==", "From": "Pablo Neira Ayuso <pablo@netfilter.org>", "To": "netfilter-devel@vger.kernel.org", "Cc": "fw@strlen.de,\n\tbestswngs@gmail.com", "Subject": "[PATCH nf] netfilter: x_tables: restrict\n xt_check_match/xt_check_target extensions for NFPROTO_ARP", "Date": "Tue, 31 Mar 2026 17:01:46 +0200", "Message-ID": "<20260331150146.958012-1-pablo@netfilter.org>", "X-Mailer": "git-send-email 2.47.3", "Precedence": "bulk", "X-Mailing-List": "netfilter-devel@vger.kernel.org", "List-Id": "<netfilter-devel.vger.kernel.org>", "List-Subscribe": "<mailto:netfilter-devel+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:netfilter-devel+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit" }, "content": "Weiming Shi says:\n\nxt_match and xt_target structs registered with NFPROTO_UNSPEC can be\nloaded by any protocol family through nft_compat. When such a\nmatch/target sets .hooks to restrict which hooks it may run on, the\nbitmask uses NF_INET_* constants. This is only correct for families\nwhose hook layout matches NF_INET_*: IPv4, IPv6, INET, and bridge\nall share the same five hooks (PRE_ROUTING ... POST_ROUTING).\n\nARP only has three hooks (IN=0, OUT=1, FORWARD=2) with different\nsemantics. Because NF_ARP_OUT == 1 == NF_INET_LOCAL_IN, the .hooks\nvalidation silently passes for the wrong reasons, allowing matches to\nrun on ARP chains where the hook assumptions (e.g. state->in being\nset on input hooks) do not hold. This leads to NULL pointer\ndereferences; xt_devgroup is one concrete example:\n\n Oops: general protection fault, probably for non-canonical address 0xdffffc0000000044: 0000 [#1] SMP KASAN NOPTI\n KASAN: null-ptr-deref in range [0x0000000000000220-0x0000000000000227]\n RIP: 0010:devgroup_mt+0xff/0x350\n Call Trace:\n <TASK>\n nft_match_eval (net/netfilter/nft_compat.c:407)\n nft_do_chain (net/netfilter/nf_tables_core.c:285)\n nft_do_chain_arp (net/netfilter/nft_chain_filter.c:61)\n nf_hook_slow (net/netfilter/core.c:623)\n arp_xmit (net/ipv4/arp.c:666)\n </TASK>\n Kernel panic - not syncing: Fatal exception in interrupt\n\nFix it by restricting arptables to NFPROTO_ARP extensions only.\nNote that arptables-legacy only supports:\n\n- arpt_CLASSIFY\n- arpt_mangle\n- arpt_MARK\n\nthat provide explicit NFPROTO_ARP match/target declarations.\n\nFixes: 9291747f118d (\"netfilter: xtables: add device group match\")\nReported-by: Xiang Mei <xmei5@asu.edu>\nSigned-off-by: Florian Westphal <fw@strlen.de>\nSigned-off-by: Pablo Neira Ayuso <pablo@netfilter.org>\n---\nAlternative to:\n\n[PATCH nf v2] netfilter: x_tables: reject unsupported families in xt_check_match/xt_check_target\n\n net/netfilter/x_tables.c | 23 +++++++++++++++++++++++\n 1 file changed, 23 insertions(+)", "diff": "diff --git a/net/netfilter/x_tables.c b/net/netfilter/x_tables.c\nindex e594b3b7ad82..b39017c80548 100644\n--- a/net/netfilter/x_tables.c\n+++ b/net/netfilter/x_tables.c\n@@ -501,6 +501,17 @@ int xt_check_match(struct xt_mtchk_param *par,\n \t\t\t\t par->match->table, par->table);\n \t\treturn -EINVAL;\n \t}\n+\n+\t/* NFPROTO_UNSPEC implies NF_INET_* hooks which do not overlap with\n+\t * NF_ARP_IN,OUT,FORWARD, allow explicit extensions with NFPROTO_ARP\n+\t * support.\n+\t */\n+\tif (par->family == NFPROTO_ARP &&\n+\t par->match->family != NFPROTO_ARP) {\n+\t\tpr_info_ratelimited(\"%s_tables: %s match: not valid for this family\\n\",\n+\t\t\t\t xt_prefix[par->family], par->match->name);\n+\t\treturn -EINVAL;\n+\t}\n \tif (par->match->hooks && (par->hook_mask & ~par->match->hooks) != 0) {\n \t\tchar used[64], allow[64];\n \n@@ -1016,6 +1027,18 @@ int xt_check_target(struct xt_tgchk_param *par,\n \t\t\t\t par->target->table, par->table);\n \t\treturn -EINVAL;\n \t}\n+\n+\t/* NFPROTO_UNSPEC implies NF_INET_* hooks which do not overlap with\n+\t * NF_ARP_IN,OUT,FORWARD, allow explicit extensions with NFPROTO_ARP\n+\t * support.\n+\t */\n+\tif (par->family == NFPROTO_ARP &&\n+\t par->target->family != NFPROTO_ARP) {\n+\t\tpr_info_ratelimited(\"%s_tables: %s target: not valid for this family\\n\",\n+\t\t\t\t xt_prefix[par->family], par->target->name);\n+\t\treturn -EINVAL;\n+\t}\n+\n \tif (par->target->hooks && (par->hook_mask & ~par->target->hooks) != 0) {\n \t\tchar used[64], allow[64];\n \n", "prefixes": [ "nf" ] }