Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2218175/?format=api
{ "id": 2218175, "url": "http://patchwork.ozlabs.org/api/patches/2218175/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260331150352.256332-3-kwolf@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260331150352.256332-3-kwolf@redhat.com>", "list_archive_url": null, "date": "2026-03-31T15:03:48", "name": "[PULL,2/6] scsi: Don't consider LOGICAL UNIT NOT SUPPORTED guest recoverable", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "6b4ae460df38be13ecec2dabcf34a7b1dfaf00ea", "submitter": { "id": 2714, "url": "http://patchwork.ozlabs.org/api/people/2714/?format=api", "name": "Kevin Wolf", "email": "kwolf@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260331150352.256332-3-kwolf@redhat.com/mbox/", "series": [ { "id": 498214, "url": "http://patchwork.ozlabs.org/api/series/498214/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=498214", "date": "2026-03-31T15:03:47", "name": "[PULL,1/6] ide: Fix potential assertion failure on VM stop for PIO read error", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/498214/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2218175/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2218175/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=KjHFuoRd;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4flWcd66d5z1yGH\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 01 Apr 2026 02:04:49 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w7adX-0003G6-RF; Tue, 31 Mar 2026 11:04:11 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <kwolf@redhat.com>) id 1w7adV-0003Bu-D7\n for qemu-devel@nongnu.org; Tue, 31 Mar 2026 11:04:09 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <kwolf@redhat.com>) id 1w7adT-0002Xt-Jl\n for qemu-devel@nongnu.org; Tue, 31 Mar 2026 11:04:09 -0400", "from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-594-sTovVP-JP0WenJ1z7xIUlA-1; Tue,\n 31 Mar 2026 11:04:02 -0400", "from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 890D3195607D; Tue, 31 Mar 2026 15:04:01 +0000 (UTC)", "from merkur.redhat.com (unknown [10.44.50.38])\n by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 28EBA1954102; Tue, 31 Mar 2026 15:03:59 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1774969446;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=vJPIebSvHta1IUQzeqCUFPwZpsWjYN1JQlABtV3dR5o=;\n b=KjHFuoRdlavu8Jb4BiwLtkcfCED/E7PN5DOpiKkFsXkwjrZddHVKmcmrmMsdrESTUlIhXb\n J0uJSpmMWiTFQ0msjnEO3hQMD/YwMDtMk+XTYU68In8KOZVkhvIyrgT1nWMDA3Liml7Idn\n C0w7vNRmLtrZZHs5Bv9UtrLZG2GoMiQ=", "X-MC-Unique": "sTovVP-JP0WenJ1z7xIUlA-1", "X-Mimecast-MFC-AGG-ID": "sTovVP-JP0WenJ1z7xIUlA_1774969441", "From": "Kevin Wolf <kwolf@redhat.com>", "To": "qemu-block@nongnu.org", "Cc": "kwolf@redhat.com,\n\tqemu-devel@nongnu.org,\n\tpeter.maydell@linaro.org", "Subject": "[PULL 2/6] scsi: Don't consider LOGICAL UNIT NOT SUPPORTED guest\n recoverable", "Date": "Tue, 31 Mar 2026 17:03:48 +0200", "Message-ID": "<20260331150352.256332-3-kwolf@redhat.com>", "In-Reply-To": "<20260331150352.256332-1-kwolf@redhat.com>", "References": "<20260331150352.256332-1-kwolf@redhat.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.17", "Received-SPF": "pass client-ip=170.10.133.124; envelope-from=kwolf@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "27", "X-Spam_score": "2.7", "X-Spam_bar": "++", "X-Spam_report": "(2.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.01, RCVD_IN_SBL_CSS=3.335,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=1, RCVD_IN_VALIDITY_RPBL_BLOCKED=1,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "When commit bdf9613b introduced scsi_sense_buf_is_guest_recoverable(),\nit included LOGICAL UNIT NOT SUPPORTED in the list of guest recoverable\nsense codes. It doesn't really explain how the codes to be in the list\nwere selected.\n\nAs the LUN doesn't come from the guest, but from the block backend\n(usually the SCSI device on the host that was opened with host_device,\nbut it could also be the iscsi block driver), there is really no way the\nguest could influence this.\n\nIt seems that on some storage arrays, LOGICAL UNIT NOT SUPPORTED can\nhappen during failover operations. When combined with multipath, the\nrequest should be retried on another path instead of being reported to\nthe guest, which would offline the filesystem in response.\n\nSimply returning false in scsi_sense_buf_is_guest_recoverable() will\nenable the retry logic in file-posix, and will also make sure that if\nthe error persists, the configured error policy is respected so that the\nVM can be stopped.\n\nBuglink: https://redhat.atlassian.net/browse/RHEL-158212\nFixes: bdf9613b7f87 ('scsi: explicitly list guest-recoverable sense codes')\nSigned-off-by: Kevin Wolf <kwolf@redhat.com>\nMessage-ID: <20260330121635.49205-1-kwolf@redhat.com>\nReviewed-by: Paolo Bonzini <pbonzini@redhat.com>\nReviewed-by: Stefan Hajnoczi <stefanha@redhat.com>\nSigned-off-by: Kevin Wolf <kwolf@redhat.com>\n---\n scsi/utils.c | 1 -\n 1 file changed, 1 deletion(-)", "diff": "diff --git a/scsi/utils.c b/scsi/utils.c\nindex 545956f4f95..daee90ecf0e 100644\n--- a/scsi/utils.c\n+++ b/scsi/utils.c\n@@ -373,7 +373,6 @@ static bool scsi_sense_is_guest_recoverable(int key, int asc, int ascq)\n case 0x1a00: /* PARAMETER LIST LENGTH ERROR */\n case 0x2000: /* INVALID OPERATION CODE */\n case 0x2400: /* INVALID FIELD IN CDB */\n- case 0x2500: /* LOGICAL UNIT NOT SUPPORTED */\n case 0x2600: /* INVALID FIELD IN PARAMETER LIST */\n \n case 0x2104: /* UNALIGNED WRITE COMMAND */\n", "prefixes": [ "PULL", "2/6" ] }