Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2218174/?format=api
{ "id": 2218174, "url": "http://patchwork.ozlabs.org/api/patches/2218174/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260331150352.256332-2-kwolf@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260331150352.256332-2-kwolf@redhat.com>", "list_archive_url": null, "date": "2026-03-31T15:03:47", "name": "[PULL,1/6] ide: Fix potential assertion failure on VM stop for PIO read error", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "5782d12789e125ab3bc7d8fc4da14c6c4c24ec4d", "submitter": { "id": 2714, "url": "http://patchwork.ozlabs.org/api/people/2714/?format=api", "name": "Kevin Wolf", "email": "kwolf@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260331150352.256332-2-kwolf@redhat.com/mbox/", "series": [ { "id": 498214, "url": "http://patchwork.ozlabs.org/api/series/498214/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=498214", "date": "2026-03-31T15:03:47", "name": "[PULL,1/6] ide: Fix potential assertion failure on VM stop for PIO read error", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/498214/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2218174/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2218174/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=PQ/QzSow;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4flWcc1Dkpz1yGH\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 01 Apr 2026 02:04:46 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w7adU-0003BC-Er; Tue, 31 Mar 2026 11:04:08 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <kwolf@redhat.com>) id 1w7adT-0003AS-K0\n for qemu-devel@nongnu.org; Tue, 31 Mar 2026 11:04:07 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <kwolf@redhat.com>) id 1w7adR-0002XK-Cr\n for qemu-devel@nongnu.org; Tue, 31 Mar 2026 11:04:07 -0400", "from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-380-WqoFMJCsMyG0fIcaYS17fw-1; Tue,\n 31 Mar 2026 11:04:00 -0400", "from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 9C3FC18005AF; Tue, 31 Mar 2026 15:03:59 +0000 (UTC)", "from merkur.redhat.com (unknown [10.44.50.38])\n by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 192D71954102; Tue, 31 Mar 2026 15:03:57 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1774969443;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=0w+FkwPEOE9/aTogVmMcduV786B/IV6iPoHRVRGznug=;\n b=PQ/QzSowe/+OL/+g7fdcPID2zz1fGxlpGqPBaGmdTgSIKirZrL2hSVScPK8wAsV3n7rh3V\n Xs4cdR0Fj5sPNVBuV3cOfP7gPtOpo1AlK2MvWIkDSbPg6BMiXjqlAGsE5Tg+4FJCksOmos\n nSgjSRGtKAU9pjJ9PPsA1EUYc0QnA84=", "X-MC-Unique": "WqoFMJCsMyG0fIcaYS17fw-1", "X-Mimecast-MFC-AGG-ID": "WqoFMJCsMyG0fIcaYS17fw_1774969439", "From": "Kevin Wolf <kwolf@redhat.com>", "To": "qemu-block@nongnu.org", "Cc": "kwolf@redhat.com,\n\tqemu-devel@nongnu.org,\n\tpeter.maydell@linaro.org", "Subject": "[PULL 1/6] ide: Fix potential assertion failure on VM stop for PIO\n read error", "Date": "Tue, 31 Mar 2026 17:03:47 +0200", "Message-ID": "<20260331150352.256332-2-kwolf@redhat.com>", "In-Reply-To": "<20260331150352.256332-1-kwolf@redhat.com>", "References": "<20260331150352.256332-1-kwolf@redhat.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.17", "Received-SPF": "pass client-ip=170.10.133.124; envelope-from=kwolf@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-6", "X-Spam_score": "-0.7", "X-Spam_bar": "/", "X-Spam_report": "(-0.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.01,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=1, RCVD_IN_VALIDITY_RPBL_BLOCKED=1,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "ide_sector_read() as well as its callers neglect to call ide_set_retry()\nbefore starting I/O. If the I/O fails, this means that the retry\ninformation is stale. In particular, ide_handle_rw_error() has an\nassertion that s->bus->retry_unit == s->unit, which can fail if either\nthere was no previous request or it came from another device on the bus.\nIf the assertion weren't there, a wrong request would be retried after\nresuming the VM.\n\nFix this by adding a ide_set_retry() call to ide_sector_read().\n\nThis affects only reads because ide_transfer_start() does call\nide_set_retry(). For writes, the data transfer comes first and the I/O\nis only started when the data has been read into s->io_buffer, so by\nthat time, ide_set_retry() has been called. For reads, however, the I/O\ncomes first and only then the data is transferred to the guest, so the\ncall in ide_transfer_start() is too late.\n\nBuglink: https://redhat.atlassian.net/browse/RHEL-153537\nReported-by: Tingting Mao <timao@redhat.com>\nSigned-off-by: Kevin Wolf <kwolf@redhat.com>\nMessage-ID: <20260326165124.138593-1-kwolf@redhat.com>\nSigned-off-by: Kevin Wolf <kwolf@redhat.com>\n---\n hw/ide/core.c | 1 +\n 1 file changed, 1 insertion(+)", "diff": "diff --git a/hw/ide/core.c b/hw/ide/core.c\nindex d6719dbf31d..7a15d6cac9b 100644\n--- a/hw/ide/core.c\n+++ b/hw/ide/core.c\n@@ -799,6 +799,7 @@ static void ide_sector_read(IDEState *s)\n s->error = 0; /* not needed by IDE spec, but needed by Windows */\n sector_num = ide_get_sector(s);\n n = s->nsector;\n+ ide_set_retry(s);\n \n if (n == 0) {\n ide_transfer_stop(s);\n", "prefixes": [ "PULL", "1/6" ] }