Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2218136/?format=api
{ "id": 2218136, "url": "http://patchwork.ozlabs.org/api/patches/2218136/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260331131622.30505-3-frederic@kernel.org/", "project": { "id": 2, "url": "http://patchwork.ozlabs.org/api/projects/2/?format=api", "name": "Linux PPC development", "link_name": "linuxppc-dev", "list_id": "linuxppc-dev.lists.ozlabs.org", "list_email": "linuxppc-dev@lists.ozlabs.org", "web_url": "https://github.com/linuxppc/wiki/wiki", "scm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git", "webscm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/", "list_archive_url_format": "https://lore.kernel.org/linuxppc-dev/{}/", "commit_url_format": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}" }, "msgid": "<20260331131622.30505-3-frederic@kernel.org>", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/20260331131622.30505-3-frederic@kernel.org/", "date": "2026-03-31T13:16:10", "name": "[02/14] sched/cputime: Remove superfluous and error prone kcpustat_field() parameter", "commit_ref": null, "pull_url": null, "state": "handled-elsewhere", "archived": false, "hash": "d30bf1dab63f780e69e14b1b8eb27e566ae3a2d7", "submitter": { "id": 79411, "url": "http://patchwork.ozlabs.org/api/people/79411/?format=api", "name": "Frederic Weisbecker", "email": "frederic@kernel.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260331131622.30505-3-frederic@kernel.org/mbox/", "series": [ { "id": 498198, "url": "http://patchwork.ozlabs.org/api/series/498198/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=498198", "date": "2026-03-31T13:16:08", "name": "tick/sched: Refactor idle cputime accounting", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/498198/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2218136/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2218136/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linuxppc-dev+bounces-19082-incoming=patchwork.ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=utJ0Romu;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19082-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)", "lists.ozlabs.org;\n arc=none smtp.remote-ip=172.234.252.31", "lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org", "lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=utJ0Romu;\n\tdkim-atps=neutral", "lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org\n (client-ip=172.234.252.31; helo=sea.source.kernel.org;\n envelope-from=frederic@kernel.org; receiver=lists.ozlabs.org)" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4flTD44w0gz1y1q\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 01 Apr 2026 00:16:52 +1100 (AEDT)", "from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4flTD26bNhz2ydQ;\n\tWed, 01 Apr 2026 00:16:50 +1100 (AEDT)", "from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4flTD211rfz2ybQ\n\tfor <linuxppc-dev@lists.ozlabs.org>; Wed, 01 Apr 2026 00:16:50 +1100 (AEDT)", "from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby sea.source.kernel.org (Postfix) with ESMTP id 3A77A40C49;\n\tTue, 31 Mar 2026 13:16:48 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPSA id D5A4EC2BCB2;\n\tTue, 31 Mar 2026 13:16:40 +0000 (UTC)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1774963010;\n\tcv=none;\n b=XN8bv6IQqYv1I1OktI7AsIqDjIqm3yX6RZFpeh4KXo1B1B605H2VPRdneuu7TiPaLVSpvRvSfQfQWawU/cqsRz5GQtcmrUfyV0JLF9XdV87cFN3OD6L2wUbGnalo2Q8OBCBOIGwAHNT6AcXFjCISkk6vPHlmUyuZvpJxaRrjs3SDu41PgiRQiAzJvLxGOAuXsfb0efYzC0AYo0RmMQ3xnLZRRzA1+5Gyh7UPH6xs6cGwFqTuAScXbNPwyAmVIaRG5LAnsPU7yzPqqQTF0SUUerEiGjG3RvLUWYRfgt4n9BWkdJEfUeWGu4zyhvJs8KGUglqzxq8v3VtRnNA+zXNOKw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1774963010; c=relaxed/relaxed;\n\tbh=1BBPGX+TJM0cuDljO7C5k+2/aLwgCqi0Y/ne1BJMjQo=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=gV9kytqXqv0jil2o/631Ex2Z+uCdRHnjzo7dtoGDEB0opaS7mizS3YgV3mx2uIiKNflcH1AURRp+NqO0cv2Vphg8fbj6j8yFU+2o59k59GoERtPGfOArIdCIcgot0IysmdIG1ORODwR/rrvJ4t37XpcLP7Tf2EJeT06LmJgAHonGrhUenWT57G32PXbLRfPCDLyzlELXKJxWo4IKYxsi/C5SBfpYCXXcL/ndQPq9QLm04jCHqoqDmBDMiOfBcu9hMIUkNeiM0zMHE2EKwwkk0Um3yE6LC/pjIskCzbzGrVcq6HUNDQOavh5oSJGNYIRDp9KEH+I7NdPEbzD1wO+oYg==", "ARC-Authentication-Results": "i=1; lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=utJ0Romu; dkim-atps=neutral;\n spf=pass (client-ip=172.234.252.31; helo=sea.source.kernel.org;\n envelope-from=frederic@kernel.org;\n receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1774963008;\n\tbh=ToJm1amU84B7C3xkdXohgmvzVkmSBy0/3/PURrIxwTw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=utJ0Romu/Lw2Vfmju3QNiFc/EA0xnYIUlSWdQssecRsJ7FgzJFMgHPfVH2LvAMqja\n\t TLf2iG+Sd85g3nB/SE+Jb6dRTNC3m4WMt03izWbNdoYezhFxXjb8wqYBbJ1bUEVQp0\n\t WnXJoAtGAnZHjLjg/rFM1mKp9xtk0vnD+9+2zi/SElWUWNzQn/c+oGTEudxRE+dIje\n\t 0INTYB2sNBultg56aZn3AInnqKCzbh6XpCMtAQ5LTN5t7e659wtaW28LUMwyF032f+\n\t w94H++y/FvtDVUGczlKUyuMLCSzrD5tuW13D4sOabe9FDFBbMKMHCmIHkZpN6mBff4\n\t jfFtn4MlU++Lg==", "From": "Frederic Weisbecker <frederic@kernel.org>", "To": "LKML <linux-kernel@vger.kernel.org>", "Cc": "Frederic Weisbecker <frederic@kernel.org>,\n\t\"Christophe Leroy (CS GROUP)\" <chleroy@kernel.org>,\n\t\"Rafael J. Wysocki\" <rafael@kernel.org>,\n\tAlexander Gordeev <agordeev@linux.ibm.com>,\n\tAnna-Maria Behnsen <anna-maria@linutronix.de>,\n\tBen Segall <bsegall@google.com>,\n\tBoqun Feng <boqun.feng@gmail.com>,\n\tChristian Borntraeger <borntraeger@linux.ibm.com>,\n\tDietmar Eggemann <dietmar.eggemann@arm.com>,\n\tHeiko Carstens <hca@linux.ibm.com>,\n\tIngo Molnar <mingo@redhat.com>,\n\tJan Kiszka <jan.kiszka@siemens.com>,\n\tJoel Fernandes <joelagnelf@nvidia.com>,\n\tJuri Lelli <juri.lelli@redhat.com>,\n\tKieran Bingham <kbingham@kernel.org>,\n\tMadhavan Srinivasan <maddy@linux.ibm.com>,\n\tMel Gorman <mgorman@suse.de>,\n\tMichael Ellerman <mpe@ellerman.id.au>,\n\tNeeraj Upadhyay <neeraj.upadhyay@kernel.org>,\n\tNicholas Piggin <npiggin@gmail.com>,\n\t\"Paul E . McKenney\" <paulmck@kernel.org>,\n\tPeter Zijlstra <peterz@infradead.org>,\n\tShrikanth Hegde <sshegde@linux.ibm.com>,\n\tSteven Rostedt <rostedt@goodmis.org>,\n\tSven Schnelle <svens@linux.ibm.com>,\n\tThomas Gleixner <tglx@linutronix.de>,\n\tUladzislau Rezki <urezki@gmail.com>,\n\tValentin Schneider <vschneid@redhat.com>,\n\tVasily Gorbik <gor@linux.ibm.com>,\n\tVincent Guittot <vincent.guittot@linaro.org>,\n\tViresh Kumar <viresh.kumar@linaro.org>,\n\tXin Zhao <jackzxcui1989@163.com>,\n\tlinux-pm@vger.kernel.org,\n\tlinux-s390@vger.kernel.org,\n\tlinuxppc-dev@lists.ozlabs.org", "Subject": "[PATCH 02/14] sched/cputime: Remove superfluous and error prone\n kcpustat_field() parameter", "Date": "Tue, 31 Mar 2026 15:16:10 +0200", "Message-ID": "<20260331131622.30505-3-frederic@kernel.org>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260331131622.30505-1-frederic@kernel.org>", "References": "<20260331131622.30505-1-frederic@kernel.org>", "X-Mailing-List": "linuxppc-dev@lists.ozlabs.org", "List-Id": "<linuxppc-dev.lists.ozlabs.org>", "List-Help": "<mailto:linuxppc-dev+help@lists.ozlabs.org>", "List-Owner": "<mailto:linuxppc-dev+owner@lists.ozlabs.org>", "List-Post": "<mailto:linuxppc-dev@lists.ozlabs.org>", "List-Archive": "<https://lore.kernel.org/linuxppc-dev/>,\n <https://lists.ozlabs.org/pipermail/linuxppc-dev/>", "List-Subscribe": "<mailto:linuxppc-dev+subscribe@lists.ozlabs.org>,\n <mailto:linuxppc-dev+subscribe-digest@lists.ozlabs.org>,\n <mailto:linuxppc-dev+subscribe-nomail@lists.ozlabs.org>", "List-Unsubscribe": "<mailto:linuxppc-dev+unsubscribe@lists.ozlabs.org>", "Precedence": "list", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Spam-Status": "No, score=-0.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,\n\tDKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8", "X-Spam-Checker-Version": "SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org" }, "content": "The first parameter to kcpustat_field() is a pointer to the cpu kcpustat\nto be fetched from. This parameter is error prone because a copy to a\nkcpustat could be passed by accident instead of the original one. Also\nthe kcpustat structure can already be retrieved with the help of the\nmandatory CPU argument.\n\nRemove the needless parameter.\n\nSigned-off-by: Frederic Weisbecker <frederic@kernel.org>\nReviewed-by: Shrikanth Hegde <sshegde@linux.ibm.com>\nTested-by: Shrikanth Hegde <sshegde@linux.ibm.com>\n---\n drivers/cpufreq/cpufreq_governor.c | 6 +++---\n drivers/macintosh/rack-meter.c | 2 +-\n include/linux/kernel_stat.h | 8 +++-----\n kernel/rcu/tree.c | 9 +++------\n kernel/rcu/tree_stall.h | 7 +++----\n kernel/sched/cputime.c | 5 ++---\n 6 files changed, 15 insertions(+), 22 deletions(-)", "diff": "diff --git a/drivers/cpufreq/cpufreq_governor.c b/drivers/cpufreq/cpufreq_governor.c\nindex 36eb7aee4bcd..ed36d22195f6 100644\n--- a/drivers/cpufreq/cpufreq_governor.c\n+++ b/drivers/cpufreq/cpufreq_governor.c\n@@ -105,7 +105,7 @@ void gov_update_cpu_data(struct dbs_data *dbs_data)\n \t\t\tj_cdbs->prev_cpu_idle = get_cpu_idle_time(j, &j_cdbs->prev_update_time,\n \t\t\t\t\t\t\t\t dbs_data->io_is_busy);\n \t\t\tif (dbs_data->ignore_nice_load)\n-\t\t\t\tj_cdbs->prev_cpu_nice = kcpustat_field(&kcpustat_cpu(j), CPUTIME_NICE, j);\n+\t\t\t\tj_cdbs->prev_cpu_nice = kcpustat_field(CPUTIME_NICE, j);\n \t\t}\n \t}\n }\n@@ -165,7 +165,7 @@ unsigned int dbs_update(struct cpufreq_policy *policy)\n \t\tj_cdbs->prev_cpu_idle = cur_idle_time;\n \n \t\tif (ignore_nice) {\n-\t\t\tu64 cur_nice = kcpustat_field(&kcpustat_cpu(j), CPUTIME_NICE, j);\n+\t\t\tu64 cur_nice = kcpustat_field(CPUTIME_NICE, j);\n \n \t\t\tidle_time += div_u64(cur_nice - j_cdbs->prev_cpu_nice, NSEC_PER_USEC);\n \t\t\tj_cdbs->prev_cpu_nice = cur_nice;\n@@ -539,7 +539,7 @@ int cpufreq_dbs_governor_start(struct cpufreq_policy *policy)\n \t\tj_cdbs->prev_load = 0;\n \n \t\tif (ignore_nice)\n-\t\t\tj_cdbs->prev_cpu_nice = kcpustat_field(&kcpustat_cpu(j), CPUTIME_NICE, j);\n+\t\t\tj_cdbs->prev_cpu_nice = kcpustat_field(CPUTIME_NICE, j);\n \t}\n \n \tgov->start(policy);\ndiff --git a/drivers/macintosh/rack-meter.c b/drivers/macintosh/rack-meter.c\nindex 8a1e2c08b096..26cb93191ede 100644\n--- a/drivers/macintosh/rack-meter.c\n+++ b/drivers/macintosh/rack-meter.c\n@@ -87,7 +87,7 @@ static inline u64 get_cpu_idle_time(unsigned int cpu)\n \t\t kcpustat->cpustat[CPUTIME_IOWAIT];\n \n \tif (rackmeter_ignore_nice)\n-\t\tretval += kcpustat_field(kcpustat, CPUTIME_NICE, cpu);\n+\t\tretval += kcpustat_field(CPUTIME_NICE, cpu);\n \n \treturn retval;\n }\ndiff --git a/include/linux/kernel_stat.h b/include/linux/kernel_stat.h\nindex b97ce2df376f..dd020ecaf67b 100644\n--- a/include/linux/kernel_stat.h\n+++ b/include/linux/kernel_stat.h\n@@ -100,14 +100,12 @@ static inline unsigned long kstat_cpu_irqs_sum(unsigned int cpu)\n }\n \n #ifdef CONFIG_VIRT_CPU_ACCOUNTING_GEN\n-extern u64 kcpustat_field(struct kernel_cpustat *kcpustat,\n-\t\t\t enum cpu_usage_stat usage, int cpu);\n+extern u64 kcpustat_field(enum cpu_usage_stat usage, int cpu);\n extern void kcpustat_cpu_fetch(struct kernel_cpustat *dst, int cpu);\n #else\n-static inline u64 kcpustat_field(struct kernel_cpustat *kcpustat,\n-\t\t\t\t enum cpu_usage_stat usage, int cpu)\n+static inline u64 kcpustat_field(enum cpu_usage_stat usage, int cpu)\n {\n-\treturn kcpustat->cpustat[usage];\n+\treturn kcpustat_cpu(cpu).cpustat[usage];\n }\n \n static inline void kcpustat_cpu_fetch(struct kernel_cpustat *dst, int cpu)\ndiff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c\nindex 55df6d37145e..3cbf79bee976 100644\n--- a/kernel/rcu/tree.c\n+++ b/kernel/rcu/tree.c\n@@ -969,14 +969,11 @@ static int rcu_watching_snap_recheck(struct rcu_data *rdp)\n \t\tif (rcu_cpu_stall_cputime && rdp->snap_record.gp_seq != rdp->gp_seq) {\n \t\t\tint cpu = rdp->cpu;\n \t\t\tstruct rcu_snap_record *rsrp;\n-\t\t\tstruct kernel_cpustat *kcsp;\n-\n-\t\t\tkcsp = &kcpustat_cpu(cpu);\n \n \t\t\trsrp = &rdp->snap_record;\n-\t\t\trsrp->cputime_irq = kcpustat_field(kcsp, CPUTIME_IRQ, cpu);\n-\t\t\trsrp->cputime_softirq = kcpustat_field(kcsp, CPUTIME_SOFTIRQ, cpu);\n-\t\t\trsrp->cputime_system = kcpustat_field(kcsp, CPUTIME_SYSTEM, cpu);\n+\t\t\trsrp->cputime_irq = kcpustat_field(CPUTIME_IRQ, cpu);\n+\t\t\trsrp->cputime_softirq = kcpustat_field(CPUTIME_SOFTIRQ, cpu);\n+\t\t\trsrp->cputime_system = kcpustat_field(CPUTIME_SYSTEM, cpu);\n \t\t\trsrp->nr_hardirqs = kstat_cpu_irqs_sum(cpu) + arch_irq_stat_cpu(cpu);\n \t\t\trsrp->nr_softirqs = kstat_cpu_softirqs_sum(cpu);\n \t\t\trsrp->nr_csw = nr_context_switches_cpu(cpu);\ndiff --git a/kernel/rcu/tree_stall.h b/kernel/rcu/tree_stall.h\nindex b67532cb8770..cf7ae51cba40 100644\n--- a/kernel/rcu/tree_stall.h\n+++ b/kernel/rcu/tree_stall.h\n@@ -479,7 +479,6 @@ static void print_cpu_stat_info(int cpu)\n {\n \tstruct rcu_snap_record rsr, *rsrp;\n \tstruct rcu_data *rdp = per_cpu_ptr(&rcu_data, cpu);\n-\tstruct kernel_cpustat *kcsp = &kcpustat_cpu(cpu);\n \n \tif (!rcu_cpu_stall_cputime)\n \t\treturn;\n@@ -488,9 +487,9 @@ static void print_cpu_stat_info(int cpu)\n \tif (rsrp->gp_seq != rdp->gp_seq)\n \t\treturn;\n \n-\trsr.cputime_irq = kcpustat_field(kcsp, CPUTIME_IRQ, cpu);\n-\trsr.cputime_softirq = kcpustat_field(kcsp, CPUTIME_SOFTIRQ, cpu);\n-\trsr.cputime_system = kcpustat_field(kcsp, CPUTIME_SYSTEM, cpu);\n+\trsr.cputime_irq = kcpustat_field(CPUTIME_IRQ, cpu);\n+\trsr.cputime_softirq = kcpustat_field(CPUTIME_SOFTIRQ, cpu);\n+\trsr.cputime_system = kcpustat_field(CPUTIME_SYSTEM, cpu);\n \n \tpr_err(\"\\t hardirqs softirqs csw/system\\n\");\n \tpr_err(\"\\t number: %8lld %10d %12lld\\n\",\ndiff --git a/kernel/sched/cputime.c b/kernel/sched/cputime.c\nindex fbf31db0d2f3..caaaf0a04ced 100644\n--- a/kernel/sched/cputime.c\n+++ b/kernel/sched/cputime.c\n@@ -975,10 +975,9 @@ static int kcpustat_field_vtime(u64 *cpustat,\n \treturn 0;\n }\n \n-u64 kcpustat_field(struct kernel_cpustat *kcpustat,\n-\t\t enum cpu_usage_stat usage, int cpu)\n+u64 kcpustat_field(enum cpu_usage_stat usage, int cpu)\n {\n-\tu64 *cpustat = kcpustat->cpustat;\n+\tu64 *cpustat = kcpustat_cpu(cpu).cpustat;\n \tu64 val = cpustat[usage];\n \tstruct rq *rq;\n \tint err;\n", "prefixes": [ "02/14" ] }