Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2218078/?format=api
{ "id": 2218078, "url": "http://patchwork.ozlabs.org/api/patches/2218078/?format=api", "web_url": "http://patchwork.ozlabs.org/project/ltp/patch/20260331111857.10995-1-wegao@suse.com/", "project": { "id": 59, "url": "http://patchwork.ozlabs.org/api/projects/59/?format=api", "name": "Linux Test Project development", "link_name": "ltp", "list_id": "ltp.lists.linux.it", "list_email": "ltp@lists.linux.it", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260331111857.10995-1-wegao@suse.com>", "list_archive_url": null, "date": "2026-03-31T11:18:39", "name": "[v7] fanotify22.c: handle multiple asynchronous error events", "commit_ref": null, "pull_url": null, "state": "needs-review-ack", "archived": false, "hash": "76597a1ab71efa4bc92be123de2f0ae1d1ad0a28", "submitter": { "id": 85577, "url": "http://patchwork.ozlabs.org/api/people/85577/?format=api", "name": "Wei Gao", "email": "wegao@suse.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/ltp/patch/20260331111857.10995-1-wegao@suse.com/mbox/", "series": [ { "id": 498178, "url": "http://patchwork.ozlabs.org/api/series/498178/?format=api", "web_url": "http://patchwork.ozlabs.org/project/ltp/list/?series=498178", "date": "2026-03-31T11:18:39", "name": "[v7] fanotify22.c: handle multiple asynchronous error events", "version": 7, "mbox": "http://patchwork.ozlabs.org/series/498178/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2218078/comments/", "check": "success", "checks": "http://patchwork.ozlabs.org/api/patches/2218078/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "ltp@lists.linux.it" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "ltp@picard.linux.it" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=lists.linux.it header.i=@lists.linux.it\n header.a=rsa-sha256 header.s=picard header.b=axntBYQT;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=suse.com header.i=@suse.com header.a=rsa-sha256\n header.s=google header.b=fpVrIMsf;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=2001:1418:10:5::2; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4flQcF6R3Kz1xtJ\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 31 Mar 2026 22:19:09 +1100 (AEDT)", "from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id 2A85A3CAE45\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 31 Mar 2026 13:19:07 +0200 (CEST)", "from in-6.smtp.seeweb.it (in-6.smtp.seeweb.it [217.194.8.6])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id ACA6C3CD981\n for <ltp@lists.linux.it>; Tue, 31 Mar 2026 13:19:01 +0200 (CEST)", "from mail-wr1-x434.google.com (mail-wr1-x434.google.com\n [IPv6:2a00:1450:4864:20::434])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-6.smtp.seeweb.it (Postfix) with ESMTPS id E6A141401250\n for <ltp@lists.linux.it>; Tue, 31 Mar 2026 13:19:00 +0200 (CEST)", "by mail-wr1-x434.google.com with SMTP id\n ffacd0b85a97d-43cfde3c3f3so1698196f8f.3\n for <ltp@lists.linux.it>; Tue, 31 Mar 2026 04:19:00 -0700 (PDT)", "from localhost ([2a07:de40:b240:0:2ad6:ed42:2ad6:ed42])\n by smtp.gmail.com with UTF8SMTPSA id\n ffacd0b85a97d-43cf257b72dsm26677072f8f.34.2026.03.31.04.18.59\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 31 Mar 2026 04:18:59 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=lists.linux.it;\n i=@lists.linux.it; q=dns/txt; s=picard; t=1774955947; h=to : date :\n message-id : in-reply-to : references : mime-version : subject :\n list-id : list-unsubscribe : list-archive : list-post : list-help :\n list-subscribe : from : reply-to : cc : content-type :\n content-transfer-encoding : sender : from;\n bh=Hfsjpws9Pm/QQ/0axEwWX+TYuYveYzF+dl8QVoHekFE=;\n b=axntBYQThYXvrWU6jMh2wiYoHvHZVTaJGdzYUsIbWhr6Rsi5rQrmv3rvgiv8Y5KbAeaou\n cOXjjYd5IIPowcl6+VfyUErWDuuuJsc04xhGB0nI0cZYdtlP/BKZ7GSBCZiVg+sTLQwM1Ty\n 9v3rDU2uIkffKix/+3iVYn7ynKhQFgs=", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=suse.com; s=google; t=1774955940; x=1775560740; darn=lists.linux.it;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=vLOMIizp25xRODfAoZCehKJCf+CAt/xEoAArzta5sK0=;\n b=fpVrIMsfmQBf7cJHEF//BLRkMcuw2kRErgoPctE22cnwhkbuijkvU+91mxcGiI4kYa\n OJ5hLbdollNBDN08VKcy6pcekzVepytMRHBs9+UaO2hSr+a28gnIs7OWeiMO/9pw6Yxb\n xg3etKUZoNZ204lCH8kyr0A3Ep59Lil+hiek10tBkJCc0SOPyG5rRvpNEWCxviFVPnOb\n vmPMFkaYk8XwG0zK7csBkYoWQkk2O23u7PJdrSuhq1vbq2SqJiuCeqbWmehwxJhdkZN0\n frlA67O5DRpHjUjU5m7UCOSFA8Fv5qJvYya3eUA/t18d17e8arQde/LDyFORafflX1m2\n zyZw==" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774955940; x=1775560740;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=vLOMIizp25xRODfAoZCehKJCf+CAt/xEoAArzta5sK0=;\n b=kPqV+iXMuUWcALS+GWFzDLM9w+grG7qExDFJ517c0Sl60Y8ZRqesVVZND+kExWgGuK\n iLQlNx3iVwpy8O7D/kYFsA19TNjnY3ktZW4Pl8/F5Ie+KrsiaLdonYu65Ckv5ZxEx1JC\n QQSI6QW+9AUf3n5lK+8A7a1NbI5Ew3oMPk0BzjTfQnOAmRihcmYa7eC7E9OZf2QZ8Yif\n GCaWYdyXZRbLalEB2E+Q9sUVdv55c4aOVWSz0QxmbcFHx4TsMFfW/XvZ3hgf3mGVVjCr\n dRmfmlq2cnPaY98/Qz/yf5BbQ3oXDbecYyLz9wz33puhJVTqtPYQuTZKCpxP60VBnnnt\n s7JA==", "X-Gm-Message-State": "AOJu0YzfF47g8v0t09t4wAQzCIi4p7f6et6Wweqwa630tl+INTFAPtmB\n EQ76CAi0Hn8YLwvdA2D9c5191YMDn4UhsqBNLeaQeo4RZR21O6phBh/7BslZE6ZXXlKGI/huOzf\n 50OU=", "X-Gm-Gg": "ATEYQzzAN1VoYhpddRPOLLEIG114MIQs5lVlgA89KZGLW0lWb6ZktJCvqbvLHttIk2u\n u/kLPj9b7fLOpv1fUmjEU5DBo6iY0mcwP8tWhY1zRcEAEkM5Chis35ukAbG/mHaYHlISDwfJb5H\n aVB51aHUs7h3Ch1UjbKFdJ98dsqkGEDw6fftp5QR72wVFIhyKme2/Sy+XAr3AS3IhHvbUwKJc73\n 1isBCqEig9O/q+nAQjxwEHd4tGeCdBulge4C8whSnTPuY0C5RvEhrWRQZYDY2A6g196gyIH9Clx\n bPGu1WSP0dLiL7V7DE28LwNMaPOCjYIaRkN8IYIB5zINCsjN1gEfoPPrELl6Ke8P7vHXJT0Dg6j\n PBTxRFoFXHz8u/C6PKihnpebiQHTsXFS6ZJAESESP94aoZJuThd27sToE8Lmv8RibsBaW3nM72A\n bCFO7BC8aS1eo=", "X-Received": "by 2002:a05:6000:40dd:b0:43b:998c:9bbe with SMTP id\n ffacd0b85a97d-43b9e9e8e75mr27160455f8f.13.1774955939911;\n Tue, 31 Mar 2026 04:18:59 -0700 (PDT)", "To": "ltp@lists.linux.it", "Date": "Tue, 31 Mar 2026 11:18:39 +0000", "Message-ID": "<20260331111857.10995-1-wegao@suse.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20260317114635.944-1-wegao@suse.com>", "References": "<20260317114635.944-1-wegao@suse.com>", "MIME-Version": "1.0", "X-Spam-Status": "No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS shortcircuit=no\n autolearn=disabled version=4.0.1", "X-Spam-Checker-Version": "SpamAssassin 4.0.1 (2024-03-25) on in-6.smtp.seeweb.it", "X-Virus-Scanned": "clamav-milter 1.0.9 at in-6.smtp.seeweb.it", "X-Virus-Status": "Clean", "Subject": "[LTP] [PATCH v7] fanotify22.c: handle multiple asynchronous error\n events", "X-BeenThere": "ltp@lists.linux.it", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Linux Test Project <ltp.lists.linux.it>", "List-Unsubscribe": "<https://lists.linux.it/options/ltp>,\n <mailto:ltp-request@lists.linux.it?subject=unsubscribe>", "List-Archive": "<http://lists.linux.it/pipermail/ltp/>", "List-Post": "<mailto:ltp@lists.linux.it>", "List-Help": "<mailto:ltp-request@lists.linux.it?subject=help>", "List-Subscribe": "<https://lists.linux.it/listinfo/ltp>,\n <mailto:ltp-request@lists.linux.it?subject=subscribe>", "From": "Wei Gao via ltp <ltp@lists.linux.it>", "Reply-To": "Wei Gao <wegao@suse.com>", "Cc": "Jan Kara <jack@suse.cz>, kernel test robot <oliver.sang@intel.com>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it", "Sender": "\"ltp\" <ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it>" }, "content": "Since the introduction of the asynchronous fserror reporting framework\n(kernel commit 81d2e13a57c9), fanotify22 has encountered sporadic failures\ndue to the non-deterministic nature of event delivery and merging:\n\n1) tcase3 failure: A race condition occurs when the test reads the\n notification fd between two events. Use a poll() and read() loop to wait\n until the expected event.\n\n2) tcase4 failure: The kernel may deliver errors as independent events\n instead of a single merged event, since different worker kthread can\n end up generating each event so they won't be merged. As suggested by\n Jan Kara, this patch introduces a consolidate_events() helper. It iterates\n through the event buffer, accumulates the error_count from all independent\n events, and updates the first event's count in-place.\n\nReported-by: kernel test robot <oliver.sang@intel.com>\nCloses: https://lore.kernel.org/oe-lkp/202602042124.87bd00e3-lkp@intel.com\nSuggested-by: Jan Kara <jack@suse.cz>\nSigned-off-by: Wei Gao <wegao@suse.com>\n---\nv6->v7:\n- validation check to accept either error or error2 in check_error_event_info_error\n\n .../kernel/syscalls/fanotify/fanotify22.c | 113 +++++++++++++++---\n 1 file changed, 96 insertions(+), 17 deletions(-)", "diff": "diff --git a/testcases/kernel/syscalls/fanotify/fanotify22.c b/testcases/kernel/syscalls/fanotify/fanotify22.c\nindex e8002b160..f5d59b99d 100644\n--- a/testcases/kernel/syscalls/fanotify/fanotify22.c\n+++ b/testcases/kernel/syscalls/fanotify/fanotify22.c\n@@ -28,6 +28,7 @@\n #include \"tst_test.h\"\n #include <sys/fanotify.h>\n #include <sys/types.h>\n+#include <poll.h>\n \n #ifdef HAVE_SYS_FANOTIFY_H\n #include \"fanotify.h\"\n@@ -88,7 +89,6 @@ static void trigger_bad_link_lookup(void)\n \t\t\tret, BAD_LINK, errno, EUCLEAN);\n }\n \n-\n static void tcase3_trigger(void)\n {\n \ttrigger_bad_link_lookup();\n@@ -104,6 +104,7 @@ static void tcase4_trigger(void)\n static struct test_case {\n \tchar *name;\n \tint error;\n+\tint error2;\n \tunsigned int error_count;\n \tstruct fanotify_fid_t *fid;\n \tvoid (*trigger_error)(void);\n@@ -134,37 +135,79 @@ static struct test_case {\n \t\t.trigger_error = &tcase4_trigger,\n \t\t.error_count = 2,\n \t\t.error = EFSCORRUPTED,\n+\t\t.error2 = ESHUTDOWN,\n \t\t.fid = &bad_file_fid,\n \t}\n };\n \n+static size_t consolidate_events(char *buf, size_t len, const struct test_case *ex)\n+{\n+\tstruct fanotify_event_metadata *metadata, *first = NULL;\n+\tstruct fanotify_event_info_error *first_info = NULL;\n+\tunsigned int total_count = 0;\n+\tint event_num = 0;\n+\n+\tfor (metadata = (struct fanotify_event_metadata *)buf;\n+\t\t\tFAN_EVENT_OK(metadata, len);\n+\t\t\tmetadata = FAN_EVENT_NEXT(metadata, len)) {\n+\n+\t\tevent_num++;\n+\t\tstruct fanotify_event_info_error *info = get_event_info_error(metadata);\n+\n+\t\tif (!info) {\n+\t\t\ttst_res(TFAIL, \"Event [%d] missing error info\", event_num);\n+\t\t\tcontinue;\n+\t\t}\n+\n+\t\tif (info->error != ex->error && (ex->error2 == 0 || info->error != ex->error2)) {\n+\t\t\ttst_res(TFAIL, \"Event [%d] unexpected errno (%d)\",\n+\t\t\t\t\tevent_num, info->error);\n+\t\t\tcontinue;\n+\t\t}\n+\n+\t\tif (!first) {\n+\t\t\tfirst = metadata;\n+\t\t\tfirst_info = info;\n+\t\t}\n+\t\ttotal_count += info->error_count;\n+\n+\t\ttst_res(TINFO, \"Event [%d]: errno=%d, error_count=%d\",\n+\t\t\t\tevent_num, info->error, info->error_count);\n+\t}\n+\n+\tif (first_info)\n+\t\tfirst_info->error_count = total_count;\n+\n+\treturn (first) ? first->event_len : 0;\n+}\n+\n static int check_error_event_info_fid(struct fanotify_event_info_fid *fid,\n \t\t\t\t const struct test_case *ex)\n {\n \tstruct file_handle *fh = (struct file_handle *) &fid->handle;\n \n \tif (memcmp(&fid->fsid, &ex->fid->fsid, sizeof(fid->fsid))) {\n-\t\ttst_res(TFAIL, \"%s: Received bad FSID type (%x...!=%x...)\",\n-\t\t\tex->name, FSID_VAL_MEMBER(fid->fsid, 0),\n+\t\ttst_res(TFAIL, \"Received bad FSID type (%x...!=%x...)\",\n+\t\t\tFSID_VAL_MEMBER(fid->fsid, 0),\n \t\t\tex->fid->fsid.val[0]);\n \n \t\treturn 1;\n \t}\n \tif (fh->handle_type != ex->fid->handle.handle_type) {\n-\t\ttst_res(TFAIL, \"%s: Received bad file_handle type (%d!=%d)\",\n-\t\t\tex->name, fh->handle_type, ex->fid->handle.handle_type);\n+\t\ttst_res(TFAIL, \"Received bad file_handle type (%d!=%d)\",\n+\t\t\tfh->handle_type, ex->fid->handle.handle_type);\n \t\treturn 1;\n \t}\n \n \tif (fh->handle_bytes != ex->fid->handle.handle_bytes) {\n-\t\ttst_res(TFAIL, \"%s: Received bad file_handle len (%d!=%d)\",\n-\t\t\tex->name, fh->handle_bytes, ex->fid->handle.handle_bytes);\n+\t\ttst_res(TFAIL, \"Received bad file_handle len (%d!=%d)\",\n+\t\t\tfh->handle_bytes, ex->fid->handle.handle_bytes);\n \t\treturn 1;\n \t}\n \n \tif (memcmp(fh->f_handle, ex->fid->handle.f_handle, fh->handle_bytes)) {\n-\t\ttst_res(TFAIL, \"%s: Received wrong handle. \"\n-\t\t\t\"Expected (%x...) got (%x...) \", ex->name,\n+\t\ttst_res(TFAIL, \"Received wrong handle. \"\n+\t\t\t\"Expected (%x...) got (%x...) \",\n \t\t\t*(int *)ex->fid->handle.f_handle, *(int *)fh->f_handle);\n \t\treturn 1;\n \t}\n@@ -177,14 +220,15 @@ static int check_error_event_info_error(struct fanotify_event_info_error *info_e\n \tint fail = 0;\n \n \tif (info_error->error_count != ex->error_count) {\n-\t\ttst_res(TFAIL, \"%s: Unexpected error_count (%d!=%d)\",\n-\t\t\tex->name, info_error->error_count, ex->error_count);\n+\t\ttst_res(TFAIL, \"Unexpected error_count (%d!=%d)\",\n+\t\t\tinfo_error->error_count, ex->error_count);\n \t\tfail++;\n \t}\n \n-\tif (info_error->error != ex->error) {\n-\t\ttst_res(TFAIL, \"%s: Unexpected error code value (%d!=%d)\",\n-\t\t\tex->name, info_error->error, ex->error);\n+\tif (info_error->error != ex->error &&\n+\t (ex->error2 == 0 || info_error->error != ex->error2)) {\n+\t\ttst_res(TFAIL, \"Unexpected error code value (%d!=%d)\",\n+\t\t\tinfo_error->error, ex->error);\n \t\tfail++;\n \t}\n \n@@ -248,19 +292,54 @@ static void check_event(char *buf, size_t len, const struct test_case *ex)\n static void do_test(unsigned int i)\n {\n \tconst struct test_case *tcase = &testcases[i];\n-\tsize_t read_len;\n+\tsize_t read_len = 0;\n+\tstruct pollfd pfd;\n+\tunsigned int accumulated_count = 0;\n+\n+\ttst_res(TINFO, \"Test case: %s\", tcase->name);\n \n \tSAFE_FANOTIFY_MARK(fd_notify, FAN_MARK_ADD|FAN_MARK_FILESYSTEM,\n \t\t\t FAN_FS_ERROR, AT_FDCWD, MOUNT_PATH);\n \n \ttcase->trigger_error();\n \n-\tread_len = SAFE_READ(0, fd_notify, event_buf, BUF_SIZE);\n+\tpfd.fd = fd_notify;\n+\tpfd.events = POLLIN;\n+\n+\twhile (accumulated_count < tcase->error_count) {\n+\t\tif (poll(&pfd, 1, 5000) <= 0) {\n+\t\t\ttst_res(TFAIL, \"Timeout waiting for events\");\n+\t\t\tgoto out;\n+\t\t}\n+\n+\t\tif (BUF_SIZE - read_len < FAN_EVENT_METADATA_LEN)\n+\t\t\ttst_brk(TBROK, \"Insufficient buffer space for next event\");\n+\n+\t\tchar *current_pos = event_buf + read_len;\n+\t\tssize_t ret = SAFE_READ(0, fd_notify, current_pos, BUF_SIZE - read_len);\n+\n+\t\tstruct fanotify_event_metadata *m =\n+\t\t\t(struct fanotify_event_metadata *)current_pos;\n+\t\twhile (FAN_EVENT_OK(m, ret)) {\n+\t\t\tstruct fanotify_event_info_error *e = get_event_info_error(m);\n+\n+\t\t\tif (e)\n+\t\t\t\taccumulated_count += e->error_count;\n+\n+\t\t\tread_len += m->event_len;\n+\t\t\tm = FAN_EVENT_NEXT(m, ret);\n+\t\t}\n+\t}\n+\n+\tread_len = consolidate_events(event_buf, read_len, tcase);\n+\n+\tcheck_event(event_buf, read_len, tcase);\n+\n+out:\n \n \tSAFE_FANOTIFY_MARK(fd_notify, FAN_MARK_REMOVE|FAN_MARK_FILESYSTEM,\n \t\t\t FAN_FS_ERROR, AT_FDCWD, MOUNT_PATH);\n \n-\tcheck_event(event_buf, read_len, tcase);\n \t/* Unmount and mount the filesystem to get it out of the error state */\n \tSAFE_UMOUNT(MOUNT_PATH);\n \tSAFE_MOUNT(tst_device->dev, MOUNT_PATH, tst_device->fs_type, 0, NULL);\n", "prefixes": [ "v7" ] }