Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2218044/?format=api
{ "id": 2218044, "url": "http://patchwork.ozlabs.org/api/patches/2218044/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20260331100047.34618-6-philippe.reynes@softathome.com/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260331100047.34618-6-philippe.reynes@softathome.com>", "list_archive_url": null, "date": "2026-03-31T10:00:37", "name": "[v3,05/15] ecdsa: fix support of secp521r1", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "53cc26d4646641d67c46aa6ebd55c4a300c0a790", "submitter": { "id": 74351, "url": "http://patchwork.ozlabs.org/api/people/74351/?format=api", "name": "Philippe Reynes", "email": "philippe.reynes@softathome.com" }, "delegate": { "id": 161313, "url": "http://patchwork.ozlabs.org/api/users/161313/?format=api", "username": "raymo200915", "first_name": "Raymond", "last_name": "Mao", "email": "raymondmaoca@gmail.com" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20260331100047.34618-6-philippe.reynes@softathome.com/mbox/", "series": [ { "id": 498164, "url": "http://patchwork.ozlabs.org/api/series/498164/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=498164", "date": "2026-03-31T10:00:34", "name": "add software ecdsa support", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/498164/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2218044/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2218044/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=softathome1.onmicrosoft.com header.i=@softathome1.onmicrosoft.com\n header.a=rsa-sha256 header.s=selector1-softathome1-onmicrosoft-com\n header.b=XuU8Anlh;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=softathome.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=softathome1.onmicrosoft.com header.i=@softathome1.onmicrosoft.com\n header.b=\"XuU8Anlh\";\n\tdkim-atps=neutral", "phobos.denx.de; dmarc=none (p=none dis=none)\n header.from=softathome.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=philippe.reynes@softathome.com" ], "Received": [ "from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4flNvm3Btbz1y1q\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 31 Mar 2026 21:02:28 +1100 (AEDT)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id D91F684010;\n\tTue, 31 Mar 2026 12:01:09 +0200 (CEST)", "by phobos.denx.de (Postfix, from userid 109)\n id BF98284113; Tue, 31 Mar 2026 12:01:03 +0200 (CEST)", "from MRZP264CU002.outbound.protection.outlook.com\n (mail-francesouthazlp170100001.outbound.protection.outlook.com\n [IPv6:2a01:111:f403:c207::1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 6BA0A83E7A\n for <u-boot@lists.denx.de>; Tue, 31 Mar 2026 12:00:57 +0200 (CEST)", "from PAZP264CA0164.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:236::18)\n by MRYP264MB6542.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:6b::11) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9745.28; Tue, 31 Mar\n 2026 10:00:53 +0000", "from PA1PEPF000CC3FB.FRAP264.PROD.OUTLOOK.COM\n (2603:10a6:102:236:cafe::8d) by PAZP264CA0164.outlook.office365.com\n (2603:10a6:102:236::18) with Microsoft SMTP Server (version=TLS1_3,\n cipher=TLS_AES_256_GCM_SHA384) id 15.20.9745.28 via Frontend Transport; Tue,\n 31 Mar 2026 10:00:30 +0000", "from proxy.softathome.com (149.6.166.170) by\n PA1PEPF000CC3FB.mail.protection.outlook.com (10.167.242.6) with Microsoft\n SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9745.21\n via Frontend Transport; Tue, 31 Mar 2026 10:00:53 +0000", "from sah1lpt726.home (unknown [192.168.72.39])\n by proxy.softathome.com (Postfix) with ESMTPSA id C177420931;\n Tue, 31 Mar 2026 12:00:52 +0200 (CEST)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2", "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=V/3PVbOWtUSY2jxVjmC1/HpXViKO/29oMpjriaPekMwsw/aep+mDtI3Z/4iUAnC3gijxDt1BkiMmToQHwQT5cxjaUZ9IJdN7BYxdtL4CRWtds7zDNvqW0B3Pdu/B+wX+XpRFMeCkHV0wJd4W3Xi0eijPAr6GskKmDxLndEnT4ykoEwlHR77llb+EbJVp6v/XQn6bOnQEjplx+h4E9tT35gwZmFwK4WAniotlQxJev8LVkf3tCryqhnWKcG76QrileXiI7k8jGF29tGsW8eXqWeGb8eaCjKLS4+rUfe2JoeDX/V9L1F6jfU+ZDNbAIcmB1k0pEpcX/bj9zhwbfkQQUA==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=SOMqvgUCIcGM6jBRMkE4bkZBx7Nmsn+FBZNnJ4bGHaE=;\n b=ReYurV6joI1p5QXn60mbWxVOcidG99k2NnEsTuJSv6UhPa676RGeAv2Reguc4pmW/KnvS9FmcRGBTiV7PgCTYJzaQcrYJdd80Pi21ucnonOu+lMEz5NAu8EbNrezgZFT1Dn2UVRWKU7Q26bN49mD2rAUqG/SKu1v2doSJyoGGjUBTVX7B0r3Fs9dLgLhjurHmNdlEgHjLhwx35+6LjT9jx7Lxnt0WDJ8qsh6jbWNgi2ziGwOO6/Ju9/wN4VF4rjgqzc1U2bXFSmvoi5C6zChOCwARXLozlYWZKEU38MEimdZl3zfHN+jzAiNsi4YTHRAUNBZadSbPcsTyViRTy3yqQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 149.6.166.170) smtp.rcpttodomain=canonical.com smtp.mailfrom=softathome.com;\n dmarc=bestguesspass action=none header.from=softathome.com; dkim=none\n (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=softathome1.onmicrosoft.com; s=selector1-softathome1-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=SOMqvgUCIcGM6jBRMkE4bkZBx7Nmsn+FBZNnJ4bGHaE=;\n b=XuU8AnlhBFZoXTtEF9QcKVIphi5Mco/HEGdgg8LE6lpyZI/pNTfkDH94lbDWHLej2cx0M2LrSdaJwlQtNtI8bzoR+llcl0Hq09SrnZmMC5YMvFi7ZEehf5Q+8rYVNjqMGePQo7Qa2CIeOzQuuvcVD6FqUWeNt5YQPkIVIp1Ti066xPvhrIRjv7ZWywTpoz/Yi1n9BAdJXkhFcPJCHodHIlm9RTl8uNnbZqrcZcrUfFV5f5+nNoCrOPhWLpOeqcDoGWPYvksfsP/RJ1r9GYalFr4psGWSVkH9aIe2R5okRTJ31dqpjvXFrJSXTUT4A4RhAvJ9A3vr5rm7FzjNKy0D2Q==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 149.6.166.170)\n smtp.mailfrom=softathome.com; dkim=none (message not signed)\n header.d=none;dmarc=bestguesspass action=none header.from=softathome.com;", "Received-SPF": "Pass (protection.outlook.com: domain of softathome.com\n designates 149.6.166.170 as permitted sender)\n receiver=protection.outlook.com; client-ip=149.6.166.170;\n helo=proxy.softathome.com; pr=C", "From": "Philippe Reynes <philippe.reynes@softathome.com>", "To": "marko.makela@iki.fi, jonny.green@keytechinc.com, raymondmaoca@gmail.com,\n trini@konsulko.com, simon.glass@canonical.com", "Cc": "u-boot@lists.denx.de,\n\tPhilippe Reynes <philippe.reynes@softathome.com>", "Subject": "[PATCH v3 05/15] ecdsa: fix support of secp521r1", "Date": "Tue, 31 Mar 2026 12:00:37 +0200", "Message-ID": "<20260331100047.34618-6-philippe.reynes@softathome.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20260331100047.34618-1-philippe.reynes@softathome.com>", "References": "<20260331100047.34618-1-philippe.reynes@softathome.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "PA1PEPF000CC3FB:EE_|MRYP264MB6542:EE_", "Content-Type": "text/plain", "X-MS-Office365-Filtering-Correlation-Id": "0af95ff6-c156-45de-7bcd-08de8f0c6514", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;\n ARA:13230040|1800799024|376014|36860700016|82310400026|22082099003|18002099003|56012099003;", "X-Microsoft-Antispam-Message-Info": "\n Mk8fTVi4raWnfaZGRq6Rv2//UYLtQng/0vlEBERzBwotDktnB0zS0HuP++4fdtV/tUy/tB3ghaGi7RNpQX4yxuVv2lMqNnEUsZJGYNXkvoHla6SWFUZaKdl1ZFcWmjJvlC6SNsvHAR483cvNYLEPw5ZaQeNyknpex7o5UgLpeZdJZAQ56WNYFk47TF9Y3+d5lrIJ4XGp4oHKgXKjKClIQz818DvXMu//ebNiaqNfnjInzQ0eeZemNxhmrHKCX/Y9wiiCp7BpHSgHh3gLYtX/IGiL32wpuXyw+Y9DaGDEAeFXyr2Z2GaoJ6WQaKplZDews2ELriX4pWlLD7TI5BgrcDXK9/+UYH3yP3bB25GlQWsCLxH26XUMwomFL1NCZrBAlOgqNdMX6nJTTZFQM/DFbibsezvoDbFQZVLy3mvCUutn0UhqgU3D8SD7kanEEPTge5Nx5oED83bomq4k2HMor+OePNItDGszxxowI0mfIcod3XSnlWTPIegkVpc3ziq3uEVD9fVw5zVzXCX6ynJdBggY6lx39zIrCw3HbFqafsUWx2O4PMhYwftNR3Bv+FMQOase5xvILOMxyOu4Gn1PvYrA5zpmNW8j8vsAqZ6TdPjBAZjkzQdP5tujJfYOYT8nKbi4QizhFQfpSiClL+XfoLJew/hG+TOVg6NhRuiWeUIzYlhMSAkND6Dt6dPp+RgPYoRc2MaPQ8DlIjEKhPaJfTazqo7TpQnwwTv1p2mLWYAQ04NDktjmO5EeaeWI0Z1XmHmR9NlWMPIfmvlucAKC9g==", "X-Forefront-Antispam-Report": "CIP:149.6.166.170; CTRY:FR; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:proxy.softathome.com; PTR:InfoDomainNonexistent;\n CAT:NONE;\n SFS:(13230040)(1800799024)(376014)(36860700016)(82310400026)(22082099003)(18002099003)(56012099003);\n DIR:OUT; SFP:1101;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "\n ZhT3L4WVkpCMJSScY+j9shsfnVJOUOZAd8W/+WT2l3RdRbrxx+WiZ1bJnmjYLO7T3k3/OG/1j5sAws5ZKGfLMkJBwErPtun8QKJvn0cwhwDnXSnxFaH7Kx5+ef85vtplQC4uTMZcbv2ZP9uT7JdmnOF+HuQG/fTmCYGN6AXdDbgkKb9LyAdhMEQURFQ3p6a6idNSsLUYtAtRwZ/PZh7UuChrvXq175PvxcDLE9SGZTpcMuxOAmxJPW4iECP/HX7AveCpO1xkBPyJXuKBF46/IAPbgXf86MIkprC8gY3d6KU8oAi0R0uh5ZgFRbywCkJPJIYpmpXBw9VrpIlsa9qI8pljGlmxQB88YWvMc9NFiISmM/anZ1Z8hXGIAKCeJZ8PK2/MYyX6ujV2PcnwPQt23XReCaggwW5/5ymoVbCCU1EQkS3aHihaHPJ6OhOK8zE1", "X-OriginatorOrg": "softathome.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "31 Mar 2026 10:00:53.0930 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 0af95ff6-c156-45de-7bcd-08de8f0c6514", "X-MS-Exchange-CrossTenant-Id": "aa10e044-e405-4c10-8353-36b4d0cce511", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=aa10e044-e405-4c10-8353-36b4d0cce511; Ip=[149.6.166.170];\n Helo=[proxy.softathome.com]", "X-MS-Exchange-CrossTenant-AuthSource": "PA1PEPF000CC3FB.FRAP264.PROD.OUTLOOK.COM", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "MRYP264MB6542", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "Current implementation of ecdsa only supports key len aligned on\n8 bits. But the curve secp521r1 use a key of 521 bits which is not\naligned on 8 bits. In this commit, we update the key management\nfor ecdsa to support key of any lenght.\n\nSigned-off-by: Philippe Reynes <philippe.reynes@softathome.com>\n---\nv2:\n- intitial version\nv3:\n- fix typo in comments\n\n lib/ecdsa/ecdsa-libcrypto.c | 21 +++++++++++++++++++--\n lib/ecdsa/ecdsa-verify.c | 24 ++++++++++++++++++++++--\n lib/fdt-libcrypto.c | 2 +-\n tools/image-sig-host.c | 2 +-\n 4 files changed, 43 insertions(+), 6 deletions(-)", "diff": "diff --git a/lib/ecdsa/ecdsa-libcrypto.c b/lib/ecdsa/ecdsa-libcrypto.c\nindex c4bfb2cec61..f8ed694595c 100644\n--- a/lib/ecdsa/ecdsa-libcrypto.c\n+++ b/lib/ecdsa/ecdsa-libcrypto.c\n@@ -45,6 +45,7 @@ static int fdt_get_key(struct ecdsa_public_key *key, const void *fdt, int node)\n {\n \tint x_len;\n \tint y_len;\n+\tint expected_len;\n \n \tkey->curve_name = fdt_getprop(fdt, node, \"ecdsa,curve\", NULL);\n \tif (!key->curve_name)\n@@ -54,6 +55,8 @@ static int fdt_get_key(struct ecdsa_public_key *key, const void *fdt, int node)\n \t\tkey->size_bits = 256;\n \telse if (!strcmp(key->curve_name, \"secp384r1\"))\n \t\tkey->size_bits = 384;\n+\telse if (!strcmp(key->curve_name, \"secp521r1\"))\n+\t\tkey->size_bits = 521;\n \telse\n \t\treturn -EINVAL;\n \n@@ -63,7 +66,19 @@ static int fdt_get_key(struct ecdsa_public_key *key, const void *fdt, int node)\n \tif (!key->x || !key->y)\n \t\treturn -EINVAL;\n \n-\tif (x_len != key->size_bits / 8 || y_len != key->size_bits / 8)\n+\t/*\n+\t * The public key is stored as an array of u32, so if the key size is\n+\t * not a multiple of 32 (for example 521), we may have extra bytes.\n+\t * To avoid any issue later, we shift the x and y pointer to the first\n+\t * useful byte.\n+\t */\n+\texpected_len = (key->size_bits + 7) / 8;\n+\tif (x_len > expected_len)\n+\t\tkey->x += x_len - expected_len;\n+\tif (y_len > expected_len)\n+\t\tkey->y += y_len - expected_len;\n+\n+\tif (x_len < expected_len || y_len < expected_len)\n \t\treturn -EINVAL;\n \n \treturn 0;\n@@ -89,6 +104,8 @@ static int read_key_from_fdt(struct signer *ctx, const void *fdt, int node)\n \t\tnid = NID_X9_62_prime256v1;\n \t} else if (!strcmp(pubkey.curve_name, \"secp384r1\")) {\n \t\tnid = NID_secp384r1;\n+\t} else if (!strcmp(pubkey.curve_name, \"secp521r1\")) {\n+\t\tnid = NID_secp521r1;\n \t} else {\n \t\tfprintf(stderr, \"Unsupported curve name: '%s'\\n\", pubkey.curve_name);\n \t\treturn -EINVAL;\n@@ -111,7 +128,7 @@ static int read_key_from_fdt(struct signer *ctx, const void *fdt, int node)\n \t\treturn -ENOMEM;\n \t}\n \n-\tlen = pubkey.size_bits / 8;\n+\tlen = (pubkey.size_bits + 7) / 8;\n \n \tuint8_t buf[1 + len * 2];\n \ndiff --git a/lib/ecdsa/ecdsa-verify.c b/lib/ecdsa/ecdsa-verify.c\nindex 629b662cf6c..b90571e9fff 100644\n--- a/lib/ecdsa/ecdsa-verify.c\n+++ b/lib/ecdsa/ecdsa-verify.c\n@@ -24,13 +24,15 @@ static int ecdsa_key_size(const char *curve_name)\n \t\treturn 256;\n \telse if (!strcmp(curve_name, \"secp384r1\"))\n \t\treturn 384;\n+\telse if (!strcmp(curve_name, \"secp521r1\"))\n+\t\treturn 521;\n \n \treturn 0;\n }\n \n static int fdt_get_key(struct ecdsa_public_key *key, const void *fdt, int node)\n {\n-\tint x_len, y_len;\n+\tint expected_len, x_len, y_len;\n \n \tkey->curve_name = fdt_getprop(fdt, node, \"ecdsa,curve\", NULL);\n \tif (!key->curve_name) {\n@@ -50,7 +52,19 @@ static int fdt_get_key(struct ecdsa_public_key *key, const void *fdt, int node)\n \tif (!key->x || !key->y)\n \t\treturn -EINVAL;\n \n-\tif (x_len != (key->size_bits / 8) || y_len != (key->size_bits / 8)) {\n+\t/*\n+\t * The public key is stored as an array of u32, so if the key size is\n+\t * not a multiple of 32 (for example 521), we may have extra bytes.\n+\t * To avoid any issue later, we shift the x and y pointer to the first\n+\t * useful byte.\n+\t */\n+\texpected_len = (key->size_bits + 7) / 8;\n+\tif (x_len > expected_len)\n+\t\tkey->x += x_len - expected_len;\n+\tif (y_len > expected_len)\n+\t\tkey->y += y_len - expected_len;\n+\n+\tif (x_len < expected_len || y_len < expected_len) {\n \t\tprintf(\"%s: node=%d, curve@%p x@%p+%i y@%p+%i\\n\", __func__,\n \t\t node, key->curve_name, key->x, x_len, key->y, y_len);\n \t\treturn -EINVAL;\n@@ -135,6 +149,12 @@ U_BOOT_CRYPTO_ALGO(ecdsa384) = {\n \t.verify = ecdsa_verify,\n };\n \n+U_BOOT_CRYPTO_ALGO(ecdsa521) = {\n+\t.name = \"ecdsa521\",\n+\t.key_len = ECDSA521_BYTES,\n+\t.verify = ecdsa_verify,\n+};\n+\n /*\n * uclass definition for ECDSA API\n *\ndiff --git a/lib/fdt-libcrypto.c b/lib/fdt-libcrypto.c\nindex ecb0344c8f6..090246b44e9 100644\n--- a/lib/fdt-libcrypto.c\n+++ b/lib/fdt-libcrypto.c\n@@ -10,7 +10,7 @@\n int fdt_add_bignum(void *blob, int noffset, const char *prop_name,\n \t\t BIGNUM *num, int num_bits)\n {\n-\tint nwords = num_bits / 32;\n+\tint nwords = (num_bits + 31) / 32;\n \tint size;\n \tuint32_t *buf, *ptr;\n \tBIGNUM *tmp, *big2, *big32, *big2_32;\ndiff --git a/tools/image-sig-host.c b/tools/image-sig-host.c\nindex 5285263c616..a2272b196e7 100644\n--- a/tools/image-sig-host.c\n+++ b/tools/image-sig-host.c\n@@ -84,7 +84,7 @@ struct crypto_algo crypto_algos[] = {\n \t\t.verify = ecdsa_verify,\n \t},\n \t{\n-\t\t.name = \"secp521r1\",\n+\t\t.name = \"ecdsa521\",\n \t\t.key_len = ECDSA521_BYTES,\n \t\t.sign = ecdsa_sign,\n \t\t.add_verify_data = ecdsa_add_verify_data,\n", "prefixes": [ "v3", "05/15" ] }