Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2218034/?format=api
{ "id": 2218034, "url": "http://patchwork.ozlabs.org/api/patches/2218034/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260331095950.512326-1-pbonzini@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260331095950.512326-1-pbonzini@redhat.com>", "list_archive_url": null, "date": "2026-03-31T09:59:50", "name": "tests: add test for json-streamer.c error recovery", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "48b86c5f177aac2058bce8cb0c9882d247af62a9", "submitter": { "id": 2701, "url": "http://patchwork.ozlabs.org/api/people/2701/?format=api", "name": "Paolo Bonzini", "email": "pbonzini@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260331095950.512326-1-pbonzini@redhat.com/mbox/", "series": [ { "id": 498163, "url": "http://patchwork.ozlabs.org/api/series/498163/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=498163", "date": "2026-03-31T09:59:50", "name": "tests: add test for json-streamer.c error recovery", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/498163/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2218034/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2218034/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=Sc49GItN;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=eFNB8Akt;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4flNsG1rmHz1y1q\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 31 Mar 2026 21:00:18 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w7VtB-0004uP-Su; Tue, 31 Mar 2026 06:00:01 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <pbonzini@redhat.com>)\n id 1w7Vt9-0004u6-7O\n for qemu-devel@nongnu.org; Tue, 31 Mar 2026 05:59:59 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <pbonzini@redhat.com>)\n id 1w7Vt7-0000sD-IJ\n for qemu-devel@nongnu.org; Tue, 31 Mar 2026 05:59:58 -0400", "from mail-wr1-f70.google.com (mail-wr1-f70.google.com\n [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-150-eN4c7DXQMQCrPDumvr_qwg-1; Tue, 31 Mar 2026 05:59:54 -0400", "by mail-wr1-f70.google.com with SMTP id\n ffacd0b85a97d-43cffbe261eso1397825f8f.2\n for <qemu-devel@nongnu.org>; Tue, 31 Mar 2026 02:59:54 -0700 (PDT)", "from [192.168.10.48] ([151.49.85.67])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43cf21eba4dsm28054941f8f.11.2026.03.31.02.59.51\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 31 Mar 2026 02:59:51 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1774951196;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding;\n bh=+0zHznXzq5gUaXzFdXxiRJ2w0BmRcXmHhMrkP/J4v1k=;\n b=Sc49GItN92N04wH1KD+LGaBE1wnwRHD8M+NqrVf7TJvYotx9b7mluXR93MP+eZl6rCE+zt\n qskAys4c2oqNOVTVaySabBW9RMDJdwuiZZ7whvPQTvslDRbxlwEQSjz4kIhNaNK/rLBpN9\n LwQl4ZR1vAV2JftVh+Z5VyLDDdJwTnM=", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1774951193; x=1775555993; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=+0zHznXzq5gUaXzFdXxiRJ2w0BmRcXmHhMrkP/J4v1k=;\n b=eFNB8AktohoIOCxVF+fyBfuP7gMl6y0WpNCS62bJhM1tZoXHiQ4dxiOgd2gMeGHDT+\n 2TqDOqxKBqaQXKLQwmlTJwHxd6vhjFmEvi411dsAhkNcINRehM7sXfXDFIA2umZo5Y/A\n 2oaa0JVYulIhkLI4Ld05WDvIk2cxAHFWy3Fg+qVQZqmJaLKlkVV224BWyaIFBOYbHG0x\n 2P2VBDYJEWRRtnl79CaIPrDjeQWRpLeTZUD/8QOJpfUz4bqlhOYWbOIr0ndNOiyLoJ8I\n 3kGfj0rXgRHBOc64e6N4Win4wE2CqT0c7c3sTq8kfbyuCdSJbavnFDjhCHw65HYKJZUi\n zqEQ==" ], "X-MC-Unique": "eN4c7DXQMQCrPDumvr_qwg-1", "X-Mimecast-MFC-AGG-ID": "eN4c7DXQMQCrPDumvr_qwg_1774951193", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774951193; x=1775555993;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=+0zHznXzq5gUaXzFdXxiRJ2w0BmRcXmHhMrkP/J4v1k=;\n b=IaHN5y/78ZlESs4TZdUdaaYwlA99QrKtmag8aHM2I9OQarfR2khjS68Nf2FwQS2ZvL\n 6YBJtiQJWzgvY+8J/y30GdwSLuJgOG/BWVCeR6y3HhwWgyoHC6ev7Qm2oY6x9tn78TYI\n FMEOsWpWjKpLRpEc/Z+pPmnFGy6gq2KcP0dzFlLEA1ibfvn/GyVzbANF0QBZoMPuIPeN\n I0h/Eou5td4URbUDNmk58F+IeJ9hSKpjRivYZj2VCu7fD3O4am+rz9i+YzvsmbS3KXwW\n Qwv5rTzT4StZdHt34cs4l/CWHfvBy3zeHT/06s4uhnLSPTh4YW2C1p5rCCYEHP9MDLKl\n wO4w==", "X-Gm-Message-State": "AOJu0Yys0Mzpoy4UN25TwuGgCsHIYzACNcIKbpwgpdXLBvpMfPpf+YDh\n UWFrpp0S2upTGWGkQe1y88yjqjlJeCNngDKd1vfI2v8DclH3k2VOO9AU4DGLzbPWlSBDu+4gKTa\n 5ydBQXqFeafyFx09vDlqzW/FTFPW7WiVw0y7+fN2tGLWxcDfgjKE/cpIASAKoeADIyzG3dAdU15\n tJXKrocnYoHt4cHekfvzPzpFbbaoZMIl3UNyBVKFUx", "X-Gm-Gg": "ATEYQzwdj8PGysu/Q+kRppjItHwRwWE2qcK5NT/fzyoDDPaZZsxuiljipBaufK71V8n\n NLh8+xCQA+9Mi1+FMzvuoWK+XKUrSwwQBerVywnrXI1b0dLEL+UcNDDQ7fh8N3Mk53uevh24P1q\n k1vR+Km1kaP+sVdt7JvEs0OakP7eKxl+CCAOMxK10DPXnG1zdzqeVDQsq2xRK/iEZKedRQ6mDE/\n Imti6DyjKxCWjqMiDL72jIZZ4qZ9VRvquoFU7rXmw7HG97h+F9GmaT7xch6FxTChAId+6z/7Y8P\n Qp0YxgoJxogBQWlCTucKb+7BRM5EvCmOzaYivF1Kibge9ZPz0VJIRQreFKHhuzF2I7BHUB5Nthg\n FbxesvZWUKtR8C2MaEs4/aHlXr3VFADH5L6LzonKd82hcjuxTU0KYmRweSEhi5WrzGRFWlP7C1v\n ZI7TzbgO+e5LpQAeQm1ETz3WaQ", "X-Received": [ "by 2002:a5d:5d07:0:b0:43b:6a55:e26a with SMTP id\n ffacd0b85a97d-43b9ea776c6mr27853572f8f.51.1774951192832;\n Tue, 31 Mar 2026 02:59:52 -0700 (PDT)", "by 2002:a5d:5d07:0:b0:43b:6a55:e26a with SMTP id\n ffacd0b85a97d-43b9ea776c6mr27853513f8f.51.1774951192341;\n Tue, 31 Mar 2026 02:59:52 -0700 (PDT)" ], "From": "Paolo Bonzini <pbonzini@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "armbru@redhat.com", "Subject": "[PATCH] tests: add test for json-streamer.c error recovery", "Date": "Tue, 31 Mar 2026 11:59:50 +0200", "Message-ID": "<20260331095950.512326-1-pbonzini@redhat.com>", "X-Mailer": "git-send-email 2.53.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=170.10.133.124;\n envelope-from=pbonzini@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-6", "X-Spam_score": "-0.7", "X-Spam_bar": "/", "X-Spam_report": "(-0.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.01,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=1, RCVD_IN_VALIDITY_RPBL_BLOCKED=1,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Before rewriting the error recovery code to work in a push parsing\nsetup, make sure that we have tests for it.\n\nCover various cases of invalid JSON, to check that structural\nrecovery based on balanced brackets and braces works; and\nlexer-based recovery which documents \"\\f\" as a sure fire\nway to reset the lexer.\n\nSigned-off-by: Paolo Bonzini <pbonzini@redhat.com>\n---\n tests/unit/check-json-parser.c | 145 +++++++++++++++++++++++++++++++++\n tests/unit/meson.build | 1 +\n 2 files changed, 146 insertions(+)\n create mode 100644 tests/unit/check-json-parser.c", "diff": "diff --git a/tests/unit/check-json-parser.c b/tests/unit/check-json-parser.c\nnew file mode 100644\nindex 00000000000..ca2d5f41097\n--- /dev/null\n+++ b/tests/unit/check-json-parser.c\n@@ -0,0 +1,145 @@\n+/*\n+ * Unit tests for JSON Parser error recovery\n+ *\n+ * Copyright 2026 Red Hat\n+ * Author: Paolo Bonzini <pbonzini@redhat.com>\n+ *\n+ * This work is licensed under the terms of the GNU LGPL, version 2.1 or later.\n+ * See the COPYING.LIB file in the top-level directory.\n+ */\n+\n+#include \"qemu/osdep.h\"\n+\n+#include \"qapi/error.h\"\n+#include \"qobject/qbool.h\"\n+#include \"qobject/json-parser.h\"\n+\n+typedef struct ParseResult {\n+ int errors;\n+ QObject *result;\n+} ParseResult;\n+\n+static void parse_emit(void *opaque, QObject *json, Error *err)\n+{\n+ ParseResult *r = opaque;\n+\n+ if (err) {\n+ r->errors++;\n+ error_free(err);\n+ } else {\n+ qobject_unref(r->result);\n+ r->result = json;\n+ }\n+}\n+\n+static ParseResult do_parse(const char *input)\n+{\n+ ParseResult r = { 0, NULL };\n+ JSONMessageParser parser;\n+\n+ json_message_parser_init(&parser, parse_emit, &r, NULL);\n+ json_message_parser_feed(&parser, input, strlen(input));\n+ json_message_parser_flush(&parser);\n+ json_message_parser_destroy(&parser);\n+ return r;\n+}\n+\n+static void check_result(const char *input, int expected_errors, QType expected_type)\n+{\n+ ParseResult r = do_parse(input);\n+\n+ g_assert_cmpint(r.errors, ==, expected_errors);\n+ g_assert_nonnull(r.result);\n+ g_assert_cmpint(qobject_type(r.result), ==, expected_type);\n+ qobject_unref(r.result);\n+}\n+\n+static void check_result_error(const char *input, int expected_errors)\n+{\n+ ParseResult r = do_parse(input);\n+\n+ g_assert_cmpint(r.errors, ==, expected_errors);\n+ g_assert_null(r.result);\n+}\n+\n+static void test_simple(void)\n+{\n+ check_result(\"false\", 0, QTYPE_QBOOL);\n+}\n+\n+static void test_whitespace(void)\n+{\n+ check_result(\" false\", 0, QTYPE_QBOOL);\n+}\n+\n+static void test_extra_closing_braces(void)\n+{\n+ check_result(\"}}false\", 2, QTYPE_QBOOL);\n+}\n+\n+static void test_bad_dict(void)\n+{\n+ check_result(\"{ 'abc' }false\", 1, QTYPE_QBOOL);\n+}\n+\n+static void test_trailing_comma(void)\n+{\n+ check_result(\"[ 'abc', ]false\", 1, QTYPE_QBOOL);\n+}\n+\n+static void test_lexer_recovery(void)\n+{\n+ check_result(\"\\f{}\", 1, QTYPE_QDICT);\n+ check_result(\"\\f[]\", 1, QTYPE_QLIST);\n+ check_result(\"\\f:false\", 2, QTYPE_QBOOL);\n+ check_result(\"\\f,false\", 2, QTYPE_QBOOL);\n+\n+ /*\n+ * alphabetic characters do not start a new parsing, this is slightly weird\n+ * but it keeps the lexer simple and works well for QMP (where valid input\n+ * is a sequence of dictionaries)\n+ */\n+ check_result_error(\"\\ffalse\", 1);\n+ check_result_error(\"\\f'str'\", 1);\n+ check_result_error(\"\\f\\\"str\\\"\", 1);\n+}\n+\n+static void test_lexer_recovery_nested(void)\n+{\n+ check_result(\"{[{\\f{}\", 1, QTYPE_QDICT);\n+ check_result(\"{[{\\f[]\", 1, QTYPE_QLIST);\n+ check_result(\"{[{\\f:false\", 2, QTYPE_QBOOL);\n+ check_result(\"{[{\\f,false\", 2, QTYPE_QBOOL);\n+\n+ /* same as test_lexer_recovery */\n+ check_result_error(\"{[{\\ffalse\", 1);\n+ check_result_error(\"{[{\\f'str'\", 1);\n+ check_result_error(\"{[{\\f\\\"str\\\"\", 1);\n+}\n+\n+static void test_nested(void)\n+{\n+ check_result(\"[{'a']}false\", 1, QTYPE_QBOOL);\n+}\n+\n+static void test_nested_multiple(void)\n+{\n+ check_result(\"[{'a']}[{'a']}false\", 2, QTYPE_QBOOL);\n+}\n+\n+int main(int argc, char **argv)\n+{\n+ g_test_init(&argc, &argv, NULL);\n+\n+ g_test_add_func(\"/json-parser/simple\", test_simple);\n+ g_test_add_func(\"/json-parser/whitespace\", test_whitespace);\n+ g_test_add_func(\"/json-parser/error-recovery/extra-closing-braces\", test_extra_closing_braces);\n+ g_test_add_func(\"/json-parser/error-recovery/bad-dict\", test_bad_dict);\n+ g_test_add_func(\"/json-parser/error-recovery/trailing-comma\", test_trailing_comma);\n+ g_test_add_func(\"/json-parser/error-recovery/lexer\", test_lexer_recovery);\n+ g_test_add_func(\"/json-parser/error-recovery/lexer/nested\", test_lexer_recovery_nested);\n+ g_test_add_func(\"/json-parser/error-recovery/nested\", test_nested);\n+ g_test_add_func(\"/json-parser/error-recovery/nested/multiple\", test_nested_multiple);\n+\n+ return g_test_run();\n+}\ndiff --git a/tests/unit/meson.build b/tests/unit/meson.build\nindex 41e8b06c339..03d36748c73 100644\n--- a/tests/unit/meson.build\n+++ b/tests/unit/meson.build\n@@ -10,6 +10,7 @@ tests = {\n 'check-qnull': [],\n 'check-qobject': [],\n 'check-qjson': [],\n+ 'check-json-parser': [],\n 'check-qlit': [],\n 'test-error-report': [],\n 'test-qobject-output-visitor': [testqapi],\n", "prefixes": [] }