Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2218033/?format=api
{ "id": 2218033, "url": "http://patchwork.ozlabs.org/api/patches/2218033/?format=api", "web_url": "http://patchwork.ozlabs.org/project/opensbi/patch/20260331095943.133791-1-buenocalvachejoel@gmail.com/", "project": { "id": 67, "url": "http://patchwork.ozlabs.org/api/projects/67/?format=api", "name": "OpenSBI development", "link_name": "opensbi", "list_id": "opensbi.lists.infradead.org", "list_email": "opensbi@lists.infradead.org", "web_url": "https://github.com/riscv/opensbi", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "https://github.com/riscv/opensbi/commit/{}" }, "msgid": "<20260331095943.133791-1-buenocalvachejoel@gmail.com>", "list_archive_url": null, "date": "2026-03-31T09:59:43", "name": "firmware: fw_base: make stack guard setup conditional on Zkr", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "8ad49cb3c9c33a6bacd97b4f87877205d7e3849d", "submitter": { "id": 92309, "url": "http://patchwork.ozlabs.org/api/people/92309/?format=api", "name": "Joel Bueno", "email": "buenocalvachejoel@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/opensbi/patch/20260331095943.133791-1-buenocalvachejoel@gmail.com/mbox/", "series": [ { "id": 498162, "url": "http://patchwork.ozlabs.org/api/series/498162/?format=api", "web_url": "http://patchwork.ozlabs.org/project/opensbi/list/?series=498162", "date": "2026-03-31T09:59:43", "name": "firmware: fw_base: make stack guard setup conditional on Zkr", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/498162/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2218033/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2218033/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=kB7EK6Vk;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=mhu0lr/Z;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4flNrx5Btxz1yGH\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 31 Mar 2026 21:00:01 +1100 (AEDT)", "from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1w7Vt4-0000000CjAg-09iz;\n\tTue, 31 Mar 2026 09:59:54 +0000", "from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a])\n\tby bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1w7Vt1-0000000CjAL-3WvP\n\tfor opensbi@lists.infradead.org;\n\tTue, 31 Mar 2026 09:59:52 +0000", "by mail-wr1-x42a.google.com with SMTP id\n ffacd0b85a97d-43d0245e24cso115204f8f.3\n for <opensbi@lists.infradead.org>;\n Tue, 31 Mar 2026 02:59:51 -0700 (PDT)", "from LT-5CD5216TNC.openchip.local\n ([2a0c:5a87:e304:8b00:15b1:a941:ca1a:2bfa])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43cf247102dsm31608917f8f.27.2026.03.31.02.59.48\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 31 Mar 2026 02:59:49 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc\n\t:To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:\n\tResent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:\n\tList-Owner; bh=eZUUv4W/Hwz0w4FTP639zp1K776uEjVx4yOXhtDoaqA=; b=kB7EK6Vkom/x70\n\trELuuisBmKVALCGUo9itWJFG1f2LDwApyds6LGHIdPJ8rVF3swth6/7HVPykAEd7sHkYYGrQN9kTt\n\tDfFQnACQX/mVRWlXEOiVbu6vvdcKpxTq6tdfsB3c+1yr9BZvJ3HfEl/ZH8mxFYiRRSSmQGDucQMQP\n\tptyPmRfTBihVE7pJxJs4k4w8vY046oeFL9p4jtp6veCUh2QOu97JbAHHrXkmgJq1ZZIHS//Aa0W07\n\tN03kN2L3tUAuyKub54IKPhWzt4DMNz6kJrlPJ0bqL+oVeJiWMfV7aVflzvbZO6D0/PHQXka0Gyith\n\tFELUO0S5fpC6RDLUUflA==;", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1774951190; x=1775555990;\n darn=lists.infradead.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=nxmY6GBHrjzRgMn8HJoAGab+jgEJ5wnlSK45ova9G5U=;\n b=mhu0lr/ZuUV4u95X5OGrQcGoRkXLWkUeoZ3AXQyxMTNvDM898qh4oJWfOt/w1Rkc4k\n SB75C3V2Z25kH4ZzAzCCBkgjIqT4Z/2x4AWO2Yw7xpLT4eWlgWBE4tz/NuThMdAXYAod\n GUFLED6oPo02FkugYBVTSMNFWyVDOASs/GtCOd+PkKdaBLIJSqUcFwPQRm5XumexiBpW\n Wszr8h0lLGmZQKvPw7sqw5oEjGaduiszwbzwEdvc0JQCvZv8Dgyecz84xeKodBBE3h8y\n KnA1g+7SyqDV9rDzlx3G9Dd0KkgpLFKV0CCGkltp+nAwYJc52eL/QK3dd9+2/lnJBBTx\n lRmA==" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774951190; x=1775555990;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=nxmY6GBHrjzRgMn8HJoAGab+jgEJ5wnlSK45ova9G5U=;\n b=KBHaKGVSrioh93F0Q6D6IbVyi/8IbYwZPmRvUoNSzkiPJcbd0Ig67G5CnjsevH2JP7\n 5vOySxWZFKJXRfCClLWbcrk2V4j7wL3qiVH4tM0m+cHObKpj7r6k4PBh3MZlrYgIgQ+7\n KYyPjQYlrGLoFkHL24lsD2nGAlJPFHN3m82BgkFOboCs1yqYCywaZDYFJUIMC9dI2Xc/\n wJSVVZKbSkJ7CDCAeDVNZkL3UE9IVW2xtSz6eNuPBxvDM37PDPcCfH1cohvyZ9VhKDkG\n KBd9pYSbeHo9v1U4WT11+jvRPrQm9tobqt46cyTHtG88gI5oAXAaBAlo+/L64Q9WLUKn\n jxow==", "X-Gm-Message-State": "AOJu0YyQvBCXkaAc5l9XYSbGN61WlzIoRIsL/BYhq6XZkOAO0emeyGb0\n\t/o/2QQtm+NnAg0SlE6vK6qIX3rOg4KLfJoXrowKX4WWiJFicfKeF/yYpp/VWoeGQ4Mw=", "X-Gm-Gg": "ATEYQzzCCc+WdUGIMzHbJJRpGzXoVeiMLBfIXNBhOZkYIJ8ayfK0mfwJEHMCWksZQuY\n\t0/kvSQ4ROL/l3/d53HsoLG3cmBkukTNznGmU9B8JM4VpPtT4KCyhjUEj1CmiPdp4rmAauQKFLul\n\tlRJfBn0TKopkArRZEK3mOHaZyoLuO83XM0/Dc3bdGqITljAIjSjNBmWD0JzAEpCfkun5viFuS9o\n\td7eYYJGhotfSV/87KDtS1VcUycMSH6E3yJYFhA88vLiEk9TnNaE5+TQIRypuRwMxsZsPypWaxou\n\tGOhdm7cseX2Q5fDR948f7hsBRfnntHLtZeuUoale2+ET2iMOPT34MrhlIPjKj0o7SnWRmBjM/Ue\n\tkthtI3lZhEnr1lsBspvlXj29nbsvMGnmgAhQTCxpYApoi2Y7RFeMpZAvo1tAwpbjQ0MVFLnHUFY\n\t5oBoaV0DcgskZMHZMT75ZDnl9o5caXD5EwMlm9ywxPJRBZ50sun8nj7fkx0pKAYcHP+o6m+oNFH\n\tiDQIJiPhoqS58AUILJDf2T7N1L5BmbMbL2grXDBEbFfvJvrpVYcwRo=", "X-Received": "by 2002:a05:6000:2582:b0:43c:fa7b:6f07 with SMTP id\n ffacd0b85a97d-43cfa7b7297mr7914883f8f.7.1774951189523;\n Tue, 31 Mar 2026 02:59:49 -0700 (PDT)", "From": "buenocalvachejoel@gmail.com", "To": "opensbi@lists.infradead.org", "Cc": "anup@brainfault.org,\n\tJoel Bueno <buenocalvachejoel@gmail.com>", "Subject": "[PATCH] firmware: fw_base: make stack guard setup conditional on Zkr", "Date": "Tue, 31 Mar 2026 11:59:43 +0200", "Message-ID": "<20260331095943.133791-1-buenocalvachejoel@gmail.com>", "X-Mailer": "git-send-email 2.43.0", "MIME-Version": "1.0", "X-CRM114-Version": "20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ", "X-CRM114-CacheID": "sfid-20260331_025951_896040_B47B8C31 ", "X-CRM114-Status": "UNSURE ( 7.98 )", "X-CRM114-Notice": "Please train this message.", "X-Spam-Score": "-2.1 (--)", "X-Spam-Report": "Spam detection software,\n running on the system \"bombadil.infradead.org\",\n has NOT identified this incoming email as spam. The original\n message has been attached to this so you can view it or label\n similar future email. If you have any questions, see\n the administrator of that system for details.\n Content preview: From: Joel Bueno Zkr isn't explicitly selected as a\n mandatory\n extension to run OpenSBI as per: docs/platform_requirements.md Since this\n happens very early on the boot flow of OpenSBI where the dynamic extension\n checks haven't yet happened, we must guard the Zkr stack setup behind an\n ifdef block so that it only gets compiled [...]\n Content analysis details: (-2.1 points, 5.0 required)\n pts rule name description\n ---- ----------------------\n --------------------------------------------------\n -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no\n trust\n [2a00:1450:4864:20:0:0:0:42a listed in]\n [list.dnswl.org]\n 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record\n -0.0 SPF_PASS SPF: sender matches SPF record\n 0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n not necessarily valid\n -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from\n envelope-from domain\n -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n author's\n domain\n -0.1 DKIM_VALID Message has at least one valid DKIM or DK\n signature\n -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n [score: 0.0000]\n 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\n provider\n [buenocalvachejoel(at)gmail.com]", "X-BeenThere": "opensbi@lists.infradead.org", "X-Mailman-Version": "2.1.34", "Precedence": "list", "List-Id": "<opensbi.lists.infradead.org>", "List-Unsubscribe": "<http://lists.infradead.org/mailman/options/opensbi>,\n <mailto:opensbi-request@lists.infradead.org?subject=unsubscribe>", "List-Archive": "<http://lists.infradead.org/pipermail/opensbi/>", "List-Post": "<mailto:opensbi@lists.infradead.org>", "List-Help": "<mailto:opensbi-request@lists.infradead.org?subject=help>", "List-Subscribe": "<http://lists.infradead.org/mailman/listinfo/opensbi>,\n <mailto:opensbi-request@lists.infradead.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "\"opensbi\" <opensbi-bounces@lists.infradead.org>", "Errors-To": "opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org" }, "content": "From: Joel Bueno <buenocalvachejoel@gmail.com>\n\nZkr isn't explicitly selected as a mandatory extension to run OpenSBI\nas per: docs/platform_requirements.md\n\nSince this happens very early on the boot flow of OpenSBI where the\ndynamic extension checks haven't yet happened, we must guard the Zkr\nstack setup behind an ifdef block so that it only gets compiled for\ntargets that do actually have the extension.\n\nSigned-off-by: Joel Bueno <buenocalvachejoel@gmail.com>\n---\n firmware/fw_base.S | 2 ++\n 1 file changed, 2 insertions(+)", "diff": "diff --git a/firmware/fw_base.S b/firmware/fw_base.S\nindex 63bb4473..9ea93907 100644\n--- a/firmware/fw_base.S\n+++ b/firmware/fw_base.S\n@@ -107,6 +107,7 @@ _bss_zero:\n \tadd\ts4, s4, __SIZEOF_POINTER__\n \tblt\ts4, s5, _bss_zero\n \n+#if defined(__riscv_zkr)\n \t/* Trying to initialize the stack guard via the Zkr extension */\n \tlla\tt0, __stack_chk_guard_done\n \tcsrw\tCSR_MTVEC, t0\n@@ -130,6 +131,7 @@ __stack_chk_guard_loop:\n \tj\t__stack_chk_guard_done\n \t.align 3\n __stack_chk_guard_done:\n+#endif\n \n \t/* Setup temporary trap handler */\n \tlla\ts4, _start_hang\n", "prefixes": [] }