Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2218028/?format=api
{ "id": 2218028, "url": "http://patchwork.ozlabs.org/api/patches/2218028/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260331095302.644608-6-marcandre.lureau@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260331095302.644608-6-marcandre.lureau@redhat.com>", "list_archive_url": null, "date": "2026-03-31T09:53:01", "name": "[PULL,5/6] ui/vnc-jobs: clear source tag", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "92fad42a4896d0d3020ce3364607c6ae12a10366", "submitter": { "id": 66774, "url": "http://patchwork.ozlabs.org/api/people/66774/?format=api", "name": "Marc-André Lureau", "email": "marcandre.lureau@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260331095302.644608-6-marcandre.lureau@redhat.com/mbox/", "series": [ { "id": 498160, "url": "http://patchwork.ozlabs.org/api/series/498160/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=498160", "date": "2026-03-31T09:52:57", "name": "[PULL,1/6] audio/mixeng: fix sw/hw mixup in audio_pcm_sw_init_", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/498160/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2218028/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2218028/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=flBsSUvW;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4flNkH5nF8z1xtJ\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 31 Mar 2026 20:54:15 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w7Vn8-0000ua-1c; Tue, 31 Mar 2026 05:53:46 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1w7Vn6-0000kI-33\n for qemu-devel@nongnu.org; Tue, 31 Mar 2026 05:53:44 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1w7Vn4-0008EU-HM\n for qemu-devel@nongnu.org; Tue, 31 Mar 2026 05:53:43 -0400", "from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-335-QeGswUESNDOTKdD5OT7dHQ-1; Tue,\n 31 Mar 2026 05:53:39 -0400", "from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id B459C1956094; Tue, 31 Mar 2026 09:53:38 +0000 (UTC)", "from localhost (unknown [10.44.22.22])\n by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id A6E8A180058B; Tue, 31 Mar 2026 09:53:37 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1774950821;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=RBM9nkW+r4Seb1KGGXoI8JFaAWn2nmtP93T+sV0Bs4Y=;\n b=flBsSUvW9FLU75ciN6Dyc3wdeCAw+wK1srybd5CXKz1GISQJR35wSq5sGCzUAH/vTH+4f4\n M6BBew0pN3vMGaTFw8O93VFNpwXcagGshX7UNhYVwXqLfYv1bgWj+pwDdDuJZdT/IfvEh1\n xnXXNLjdDh0AjjDimNHsEPWpYpaCO68=", "X-MC-Unique": "QeGswUESNDOTKdD5OT7dHQ-1", "X-Mimecast-MFC-AGG-ID": "QeGswUESNDOTKdD5OT7dHQ_1774950818", "From": "marcandre.lureau@redhat.com", "To": "qemu-devel@nongnu.org", "Cc": "peter.maydell@linaro.org,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "Subject": "[PULL 5/6] ui/vnc-jobs: clear source tag", "Date": "Tue, 31 Mar 2026 13:53:01 +0400", "Message-ID": "<20260331095302.644608-6-marcandre.lureau@redhat.com>", "In-Reply-To": "<20260331095302.644608-1-marcandre.lureau@redhat.com>", "References": "<20260331095302.644608-1-marcandre.lureau@redhat.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.111", "Received-SPF": "pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "27", "X-Spam_score": "2.7", "X-Spam_bar": "++", "X-Spam_report": "(2.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_SBL_CSS=3.335,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=1, RCVD_IN_VALIDITY_RPBL_BLOCKED=1,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Marc-André Lureau <marcandre.lureau@redhat.com>\n\nAvoid potentially removing a dangling source & simplify code.\n\nReviewed-by: Daniel P. Berrangé <berrange@redhat.com>\nSigned-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>\n---\n ui/vnc-jobs.c | 4 +---\n ui/vnc.c | 31 +++++++------------------------\n 2 files changed, 8 insertions(+), 27 deletions(-)", "diff": "diff --git a/ui/vnc-jobs.c b/ui/vnc-jobs.c\nindex ca625da6d05..ec90ae6d5fc 100644\n--- a/ui/vnc-jobs.c\n+++ b/ui/vnc-jobs.c\n@@ -162,9 +162,7 @@ void vnc_jobs_consume_buffer(VncState *vs)\n vnc_lock_output(vs);\n if (vs->jobs_buffer.offset) {\n if (vs->ioc != NULL && buffer_empty(&vs->output)) {\n- if (vs->ioc_tag) {\n- g_source_remove(vs->ioc_tag);\n- }\n+ g_clear_handle_id(&vs->ioc_tag, g_source_remove);\n if (vs->disconnecting == FALSE) {\n vs->ioc_tag = qio_channel_add_watch(\n vs->ioc, G_IO_IN | G_IO_HUP | G_IO_ERR | G_IO_OUT,\ndiff --git a/ui/vnc.c b/ui/vnc.c\nindex 952976e9649..ccc73bd7aa4 100644\n--- a/ui/vnc.c\n+++ b/ui/vnc.c\n@@ -1301,10 +1301,7 @@ static void vnc_disconnect_start(VncState *vs)\n }\n trace_vnc_client_disconnect_start(vs, vs->ioc);\n vnc_set_share_mode(vs, VNC_SHARE_MODE_DISCONNECTED);\n- if (vs->ioc_tag) {\n- g_source_remove(vs->ioc_tag);\n- vs->ioc_tag = 0;\n- }\n+ g_clear_handle_id(&vs->ioc_tag, g_source_remove);\n qio_channel_close(vs->ioc, NULL);\n vs->disconnecting = TRUE;\n }\n@@ -1462,9 +1459,7 @@ static size_t vnc_client_write_plain(VncState *vs)\n }\n \n if (vs->output.offset == 0) {\n- if (vs->ioc_tag) {\n- g_source_remove(vs->ioc_tag);\n- }\n+ g_clear_handle_id(&vs->ioc_tag, g_source_remove);\n vs->ioc_tag = qio_channel_add_watch(\n vs->ioc, G_IO_IN | G_IO_HUP | G_IO_ERR,\n vnc_client_io, vs, NULL);\n@@ -1500,9 +1495,7 @@ static void vnc_client_write(VncState *vs)\n if (vs->output.offset) {\n vnc_client_write_locked(vs);\n } else if (vs->ioc != NULL) {\n- if (vs->ioc_tag) {\n- g_source_remove(vs->ioc_tag);\n- }\n+ g_clear_handle_id(&vs->ioc_tag, g_source_remove);\n vs->ioc_tag = qio_channel_add_watch(\n vs->ioc, G_IO_IN | G_IO_HUP | G_IO_ERR,\n vnc_client_io, vs, NULL);\n@@ -1638,10 +1631,7 @@ gboolean vnc_client_io(QIOChannel *ioc G_GNUC_UNUSED,\n }\n \n if (vs->disconnecting) {\n- if (vs->ioc_tag != 0) {\n- g_source_remove(vs->ioc_tag);\n- }\n- vs->ioc_tag = 0;\n+ g_clear_handle_id(&vs->ioc_tag, g_source_remove);\n }\n return TRUE;\n }\n@@ -1684,9 +1674,7 @@ void vnc_write(VncState *vs, const void *data, size_t len)\n buffer_reserve(&vs->output, len);\n \n if (vs->ioc != NULL && buffer_empty(&vs->output)) {\n- if (vs->ioc_tag) {\n- g_source_remove(vs->ioc_tag);\n- }\n+ g_clear_handle_id(&vs->ioc_tag, g_source_remove);\n vs->ioc_tag = qio_channel_add_watch(\n vs->ioc, G_IO_IN | G_IO_HUP | G_IO_ERR | G_IO_OUT,\n vnc_client_io, vs, NULL);\n@@ -1734,10 +1722,7 @@ void vnc_flush(VncState *vs)\n vnc_client_write_locked(vs);\n }\n if (vs->disconnecting) {\n- if (vs->ioc_tag != 0) {\n- g_source_remove(vs->ioc_tag);\n- }\n- vs->ioc_tag = 0;\n+ g_clear_handle_id(&vs->ioc_tag, g_source_remove);\n }\n vnc_unlock_output(vs);\n }\n@@ -3342,9 +3327,7 @@ static void vnc_connect(VncDisplay *vd, QIOChannelSocket *sioc,\n VNC_DEBUG(\"New client on socket %p\\n\", vs->sioc);\n update_displaychangelistener(&vd->dcl, VNC_REFRESH_INTERVAL_BASE);\n qio_channel_set_blocking(vs->ioc, false, &error_abort);\n- if (vs->ioc_tag) {\n- g_source_remove(vs->ioc_tag);\n- }\n+ g_clear_handle_id(&vs->ioc_tag, g_source_remove);\n if (websocket) {\n vs->websocket = 1;\n if (vd->tlscreds) {\n", "prefixes": [ "PULL", "5/6" ] }