Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2218026/?format=api
{ "id": 2218026, "url": "http://patchwork.ozlabs.org/api/patches/2218026/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260331095302.644608-5-marcandre.lureau@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260331095302.644608-5-marcandre.lureau@redhat.com>", "list_archive_url": null, "date": "2026-03-31T09:53:00", "name": "[PULL,4/6] ui/vnc-jobs: fix VncRectEntry leak on job cleanup", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "06abbed26c5fbb556903e6cfde26ba0cd5064a03", "submitter": { "id": 66774, "url": "http://patchwork.ozlabs.org/api/people/66774/?format=api", "name": "Marc-André Lureau", "email": "marcandre.lureau@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260331095302.644608-5-marcandre.lureau@redhat.com/mbox/", "series": [ { "id": 498160, "url": "http://patchwork.ozlabs.org/api/series/498160/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=498160", "date": "2026-03-31T09:52:57", "name": "[PULL,1/6] audio/mixeng: fix sw/hw mixup in audio_pcm_sw_init_", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/498160/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2218026/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2218026/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=ZdWrMZ5L;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4flNjl6cwDz1xtJ\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 31 Mar 2026 20:53:47 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w7Vn2-0000Zr-VI; Tue, 31 Mar 2026 05:53:40 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1w7Vn0-0000Xs-QM\n for qemu-devel@nongnu.org; Tue, 31 Mar 2026 05:53:39 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1w7Vmz-00089S-Et\n for qemu-devel@nongnu.org; Tue, 31 Mar 2026 05:53:38 -0400", "from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-376-LWtE86NEOrW71MRV9zAneA-1; Tue,\n 31 Mar 2026 05:53:33 -0400", "from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 5CB18180034E; Tue, 31 Mar 2026 09:53:32 +0000 (UTC)", "from localhost (unknown [10.44.22.22])\n by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 61DE418002A6; Tue, 31 Mar 2026 09:53:29 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1774950816;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=f2zQVVCmyQ0LGrf0EklnYlbhl3AtvR1KwwHBqe0PJ9I=;\n b=ZdWrMZ5LwZWcM8aZZ48wpvq1P1j84Om94KesaBaCicGSAwWFaCIGl77Yi6G8w70UiiI+Z7\n 0S97EP/MskEp4d3SVG22AXvEfxU+oySopXpnXWB4Jv6w85JhDOGB3mK6mDxjlqp2ZynGtQ\n C3EOBH6vHMNvS7dXmIlFQedtDkPZ7T0=", "X-MC-Unique": "LWtE86NEOrW71MRV9zAneA-1", "X-Mimecast-MFC-AGG-ID": "LWtE86NEOrW71MRV9zAneA_1774950812", "From": "marcandre.lureau@redhat.com", "To": "qemu-devel@nongnu.org", "Cc": "peter.maydell@linaro.org,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "Subject": "[PULL 4/6] ui/vnc-jobs: fix VncRectEntry leak on job cleanup", "Date": "Tue, 31 Mar 2026 13:53:00 +0400", "Message-ID": "<20260331095302.644608-5-marcandre.lureau@redhat.com>", "In-Reply-To": "<20260331095302.644608-1-marcandre.lureau@redhat.com>", "References": "<20260331095302.644608-1-marcandre.lureau@redhat.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.111", "Received-SPF": "pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-6", "X-Spam_score": "-0.7", "X-Spam_bar": "/", "X-Spam_report": "(-0.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.01,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=1, RCVD_IN_VALIDITY_RPBL_BLOCKED=1,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Marc-André Lureau <marcandre.lureau@redhat.com>\n\nWhen a VncJob is freed, its associated VncRectEntry list must also be\nfreed. Previously, vnc_job_push() and the disconnected path in\nvnc_worker_thread_loop() called g_free(job) directly, leaking all\nVncRectEntry allocations.\n\nIntroduce vnc_job_free() which iterates and frees the rectangle entries\nbefore freeing the job itself, and use it in both paths.\n\nAlso add QLIST_REMOVE() in the worker loop before g_free(entry), so\nthat entries processed during normal operation are properly unlinked.\nWithout this, vnc_job_free() would iterate dangling pointers to\nalready-freed entries, causing use-after-free.\n\nFixes: bd023f953e5e (\"vnc: threaded VNC server\")\nReviewed-by: Daniel P. Berrangé <berrange@redhat.com>\nSigned-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>\n---\n ui/vnc-jobs.c | 19 +++++++++++++++++--\n 1 file changed, 17 insertions(+), 2 deletions(-)", "diff": "diff --git a/ui/vnc-jobs.c b/ui/vnc-jobs.c\nindex b296d19e089..ca625da6d05 100644\n--- a/ui/vnc-jobs.c\n+++ b/ui/vnc-jobs.c\n@@ -107,11 +107,25 @@ int vnc_job_add_rect(VncJob *job, int x, int y, int w, int h)\n return 1;\n }\n \n+static void vnc_job_free(VncJob *job)\n+{\n+ VncRectEntry *entry, *tmp;\n+\n+ if (!job) {\n+ return;\n+ }\n+ QLIST_FOREACH_SAFE(entry, &job->rectangles, next, tmp) {\n+ /* no need for QLIST_REMOVE(entry, next) */\n+ g_free(entry);\n+ }\n+ g_free(job);\n+}\n+\n void vnc_job_push(VncJob *job)\n {\n vnc_lock_queue(queue);\n if (queue->exit || QLIST_EMPTY(&job->rectangles)) {\n- g_free(job);\n+ vnc_job_free(job);\n } else {\n QTAILQ_INSERT_TAIL(&queue->jobs, job, next);\n qemu_cond_broadcast(&queue->cond);\n@@ -296,6 +310,7 @@ static int vnc_worker_thread_loop(VncJobQueue *queue)\n n_rectangles += n;\n }\n }\n+ QLIST_REMOVE(entry, next);\n g_free(entry);\n }\n trace_vnc_job_nrects(&vs, job, n_rectangles);\n@@ -324,7 +339,7 @@ disconnected:\n QTAILQ_REMOVE(&queue->jobs, job, next);\n vnc_unlock_queue(queue);\n qemu_cond_broadcast(&queue->cond);\n- g_free(job);\n+ vnc_job_free(job);\n vs.magic = 0;\n return 0;\n }\n", "prefixes": [ "PULL", "4/6" ] }