Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2218025/?format=api
{ "id": 2218025, "url": "http://patchwork.ozlabs.org/api/patches/2218025/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260331095302.644608-2-marcandre.lureau@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260331095302.644608-2-marcandre.lureau@redhat.com>", "list_archive_url": null, "date": "2026-03-31T09:52:57", "name": "[PULL,1/6] audio/mixeng: fix sw/hw mixup in audio_pcm_sw_init_", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "009dcfb2d212108e597ac553473b180dd8a6fc26", "submitter": { "id": 66774, "url": "http://patchwork.ozlabs.org/api/people/66774/?format=api", "name": "Marc-André Lureau", "email": "marcandre.lureau@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260331095302.644608-2-marcandre.lureau@redhat.com/mbox/", "series": [ { "id": 498160, "url": "http://patchwork.ozlabs.org/api/series/498160/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=498160", "date": "2026-03-31T09:52:57", "name": "[PULL,1/6] audio/mixeng: fix sw/hw mixup in audio_pcm_sw_init_", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/498160/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2218025/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2218025/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=DIj7xP7L;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4flNjh5vMxz1xtJ\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 31 Mar 2026 20:53:44 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w7Vmk-0000Uk-JK; Tue, 31 Mar 2026 05:53:22 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1w7Vmi-0000UV-SA\n for qemu-devel@nongnu.org; Tue, 31 Mar 2026 05:53:20 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1w7Vmh-00084R-ET\n for qemu-devel@nongnu.org; Tue, 31 Mar 2026 05:53:20 -0400", "from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-457-ZOGNzu5sOvyywyQXzHwr-A-1; Tue,\n 31 Mar 2026 05:53:14 -0400", "from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id D058119560B4; Tue, 31 Mar 2026 09:53:13 +0000 (UTC)", "from localhost (unknown [10.44.22.22])\n by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 866EA180075B; Tue, 31 Mar 2026 09:53:11 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1774950798;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=jvHT6BwsoBPWDujNFtkt+Bu13w+qxfZDiiZxPnQYDZM=;\n b=DIj7xP7LP3gmpatHObS4gi3o/EMETUgV45dVfHxt9B/9D1SiAQFQPZKfdU3yxNNcjBMmMd\n eMlUe+aQGVFZ2W+GpgHYbBTxoIeKWN2/Hvq7TOg9oy2fl42M3zFgBIHWWME71+H+6cWe7b\n 62cdb7AudN90w2vG+np+tEtw/ggtDkw=", "X-MC-Unique": "ZOGNzu5sOvyywyQXzHwr-A-1", "X-Mimecast-MFC-AGG-ID": "ZOGNzu5sOvyywyQXzHwr-A_1774950794", "From": "marcandre.lureau@redhat.com", "To": "qemu-devel@nongnu.org", "Cc": "peter.maydell@linaro.org,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n Gerd Hoffmann <kraxel@redhat.com>", "Subject": "[PULL 1/6] audio/mixeng: fix sw/hw mixup in audio_pcm_sw_init_", "Date": "Tue, 31 Mar 2026 13:52:57 +0400", "Message-ID": "<20260331095302.644608-2-marcandre.lureau@redhat.com>", "In-Reply-To": "<20260331095302.644608-1-marcandre.lureau@redhat.com>", "References": "<20260331095302.644608-1-marcandre.lureau@redhat.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.93", "Received-SPF": "pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "27", "X-Spam_score": "2.7", "X-Spam_bar": "++", "X-Spam_report": "(2.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_SBL_CSS=3.335,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=1, RCVD_IN_VALIDITY_RPBL_BLOCKED=1,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Marc-André Lureau <marcandre.lureau@redhat.com>\n\nCommit 42061a14358 (\"audio/mixeng: replace redundant pcm_info fields\nwith AudioFormat\") accidentally changed the conv/clip function selection\nin audio_pcm_sw_init_ to use hw->info.af (the hardware voice format)\ninstead of sw->info.af (the software voice format). This causes audio\ndistortion when the software and hardware voices use different formats,\nas the wrong conversion functions are applied to the audio data.\n\nFix by using sw->info.af, restoring the original behavior.\n\nFixes: 42061a14358c (\"audio/mixeng: replace redundant pcm_info fields with AudioFormat\")\nReported-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>\nReviewed-by: Christian Schoenebeck <qemu_oss@crudebyte.com>\nSigned-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>\n---\n audio/audio_template.h | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/audio/audio_template.h b/audio/audio_template.h\nindex fe769cde667..398a7273739 100644\n--- a/audio/audio_template.h\n+++ b/audio/audio_template.h\n@@ -172,7 +172,7 @@ static int glue (audio_pcm_sw_init_, TYPE) (\n sw->empty = true;\n #endif\n \n- if (audio_format_is_float(hw->info.af)) {\n+ if (audio_format_is_float(sw->info.af)) {\n #ifdef DAC\n sw->conv = mixeng_conv_float[sw->info.nchannels == 2]\n [sw->info.swap_endianness];\n@@ -187,9 +187,9 @@ static int glue (audio_pcm_sw_init_, TYPE) (\n sw->clip = mixeng_clip\n #endif\n [sw->info.nchannels == 2]\n- [audio_format_is_signed(hw->info.af)]\n+ [audio_format_is_signed(sw->info.af)]\n [sw->info.swap_endianness]\n- [audio_format_to_index(hw->info.af)];\n+ [audio_format_to_index(sw->info.af)];\n }\n \n sw->name = g_strdup (name);\n", "prefixes": [ "PULL", "1/6" ] }