Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2218016/?format=api
{ "id": 2218016, "url": "http://patchwork.ozlabs.org/api/patches/2218016/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/patch/20260331094037.3408-7-gerris.rs@gmail.com/", "project": { "id": 17, "url": "http://patchwork.ozlabs.org/api/projects/17/?format=api", "name": "GNU Compiler Collection", "link_name": "gcc", "list_id": "gcc-patches.gcc.gnu.org", "list_email": "gcc-patches@gcc.gnu.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260331094037.3408-7-gerris.rs@gmail.com>", "list_archive_url": null, "date": "2026-03-31T09:40:33", "name": "[gccrs,COMMIT,07/10] Add a function for default outer attribute checks", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "fe187a620791fc2bd4a6186c08db92fa461ae9a1", "submitter": { "id": 92092, "url": "http://patchwork.ozlabs.org/api/people/92092/?format=api", "name": null, "email": "gerris.rs@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/gcc/patch/20260331094037.3408-7-gerris.rs@gmail.com/mbox/", "series": [ { "id": 498158, "url": "http://patchwork.ozlabs.org/api/series/498158/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/list/?series=498158", "date": "2026-03-31T09:40:27", "name": "[gccrs,COMMIT,01/10] Remove AttrInputMacro attribute input kind", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/498158/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2218016/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2218016/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=Gpg+xrNY;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)", "sourceware.org;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=Gpg+xrNY", "sourceware.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com", "sourceware.org; spf=pass smtp.mailfrom=gmail.com", "server2.sourceware.org;\n arc=none smtp.remote-ip=74.125.82.173" ], "Received": [ "from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4flNSP6dsvz1yGT\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 31 Mar 2026 20:42:13 +1100 (AEDT)", "from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id E69664BA2E0F\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 31 Mar 2026 09:42:11 +0000 (GMT)", "from mail-dy1-f173.google.com (mail-dy1-f173.google.com\n [74.125.82.173])\n by sourceware.org (Postfix) with ESMTPS id EAC9E4B7A1F1\n for <gcc-patches@gcc.gnu.org>; Tue, 31 Mar 2026 09:40:49 +0000 (GMT)", "by mail-dy1-f173.google.com with SMTP id\n 5a478bee46e88-2c160cb021cso5486791eec.1\n for <gcc-patches@gcc.gnu.org>; Tue, 31 Mar 2026 02:40:49 -0700 (PDT)", "from\n runnervmrg6be.i0fnop2thlderixbsj2qpy22md.yx.internal.cloudapp.net\n ([57.151.128.242]) by smtp.gmail.com with ESMTPSA id\n 5a478bee46e88-2c3c796d895sm9175510eec.28.2026.03.31.02.40.47\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 31 Mar 2026 02:40:48 -0700 (PDT)" ], "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 sourceware.org E69664BA2E0F", "OpenDKIM Filter v2.11.0 sourceware.org EAC9E4B7A1F1" ], "DMARC-Filter": "OpenDMARC Filter v1.4.2 sourceware.org EAC9E4B7A1F1", "ARC-Filter": "OpenARC Filter v1.0.0 sourceware.org EAC9E4B7A1F1", "ARC-Seal": "i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1774950050; cv=none;\n b=Vp531Yp2KcQOdxtt0FKiGv8fjPDAl7TvVEuMe27h6N5FO1lwdYkGjj556YBKTX8H8FOa2iN/VIreRU5GBKY42GIPJTi4REIj7FgBGBoF1qr5F8t5RWuNWnu9xndmDcTYHjF9P9W+dHwhGiB1EFRd4tb7WoY8ocjnl4Ds8GU0hWc=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1774950050; c=relaxed/simple;\n bh=hTyzsshQaUt0vckMNdvBgCrz7iOB8iXfkKvP7t5dLGI=;\n h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version;\n b=cZQrRBe65c1KAKVNEb7B4X0mzkZc1XMTVA9PubkCzbwSJ2poBYOd7Wq7NxMlONRsoii7zGBbkq3RfrqjzeBWalzVTGdw5HON7I0rr0TI/PUrIhgm+BtcSXrcZ5VXCyDtllStrhvBMv2VT1sWtgqZNnM3hQZz3kb7YTPR1jEQMjc=", "ARC-Authentication-Results": "i=1; server2.sourceware.org", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1774950049; x=1775554849; darn=gcc.gnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=5bCrFqWy8IEqeaVRndUK0JkeTeA7k8VjVbQxfPRi2Dw=;\n b=Gpg+xrNYGLkiq3lOWcWp2SIwf6eFGJCqxyREvvpPa0jh+5xr6WgL2aq1X+tM4eZXGi\n WWKPUekvzC6hQ4DMXbdUbI1IIli1Vd5FlA2ncGvehLndZGpKPWrbfngwg7tU4JOBgWw7\n UVVGf6S2TSj3nriixAOoBN5uDn0NwLg4IRLu751RE3qIMNnGPZWIcXQQEp7sRTcTLaXR\n LukpP3alhlqAXlHUgOH2gITXO4EGDgme+8eWYaj4SrKoXMWY9k44hRHwgteEb9PgRq/T\n 2rU2X6UBBjkeK6LmW22XwXZdZ8ymxzZ3aZ48Ol+B9eSU6v2X0PhCzUMaRvy6+3sPbaQ9\n O2Dg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774950049; x=1775554849;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=5bCrFqWy8IEqeaVRndUK0JkeTeA7k8VjVbQxfPRi2Dw=;\n b=M18zyx+mTC8uvDLA7AkHfCypD4dVjc++1GN8CoYW8JlcRxLYu4VQxDUhvJrnR+6izi\n M3GRYVGa97Dsb5JMgEnKWJnhLX0RkNOH3+w29B66LO7CQMyfZzGKSYx9YUDYjOVNSrT8\n EH1bC2I8sJve6X6cyS8Y0xcuOlZQx/8pLTkRRTeSJliDYq0F15Y2wfl123DEesAcXJWb\n iWMSlGBq9F1cj/p301UAkeqO6sx7fGpDE7r+pG0NZwZqh4SAGZSo8/gtyxwhK5xjm8Ub\n mSDGLfXCI/TlmRcC/8xUGkPHQrng7qrVB6kR68CnnjI7D0p+6p3KSRtlABFEvvBuX9ZE\n py2Q==", "X-Gm-Message-State": "AOJu0Yz7ui0v7CKgDpIN8OeFUDTb2B7ChIiDWRvsie7P38kWA/54qxjL\n 6eFOVK3WsbmTH2G+JZ1hkNOWmVoO53OkKV7o2GVWSUROnlqcclwgpL003N4DGShj", "X-Gm-Gg": "ATEYQzyfi09RmYRiCwKSadb4myOtYfJ8FAbu0K6DH49gu2wBYVmrv3rJ2b8r7Q9L2m8\n eStdNWGWUmBkADquOMmIQM8YgWP7zfmLcIq0qTI1gRCTWC+/E+ELOB/0+eAamqEeKksPZ4UHvAa\n gS5p/MVRwKlc98md6fflysPqw5W/WXcYhHiQYrCZyhKoa2Xs3Ye3SRVyVQB1ZMNLlVzeicHPl8+\n V4TA/oD5Xvs8tVdZttFWcfOvczlgBLPdVwB1S6UOQdUiiPK0SfD4yUG42z33+Idgza68INOX1oM\n sWHlUJnXByroAmZOcD+yqRRSJkAlbTSJIhgBa4t30Qagc1gyYX8LQDyThnljjMlNo6YdMgtLrej\n RTIkr9teuccsdC4un0G/KG8P3g1stOtC0/shEyPpt5mlLl8lrA95JKVIoWJf/Kwe7ybK/sX709W\n xUUU+/vFC9mRcxU8DMT7/K+zMyTjwpF3qCb3M4DbfNifPSXJLufMTcnebGm/fODQqDjPtcuwhFz\n BYVhuDsXOQN2GurkqUMgAM=", "X-Received": "by 2002:a05:7301:2f95:b0:2c5:50fe:c792 with SMTP id\n 5a478bee46e88-2c550ff1ad6mr4655143eec.12.1774950048791;\n Tue, 31 Mar 2026 02:40:48 -0700 (PDT)", "From": "gerris.rs@gmail.com", "To": "gcc-patches@gcc.gnu.org,\n\tgcc-rust@gcc.gnu.org", "Cc": "pierre-emmanuel.patry@embecosm.com, arthur.cohen@embecosm.com,\n dkm+gccrs@kataplop.net", "Subject": "[gccrs COMMIT 07/10] Add a function for default outer attribute\n checks", "Date": "Tue, 31 Mar 2026 09:40:33 +0000", "Message-ID": "<20260331094037.3408-7-gerris.rs@gmail.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20260331094037.3408-1-gerris.rs@gmail.com>", "References": "<20260331094037.3408-1-gerris.rs@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "gcc-patches@gcc.gnu.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Gcc-patches mailing list <gcc-patches.gcc.gnu.org>", "List-Unsubscribe": "<https://gcc.gnu.org/mailman/options/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>", "List-Archive": "<https://gcc.gnu.org/pipermail/gcc-patches/>", "List-Post": "<mailto:gcc-patches@gcc.gnu.org>", "List-Help": "<mailto:gcc-patches-request@gcc.gnu.org?subject=help>", "List-Subscribe": "<https://gcc.gnu.org/mailman/listinfo/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>", "Errors-To": "gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org" }, "content": "From: Pierre-Emmanuel Patry <pierre-emmanuel.patry@embecosm.com>\n\nAdd an helper function to keep most of the attribute checking short.\n\ngcc/rust/ChangeLog:\n\n\t* checks/errors/rust-builtin-attribute-checker.cc (BuiltinAttributeChecker::visit):\n\tDeduplicate lines using the new templated function within the visitor\n\tfunctions.\n\t* checks/errors/rust-builtin-attribute-checker.h (class BuiltinAttributeChecker):\n\tCreate a new templated function that achieves the default attribute\n\tchecking operations.\n\nSigned-off-by: Pierre-Emmanuel Patry <pierre-emmanuel.patry@embecosm.com>\n---\nThis change was merged into the gccrs repository and is posted here for\nupstream visibility and potential drive-by review, as requested by GCC\nrelease managers.\nEach commit email contains a link to its details on github from where you can\nfind the Pull-Request and associated discussions.\n\n\nCommit on github: https://github.com/Rust-GCC/gccrs/commit/0ec73cdf0a7450db60b8a1886cb6bea8993d3099\n\nThe commit has been mentioned in the following pull-request(s):\n - https://github.com/Rust-GCC/gccrs/pull/4505\n\n .../errors/rust-builtin-attribute-checker.cc | 67 ++++---------------\n .../errors/rust-builtin-attribute-checker.h | 7 ++\n 2 files changed, 21 insertions(+), 53 deletions(-)", "diff": "diff --git a/gcc/rust/checks/errors/rust-builtin-attribute-checker.cc b/gcc/rust/checks/errors/rust-builtin-attribute-checker.cc\nindex 8cb251f76..a2bf83f93 100644\n--- a/gcc/rust/checks/errors/rust-builtin-attribute-checker.cc\n+++ b/gcc/rust/checks/errors/rust-builtin-attribute-checker.cc\n@@ -367,28 +367,19 @@ BuiltinAttributeChecker::visit (AST::Attribute &attribute)\n void\n BuiltinAttributeChecker::visit (AST::Module &module)\n {\n- for (auto &attr : module.get_outer_attrs ())\n- check_valid_attribute_for_item (attr, module);\n-\n- AST::DefaultASTVisitor::visit (module);\n+ default_outer_attribute_check (module);\n }\n \n void\n-BuiltinAttributeChecker::visit (AST::ExternCrate &crate)\n+BuiltinAttributeChecker::visit (AST::ExternCrate &extern_crate)\n {\n- for (auto &attr : crate.get_outer_attrs ())\n- check_valid_attribute_for_item (attr, crate);\n-\n- AST::DefaultASTVisitor::visit (crate);\n+ default_outer_attribute_check (extern_crate);\n }\n \n void\n BuiltinAttributeChecker::visit (AST::UseDeclaration &declaration)\n {\n- for (auto &attr : declaration.get_outer_attrs ())\n- check_valid_attribute_for_item (attr, declaration);\n-\n- AST::DefaultASTVisitor::visit (declaration);\n+ default_outer_attribute_check (declaration);\n }\n \n void\n@@ -492,55 +483,37 @@ BuiltinAttributeChecker::visit (AST::Function &function)\n void\n BuiltinAttributeChecker::visit (AST::TypeAlias &alias)\n {\n- for (auto &attr : alias.get_outer_attrs ())\n- check_valid_attribute_for_item (attr, alias);\n-\n- AST::DefaultASTVisitor::visit (alias);\n+ default_outer_attribute_check (alias);\n }\n \n void\n BuiltinAttributeChecker::visit (AST::StructStruct &struct_item)\n {\n- for (auto &attr : struct_item.get_outer_attrs ())\n- check_valid_attribute_for_item (attr, struct_item);\n-\n- AST::DefaultASTVisitor::visit (struct_item);\n+ default_outer_attribute_check (struct_item);\n }\n \n void\n BuiltinAttributeChecker::visit (AST::TupleStruct &tuple_struct)\n {\n- for (auto &attr : tuple_struct.get_outer_attrs ())\n- check_valid_attribute_for_item (attr, tuple_struct);\n-\n- AST::DefaultASTVisitor::visit (tuple_struct);\n+ default_outer_attribute_check (tuple_struct);\n }\n \n void\n BuiltinAttributeChecker::visit (AST::Enum &enumeration)\n {\n- for (auto &attr : enumeration.get_outer_attrs ())\n- check_valid_attribute_for_item (attr, enumeration);\n-\n- AST::DefaultASTVisitor::visit (enumeration);\n+ default_outer_attribute_check (enumeration);\n }\n \n void\n BuiltinAttributeChecker::visit (AST::Union &u)\n {\n- for (auto &attr : u.get_outer_attrs ())\n- check_valid_attribute_for_item (attr, u);\n-\n- AST::DefaultASTVisitor::visit (u);\n+ default_outer_attribute_check (u);\n }\n \n void\n BuiltinAttributeChecker::visit (AST::ConstantItem &item)\n {\n- for (auto &attr : item.get_outer_attrs ())\n- check_valid_attribute_for_item (attr, item);\n-\n- AST::DefaultASTVisitor::visit (item);\n+ default_outer_attribute_check (item);\n }\n \n void\n@@ -565,37 +538,25 @@ BuiltinAttributeChecker::visit (AST::StaticItem &item)\n void\n BuiltinAttributeChecker::visit (AST::Trait &trait)\n {\n- for (auto &attr : trait.get_outer_attrs ())\n- check_valid_attribute_for_item (attr, trait);\n-\n- AST::DefaultASTVisitor::visit (trait);\n+ default_outer_attribute_check (trait);\n }\n \n void\n BuiltinAttributeChecker::visit (AST::InherentImpl &impl)\n {\n- for (auto &attr : impl.get_outer_attrs ())\n- check_valid_attribute_for_item (attr, impl);\n-\n- AST::DefaultASTVisitor::visit (impl);\n+ default_outer_attribute_check (impl);\n }\n \n void\n BuiltinAttributeChecker::visit (AST::TraitImpl &impl)\n {\n- for (auto &attr : impl.get_outer_attrs ())\n- check_valid_attribute_for_item (attr, impl);\n-\n- AST::DefaultASTVisitor::visit (impl);\n+ default_outer_attribute_check (impl);\n }\n \n void\n BuiltinAttributeChecker::visit (AST::ExternBlock &block)\n {\n- for (auto &attr : block.get_outer_attrs ())\n- check_valid_attribute_for_item (attr, block);\n-\n- AST::DefaultASTVisitor::visit (block);\n+ default_outer_attribute_check (block);\n }\n \n } // namespace Analysis\ndiff --git a/gcc/rust/checks/errors/rust-builtin-attribute-checker.h b/gcc/rust/checks/errors/rust-builtin-attribute-checker.h\nindex 6717de8ab..957243a1a 100644\n--- a/gcc/rust/checks/errors/rust-builtin-attribute-checker.h\n+++ b/gcc/rust/checks/errors/rust-builtin-attribute-checker.h\n@@ -28,6 +28,13 @@ class BuiltinAttributeChecker : public AST::DefaultASTVisitor\n {\n using AST::DefaultASTVisitor::visit;\n \n+ template <class I> void default_outer_attribute_check (I item)\n+ {\n+ for (auto &attr : item.get_outer_attrs ())\n+ check_valid_attribute_for_item (attr, item);\n+ AST::DefaultASTVisitor::visit (item);\n+ }\n+\n public:\n BuiltinAttributeChecker ();\n void go (AST::Crate &crate);\n", "prefixes": [ "gccrs", "COMMIT", "07/10" ] }