Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2218015/?format=api
{ "id": 2218015, "url": "http://patchwork.ozlabs.org/api/patches/2218015/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/patch/20260331094037.3408-3-gerris.rs@gmail.com/", "project": { "id": 17, "url": "http://patchwork.ozlabs.org/api/projects/17/?format=api", "name": "GNU Compiler Collection", "link_name": "gcc", "list_id": "gcc-patches.gcc.gnu.org", "list_email": "gcc-patches@gcc.gnu.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260331094037.3408-3-gerris.rs@gmail.com>", "list_archive_url": null, "date": "2026-03-31T09:40:29", "name": "[gccrs,COMMIT,03/10] Visit builtin attributes within the expand visitor", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "47445577e601827cf1fcc5a57fa3ad25b68c2b64", "submitter": { "id": 92092, "url": "http://patchwork.ozlabs.org/api/people/92092/?format=api", "name": null, "email": "gerris.rs@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/gcc/patch/20260331094037.3408-3-gerris.rs@gmail.com/mbox/", "series": [ { "id": 498158, "url": "http://patchwork.ozlabs.org/api/series/498158/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/list/?series=498158", "date": "2026-03-31T09:40:27", "name": "[gccrs,COMMIT,01/10] Remove AttrInputMacro attribute input kind", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/498158/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2218015/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2218015/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=bPFcRHg6;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)", "sourceware.org;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=bPFcRHg6", "sourceware.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com", "sourceware.org; spf=pass smtp.mailfrom=gmail.com", "server2.sourceware.org;\n arc=none smtp.remote-ip=74.125.82.180" ], "Received": [ "from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4flNSK3FJgz1yGT\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 31 Mar 2026 20:42:09 +1100 (AEDT)", "from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 467134BB590B\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 31 Mar 2026 09:42:07 +0000 (GMT)", "from mail-dy1-f180.google.com (mail-dy1-f180.google.com\n [74.125.82.180])\n by sourceware.org (Postfix) with ESMTPS id E8ED14BA902D\n for <gcc-patches@gcc.gnu.org>; Tue, 31 Mar 2026 09:40:44 +0000 (GMT)", "by mail-dy1-f180.google.com with SMTP id\n 5a478bee46e88-2c7d8bbad06so1677107eec.1\n for <gcc-patches@gcc.gnu.org>; Tue, 31 Mar 2026 02:40:44 -0700 (PDT)", "from\n runnervmrg6be.i0fnop2thlderixbsj2qpy22md.yx.internal.cloudapp.net\n ([57.151.128.242]) by smtp.gmail.com with ESMTPSA id\n 5a478bee46e88-2c3c796d895sm9175510eec.28.2026.03.31.02.40.41\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 31 Mar 2026 02:40:43 -0700 (PDT)" ], "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 sourceware.org 467134BB590B", "OpenDKIM Filter v2.11.0 sourceware.org E8ED14BA902D" ], "DMARC-Filter": "OpenDMARC Filter v1.4.2 sourceware.org E8ED14BA902D", "ARC-Filter": "OpenARC Filter v1.0.0 sourceware.org E8ED14BA902D", "ARC-Seal": "i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1774950045; cv=none;\n b=GJmszIOjEcCw4W6lq4DYbn5kIjTzLk6dWkfNE/EKQz3AQdrPNiex8a9wtS9Of2X1eCJVXxNiGUql7B2n/cieYsGkc5omsVAKndtaTjDwZ7uT9JZIIAhYGTobF2zycpr4XEkrnd50BAuDne5qDW8Y4a2oEqjuG8dM0pMajCdnLZI=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1774950045; c=relaxed/simple;\n bh=yu0vqC8VSjOTAEQLxHlJ+V5kLRBDA62Xet+6Inw7DZk=;\n h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version;\n b=V4DohpTOzS6lF35W8v1NwL1063qg2MT7MwWqanzcfEe3QhzZ+w08kgrFrnaqm+ohh+wNNO1InBS1x4c7tJUpJNsSKJ5Vv3Hdusy6Iz2I2v58Ia8sG6Bz/OsxNcpWv7rSEUTc3E4OBKj47oICjE5JVzs78pUdvl4ECeVXGN8dVxs=", "ARC-Authentication-Results": "i=1; server2.sourceware.org", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1774950044; x=1775554844; darn=gcc.gnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=0G8+xOASkjOK9nIcOkd0+hpEYj0DObyDLpTw/7XBrUs=;\n b=bPFcRHg6d/i6Y5Vqkw7NnqlM76GI/BTbK/JgK/VJxHoMhJKFyWKu5gkUHlJH5yPT1k\n FWGgPwQEwwFCil8tJH3Uq8vp6lz79GZUtUlabvJIxws8nkhOqkIet+OplcBNuqEX/HFQ\n rEYoxxcpz4nx+5J+8x5ZD2liasWdQxLsKlQ1SwLeB9O4DI3M4M8j1x11U8NsWNwzva3W\n wXrFX3reUVz+RQ79ghazqnIVqcy5SD1gPgBngO7jMQmjeBhZl4k/Ak/dsfVyVaWHEQRi\n hrn6pQKqKg4zSRYrJv86ejrzwhsXQBg71d+bG2GCbKUCuhd+vi3XUfDfWKodhhAONyHg\n Wddw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774950044; x=1775554844;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=0G8+xOASkjOK9nIcOkd0+hpEYj0DObyDLpTw/7XBrUs=;\n b=nKm3S2P0NE5uPXD/LXyjvmYv75AHWTu5vev+ZP0N/hH1f8o6vMgtTv5QwojKeL+hy4\n 2OeDLP79UBi4Xm9RaVcMNpGcBChENLcGUdoZDiT+FvnoMmcRSw9GCF2yuAB9E05N1KuN\n OlZY7tYH+SI+9WpMbXhZXnLsDo0VRsmO9gxvBBVi0PzjVGnftwQx0Uk6dnmqjMs6CAer\n fOZBSWxV5HDtaRS0v2fu95GUAbcFz5xRbiSKbJpFKyIqI/jBRC2uSvSxlP8+to5lYhHk\n fCBmYh6SK83lM8952Ndh6wvnlYbdgjtUl3Lp+iJ1phvH3IkMVsvggVrc6VuInJF6DoDD\n f8cw==", "X-Gm-Message-State": "AOJu0Yz5i4+yU2XxVhWAG2SET/a8Va5tGdALFvzJzjET3un0R70oE5W/\n Gh82GkrSP9JhiUUGG06VCJ1Nh9eEUZsCzTZOtfdIgZo5keUgu0kI70GTDiJlaMFy", "X-Gm-Gg": "ATEYQzxERf4eu5/Q6cGQOvMLTf3JHSW0rEiuPlE6gzWdL3Xa/SBb6EvuNZ2Ty7OYOZw\n N9sWbWQQSo0Qh642ib9UNshli4htMClkqOGvJxOXa9NTQyAeA/4IlhuG2YARbOMbfBs82TnM72/\n r5xzkmdvIj0f9Wb0uPNhBqrzbQ4BnXN0UVb+TSE/7bPuhHNlOFT0rabgvbD8JElCLoIqmWZzSrb\n V3nrD89w+jIc+AbbBSUZqz8PGDi77eOmQjx976/diXzyy+QLPTgu+RuUKc8aSm88f6xEUoYBxsy\n Sn5jYQoVItxiVVnPZAG72ZDqLKdSHmi+3o3b9HTHKAjXyKQTBzZB/kVhYhK8rWuevmcBxy/f5bJ\n UnM1ztxQl27u1Fnrw3cLohAgoViqQoVUsXecxM8CF8b1pa/uh/+bXtCUXIA3f9qcYADhOnNVte4\n XrBV8w0lORANuOMdN11pDmzGislwjT2d9gxeeHCQTTsrK+jGYNBkzkbE3pNLrGcVI2OwlMjFGUP\n eacNVSV6iej06U+J/KK/Gg8Jmr+ICF9KA==", "X-Received": "by 2002:a05:7300:dc90:b0:2c5:a6ce:e534 with SMTP id\n 5a478bee46e88-2c5a6cef339mr4412063eec.8.1774950043484;\n Tue, 31 Mar 2026 02:40:43 -0700 (PDT)", "From": "gerris.rs@gmail.com", "To": "gcc-patches@gcc.gnu.org,\n\tgcc-rust@gcc.gnu.org", "Cc": "pierre-emmanuel.patry@embecosm.com, arthur.cohen@embecosm.com,\n dkm+gccrs@kataplop.net", "Subject": "[gccrs COMMIT 03/10] Visit builtin attributes within the expand\n visitor", "Date": "Tue, 31 Mar 2026 09:40:29 +0000", "Message-ID": "<20260331094037.3408-3-gerris.rs@gmail.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20260331094037.3408-1-gerris.rs@gmail.com>", "References": "<20260331094037.3408-1-gerris.rs@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "gcc-patches@gcc.gnu.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Gcc-patches mailing list <gcc-patches.gcc.gnu.org>", "List-Unsubscribe": "<https://gcc.gnu.org/mailman/options/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>", "List-Archive": "<https://gcc.gnu.org/pipermail/gcc-patches/>", "List-Post": "<mailto:gcc-patches@gcc.gnu.org>", "List-Help": "<mailto:gcc-patches-request@gcc.gnu.org?subject=help>", "List-Subscribe": "<https://gcc.gnu.org/mailman/listinfo/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>", "Errors-To": "gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org" }, "content": "From: Pierre-Emmanuel Patry <pierre-emmanuel.patry@embecosm.com>\n\nThose attribute may contain macros within their input that must be\nexpanded, hence why we must visit them.\n\ngcc/rust/ChangeLog:\n\n\t* ast/rust-ast.h: Add helper to set a new attribute input.\n\t* expand/rust-expand-visitor.cc (ExpandVisitor::expand_inner_stmts):\n\tVisit builtin attributes.\n\t(ExpandVisitor::visit): Likewise.\n\t* resolve/rust-early-name-resolver-2.0.cc (Early::visit): Expand\n\tattribute input expr.\n\nSigned-off-by: Pierre-Emmanuel Patry <pierre-emmanuel.patry@embecosm.com>\n---\nThis change was merged into the gccrs repository and is posted here for\nupstream visibility and potential drive-by review, as requested by GCC\nrelease managers.\nEach commit email contains a link to its details on github from where you can\nfind the Pull-Request and associated discussions.\n\n\nCommit on github: https://github.com/Rust-GCC/gccrs/commit/00730118c0036ba32c0a7072608ee0f01e23e5cc\n\nThe commit has been mentioned in the following pull-request(s):\n - https://github.com/Rust-GCC/gccrs/pull/4505\n\n gcc/rust/ast/rust-ast.h | 5 +++++\n gcc/rust/expand/rust-expand-visitor.cc | 4 +++-\n gcc/rust/resolve/rust-early-name-resolver-2.0.cc | 2 ++\n 3 files changed, 10 insertions(+), 1 deletion(-)", "diff": "diff --git a/gcc/rust/ast/rust-ast.h b/gcc/rust/ast/rust-ast.h\nindex 4a1974d4d..f6b704507 100644\n--- a/gcc/rust/ast/rust-ast.h\n+++ b/gcc/rust/ast/rust-ast.h\n@@ -632,6 +632,11 @@ public:\n \n AttrInput &get_attr_input () const { return *attr_input; }\n \n+ void set_attr_input (std::unique_ptr<AST::AttrInput> input)\n+ {\n+ attr_input = std::move (input);\n+ }\n+\n /* e.g.:\n #![crate_type = \"lib\"]\n #[test]\ndiff --git a/gcc/rust/expand/rust-expand-visitor.cc b/gcc/rust/expand/rust-expand-visitor.cc\nindex c124f9ab9..16786e32e 100644\n--- a/gcc/rust/expand/rust-expand-visitor.cc\n+++ b/gcc/rust/expand/rust-expand-visitor.cc\n@@ -218,6 +218,7 @@ ExpandVisitor::expand_inner_items (\n \t\t{\n \t\t if (is_builtin (current))\n \t\t {\n+\t\t visit (*attr_it);\n \t\t attr_it++;\n \t\t }\n \t\t else\n@@ -303,6 +304,7 @@ ExpandVisitor::expand_inner_stmts (AST::BlockExpr &expr)\n \t\t{\n \t\t if (is_builtin (current))\n \t\t {\n+\t\t visit (*attr_it);\n \t\t attr_it++;\n \t\t }\n \t\t else\n@@ -586,7 +588,7 @@ ExpandVisitor::visit (AST::AttrInputLiteral &)\n void\n ExpandVisitor::visit (AST::AttrInputExpr &attr_input)\n {\n- reseat (attr_input.get_expr_ptr ());\n+ maybe_expand_expr (attr_input.get_expr_ptr ());\n }\n \n void\ndiff --git a/gcc/rust/resolve/rust-early-name-resolver-2.0.cc b/gcc/rust/resolve/rust-early-name-resolver-2.0.cc\nindex 91ad82c89..058207f1f 100644\n--- a/gcc/rust/resolve/rust-early-name-resolver-2.0.cc\n+++ b/gcc/rust/resolve/rust-early-name-resolver-2.0.cc\n@@ -397,6 +397,8 @@ Early::visit (AST::Attribute &attr)\n {\n visit_non_builtin_attribute (attr, mappings, name);\n }\n+\n+ DefaultResolver::visit (attr);\n }\n \n void\n", "prefixes": [ "gccrs", "COMMIT", "03/10" ] }