Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2218012/?format=api
{ "id": 2218012, "url": "http://patchwork.ozlabs.org/api/patches/2218012/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pci/patch/20260331091455.30394-1-manivannan.sadhasivam@oss.qualcomm.com/", "project": { "id": 28, "url": "http://patchwork.ozlabs.org/api/projects/28/?format=api", "name": "Linux PCI development", "link_name": "linux-pci", "list_id": "linux-pci.vger.kernel.org", "list_email": "linux-pci@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260331091455.30394-1-manivannan.sadhasivam@oss.qualcomm.com>", "list_archive_url": null, "date": "2026-03-31T09:14:55", "name": "Revert \"PCI: Enable ACS after configuring IOMMU for OF platforms\"", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "a67760927e55637a4899d7603314726cfcddd7e4", "submitter": { "id": 91273, "url": "http://patchwork.ozlabs.org/api/people/91273/?format=api", "name": "Manivannan Sadhasivam", "email": "manivannan.sadhasivam@oss.qualcomm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-pci/patch/20260331091455.30394-1-manivannan.sadhasivam@oss.qualcomm.com/mbox/", "series": [ { "id": 498156, "url": "http://patchwork.ozlabs.org/api/series/498156/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pci/list/?series=498156", "date": "2026-03-31T09:14:55", "name": "Revert \"PCI: Enable ACS after configuring IOMMU for OF platforms\"", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/498156/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2218012/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2218012/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-pci+bounces-51545-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-pci@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=a5rzIaPP;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=GCPgZWFq;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-pci+bounces-51545-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com\n header.b=\"a5rzIaPP\";\n\tdkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.b=\"GCPgZWFq\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=205.220.180.131", "smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=oss.qualcomm.com" ], "Received": [ "from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4flN1s6YZWz1xtJ\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 31 Mar 2026 20:22:41 +1100 (AEDT)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 0AD5130D802B\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 31 Mar 2026 09:15:25 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 927A33ED104;\n\tTue, 31 Mar 2026 09:15:24 +0000 (UTC)", "from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com\n [205.220.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A204344D86\n\tfor <linux-pci@vger.kernel.org>; Tue, 31 Mar 2026 09:15:22 +0000 (UTC)", "from pps.filterd (m0279869.ppops.net [127.0.0.1])\n\tby mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 62V5s4OC2409165\n\tfor <linux-pci@vger.kernel.org>; Tue, 31 Mar 2026 09:15:22 GMT", "from mail-pf1-f198.google.com (mail-pf1-f198.google.com\n [209.85.210.198])\n\tby mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d80hetbnm-1\n\t(version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n\tfor <linux-pci@vger.kernel.org>; Tue, 31 Mar 2026 09:15:21 +0000 (GMT)", "by mail-pf1-f198.google.com with SMTP id\n d2e1a72fcca58-82c8768a704so2738371b3a.3\n for <linux-pci@vger.kernel.org>; Tue, 31 Mar 2026 02:15:21 -0700 (PDT)", "from work ([117.193.210.140])\n by smtp.gmail.com with ESMTPSA id\n d2e1a72fcca58-82ca847ff4dsm9760492b3a.23.2026.03.31.02.15.16\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 31 Mar 2026 02:15:19 -0700 (PDT)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774948524; cv=none;\n b=JS9LcCBx5sXRUfFItjXCcP3JrpeaF+FVCyzLCr10eooSuDG/Rgfv5NhafbCjDzfh2dBY80377Godmnce53+x1IBIYmWGquzMJT4Yoh8OT8ckbaTdX3sX3xNE8BiPZsCheKC4k5R0lY/zqbhQhTUibXeSpEVGY8oMBbKOTR29xFk=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774948524; c=relaxed/simple;\n\tbh=wqEtTcfrnfkB1/1JAggq7TeFTa6jZH31RqJX87K/lOU=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=atKHORbYXVrSzXz3VqCaLxDSjq+SDt3k/fbWDPHY0nOhDFIhgyJoETA5qo9P65i9v8rDCTvPcQJZ23l0H0USXtvTeGZ/tIzLnxLh9qmkDFBzMF5ShFqwRT8yexpFpVna4KtFxdPkbeHGXvgeafxbCcwyEHWDq3rvOOisyIQ1JHM=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com;\n spf=pass smtp.mailfrom=oss.qualcomm.com;\n dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com\n header.b=a5rzIaPP;\n dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.b=GCPgZWFq; arc=none smtp.client-ip=205.220.180.131", "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n\tcc:content-transfer-encoding:date:from:message-id:mime-version\n\t:subject:to; s=qcppdkim1; bh=mwgbVgvQHgOopgtkJu/D2bFIW5S1SsBBybk\n\t+5nhk3pk=; b=a5rzIaPPWYZ/yKSPse1+2tR6kEr3RHcj7ZMNPi0t9/iUPCcSCQt\n\tjwi2yDN2+hCnDQAdLYG8HQGes5sHE1aUgtpgv33+EzRZSP8iFpEHAy5EsOHaRiii\n\tA89Xemcdb4dF+booUb0mX6SluqH5bzFHWrDuTwl+pS1JkN9/pfV0uFbKmvvQPepG\n\tTZsUoMR+lEg1SUvwrZ6BbJN9+J5WT0VqoEpgbV9Q9Exmrso/K9dqvxAjx/e8g3sD\n\tyZ3cLZhjv44SqvD0syeShb/NU5LQGLmXWZjzCbK2DJGLRXXTfcBwUQSSbBL5mJ7y\n\tSP0AZymxvlGKtgPfbbCyuP9B0Er1ZC0diug==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oss.qualcomm.com; s=google; t=1774948521; x=1775553321;\n darn=vger.kernel.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=mwgbVgvQHgOopgtkJu/D2bFIW5S1SsBBybk+5nhk3pk=;\n b=GCPgZWFqSc8uCivfhvAfTQOZQ0dX6//d7SbJXSmg97qBp7+ISnEeBaqd7i4Y1kKmt5\n e0LSehacH3XU+ketp3QIERtemhEvFfD2ZSe45SDk6VNSJrn/pWrUn4HBBMzhCLubrU5M\n rAV7Lwx2MltYRU+jtjdD4VDZjJQ1VDkx2WK7A1WuNqxajEwCyVL26U3LVuIeYKjhhWXh\n h5YfObkKdvvEK9PjX+RGF1iivnoNvVZUaUcbKpwzFoEnRvOML/p7tkAnNaRtsve+UgsK\n 7sJMm0T2+Is0CfjwTY1WKpdAVOnseRAHP33AvWnKyJgDTlZQg9G3zbyQ7080dzIFfP6U\n p/Uw==" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774948521; x=1775553321;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=mwgbVgvQHgOopgtkJu/D2bFIW5S1SsBBybk+5nhk3pk=;\n b=nxb1nQJadFGbJBbcqL325Ggy7xzUFxJMKy6zM38irHXep2Sn6Gs6qM3VS/jKnul3Ge\n 63kY6RwNP7TrVuJFo+KKxoPBtzfOFoMj47bb/XH9KQl8kscPDPgfHE5OhaGwtvIHRlX3\n 2YO1+0d0SxmrfL9CGwdMYLb0B+WQoHROdnihjFpmUOg5hd7oCP76LyE6evopWgeUPnva\n gD6CGoiXs9A6S44o3yEr8QZ/13d4jZIA6ATfhVfSD7WbL3nXlPUy+U2oM86nMd84oFJ+\n e+Ooq06ongr2T2xlIYgjk8ReHg99xSSXsBa/YBR4YanztmaQDehnlGiAHWR4vLYfH6uY\n uOjQ==", "X-Forwarded-Encrypted": "i=1;\n AJvYcCVJzREPEtRAeT0G78DV9HMTeweEyYT+bemkQ1uzNvACicG5elrIcgQ6Kz2aXadBMi9W6YpqRagkTvM=@vger.kernel.org", "X-Gm-Message-State": "AOJu0YzhFd+j6hLkx9lNW7QZg1oWwccapIzqIT4WgrlKvaa6SGWEswOf\n\tX0yigFYe2lacpnAn8zJWpaqin60rCOcMqHjd6h0yNZ0Ntu11e6/ijLhBl26pFqYjdEjwwdsvKoM\n\tQ/ywC7g0/9QV9zbfvYiw6SvfFSEp9ggtVjKetkxGinj+S+dkoG9/wfoLqMjwY9ak=", "X-Gm-Gg": "ATEYQzxqzRnddGwBYSys3GucNlLuYV7s3DA+dpC8n53+SI+pO7O5WUZ1E71PmaHAVMH\n\tZr5yfQ6ReEyJEMnPGuIuUAPKWjMDiBk5TiYQ+7p76wk5d2uUfZFFvNslxXmFVMdWSeehE1tEwmI\n\tOUSp2RhwOLSaJaX0cIbyDNpmZTg8HShNknUK30OiAzxn7zZFhXwf4ZNwEgbzJuKFYov+dFkxY3d\n\tBcKRRNN55ATgVEh/KAGoZYwGVe7bwJ4CISO7TlFwM4p/D9ORqGa59dzfuRzpf0GqF3BOGc8dfaf\n\tamUPgXB+aN+BBEJaRAI7TAPT07FvArJ3/faeXVyBYYyY79JCzKvulFSIe1Bfp9em1yKXLEk1quU\n\tetf2mnMtg0oMQnKQ0HsY+tO4F15pOv4bOqExstSc=", "X-Received": [ "by 2002:a05:6a00:4197:b0:829:7057:b99e with SMTP id\n d2e1a72fcca58-82c962124bcmr13030029b3a.54.1774948520795;\n Tue, 31 Mar 2026 02:15:20 -0700 (PDT)", "by 2002:a05:6a00:4197:b0:829:7057:b99e with SMTP id\n d2e1a72fcca58-82c962124bcmr13030002b3a.54.1774948520077;\n Tue, 31 Mar 2026 02:15:20 -0700 (PDT)" ], "From": "Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>", "To": "stable@vger.kernel.org", "Cc": "bhelgaas@google.com, linux-pci@vger.kernel.org,\n linux-kernel@vger.kernel.org, robin.murphy@arm.com,\n Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>,\n John Hancock <john@kernel.doghat.io>, bjorn.forsman@gmail.com,\n Linux kernel regressions list <regressions@lists.linux.dev>", "Subject": "[PATCH] Revert \"PCI: Enable ACS after configuring IOMMU for OF\n platforms\"", "Date": "Tue, 31 Mar 2026 14:44:55 +0530", "Message-ID": "<20260331091455.30394-1-manivannan.sadhasivam@oss.qualcomm.com>", "X-Mailer": "git-send-email 2.51.0", "Precedence": "bulk", "X-Mailing-List": "linux-pci@vger.kernel.org", "List-Id": "<linux-pci.vger.kernel.org>", "List-Subscribe": "<mailto:linux-pci+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-pci+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Authority-Analysis": "v=2.4 cv=Gb0aXAXL c=1 sm=1 tr=0 ts=69cb90a9 cx=c_pps\n a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=vr9TklybbRi32TvS4M0W1g==:17\n a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=VwQbUJbxAAAA:8\n a=lAgNKBcoAAAA:8 a=pGLkceISAAAA:8 a=EUspDBNiAAAA:8 a=hAXPUp1672zZkZ7mbzMA:9\n a=IoOABgeZipijB_acs4fv:22 a=drE6d5tx1tjNRBs8zHOc:22", "X-Proofpoint-GUID": "4m8eeK71TszVtaXqs71P7UOWvuOujStu", "X-Proofpoint-ORIG-GUID": "4m8eeK71TszVtaXqs71P7UOWvuOujStu", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwMzMxMDA4NiBTYWx0ZWRfX32PvgGsrVGeM\n a6RMnAk2Ylexw2Nhdjo4212hZSqE7NkIE15sqMS5tlS+EuFJcWZRZ683ftu23kiJdUN3C999UC5\n freilLQo825m9kgy9/9L4fJ67ICszBWZXDVRC7G0J2j96tQRmo4BLXexRnmUbkETe+bgED3kZ6L\n 3Lqocl3ARLI+ORkzC0jFZDrzgVywSII2Mzpkj0T42tmtKEpvbLX18irs5BoBykkX4llDLrjbxK7\n sFCRRpIOtOniY+AQEfOLFGz6jhJC0qjro//SGArPLYx4JOihXDqrKPJyl+KSBhEDR//ZqKG3ZKe\n 6IQtAaofNxRWWDQBn1wspMyE5QlBISwkLU6R3M65vvvtewzTpO3aqKjTI5fFhp1ykvEHvCSulq2\n XnE85U0P8aWIyzxmwaxu/4GcN3UjnS6f/hgyTJLQhMXhTpm+hJJa9kAJ1PhTp4b2RWvfA0S38Bm\n me4JisknAYqZ/JldYBw==", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-03-31_02,2026-03-28_01,2025-10-01_01", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n lowpriorityscore=0 impostorscore=0 adultscore=0 spamscore=0 bulkscore=0\n malwarescore=0 clxscore=1015 suspectscore=0 priorityscore=1501 phishscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603310086" }, "content": "This reverts commit 5d57164c0ab0ac5c99eca49c577994bfbca70a2a.\n\nThe original commit attempted to enable ACS in pci_dma_configure() prior\nto IOMMU group assignment in iommu_init_device() to fix the ACS enablement\nissue for OF platforms. But that assumption doesn't hold true for kernel\nversions prior to v6.15, because on these older kernels,\npci_dma_configure() is called *after* iommu_init_device(). So the IOMMU\ngroups are already created before the ACS gets enabled. This causes the\ndevices that should have been split into separate groups by ACS, getting\nmerged into one group, thereby breaking the IOMMU isolation as reported on\nthe AMD machines.\n\nSo revert the offending commit to restore the IOMMU group assignment on\nthose affected machines. It should be noted that ACS has never really\nworked on kernel versions prior to v6.15, so the revert doesn't make any\ndifference for OF platforms.\n\nReported-by: John Hancock <john@kernel.doghat.io>\nReported-by: bjorn.forsman@gmail.com\nCloses: https://bugzilla.kernel.org/show_bug.cgi?id=221234\nFixes: b20b659c2c6a (\"PCI: Enable ACS after configuring IOMMU for OF platforms\")\nCc: Linux kernel regressions list <regressions@lists.linux.dev>\nLink: https://lore.kernel.org/regressions/2c30f181-ffc6-4d63-a64e-763cf4528f48@leemhuis.info\nSigned-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>\n---\n\nThis revert is targeted for v6.1 stable kernel.\n\n drivers/pci/pci-driver.c | 8 --------\n drivers/pci/pci.c | 10 +++++++++-\n drivers/pci/pci.h | 1 -\n 3 files changed, 9 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/pci/pci-driver.c b/drivers/pci/pci-driver.c\nindex 8b5796a6ed5f..fe6e5f716543 100644\n--- a/drivers/pci/pci-driver.c\n+++ b/drivers/pci/pci-driver.c\n@@ -1667,14 +1667,6 @@ static int pci_dma_configure(struct device *dev)\n \t\tret = acpi_dma_configure(dev, acpi_get_dma_attr(adev));\n \t}\n \n-\t/*\n-\t * Attempt to enable ACS regardless of capability because some Root\n-\t * Ports (e.g. those quirked with *_intel_pch_acs_*) do not have\n-\t * the standard ACS capability but still support ACS via those\n-\t * quirks.\n-\t */\n-\tpci_enable_acs(to_pci_dev(dev));\n-\n \tpci_put_host_bridge_device(bridge);\n \n \tif (!ret && !driver->driver_managed_dma) {\ndiff --git a/drivers/pci/pci.c b/drivers/pci/pci.c\nindex d2d6b7da8c66..0778bb09d878 100644\n--- a/drivers/pci/pci.c\n+++ b/drivers/pci/pci.c\n@@ -1040,7 +1040,7 @@ static void pci_std_enable_acs(struct pci_dev *dev)\n * pci_enable_acs - enable ACS if hardware support it\n * @dev: the PCI device\n */\n-void pci_enable_acs(struct pci_dev *dev)\n+static void pci_enable_acs(struct pci_dev *dev)\n {\n \tif (!pci_acs_enable)\n \t\tgoto disable_acs_redir;\n@@ -3777,6 +3777,14 @@ bool pci_acs_path_enabled(struct pci_dev *start,\n void pci_acs_init(struct pci_dev *dev)\n {\n \tdev->acs_cap = pci_find_ext_capability(dev, PCI_EXT_CAP_ID_ACS);\n+\n+\t/*\n+\t * Attempt to enable ACS regardless of capability because some Root\n+\t * Ports (e.g. those quirked with *_intel_pch_acs_*) do not have\n+\t * the standard ACS capability but still support ACS via those\n+\t * quirks.\n+\t */\n+\tpci_enable_acs(dev);\n }\n \n /**\ndiff --git a/drivers/pci/pci.h b/drivers/pci/pci.h\nindex 0debf921a9fe..85488bc8e779 100644\n--- a/drivers/pci/pci.h\n+++ b/drivers/pci/pci.h\n@@ -526,7 +526,6 @@ static inline resource_size_t pci_resource_alignment(struct pci_dev *dev,\n }\n \n void pci_acs_init(struct pci_dev *dev);\n-void pci_enable_acs(struct pci_dev *dev);\n #ifdef CONFIG_PCI_QUIRKS\n int pci_dev_specific_acs_enabled(struct pci_dev *dev, u16 acs_flags);\n int pci_dev_specific_enable_acs(struct pci_dev *dev);\n", "prefixes": [] }