Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2218010/?format=api
{ "id": 2218010, "url": "http://patchwork.ozlabs.org/api/patches/2218010/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pci/patch/20260331091727.33552-1-manivannan.sadhasivam@oss.qualcomm.com/", "project": { "id": 28, "url": "http://patchwork.ozlabs.org/api/projects/28/?format=api", "name": "Linux PCI development", "link_name": "linux-pci", "list_id": "linux-pci.vger.kernel.org", "list_email": "linux-pci@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260331091727.33552-1-manivannan.sadhasivam@oss.qualcomm.com>", "list_archive_url": null, "date": "2026-03-31T09:17:27", "name": "Revert \"PCI: Enable ACS after configuring IOMMU for OF platforms\"", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "a67760927e55637a4899d7603314726cfcddd7e4", "submitter": { "id": 91273, "url": "http://patchwork.ozlabs.org/api/people/91273/?format=api", "name": "Manivannan Sadhasivam", "email": "manivannan.sadhasivam@oss.qualcomm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-pci/patch/20260331091727.33552-1-manivannan.sadhasivam@oss.qualcomm.com/mbox/", "series": [ { "id": 498154, "url": "http://patchwork.ozlabs.org/api/series/498154/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pci/list/?series=498154", "date": "2026-03-31T09:17:27", "name": "Revert \"PCI: Enable ACS after configuring IOMMU for OF platforms\"", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/498154/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2218010/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2218010/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-pci+bounces-51546-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-pci@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=Sf5b7NfN;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=H9OA+HSR;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=linux-pci+bounces-51546-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com\n header.b=\"Sf5b7NfN\";\n\tdkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.b=\"H9OA+HSR\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=205.220.180.131", "smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=oss.qualcomm.com" ], "Received": [ "from sto.lore.kernel.org (sto.lore.kernel.org\n [IPv6:2600:3c09:e001:a7::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4flMwT1VGpz1y1q\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 31 Mar 2026 20:18:01 +1100 (AEDT)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 5E0A930233C3\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 31 Mar 2026 09:17:44 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 2157D3ED5B7;\n\tTue, 31 Mar 2026 09:17:40 +0000 (UTC)", "from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com\n [205.220.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 83C953ED132\n\tfor <linux-pci@vger.kernel.org>; Tue, 31 Mar 2026 09:17:38 +0000 (UTC)", "from pps.filterd (m0279869.ppops.net [127.0.0.1])\n\tby mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 62V5SH0f2408168\n\tfor <linux-pci@vger.kernel.org>; Tue, 31 Mar 2026 09:17:37 GMT", "from mail-pl1-f199.google.com (mail-pl1-f199.google.com\n [209.85.214.199])\n\tby mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d80hetbwt-1\n\t(version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n\tfor <linux-pci@vger.kernel.org>; Tue, 31 Mar 2026 09:17:37 +0000 (GMT)", "by mail-pl1-f199.google.com with SMTP id\n d9443c01a7336-2a90510a6d1so53292855ad.0\n for <linux-pci@vger.kernel.org>; Tue, 31 Mar 2026 02:17:37 -0700 (PDT)", "from work ([117.193.210.140])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b2427663acsm104909665ad.46.2026.03.31.02.17.31\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 31 Mar 2026 02:17:34 -0700 (PDT)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774948660; cv=none;\n b=peferwgK0RwML2Pet4o634Qm0DNQVQdwZN5rmhcaqOmm+2jSr9vDnHGTE6pr2W8LfFKgRSNd43iUWaUeUn8PBw5TVVsUSR0uvpIoB1cOFUVdy9zBiENyz9fdhMf0d+IYgUd51ieK9qnSOGxp8Q/Qaz7kNlFXZWCrW15bE4vBn+Q=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774948660; c=relaxed/simple;\n\tbh=N/eES/Xh/38FhKMRuW7Q6v2kLjf92GpFC2BRpl1Ud4w=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=GQe8S8UvF+GKpzPBEi0kt12DdgOLiyJgpN8tFOI3lXQeESk3fIG3lLx/6sZ4RJwUP0KG8ywRTDF/LVBCKcOShypwSTF9A4rBTkEzx71nb1nJvYH16l+UuZ8A2/NAxs19fqSxc7Sh+Qukx9K97SJkwSQnYQ7XaUQ3TPmCKiMLes4=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com;\n spf=pass smtp.mailfrom=oss.qualcomm.com;\n dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com\n header.b=Sf5b7NfN;\n dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.b=H9OA+HSR; arc=none smtp.client-ip=205.220.180.131", "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n\tcc:content-transfer-encoding:date:from:message-id:mime-version\n\t:subject:to; s=qcppdkim1; bh=N5vIQzVWTdz2F4TNIPIiGoPdK8bGPWTisCz\n\tWzVjic3I=; b=Sf5b7NfNiJQTHSohskYwVmu7ZnhPhLyShbQHQplcY2QkqqIPGaj\n\tzBhr7cfuqZTDhHjOzuyLsrTVsgDe7EuRrL4qPmIE2+gYp4//xiUFeN/z5zBenaBA\n\tKBppuSduPZmTrf00Mg4U6hR+Ck3RU7FR/In+GEMofWbUxUx7NJWogJ+Ifu6VR8Au\n\t8WwJ0BWa/7MBv+AxISrlHt5PTWc2zKbbGHodCFrAN8V+xks2EDp3YlhYtQ8bIjAz\n\t0AjUvygqct8I9R548/dIX8TGUn0OdvzEvGLW9DctahTZkwrPpuYaDXRfgUXqclEp\n\tP/Sts/3RCH9Yw5Blp0qkdEmQOfFVNPmm6mQ==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oss.qualcomm.com; s=google; t=1774948656; x=1775553456;\n darn=vger.kernel.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=N5vIQzVWTdz2F4TNIPIiGoPdK8bGPWTisCzWzVjic3I=;\n b=H9OA+HSRw4TRxI7CjGqTEIeiQoX7/7miajnByESfBokbRfeBuTZXaFXz2Cq3nhiJ6S\n zhm4n58Il3xwNo+2xCkPOPPuT+1NW0tZovRyCOE6T2KAbwyjCYuyuT7xniVxmJLHUSlW\n /ZYMm9DaXQFWPFw3Z2BO/Hi3s444C95O+PhUtqDjCzvWjy6z1PABANiMZl1t+0L+A0Zi\n BpMgcY+7V1efgbvbKGwXG80CS/BeFiuxNpeQcokO8kyXCXW9yGQkXcFc50/CMoFyNcub\n SaeZCmNuhWUyrHxHLC9zoyTYbNsLB/KBAx+QONYS3e+qkIFJk5qrmEr3LID9i6PAvnWz\n 0Juw==" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774948656; x=1775553456;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=N5vIQzVWTdz2F4TNIPIiGoPdK8bGPWTisCzWzVjic3I=;\n b=ZLAhiYfsKWYBq9laqMvMT5D0GnqGo56m+yxIfxUJJG0lZlvyCJj4WtbU/e7pW9Mc8u\n RubLSBGXejl4APCLT8J1BsKYlEYajoGg/HFssEnpEa9tOYAcAD07y0bHqcMOF6wxiG2Y\n 7OnlxhejJaLroy9hQ71LmXW2jBqab7Vw1blVeAp6dLzGvWvDoyeOKfMCgIBQbg8Qfw+M\n 6Zr0njpdl9/9J5l9rQNixHDeTsROvfWiAngAdsHVHTnz4N8zYuR6aD+P+ufWWSGftIEW\n 4iv9ErzBdii5Y5Ni/UIvq9qo7DshK7RsbgMhLLm/LWBIpL8JUxX+mpSItWhLhwpBr94T\n pTNA==", "X-Forwarded-Encrypted": "i=1;\n AJvYcCWTsoCPRlEmh9S79hQiLCNGWHk2EDc3yVWgT1dRbnm1Jiye3LWoLopsPeIqwdQ5keFJgn4pn765/g0=@vger.kernel.org", "X-Gm-Message-State": "AOJu0YyHBXRKdTmbBX5qvCQaL8RxawxsCe3hecF27nRXYLsKReM4GiZZ\n\tvdFfD8FyTMg5QuiT6RZqDMPxfmMwfdbLhHu2eO90xMkyFq87FROcSXXDjkNJ0GPUCSsnxV8tI2z\n\tCYfYwuiKmafqJdN6xdV/rIFe/bwA6qUuSdAm/l1sv5CJTtoArELjpx4FeeDSBAkw=", "X-Gm-Gg": "ATEYQzyC9Zungvl9LVogQJ3N/PcssheuEU+88kDHo7X67XfRC13EPg/QfVGxDyVx0Jk\n\tNSjF5iV07+33EnKniTFN9F9TNvwJ7Zx733XTU36qORnr3XKOHBFn22wOulFP4ZjCq51x5qR8Bt3\n\tCiSbGe31yPekvEWIhsaTBbWam/IpEVyXfEhFAQhKV6IACAi282GQjQ0UNpKg+Auf3EiS8VZ2NeE\n\tT7/xRP3/C77JQhrLtYlqmoSmhjFBoMtgQ7vS7QXX8f62NReFKKA/aeEsESLsfBrZ63mggzFkxfE\n\tpGyXRpCnaHZq8JpBkpG+XQCVHct4IUDs/YmAbXRAr/6FuVk21pCh2yopqGQkX2krZC0tgkT8HxX\n\tAGBJ47GIWuSCswop3c7PjVkbT6C3v2AYIAoLobis=", "X-Received": [ "by 2002:a17:902:d60d:b0:2b2:4f43:b49a with SMTP id\n d9443c01a7336-2b25ef77bccmr24215075ad.22.1774948655931;\n Tue, 31 Mar 2026 02:17:35 -0700 (PDT)", "by 2002:a17:902:d60d:b0:2b2:4f43:b49a with SMTP id\n d9443c01a7336-2b25ef77bccmr24214735ad.22.1774948655386;\n Tue, 31 Mar 2026 02:17:35 -0700 (PDT)" ], "From": "Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>", "To": "stable@vger.kernel.org", "Cc": "bhelgaas@google.com, linux-pci@vger.kernel.org,\n linux-kernel@vger.kernel.org, robin.murphy@arm.com,\n Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>,\n John Hancock <john@kernel.doghat.io>, bjorn.forsman@gmail.com,\n Linux kernel regressions list <regressions@lists.linux.dev>", "Subject": "[PATCH] Revert \"PCI: Enable ACS after configuring IOMMU for OF\n platforms\"", "Date": "Tue, 31 Mar 2026 14:47:27 +0530", "Message-ID": "<20260331091727.33552-1-manivannan.sadhasivam@oss.qualcomm.com>", "X-Mailer": "git-send-email 2.51.0", "Precedence": "bulk", "X-Mailing-List": "linux-pci@vger.kernel.org", "List-Id": "<linux-pci.vger.kernel.org>", "List-Subscribe": "<mailto:linux-pci+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-pci+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Authority-Analysis": "v=2.4 cv=Gb0aXAXL c=1 sm=1 tr=0 ts=69cb9131 cx=c_pps\n a=JL+w9abYAAE89/QcEU+0QA==:117 a=vr9TklybbRi32TvS4M0W1g==:17\n a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=VwQbUJbxAAAA:8\n a=lAgNKBcoAAAA:8 a=pGLkceISAAAA:8 a=EUspDBNiAAAA:8 a=hAXPUp1672zZkZ7mbzMA:9\n a=324X-CrmTo6CU4MGRt3R:22 a=drE6d5tx1tjNRBs8zHOc:22", "X-Proofpoint-GUID": "O4g0REmIGFYrcLfgk_ycEyydcIpOaVpM", "X-Proofpoint-ORIG-GUID": "O4g0REmIGFYrcLfgk_ycEyydcIpOaVpM", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwMzMxMDA4OCBTYWx0ZWRfX+aMgNQb1iOl7\n nibZiONLt/Ktbp62Vo5ecsf/KvqR5OU12AechaL/7YuZRTtpd7czctjUNM03cjULfeLu24OUOi0\n LnYH6dfFWo0LYPLcNKlko/vlI8UjJmSb6TV5AKvBvHh0tQ4A2xRHB99O/DpyZCYjiefwXpktN+r\n sdrR92/h3/Gs3dJluCAD95Dg+CDg0LnD8k4PCyHCBcmp3pH4etsNB2ywEZpMAU9O8bs1R0nx+RI\n V6BGBqhImfBVy/xPp1adwAdd2hgKgBKLUWs2f40NbPJhqq5QuZdVNIt4ceoZeGeOawQOpl6xd6d\n JxA8gYcCdbeJg3bVX8ZM8uxpCOL1fK7GzDlUEtW6AbiQWexo3NphP7TtL2GBdSYUvviadMxyJv7\n D3eYEe5r/3VWENpYFoSIyHhqP2vIz+7/cMRPIOq/92tiHxuW8VrDRK1Y0RJbaYkW3RylKa7Yo0E\n UDVrOVhcvi90Pb7U8dg==", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-03-31_02,2026-03-28_01,2025-10-01_01", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n lowpriorityscore=0 impostorscore=0 adultscore=0 spamscore=0 bulkscore=0\n malwarescore=0 clxscore=1015 suspectscore=0 priorityscore=1501 phishscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603310088" }, "content": "This reverts commit ec494c0260bf57a6fa3aa43a91daf7a774f8bd97.\n\nThe original commit attempted to enable ACS in pci_dma_configure() prior\nto IOMMU group assignment in iommu_init_device() to fix the ACS enablement\nissue for OF platforms. But that assumption doesn't hold true for kernel\nversions prior to v6.15, because on these older kernels,\npci_dma_configure() is called *after* iommu_init_device(). So the IOMMU\ngroups are already created before the ACS gets enabled. This causes the\ndevices that should have been split into separate groups by ACS, getting\nmerged into one group, thereby breaking the IOMMU isolation as reported on\nthe AMD machines.\n\nSo revert the offending commit to restore the IOMMU group assignment on\nthose affected machines. It should be noted that ACS has never really\nworked on kernel versions prior to v6.15, so the revert doesn't make any\ndifference for OF platforms.\n\nReported-by: John Hancock <john@kernel.doghat.io>\nReported-by: bjorn.forsman@gmail.com\nCloses: https://bugzilla.kernel.org/show_bug.cgi?id=221234\nFixes: b20b659c2c6a (\"PCI: Enable ACS after configuring IOMMU for OF platforms\")\nCc: Linux kernel regressions list <regressions@lists.linux.dev>\nLink: https://lore.kernel.org/regressions/2c30f181-ffc6-4d63-a64e-763cf4528f48@leemhuis.info\nSigned-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>\n---\n\nThis revert is targeted for v6.6 stable kernel.\n\n drivers/pci/pci-driver.c | 8 --------\n drivers/pci/pci.c | 10 +++++++++-\n drivers/pci/pci.h | 1 -\n 3 files changed, 9 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/pci/pci-driver.c b/drivers/pci/pci-driver.c\nindex b7a6d8a28fe9..8c941d6267a5 100644\n--- a/drivers/pci/pci-driver.c\n+++ b/drivers/pci/pci-driver.c\n@@ -1668,14 +1668,6 @@ static int pci_dma_configure(struct device *dev)\n \t\tret = acpi_dma_configure(dev, acpi_get_dma_attr(adev));\n \t}\n \n-\t/*\n-\t * Attempt to enable ACS regardless of capability because some Root\n-\t * Ports (e.g. those quirked with *_intel_pch_acs_*) do not have\n-\t * the standard ACS capability but still support ACS via those\n-\t * quirks.\n-\t */\n-\tpci_enable_acs(to_pci_dev(dev));\n-\n \tpci_put_host_bridge_device(bridge);\n \n \tif (!ret && !driver->driver_managed_dma) {\ndiff --git a/drivers/pci/pci.c b/drivers/pci/pci.c\nindex d015df77ddff..b82927905968 100644\n--- a/drivers/pci/pci.c\n+++ b/drivers/pci/pci.c\n@@ -1046,7 +1046,7 @@ static void pci_std_enable_acs(struct pci_dev *dev)\n * pci_enable_acs - enable ACS if hardware support it\n * @dev: the PCI device\n */\n-void pci_enable_acs(struct pci_dev *dev)\n+static void pci_enable_acs(struct pci_dev *dev)\n {\n \tif (!pci_acs_enable)\n \t\tgoto disable_acs_redir;\n@@ -3823,6 +3823,14 @@ bool pci_acs_path_enabled(struct pci_dev *start,\n void pci_acs_init(struct pci_dev *dev)\n {\n \tdev->acs_cap = pci_find_ext_capability(dev, PCI_EXT_CAP_ID_ACS);\n+\n+\t/*\n+\t * Attempt to enable ACS regardless of capability because some Root\n+\t * Ports (e.g. those quirked with *_intel_pch_acs_*) do not have\n+\t * the standard ACS capability but still support ACS via those\n+\t * quirks.\n+\t */\n+\tpci_enable_acs(dev);\n }\n \n /**\ndiff --git a/drivers/pci/pci.h b/drivers/pci/pci.h\nindex dae7b98536f7..3c35aae7431f 100644\n--- a/drivers/pci/pci.h\n+++ b/drivers/pci/pci.h\n@@ -557,7 +557,6 @@ static inline resource_size_t pci_resource_alignment(struct pci_dev *dev,\n }\n \n void pci_acs_init(struct pci_dev *dev);\n-void pci_enable_acs(struct pci_dev *dev);\n #ifdef CONFIG_PCI_QUIRKS\n int pci_dev_specific_acs_enabled(struct pci_dev *dev, u16 acs_flags);\n int pci_dev_specific_enable_acs(struct pci_dev *dev);\n", "prefixes": [] }