Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2217980/?format=api
{ "id": 2217980, "url": "http://patchwork.ozlabs.org/api/patches/2217980/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20260331075338.2391-2-ansuelsmth@gmail.com/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260331075338.2391-2-ansuelsmth@gmail.com>", "list_archive_url": null, "date": "2026-03-31T07:53:20", "name": "[v4,1/5] misc: fs_loader: fix ubifs not unmounted on dev_get_priv error", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "c99bec27a90482e924d42db81ef097a24e0a1ef0", "submitter": { "id": 71108, "url": "http://patchwork.ozlabs.org/api/people/71108/?format=api", "name": "Christian Marangi", "email": "ansuelsmth@gmail.com" }, "delegate": { "id": 3651, "url": "http://patchwork.ozlabs.org/api/users/3651/?format=api", "username": "trini", "first_name": "Tom", "last_name": "Rini", "email": "trini@ti.com" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20260331075338.2391-2-ansuelsmth@gmail.com/mbox/", "series": [ { "id": 498136, "url": "http://patchwork.ozlabs.org/api/series/498136/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=498136", "date": "2026-03-31T07:53:19", "name": "misc: fs_loader: reorg and split to FS and FW loader + FIP loader", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/498136/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2217980/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2217980/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=UaPlz4f9;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.b=\"UaPlz4f9\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=ansuelsmth@gmail.com" ], "Received": [ "from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4flL3Z6f7tz1xtJ\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 31 Mar 2026 18:54:02 +1100 (AEDT)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 73BE384010;\n\tTue, 31 Mar 2026 09:53:54 +0200 (CEST)", "by phobos.denx.de (Postfix, from userid 109)\n id 1E59F83DBF; Tue, 31 Mar 2026 09:53:52 +0200 (CEST)", "from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com\n [IPv6:2a00:1450:4864:20::32a])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 1E49283F0A\n for <u-boot@lists.denx.de>; Tue, 31 Mar 2026 09:53:50 +0200 (CEST)", "by mail-wm1-x32a.google.com with SMTP id\n 5b1f17b1804b1-483487335c2so56801315e9.2\n for <u-boot@lists.denx.de>; Tue, 31 Mar 2026 00:53:50 -0700 (PDT)", "from Ansuel-XPS24 (93-34-88-122.ip49.fastwebnet.it. [93.34.88.122])\n by smtp.googlemail.com with ESMTPSA id\n 5b1f17b1804b1-4887c561750sm23889915e9.2.2026.03.31.00.53.48\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 31 Mar 2026 00:53:48 -0700 (PDT)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1774943629; x=1775548429; darn=lists.denx.de;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:from:to:cc:subject:date:message-id\n :reply-to; bh=ncf5CGqxvO5twq8XmgDTVmMycW8ixnJNHA/TGHwyw7Q=;\n b=UaPlz4f93d/zD9LU9IUoQK6B5gv6WMoZPJ3MfnOOH5VBF3RUSA9gxmCfWVbuO7P9iH\n r0d0+ZGnA5f5l1ryEoLOpb8Rls4UyhMnFRIIg7+kPjVu9xDJgu6x70mOiFJ5jv672tbG\n zQoGtj+bWofploP0wbuPzuVHLB7wgDYvG/4wNRkgav72ufyIJeWxEeEhD7W0/erLsvcO\n SgR3AN5Ozm0jSHbaWEE9faAFxuZVmJM5+daQpVQ/u0HD8tPHTbF+We/zmXgJEq14UuBl\n 1hSnfgT0l5xgFwByrxJwttV0e/+4r2g8S+dq/gxC3U3jk2OJWUOfPOPYAcQcn0X2JXB5\n 3yEQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774943629; x=1775548429;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=ncf5CGqxvO5twq8XmgDTVmMycW8ixnJNHA/TGHwyw7Q=;\n b=MCOTyBR+WK1HnvIy/giFwN4BYrcFIG5S81sh4FPzPV0OXAB1Yo/9ggCY39v3PBjGfy\n HDnibFrAeKMj+2VTRBesFHN2gPC2NNo6HI4LvGMfb4TKqfuRaabP4peyd/DVn/bvL7hT\n 5Z6ExHowISMrOQhtgkd2W2kl3D0ofmTnmf7x2XZsUw5kcZj+M4JhbjYCSytGfo4YXO+E\n RaXbj0Fpcs72rErj5PUjX3BsOiqNrmQNfB7MsdMOg+3iYcexbkg0MWXYQx8J/htiKaok\n yn4BqsE69CLOsQP6IaUeUGS5hLultD6C2oIQkAmNKgtckjeFerNE70OqPJqwiFWxPlik\n 9b+A==", "X-Forwarded-Encrypted": "i=1;\n AJvYcCVXB9ye0gCk0RS7d3miTvRf4Q2w1/g1TYIe5VIlcBXI+xV9HHVt743cFNRP/wTHCqXzuzEyXLE=@lists.denx.de", "X-Gm-Message-State": "AOJu0YyxdoKNO2x6nXZA/wwhx6X8Eut4UOCbviw3FSRxX7b5xe09hkS+\n Yg1RqNKmGNjSYNhK6vSESjRKud9pHb0ciMn4wIuVd9aiMmfjE+fguiLk", "X-Gm-Gg": "ATEYQzyipcYFqM/6nRVmeSXvzzqtiUhJBxZCPO+ao0fqtiCk97VUhIwsEfUNf4kiuWE\n y5gD+/U/CcLkaf5Z3N9OVQ5J9rleHLw/yp1+WiiyAf7osWY35I5WInplMN0uV2HGtpCfGZHAJyG\n qEsb+VDN4PIii9fVfJasFdHFrI4aov2oNMHJ3F+AYJXHeZxD0lY0HYyIwg+ipTl473zy6iu6DcZ\n eRsdxmH85mJz15zI41/Nt5s2AyvJEtndY+Ugh81IZMqNp26fyuMpdpNUxqK7I41csaveieTo12O\n 7nWg0ANNeW18hWuhvRw3w/7LU+PB1rQiksysm3jwPTpG4yWkN3pbIt2lWnnUjJbOBSAcO67Y8+d\n q5qYDTb59EvCuGEz6KbkckUPw0atU3a6E3YGdB91/Hwt3JkDEg8IY4xawOcwEhh88nP2kGSn+FJ\n stEoDsDNJPswXwn0VJEy2pFlOkZyrkZwY4AGQpGHwdxEtOynl/rBfo0lE=", "X-Received": "by 2002:a05:600c:8b66:b0:480:1e40:3d2 with SMTP id\n 5b1f17b1804b1-487280b2f9fmr269291885e9.29.1774943629336;\n Tue, 31 Mar 2026 00:53:49 -0700 (PDT)", "From": "Christian Marangi <ansuelsmth@gmail.com>", "To": "Tom Rini <trini@konsulko.com>, Simon Glass <sjg@chromium.org>,\n Casey Connolly <casey.connolly@linaro.org>,\n Quentin Schulz <quentin.schulz@cherry.de>,\n Christian Marangi <ansuelsmth@gmail.com>, Peng Fan <peng.fan@nxp.com>,\n Ilias Apalodimas <ilias.apalodimas@linaro.org>,\n Chen-Yu Tsai <wens@kernel.org>,\n Jamie Gibbons <jamie.gibbons@microchip.com>,\n Neha Malcom Francis <n-francis@ti.com>,\n Justin Klaassen <justin@tidylabs.net>, Harsha Vardhan V M <h-vm@ti.com>,\n Leo Yu-Chi Liang <ycliang@andestech.com>,\n Weijie Gao <weijie.gao@mediatek.com>,\n Marek Vasut <marek.vasut+renesas@mailbox.org>,\n Alif Zakuan Yuslaimi <alif.zakuan.yuslaimi@altera.com>,\n Sky Huang <SkyLake.Huang@mediatek.com>,\n \"Lucien.Jheng\" <lucienzx159@gmail.com>, u-boot@lists.denx.de", "Subject": "[PATCH v4 1/5] misc: fs_loader: fix ubifs not unmounted on\n dev_get_priv error", "Date": "Tue, 31 Mar 2026 09:53:20 +0200", "Message-ID": "<20260331075338.2391-2-ansuelsmth@gmail.com>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260331075338.2391-1-ansuelsmth@gmail.com>", "References": "<20260331075338.2391-1-ansuelsmth@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "When dev_get_priv errors out, the ubifs is not umounted (if used).\n\nCorrectly handle this handle condition and while at it also return -EINVAL\ninstead of -ENOMEM as a better error since no memory is allocated but is\nactually an invalid scenario for fw_get_filesystem_firmware().\n\nSigned-off-by: Christian Marangi <ansuelsmth@gmail.com>\nReviewed-by: Simon Glass <sjg@chromium.org>\nReviewed-by: Neha Malcom Francis <n-francis@ti.com>\n---\n drivers/misc/fs_loader.c | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/misc/fs_loader.c b/drivers/misc/fs_loader.c\nindex 6af4c7f15e7b..cd4695b08eea 100644\n--- a/drivers/misc/fs_loader.c\n+++ b/drivers/misc/fs_loader.c\n@@ -175,8 +175,10 @@ static int fw_get_filesystem_firmware(struct udevice *dev)\n \n \tstruct firmware *firmwarep = dev_get_priv(dev);\n \n-\tif (!firmwarep)\n-\t\treturn -ENOMEM;\n+\tif (!firmwarep) {\n+\t\tret = -EINVAL;\n+\t\tgoto out;\n+\t}\n \n \tret = fs_read(firmwarep->name, (ulong)map_to_sysmem(firmwarep->data),\n \t\t\tfirmwarep->offset, firmwarep->size, &actread);\n", "prefixes": [ "v4", "1/5" ] }