Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2217961/?format=api
{ "id": 2217961, "url": "http://patchwork.ozlabs.org/api/patches/2217961/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260331061712.85484-1-tpluszz77@gmail.com/", "project": { "id": 26, "url": "http://patchwork.ozlabs.org/api/projects/26/?format=api", "name": "Netfilter Development", "link_name": "netfilter-devel", "list_id": "netfilter-devel.vger.kernel.org", "list_email": "netfilter-devel@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260331061712.85484-1-tpluszz77@gmail.com>", "list_archive_url": null, "date": "2026-03-31T06:17:12", "name": "[v2] netfilter: ctnetlink: zero expect NAT fields when CTA_EXPECT_NAT absent", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "8cc97d43fdf3c33ec9678aebd935d772c2d7c2a8", "submitter": { "id": 93002, "url": "http://patchwork.ozlabs.org/api/people/93002/?format=api", "name": "Qi Tang", "email": "tpluszz77@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260331061712.85484-1-tpluszz77@gmail.com/mbox/", "series": [ { "id": 498127, "url": "http://patchwork.ozlabs.org/api/series/498127/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netfilter-devel/list/?series=498127", "date": "2026-03-31T06:17:12", "name": "[v2] netfilter: ctnetlink: zero expect NAT fields when CTA_EXPECT_NAT absent", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/498127/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2217961/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2217961/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <netfilter-devel+bounces-11510-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "netfilter-devel@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=SWQiRofA;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c15:e001:75::12fc:5321; helo=sin.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-11510-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"SWQiRofA\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.214.176", "smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com" ], "Received": [ "from sin.lore.kernel.org (sin.lore.kernel.org\n [IPv6:2600:3c15:e001:75::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4flHwC3wp1z1y1q\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 31 Mar 2026 17:17:31 +1100 (AEDT)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id BD5BA301A6A5\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 31 Mar 2026 06:17:26 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 60E25385509;\n\tTue, 31 Mar 2026 06:17:22 +0000 (UTC)", "from mail-pl1-f176.google.com (mail-pl1-f176.google.com\n [209.85.214.176])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id D44EE2BF3D7\n\tfor <netfilter-devel@vger.kernel.org>; Tue, 31 Mar 2026 06:17:20 +0000 (UTC)", "by mail-pl1-f176.google.com with SMTP id\n d9443c01a7336-2b258576d8cso9616135ad.0\n for <netfilter-devel@vger.kernel.org>;\n Mon, 30 Mar 2026 23:17:20 -0700 (PDT)", "from localhost.localdomain ([47.236.127.140])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b24267397bsm108101525ad.27.2026.03.30.23.17.16\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 30 Mar 2026 23:17:19 -0700 (PDT)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774937842; cv=none;\n b=g+MbiHifDSK6gDZYjd8PkEfhtAX4/LYUP3AyqjiD3V4PLRNrMdVPzEy+3FhXmv5lEzzlivYHM9iFu9+YTIMnMhMfot2L3KdViCVJ3YS+4DECT5GxEP0QZ0XZnkhS6YVnLuEE1Tl/f7uO+M1qPQZlKiJu+a7fHbX8Y0DvHvTPXhg=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774937842; c=relaxed/simple;\n\tbh=+MVwa06bQ80jTsJAxdYTPPItAkzHNOIIwQDDMrjTfLk=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=tCthXFfwnmDEO08UFZG17VWuIUUaYX/O2Y+v6W4OMtg2IWWtDJS0XWPG8SuMnVs5hnOUmKkbiQj28l50vOvO+I+inXBfggJXOUITNZ7LP49cTCp2yFD2vHXBzVF99RA9R0m9c6HOvo7WRX82u7Mp1dBg0xw/mlIdR5TCUuR5aOI=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=SWQiRofA; arc=none smtp.client-ip=209.85.214.176", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1774937840; x=1775542640;\n darn=vger.kernel.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=bkzyJ4oLOwweestkp4e2+gtljA8YSDiok5IOKRVAFxc=;\n b=SWQiRofAKkGjqPfXCm5gjRdeLdi78+27ZTwJKQifuOlhXyRHa4NzFEIFj25Q9AlTCr\n DsMsdzYTcUi34q/h2h5G0E/V+194WBNjwSLZKL/qmtbxI+9D/Qbq+xnTYht7OwF1KrEh\n qFBEJFrMrspfU3QXoEaYz4XGqtIdWFn5E6V7yRefT54D9U7+6HkJEh4UDxFIT7gXEbeX\n kU99dNgITl8F6W081WHukjqikKobxz6Ne2op61eHGETg2a4sR3lW0870/hfkp1HZ65fu\n 5c+bO/raqzGrqO+Ca7eOLauFMbPi6PMkAv5NpJ4EwJZ5DzCRzLn/zbv290TWDNkZtJNg\n 3faw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774937840; x=1775542640;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=bkzyJ4oLOwweestkp4e2+gtljA8YSDiok5IOKRVAFxc=;\n b=hrcaZmvWjMuD++G1QxLC9dkLyxWCoNLzEIkj4J1NzhwfYARLlbp/uYwb1nyI0VWUKK\n +cjFhnJUu0ovhFvwSTcv9JyZ8NDGJyXDsgt7HUKR8tyb5/8ZbxOPEZ7VzDo147tsFRI3\n 9Uz+XLoBQ6cDD279l/6TKShzvZc49FlwfZ8tYopjQ7La5bke/84CLXLGAAGZDe/Ys60v\n pc2X0QwrVrbriWJyU1sm8nhion2eFY7r0dINttRUMHvhob8N318HnrIjuQe/A83nIpGp\n B9KXpd7HpLtDp9NPXXtBLLpfP2Or74ape9klaBYGUy4DhRXb+D9pfLiQw//zOzm4hafp\n jLxw==", "X-Forwarded-Encrypted": "i=1;\n AJvYcCWBKRhFjOvEy6GopVKpoy62ohuKKpI37K69jKdggiGvZPfBqenx4jteO5pAk7VOLVRJXxhJsWjkyz1QOmeLMuM=@vger.kernel.org", "X-Gm-Message-State": "AOJu0Yz29al6N6XXnVkPGVqud5ePGrWhw7ZoRfqNmoIb/lHWRS2dZ51l\n\trqrNNpq+8Wb8o3SJGyNZjpVnl2hI5NFKNdP/kpIPa5Qd99th/fU7Fh2p", "X-Gm-Gg": "ATEYQzygeudidJv2LRqmrcbUrYOzrd66WnjFD0AYPDCU/1Pu2vxv1D5eZ+lqMsiPo58\n\tVcZ1OmSn5XUJRJE7OcS3I7mqMuX8iv61wsWdjSITosXW6v50nWWFMJu8lIuNUHUSbZZ7mHZhFUS\n\tZ9atdGYK9aRCE+DV/AGmQSbHQ5VbHQ0iC6Bcjya8Zx13vztuMhUHDupJ0jeb/V8iM0TKN7oiKtt\n\tb0rCpZqJfpcwoCmzrNzB3Jp7DMK6COcTmt/hzs483qDBjhFy1zmiLRwzhMQMkEZ6svLi/X14ZoQ\n\tlotfjwqfhCMoLl8JmBxhbhE8/4kFvGVWvI8YmY5JV6nZVgymdO7opdJR8BknMsJcCeBkH1UWaiH\n\tsCuhNAaEMyqiio1cBLYzb5kx9f5bAfTaKCHrQjhH7COFIXlpTiB4W5H6yZyFlL6Xavvti/Bb7TT\n\tOQ+9MyF9tisnsgdNQVbnEnOFeaMZWJbwKUX1w=", "X-Received": "by 2002:a17:903:1c9:b0:2b0:608d:d8a8 with SMTP id\n d9443c01a7336-2b0cdc76509mr162648985ad.1.1774937839921;\n Mon, 30 Mar 2026 23:17:19 -0700 (PDT)", "From": "Qi Tang <tpluszz77@gmail.com>", "To": "Pablo Neira Ayuso <pablo@netfilter.org>,\n\tFlorian Westphal <fw@strlen.de>", "Cc": "Phil Sutter <phil@nwl.cc>,\n\tnetfilter-devel@vger.kernel.org,\n\tcoreteam@netfilter.org,\n\tnetdev@vger.kernel.org,\n\tkernel test robot <lkp@intel.com>,\n\tQi Tang <tpluszz77@gmail.com>", "Subject": "[PATCH v2] netfilter: ctnetlink: zero expect NAT fields when\n CTA_EXPECT_NAT absent", "Date": "Tue, 31 Mar 2026 14:17:12 +0800", "Message-ID": "<20260331061712.85484-1-tpluszz77@gmail.com>", "X-Mailer": "git-send-email 2.43.0", "Precedence": "bulk", "X-Mailing-List": "netfilter-devel@vger.kernel.org", "List-Id": "<netfilter-devel.vger.kernel.org>", "List-Subscribe": "<mailto:netfilter-devel+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:netfilter-devel+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit" }, "content": "ctnetlink_alloc_expect() allocates expectations from a non-zeroing\nslab cache via nf_ct_expect_alloc(). When CTA_EXPECT_NAT is not\npresent in the netlink message, saved_addr and saved_proto are\nnever initialized. Stale data from a previous slab occupant can\nthen be dumped to userspace by ctnetlink_exp_dump_expect(), which\nchecks these fields to decide whether to emit CTA_EXPECT_NAT.\n\nThe safe sibling nf_ct_expect_init(), used by the packet path,\nexplicitly zeroes these fields.\n\nZero saved_addr, saved_proto and dir in the else branch, guarded\nby IS_ENABLED(CONFIG_NF_NAT) since these fields only exist when\nNAT is enabled.\n\nConfirmed by priming the expect slab with NAT-bearing expectations,\nfreeing them, creating a new expectation without CTA_EXPECT_NAT,\nand observing that the ctnetlink dump emits a spurious\nCTA_EXPECT_NAT containing stale data from the prior allocation.\n\nFixes: 076a0ca02644 (\"netfilter: ctnetlink: add NAT support for expectations\")\nReported-by: kernel test robot <lkp@intel.com>\nCloses: https://lore.kernel.org/oe-kbuild-all/202603310541.XVM8V7WG-lkp@intel.com/\nSigned-off-by: Qi Tang <tpluszz77@gmail.com>\n---\n\nChanges in v2:\n - Wrap zeroing in #if IS_ENABLED(CONFIG_NF_NAT) to fix build\n when CONFIG_NF_NAT is disabled (kernel test robot)\n\nLink: https://lore.kernel.org/all/20260329165217.241038-1-tpluszz77@gmail.com/\n net/netfilter/nf_conntrack_netlink.c | 6 ++++++\n 1 file changed, 6 insertions(+)", "diff": "diff --git a/net/netfilter/nf_conntrack_netlink.c b/net/netfilter/nf_conntrack_netlink.c\nindex c57c665363e0..6d7eab7e8cf8 100644\n--- a/net/netfilter/nf_conntrack_netlink.c\n+++ b/net/netfilter/nf_conntrack_netlink.c\n@@ -3593,6 +3593,12 @@ ctnetlink_alloc_expect(const struct nlattr * const cda[], struct nf_conn *ct,\n \t\t\t\t\t\t exp, nf_ct_l3num(ct));\n \t\tif (err < 0)\n \t\t\tgoto err_out;\n+#if IS_ENABLED(CONFIG_NF_NAT)\n+\t} else {\n+\t\tmemset(&exp->saved_addr, 0, sizeof(exp->saved_addr));\n+\t\tmemset(&exp->saved_proto, 0, sizeof(exp->saved_proto));\n+\t\texp->dir = 0;\n+#endif\n \t}\n \treturn exp;\n err_out:\n", "prefixes": [ "v2" ] }