Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2217928/?format=api
{ "id": 2217928, "url": "http://patchwork.ozlabs.org/api/patches/2217928/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260331012508.17410-3-ddiss@suse.de/", "project": { "id": 12, "url": "http://patchwork.ozlabs.org/api/projects/12/?format=api", "name": "Linux CIFS Client", "link_name": "linux-cifs-client", "list_id": "linux-cifs.vger.kernel.org", "list_email": "linux-cifs@vger.kernel.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260331012508.17410-3-ddiss@suse.de>", "list_archive_url": null, "date": "2026-03-31T00:37:52", "name": "[2/3] mount.cifs: adjust get_password_from_file() buf size", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "da5fd0b0fc7f5f7b806ddabe9f7c30673109ae04", "submitter": { "id": 26890, "url": "http://patchwork.ozlabs.org/api/people/26890/?format=api", "name": "David Disseldorp", "email": "ddiss@suse.de" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260331012508.17410-3-ddiss@suse.de/mbox/", "series": [ { "id": 498116, "url": "http://patchwork.ozlabs.org/api/series/498116/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-cifs-client/list/?series=498116", "date": "2026-03-31T00:37:50", "name": "mount.cifs: minor buflen tracking cleanups", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/498116/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2217928/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2217928/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-cifs+bounces-10591-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-cifs@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=mLiYqpb2;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=qrWPYeLd;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=mLiYqpb2;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=qrWPYeLd;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-cifs+bounces-10591-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.b=\"mLiYqpb2\";\n\tdkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de\n header.b=\"qrWPYeLd\";\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.b=\"mLiYqpb2\";\n\tdkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de\n header.b=\"qrWPYeLd\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=195.135.223.130", "smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=suse.de", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=suse.de", "smtp-out1.suse.de;\n\tnone" ], "Received": [ "from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fl9TN5Ch3z1yGH\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 31 Mar 2026 12:27:20 +1100 (AEDT)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 9B3A03019916\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 31 Mar 2026 01:25:43 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 74E463246FE;\n\tTue, 31 Mar 2026 01:25:43 +0000 (UTC)", "from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 3131231AF2D\n\tfor <linux-cifs@vger.kernel.org>; Tue, 31 Mar 2026 01:25:42 +0000 (UTC)", "from imap1.dmz-prg2.suse.org (unknown [10.150.64.97])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby smtp-out1.suse.de (Postfix) with ESMTPS id 1504B4D635;\n\tTue, 31 Mar 2026 01:25:36 +0000 (UTC)", "from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 86A594A0A2;\n\tTue, 31 Mar 2026 01:25:34 +0000 (UTC)", "from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n\tby imap1.dmz-prg2.suse.org with ESMTPSA\n\tid 4OvFDo4iy2mpbgAAD6G6ig\n\t(envelope-from <ddiss@suse.de>); Tue, 31 Mar 2026 01:25:34 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774920343; cv=none;\n b=S2OH0XfYe63e8G6FVPDwM0MkVoRGWSN2+k+icpYU/yn+ggzOmBxnNtpnvhs/NYXYueMqKUfvYIvd5jfcMsLVlU6Ic0L4iWC4ARFDVIj+O18ZZBygd9iY5dc4rKA46d6x0lG3lRJDH2NEJWEZVQ5qRjYqI8AKMdOKnhjB5Nfgk/A=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774920343; c=relaxed/simple;\n\tbh=LWz5esiwB/9kMnmrkPPNwVFOSJAyHpexKRRRViQER3U=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=enP88uZCnqh3hrfiuSFwB4Yn59xRp8rOALKx/IGJWO6tlBGaN/s4dATg6LaPUgpRLhHHqii+R+gB17Q/ufSVg+PWgHLsI7Id13owFylsVEcraXX6EMAmS1vX/16UrafRQPS56gVbEoJQX4RzLwzkKQA+JF5mqSK3zkkGce4Bh90=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=suse.de;\n spf=pass smtp.mailfrom=suse.de;\n dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.b=mLiYqpb2;\n dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de\n header.b=qrWPYeLd;\n dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.b=mLiYqpb2;\n dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de\n header.b=qrWPYeLd; arc=none smtp.client-ip=195.135.223.130", "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n\tt=1774920336;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n\t mime-version:mime-version:\n\t content-transfer-encoding:content-transfer-encoding:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=K/wtcZMY4V0XiILQfZPcG0rCbNUMcvfGDxltiO6Mj3w=;\n\tb=mLiYqpb2H0UnNuYSi9nNNq4/nqTKcD9dqCu07hJqSlD5g/DW/8qaowyeD32CQ5PVUx/rVQ\n\tzSEynxGv+x2v7BQnRww6iisRZY2tTcVxHm0I54Ftz5Ot8gFuzI6NnRuqp9deWE1mzANu0g\n\tO4zjeumqWEVxbkfWKLVqp1u+LRJcSn4=", "v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n\ts=susede2_ed25519; t=1774920336;\n\th=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n\t mime-version:mime-version:\n\t content-transfer-encoding:content-transfer-encoding:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=K/wtcZMY4V0XiILQfZPcG0rCbNUMcvfGDxltiO6Mj3w=;\n\tb=qrWPYeLdmN5RyUJv/FLggFYTZ5b5pSBUQUFJ0nHvXXEWbhyfBtwDGW130sVBGsJGRAc0Nx\n\tOChbL1lLEOC3AlBA==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n\tt=1774920336;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n\t mime-version:mime-version:\n\t content-transfer-encoding:content-transfer-encoding:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=K/wtcZMY4V0XiILQfZPcG0rCbNUMcvfGDxltiO6Mj3w=;\n\tb=mLiYqpb2H0UnNuYSi9nNNq4/nqTKcD9dqCu07hJqSlD5g/DW/8qaowyeD32CQ5PVUx/rVQ\n\tzSEynxGv+x2v7BQnRww6iisRZY2tTcVxHm0I54Ftz5Ot8gFuzI6NnRuqp9deWE1mzANu0g\n\tO4zjeumqWEVxbkfWKLVqp1u+LRJcSn4=", "v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n\ts=susede2_ed25519; t=1774920336;\n\th=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n\t mime-version:mime-version:\n\t content-transfer-encoding:content-transfer-encoding:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=K/wtcZMY4V0XiILQfZPcG0rCbNUMcvfGDxltiO6Mj3w=;\n\tb=qrWPYeLdmN5RyUJv/FLggFYTZ5b5pSBUQUFJ0nHvXXEWbhyfBtwDGW130sVBGsJGRAc0Nx\n\tOChbL1lLEOC3AlBA==" ], "From": "David Disseldorp <ddiss@suse.de>", "To": "linux-cifs@vger.kernel.org", "Cc": "Steve French <smfrench@gmail.com>,\n\tDavid Disseldorp <ddiss@suse.de>", "Subject": "[PATCH 2/3] mount.cifs: adjust get_password_from_file() buf size", "Date": "Tue, 31 Mar 2026 11:37:52 +1100", "Message-ID": "<20260331012508.17410-3-ddiss@suse.de>", "X-Mailer": "git-send-email 2.51.0", "In-Reply-To": "<20260331012508.17410-1-ddiss@suse.de>", "References": "<20260331012508.17410-1-ddiss@suse.de>", "Precedence": "bulk", "X-Mailing-List": "linux-cifs@vger.kernel.org", "List-Id": "<linux-cifs.vger.kernel.org>", "List-Subscribe": "<mailto:linux-cifs+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-cifs+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Spamd-Result": "default: False [-6.80 / 50.00];\n\tREPLY(-4.00)[];\n\tBAYES_HAM(-3.00)[99.99%];\n\tNEURAL_HAM_LONG(-1.00)[-1.000];\n\tMID_CONTAINS_FROM(1.00)[];\n\tR_MISSING_CHARSET(0.50)[];\n\tNEURAL_HAM_SHORT(-0.20)[-1.000];\n\tMIME_GOOD(-0.10)[text/plain];\n\tRCVD_COUNT_TWO(0.00)[2];\n\tARC_NA(0.00)[];\n\tRCVD_VIA_SMTP_AUTH(0.00)[];\n\tFREEMAIL_CC(0.00)[gmail.com,suse.de];\n\tTO_DN_SOME(0.00)[];\n\tMIME_TRACE(0.00)[0:+];\n\tTO_MATCH_ENVRCPT_ALL(0.00)[];\n\tFUZZY_RATELIMITED(0.00)[rspamd.com];\n\tRCVD_TLS_ALL(0.00)[];\n\tDBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.de:mid,suse.de:email];\n\tFROM_HAS_DN(0.00)[];\n\tDKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n\tFROM_EQ_ENVFROM(0.00)[];\n\tRCPT_COUNT_THREE(0.00)[3];\n\tFREEMAIL_ENVRCPT(0.00)[gmail.com]", "X-Spam-Flag": "NO", "X-Spam-Score": "-6.80", "X-Spam-Level": "" }, "content": "The parsed_mount_info password and password2 fields are both zero\nterminated and sized MOUNT_PASSWD_SIZE + 1.\nThe get_password_from_file() buf adds one to this size, presumably to\naccount for (extra) zero termination. This is unnecessary, so use a\nconsistent size across all buffers.\n\nSigned-off-by: David Disseldorp <ddiss@suse.de>\n---\n mount.cifs.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/mount.cifs.c b/mount.cifs.c\nindex d41ca6a..945196f 100644\n--- a/mount.cifs.c\n+++ b/mount.cifs.c\n@@ -684,7 +684,7 @@ get_password_from_file(int file_descript, char *filename,\n \tint is_pass2 = which_pass == OPT_PASS2;\n \tunsigned int pass_length = is_pass2 ?\n \t\t\t\t\t sizeof(parsed_info->password2) : sizeof(parsed_info->password);\n-\tchar buf[pass_length + 1];\n+\tchar buf[pass_length];\n \n \tif (filename != NULL) {\n \t\trc = toggle_dac_capability(0, 1);\n", "prefixes": [ "2/3" ] }