Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2217921/?format=api
{ "id": 2217921, "url": "http://patchwork.ozlabs.org/api/patches/2217921/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pci/patch/20260330230248.646900-4-anthony.l.nguyen@intel.com/", "project": { "id": 28, "url": "http://patchwork.ozlabs.org/api/projects/28/?format=api", "name": "Linux PCI development", "link_name": "linux-pci", "list_id": "linux-pci.vger.kernel.org", "list_email": "linux-pci@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260330230248.646900-4-anthony.l.nguyen@intel.com>", "list_archive_url": null, "date": "2026-03-30T23:02:32", "name": "[net-next,03/15] igc: Don't reset the hardware on suspend path", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "ac3d2fdf7715e4bba94fb035f9080c593786b98c", "submitter": { "id": 68875, "url": "http://patchwork.ozlabs.org/api/people/68875/?format=api", "name": "Tony Nguyen", "email": "anthony.l.nguyen@intel.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-pci/patch/20260330230248.646900-4-anthony.l.nguyen@intel.com/mbox/", "series": [ { "id": 498113, "url": "http://patchwork.ozlabs.org/api/series/498113/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pci/list/?series=498113", "date": "2026-03-30T23:02:30", "name": "[net-next,01/15] igc: Call netif_queue_set_napi() with rtnl locked", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/498113/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2217921/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2217921/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-pci+bounces-51508-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-pci@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=Bi0T2mqA;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.232.135.74; helo=sto.lore.kernel.org;\n envelope-from=linux-pci+bounces-51508-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.b=\"Bi0T2mqA\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=198.175.65.10", "smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=intel.com", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=intel.com" ], "Received": [ "from sto.lore.kernel.org (sto.lore.kernel.org [172.232.135.74])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fl6H80MZZz1y1q\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 31 Mar 2026 10:03:16 +1100 (AEDT)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 8F055301C56B\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 30 Mar 2026 23:03:04 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 218753B7767;\n\tMon, 30 Mar 2026 23:02:57 +0000 (UTC)", "from mgamail.intel.com (mgamail.intel.com [198.175.65.10])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 90673398905;\n\tMon, 30 Mar 2026 23:02:55 +0000 (UTC)", "from orviesa002.jf.intel.com ([10.64.159.142])\n by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 30 Mar 2026 16:02:53 -0700", "from anguy11-upstream.jf.intel.com ([10.166.9.133])\n by orviesa002.jf.intel.com with ESMTP; 30 Mar 2026 16:02:52 -0700" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774911777; cv=none;\n b=J5DIo3DQnOmmC19EJ5nAdHjCRGr0zkLdvA3tY4e3ycZ5TF/br/wmmGK+CiNZxe0UdRTMyDTAsZyGH1rtQ6gLc8DoS/K4SUqrGsKUhWarFyKwMk27R3b6P4UES05RHa+PbSjMFNYL6Fmduijj5zmcbBgvCCxDJqXO/MPI9zMm/as=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774911777; c=relaxed/simple;\n\tbh=Ed5V2hmcxxu7yQL6n80HzX/Bg/5WgEmq3+NmnnOazks=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=pwQLmm8RgcBbJ7CgH0y4bJpxCJPAsTCB6u0PuCSZ+j9scwIgOiWXVcJkjMHoXTxjeKmQEH/qTKrlJ1leDGxVesr7uzzzeGtBIXF5EQCBw7hoPF8gcfu15AMCZfCIqfYLnpDmzL3l6XZcpk5nynHuQbkenQfUYXczcaqi4B0WQu4=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=intel.com;\n spf=pass smtp.mailfrom=intel.com;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.b=Bi0T2mqA; arc=none smtp.client-ip=198.175.65.10", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1774911776; x=1806447776;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=Ed5V2hmcxxu7yQL6n80HzX/Bg/5WgEmq3+NmnnOazks=;\n b=Bi0T2mqAF0+5mMlGEmy6J2r2xUklOvqWjpkFDPLe1jJREem8RcpB1JaH\n uiUNViznWDmlr0+RLX4V9XvvkFaEj5GqIEt2Tjz+TjHpKgeI6kF78O0aV\n VTxC7KQArs/tLxcjEhVFg5Q3sXOqH1VFjfWY9d8mzpeA7sYYf/fq7Yi5X\n TgmKztolAvUF/KJgYpoPKDenrZfYlGLLutl9wIOTfbPdPugt/RcGX8WWR\n LhlVfkoBUFNBkKsT5VnvysdrXvF3rvnejD0kdwCab4hsrprzqdc4GoA/O\n PEOerraLvW4EwP6umD9D+/2SWIv8tYjWg1XE+VG7GFhWXlN4vPp+p6o5a\n g==;", "X-CSE-ConnectionGUID": [ "8xiTWigFRpChFNi9UO3rkQ==", "doNwZa4JS+q8VdjEq/EX9w==" ], "X-CSE-MsgGUID": [ "N4Jh+B0fSYuejPoLaj+hmg==", "wD2Qj1D1SLWiWt5BCiD3qA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11744\"; a=\"93297560\"", "E=Sophos;i=\"6.23,150,1770624000\";\n d=\"scan'208\";a=\"93297560\"", "E=Sophos;i=\"6.23,150,1770624000\";\n d=\"scan'208\";a=\"256687711\"" ], "X-ExtLoop1": "1", "From": "Tony Nguyen <anthony.l.nguyen@intel.com>", "To": "davem@davemloft.net,\n\tkuba@kernel.org,\n\tpabeni@redhat.com,\n\tedumazet@google.com,\n\tandrew+netdev@lunn.ch,\n\tnetdev@vger.kernel.org", "Cc": "Mika Westerberg <mika.westerberg@linux.intel.com>,\n\tanthony.l.nguyen@intel.com,\n\tandriy.shevchenko@intel.com,\n\tilpo.jarvinen@linux.intel.com,\n\tdima.ruinskiy@intel.com,\n\tmbloch@nvidia.com,\n\tleon@kernel.org,\n\tlinux-pci@vger.kernel.org,\n\tsaeedm@nvidia.com,\n\ttariqt@nvidia.com,\n\tlukas@wunner.de,\n\tbhelgaas@google.com,\n\trichardcochran@gmail.com,\n\tVinicius Costa Gomes <vinicius.gomes@intel.com>,\n\tJacob Keller <jacob.e.keller@intel.com>,\n\tAvigail Dahan <avigailx.dahan@intel.com>", "Subject": "[PATCH net-next 03/15] igc: Don't reset the hardware on suspend path", "Date": "Mon, 30 Mar 2026 16:02:32 -0700", "Message-ID": "<20260330230248.646900-4-anthony.l.nguyen@intel.com>", "X-Mailer": "git-send-email 2.47.1", "In-Reply-To": "<20260330230248.646900-1-anthony.l.nguyen@intel.com>", "References": "<20260330230248.646900-1-anthony.l.nguyen@intel.com>", "Precedence": "bulk", "X-Mailing-List": "linux-pci@vger.kernel.org", "List-Id": "<linux-pci.vger.kernel.org>", "List-Subscribe": "<mailto:linux-pci+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-pci+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit" }, "content": "From: Mika Westerberg <mika.westerberg@linux.intel.com>\n\nCommit c01163dbd1b8 (\"PCI/PM: Always disable PTM for all devices during\nsuspend\") made the PCI core to suspend (disable) PTM before driver\nsuspend hooks are called. In case of igc what happens is that on suspend\npath PCI core calls pci_suspend_ptm() then igc suspend hook that calls\nigc_down() that ends up calling igc_ptp_reset() (which according to the\ncomment is actually needed for re-enabling the device). Anyways that\nfunction also poll IGC_PTM_STAT that will end up timing out because PTM\nis already disabled:\n\n [ 160.716119] igc 0000:03:00.0 enp3s0: Timeout reading IGC_PTM_STAT register\n\nThere should be no reason resetting the hardware on suspend path so fix\nthis by avoiding the reset.\n\nSigned-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>\nAcked-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>\nReviewed-by: Jacob Keller <jacob.e.keller@intel.com>\nTested-by: Avigail Dahan <avigailx.dahan@intel.com>\nSigned-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>\n---\n drivers/net/ethernet/intel/igc/igc.h | 2 +-\n drivers/net/ethernet/intel/igc/igc_ethtool.c | 6 +++---\n drivers/net/ethernet/intel/igc/igc_main.c | 13 +++++++------\n 3 files changed, 11 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igc/igc.h b/drivers/net/ethernet/intel/igc/igc.h\nindex 17236813965d..caa5b89b2b24 100644\n--- a/drivers/net/ethernet/intel/igc/igc.h\n+++ b/drivers/net/ethernet/intel/igc/igc.h\n@@ -349,7 +349,7 @@ struct igc_adapter {\n };\n \n void igc_up(struct igc_adapter *adapter);\n-void igc_down(struct igc_adapter *adapter);\n+void igc_down(struct igc_adapter *adapter, bool reset);\n int igc_open(struct net_device *netdev);\n int igc_close(struct net_device *netdev);\n int igc_setup_tx_resources(struct igc_ring *ring);\ndiff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c b/drivers/net/ethernet/intel/igc/igc_ethtool.c\nindex 0122009bedd0..4d1bcc19255f 100644\n--- a/drivers/net/ethernet/intel/igc/igc_ethtool.c\n+++ b/drivers/net/ethernet/intel/igc/igc_ethtool.c\n@@ -638,7 +638,7 @@ igc_ethtool_set_ringparam(struct net_device *netdev,\n \t\tgoto clear_reset;\n \t}\n \n-\tigc_down(adapter);\n+\tigc_down(adapter, true);\n \n \t/* We can't just free everything and then setup again,\n \t * because the ISRs in MSI-X mode get passed pointers\n@@ -737,7 +737,7 @@ static int igc_ethtool_set_pauseparam(struct net_device *netdev,\n \tif (adapter->fc_autoneg == AUTONEG_ENABLE) {\n \t\thw->fc.requested_mode = igc_fc_default;\n \t\tif (netif_running(adapter->netdev)) {\n-\t\t\tigc_down(adapter);\n+\t\t\tigc_down(adapter, true);\n \t\t\tigc_up(adapter);\n \t\t} else {\n \t\t\tigc_reset(adapter);\n@@ -2077,7 +2077,7 @@ igc_ethtool_set_link_ksettings(struct net_device *netdev,\n \n \t/* reset the link */\n \tif (netif_running(adapter->netdev)) {\n-\t\tigc_down(adapter);\n+\t\tigc_down(adapter, true);\n \t\tigc_up(adapter);\n \t} else {\n \t\tigc_reset(adapter);\ndiff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c\nindex 0e785af0a3a3..80a90ce0ad0e 100644\n--- a/drivers/net/ethernet/intel/igc/igc_main.c\n+++ b/drivers/net/ethernet/intel/igc/igc_main.c\n@@ -5312,8 +5312,9 @@ void igc_update_stats(struct igc_adapter *adapter)\n /**\n * igc_down - Close the interface\n * @adapter: board private structure\n+ * @reset: issue reset\n */\n-void igc_down(struct igc_adapter *adapter)\n+void igc_down(struct igc_adapter *adapter, bool reset)\n {\n \tstruct net_device *netdev = adapter->netdev;\n \tstruct igc_hw *hw = &adapter->hw;\n@@ -5369,7 +5370,7 @@ void igc_down(struct igc_adapter *adapter)\n \tadapter->link_speed = 0;\n \tadapter->link_duplex = 0;\n \n-\tif (!pci_channel_offline(adapter->pdev))\n+\tif (reset && !pci_channel_offline(adapter->pdev))\n \t\tigc_reset(adapter);\n \n \t/* clear VLAN promisc flag so VFTA will be updated if necessary */\n@@ -5387,7 +5388,7 @@ void igc_reinit_locked(struct igc_adapter *adapter)\n {\n \twhile (test_and_set_bit(__IGC_RESETTING, &adapter->state))\n \t\tusleep_range(1000, 2000);\n-\tigc_down(adapter);\n+\tigc_down(adapter, true);\n \tigc_up(adapter);\n \tclear_bit(__IGC_RESETTING, &adapter->state);\n }\n@@ -5441,7 +5442,7 @@ static int igc_change_mtu(struct net_device *netdev, int new_mtu)\n \tadapter->max_frame_size = max_frame;\n \n \tif (netif_running(netdev))\n-\t\tigc_down(adapter);\n+\t\tigc_down(adapter, true);\n \n \tnetdev_dbg(netdev, \"changing MTU from %d to %d\\n\", netdev->mtu, new_mtu);\n \tWRITE_ONCE(netdev->mtu, new_mtu);\n@@ -6305,7 +6306,7 @@ static int __igc_close(struct net_device *netdev, bool suspending)\n \tif (!suspending)\n \t\tpm_runtime_get_sync(&pdev->dev);\n \n-\tigc_down(adapter);\n+\tigc_down(adapter, !suspending);\n \n \tigc_release_hw_control(adapter);\n \n@@ -7646,7 +7647,7 @@ static pci_ers_result_t igc_io_error_detected(struct pci_dev *pdev,\n \t}\n \n \tif (netif_running(netdev))\n-\t\tigc_down(adapter);\n+\t\tigc_down(adapter, true);\n \tpci_disable_device(pdev);\n \trtnl_unlock();\n \n", "prefixes": [ "net-next", "03/15" ] }