Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2217919/?format=api
{ "id": 2217919, "url": "http://patchwork.ozlabs.org/api/patches/2217919/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openbmc/patch/20260328181749.13047-1-devnexen@gmail.com/", "project": { "id": 56, "url": "http://patchwork.ozlabs.org/api/projects/56/?format=api", "name": "OpenBMC development", "link_name": "openbmc", "list_id": "openbmc.lists.ozlabs.org", "list_email": "openbmc@lists.ozlabs.org", "web_url": "http://github.com/openbmc/", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260328181749.13047-1-devnexen@gmail.com>", "list_archive_url": null, "date": "2026-03-28T18:17:49", "name": "[v3,1/2] media: nuvoton: npcm-video: fix error handling in npcm_video_init()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "ee6e37587fbee3bf1af140972ded31e18c4ce4e0", "submitter": { "id": 76714, "url": "http://patchwork.ozlabs.org/api/people/76714/?format=api", "name": "David Carlier", "email": "devnexen@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/openbmc/patch/20260328181749.13047-1-devnexen@gmail.com/mbox/", "series": [ { "id": 498110, "url": "http://patchwork.ozlabs.org/api/series/498110/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openbmc/list/?series=498110", "date": "2026-03-28T18:18:09", "name": "[v3,1/2] media: nuvoton: npcm-video: fix error handling in npcm_video_init()", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/498110/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2217919/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2217919/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <openbmc+bounces-1754-incoming=patchwork.ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "openbmc@lists.ozlabs.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=mUmJLYEz;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=openbmc+bounces-1754-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)", "lists.ozlabs.org;\n arc=none smtp.remote-ip=\"2a00:1450:4864:20::42f\"", "lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com", "lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=mUmJLYEz;\n\tdkim-atps=neutral", "lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com\n (client-ip=2a00:1450:4864:20::42f; helo=mail-wr1-x42f.google.com;\n envelope-from=devnexen@gmail.com; receiver=lists.ozlabs.org)" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fl61z4WTGz1xtJ\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 31 Mar 2026 09:51:51 +1100 (AEDT)", "from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fl61l3GM2z2ySf;\n\tTue, 31 Mar 2026 09:51:39 +1100 (AEDT)", "from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com\n [IPv6:2a00:1450:4864:20::42f])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fjm2x6t6Cz2ySY\n\tfor <openbmc@lists.ozlabs.org>; Sun, 29 Mar 2026 05:18:00 +1100 (AEDT)", "by mail-wr1-x42f.google.com with SMTP id\n ffacd0b85a97d-439cd6b09f8so2097196f8f.3\n for <openbmc@lists.ozlabs.org>; Sat, 28 Mar 2026 11:18:00 -0700 (PDT)", "from dohko.chello.ie (188-141-5-72.dynamic.upc.ie. [188.141.5.72])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43cf247472csm5435632f8f.28.2026.03.28.11.17.51\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sat, 28 Mar 2026 11:17:52 -0700 (PDT)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1774721883;\n\tcv=none;\n b=bxtMZAQZwC/K4QC010I7OMi4JF7Bt51M7H0qYr/Xfd3SLVWUWI82MV2XMxDdidx3bB6QxFgvDMXNE3Fv9/75Q6cfG5w5qADLlZiTKJSaoYXlycOuYjhC+rku13i02uV7MxR5FokZcSHuCI0m2UjyBfBlPh1CZMpBK4Xv9T1dfdsX38U229+O3NYd2AJBERNNVaF74CTJnS/FKiPa+wR9Av3ZCHjimY6Aal4oTEslutslqNDJvbihk+LL4Th8XUDuhUdW62TQnOCXLpu1/tjJBiyv5tFtnfTlbDwOBqyycEvYe9M8raPjttlYnyINMpYmJiE6NPWKg0KLmGm02oDWog==", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1774721883; c=relaxed/relaxed;\n\tbh=rprbcKOKh6LbVDBtx1L6evH/A6xyQAWdrHbB0AMy/jA=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=iiuKoZSV5oJCE8pTS6Xzq2et22cH8g7ria8gXXsfBJDhsqUsvy2R4PLutc//WgkpJdh3bX0V4vKV5fwh8FLuF8HZsJWQlVYLBey5xgrEJHryacGafG9QdnY2EO34smH/eWNdAOvMO/EGFmqf/GQkMfx+QQW60MQeCtLyfmpUsR9mzH7LVFJ9abyYa1IEBE4XwT+/XXw+JvPXgv2US9ZyTQ/1fWKMnyi7MflI7UFMFTaXiIvl0GCHPnCBGFOWX54epc3u/Bih8LdhchDgvjw4yLbCDoiOT7yWLbKxfzC0MBooL56aUqDqCnHJ8lGjXNlzp8VUa0fv62AWN2BtaLhccg==", "ARC-Authentication-Results": "i=1; lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com; dkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=mUmJLYEz; dkim-atps=neutral;\n spf=pass (client-ip=2a00:1450:4864:20::42f; helo=mail-wr1-x42f.google.com;\n envelope-from=devnexen@gmail.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=gmail.com", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1774721873; x=1775326673;\n darn=lists.ozlabs.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=rprbcKOKh6LbVDBtx1L6evH/A6xyQAWdrHbB0AMy/jA=;\n b=mUmJLYEzsBMDIKtRRwZA4bfLNXj6E1IBS0F6hr2BnYrKEARzTRy+o4sXXiNjvKAIxF\n 4U0oQbk5MYO1xOQPc0V3FO0ggydH6Y9UA9epK6TuXqSdAI7fGMm/CGt6QZbUjiSeD6bw\n K7G+wyhgeYnTALccy4iAgYP+K5JIZnMLqM22/X22VKGyBY1J2uklmPa08eT8woanWeDS\n OUirmmTJAObvEQWzzuYxSu3bFK+DOW1FJj2snuGFyLuRTEPGFKbq9JqNKaIbg55SX9oQ\n cWir1fLwn2pqzTUiDNuHuLTTK9ZRwpZMMY6A7Y+SC6jrt0YblmoYtDwBMurXnk34ECOK\n JLIg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774721873; x=1775326673;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=rprbcKOKh6LbVDBtx1L6evH/A6xyQAWdrHbB0AMy/jA=;\n b=NqicSDeRxfcO27kUi3njzCHkATsbu2SLCAYCfYeQU4VbTyUcqMIiqcfjomFrsln3q/\n N1kPH3HZ24Owsr9DkAxAhH/NaEEaJFAgT1S4pTLi92tAcdHO5yFkATOnM5j4pr9yN5gG\n mNAccxZ8sh8jaPCpKWtqlPFPgDohKuC0Vw/Y7T8+ADZ3LYaDXwGBS9Mq37bSEZJHVos8\n 1pZlw9oA+qfmde290djH7jpv1GHKJybWRug7J2m4h4ws7L2sD1wRKNNC4JQx8vSPn8o0\n Oh2MIp9tBerPsmpgOLezPg8HvDGqzY1ffCu9g419de7Q0iWGNmRp3SlTy7v8RYB+re3e\n Zy1A==", "X-Forwarded-Encrypted": "i=1;\n AJvYcCXyBIBjDP3sHakyCz7MBJNsoa94AzY7RUx5big7+4T6LEf6gvCobw9MT14zEhBcFm0mezKFZiPj@lists.ozlabs.org", "X-Gm-Message-State": "AOJu0YyaJ0R/NSmv+eJ6Xerr7slzZxm4hVDHm+Bg9C3Z9wTq4TekP/zm\n\tgdX0IIutVSsw00T9OACUx78ukrCnajWoqK4ijOETrXH6IeXCRXV7VSMI", "X-Gm-Gg": "ATEYQzzrOwqIn/UFEyak8OxAolR0YpstdAD626/1ZvQ+p9R5yk2XSyz2qzoc95In/z6\n\tC7D7dB9eC8PPLF435T/T1x6OnHbEiwojIq3i5S5Bb23Ene/u2764m+ggfKkoYV88vSslT3PZcyy\n\tlRbL0Za7qo+waRpeNaY1pmF8d9WS0joiWm5mrHmb0kSqO9CxIG1NbL0FKhGJ2E12UsRFZqmioXA\n\thrmZ30HUyCSKTaaFUmZrAXKd8poW0rF+je6F6mhgBKjGwuNKiekTz1ZUkeZINpKFlMedkgy2kV1\n\tJLx4lp3WueaNMkYfAntBMxLAKMhAEv08J926XRYx6ezgR8fjzkE/acPFjgZTiXS/6X9XweWtZqx\n\tHXZLQ71M5yLYUAkg8ju3A4yCGhvEMREu2rxWtpJ8ktf5dsEr1SLoL7nUXrBtL1XaqZosC17Ikhd\n\tLQJwAHbyYfjvpPKZPodtlVZaRD5M0PC7g+eer+9i/Uol6opnXG7fxqcCMyH+iF9mfYJPl7vYo1Y\n\tD1fImKtn9uf", "X-Received": "by 2002:a05:6000:220b:b0:43b:8023:8b2 with SMTP id\n ffacd0b85a97d-43b9ea76481mr11973788f8f.45.1774721872613;\n Sat, 28 Mar 2026 11:17:52 -0700 (PDT)", "From": "David Carlier <devnexen@gmail.com>", "To": "kwliu@nuvoton.com,\n\tkflin@nuvoton.com,\n\tmchehab@kernel.org", "Cc": "linux-media@vger.kernel.org,\n\topenbmc@lists.ozlabs.org,\n\tDavid Carlier <devnexen@gmail.com>", "Subject": "[PATCH v3 1/2] media: nuvoton: npcm-video: fix error handling in\n npcm_video_init()", "Date": "Sat, 28 Mar 2026 18:17:49 +0000", "Message-ID": "<20260328181749.13047-1-devnexen@gmail.com>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<69c81867.050a0220.26a904.f72a@mx.google.com>", "References": "<69c81867.050a0220.26a904.f72a@mx.google.com>", "X-Mailing-List": "openbmc@lists.ozlabs.org", "List-Id": "<openbmc.lists.ozlabs.org>", "List-Help": "<mailto:openbmc+help@lists.ozlabs.org>", "List-Owner": "<mailto:openbmc+owner@lists.ozlabs.org>", "List-Post": "<mailto:openbmc@lists.ozlabs.org>", "List-Subscribe": "<mailto:openbmc+subscribe@lists.ozlabs.org>,\n <mailto:openbmc+subscribe-digest@lists.ozlabs.org>,\n <mailto:openbmc+subscribe-nomail@lists.ozlabs.org>", "List-Unsubscribe": "<mailto:openbmc+unsubscribe@lists.ozlabs.org>", "Precedence": "list", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Spam-Status": "No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tDKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,\n\tSPF_HELO_NONE,SPF_PASS autolearn=disabled version=4.0.1", "X-Spam-Checker-Version": "SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org" }, "content": "npcm_video_init() has two error handling issues after\nof_reserved_mem_device_init() is called:\n\nWhen dma_set_mask_and_coherent() fails, the function releases the\nreserved memory but does not return, allowing execution to fall through\ninto npcm_video_ece_init() with a failed DMA configuration.\n\nWhen npcm_video_ece_init() fails, the function returns an error without\ncalling of_reserved_mem_device_release(), leaking the reserved memory\nassociation.\n\nFix both by adding the missing return after the DMA mask failure and\nadding the missing of_reserved_mem_device_release() call on the ECE init\nerror path.\n\nFixes: 46c15a4ff1f4 (\"media: nuvoton: Add driver for NPCM video capture and encoding engine\")\nSigned-off-by: David Carlier <devnexen@gmail.com>\n---\n drivers/media/platform/nuvoton/npcm-video.c | 2 ++\n 1 file changed, 2 insertions(+)", "diff": "diff --git a/drivers/media/platform/nuvoton/npcm-video.c b/drivers/media/platform/nuvoton/npcm-video.c\nindex b2a562e1ee1c..5c6bddfe8073 100644\n--- a/drivers/media/platform/nuvoton/npcm-video.c\n+++ b/drivers/media/platform/nuvoton/npcm-video.c\n@@ -1720,10 +1720,12 @@ static int npcm_video_init(struct npcm_video *video)\n \tif (rc) {\n \t\tdev_err(dev, \"Failed to set DMA mask\\n\");\n \t\tof_reserved_mem_device_release(dev);\n+\t\treturn rc;\n \t}\n \n \trc = npcm_video_ece_init(video);\n \tif (rc) {\n+\t\tof_reserved_mem_device_release(dev);\n \t\tdev_err(dev, \"Failed to initialize ECE\\n\");\n \t\treturn rc;\n \t}\n", "prefixes": [ "v3", "1/2" ] }