Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2217916/?format=api
{ "id": 2217916, "url": "http://patchwork.ozlabs.org/api/patches/2217916/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openbmc/patch/20260328181809.13988-1-devnexen@gmail.com/", "project": { "id": 56, "url": "http://patchwork.ozlabs.org/api/projects/56/?format=api", "name": "OpenBMC development", "link_name": "openbmc", "list_id": "openbmc.lists.ozlabs.org", "list_email": "openbmc@lists.ozlabs.org", "web_url": "http://github.com/openbmc/", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260328181809.13988-1-devnexen@gmail.com>", "list_archive_url": null, "date": "2026-03-28T18:18:09", "name": "[v3,2/2] media: nuvoton: npcm-video: fix memory leaks in probe and remove", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "55eb52aafafd3d84b05e539666a2c4115803fd4c", "submitter": { "id": 76714, "url": "http://patchwork.ozlabs.org/api/people/76714/?format=api", "name": "David Carlier", "email": "devnexen@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/openbmc/patch/20260328181809.13988-1-devnexen@gmail.com/mbox/", "series": [ { "id": 498110, "url": "http://patchwork.ozlabs.org/api/series/498110/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openbmc/list/?series=498110", "date": "2026-03-28T18:18:09", "name": "[v3,1/2] media: nuvoton: npcm-video: fix error handling in npcm_video_init()", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/498110/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2217916/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2217916/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <openbmc+bounces-1751-incoming=patchwork.ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "openbmc@lists.ozlabs.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=gAVric9s;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=openbmc+bounces-1751-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)", "lists.ozlabs.org;\n arc=none smtp.remote-ip=\"2a00:1450:4864:20::32a\"", "lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com", "lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=gAVric9s;\n\tdkim-atps=neutral", "lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com\n (client-ip=2a00:1450:4864:20::32a; helo=mail-wm1-x32a.google.com;\n envelope-from=devnexen@gmail.com; receiver=lists.ozlabs.org)" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fl5wR0ZBJz1y1q\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 31 Mar 2026 09:47:03 +1100 (AEDT)", "from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fl5w60Q6Kz2ygl;\n\tTue, 31 Mar 2026 09:46:46 +1100 (AEDT)", "from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com\n [IPv6:2a00:1450:4864:20::32a])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fjm3C5k3Qz2ySY\n\tfor <openbmc@lists.ozlabs.org>; Sun, 29 Mar 2026 05:18:15 +1100 (AEDT)", "by mail-wm1-x32a.google.com with SMTP id\n 5b1f17b1804b1-4838c15e3cbso25407015e9.3\n for <openbmc@lists.ozlabs.org>; Sat, 28 Mar 2026 11:18:15 -0700 (PDT)", "from dohko.chello.ie (188-141-5-72.dynamic.upc.ie. [188.141.5.72])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-487270dd790sm83670455e9.5.2026.03.28.11.18.11\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sat, 28 Mar 2026 11:18:11 -0700 (PDT)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1774721896;\n\tcv=none;\n b=ooE1WXfIqEIDkALy1mIdlWtXqfsqZoO/g2/zY7uHiHYh5vCUB9Cl/iGf2sn/1VmNgvBcVPXLKWqfDThqOltsA4lYXohwjGoKijmS78BfNBLf/WCIkhs9awE9al42RUE4TH3gHVT7QxOLskUbITeUfLzPxEOpkLzodayRza6V5oJb1h22kQfxUachzwkbhJGvwpw2tQiwALi4kBILaEVWYEPyBCJ9jczE3tkLPsohWiuQsRhNgorTZsH4eIo1V0VrnD4LUbW6KSD+ihJ7ilI4LcwHTBFQn/z4dvXig3edV2r3UbEoM2sZrpztw246FGNViTrhthkVx45cHG8Nu7fiZQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1774721896; c=relaxed/relaxed;\n\tbh=4wNuQm4/hkzS93ZEPVy54NJxy1R6wP2SseNtwzyElDg=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=OfjzBMaHZoGU26TyBxKvO7NpvhIbTpWWt5SX5UZ5yYWhqo5DPfLL5SEYfoGXFxj1NGISyj3dFuvZeEz5ON2pqXmaUdZUmncUm5Yt4spw1A+UJzUbJCCVPkIe08V9QUVP6cvptzo1ctP59bx0HwSf9rRXlP+GaGrcRtRcEz2DdthKQ4CntEyIhqAyLAXpTiJR123YpwTPI8xp4ON5H/XKb9kfFlbfP0o/bv4aZMp+kG3IAuFUWCjCc4TMdtlaKh1haWiD2ukk82JXuGmH51pWlpe7bcDLwFEjSsHmwWGNMdqUeDbJPiZNZe8CIbzTl/x4AOdVMu7dVNINNq+atMlvWA==", "ARC-Authentication-Results": "i=1; lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com; dkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=gAVric9s; dkim-atps=neutral;\n spf=pass (client-ip=2a00:1450:4864:20::32a; helo=mail-wm1-x32a.google.com;\n envelope-from=devnexen@gmail.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=gmail.com", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1774721892; x=1775326692;\n darn=lists.ozlabs.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=4wNuQm4/hkzS93ZEPVy54NJxy1R6wP2SseNtwzyElDg=;\n b=gAVric9szifx96n5L1dYokKtS3E+uDjBmetJca9gudd94BWpUaFV79JIzzG5eJWqPm\n d1FJJYgF2zgQnGB9awJsimN5O84uIqrZdNJ6pzYjsKcdnQeumZrw//RwnN+PEYoq+8+9\n KQX9J4a4BYqL0AojO1bjG2qdwb5aXhwzXPaj9gyPI8v+Iyr4+1eT+PtNM4kFK5j6tlKp\n nSvRYZkZ9hAyjtjMmOfLfNpGhCfl4sOE3oGA43rLzGajG3MOvWr17/37xVKM68b18n2S\n AvyXFhU2vP7wV+I+t6sWTCoO9utrkzWIwxcUA5Y2c1hUXL3bc8YFUgl0bnMbvDELXCeK\n 8G4w==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774721892; x=1775326692;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=4wNuQm4/hkzS93ZEPVy54NJxy1R6wP2SseNtwzyElDg=;\n b=QL1GNtZzlBcHvKq42kgRFKAUhb356mzTTGRMft/39O3YhvGTOmaAgeN1JnvNzMBmke\n 2agqEE5QH8OOpi55v+Bz2ZyDVGMqS1VTBGmv8XZ0/u3HcEPwtmoojv1oU8ii27hdRBxG\n Ilk5GacKiySoPy1s+mfIRS4X8dzqh1w+d5KhP6DnkiRyhbd73iX2tW5MVzj7qJo4CplS\n xmDzV5WZQlzZEbj+llU4qdpDl6KhIAwxxvSrhPRr6U3aEdof7WvqCh2IEehVVxb/3XIX\n FgxR9hx+6UvY4JLhMMstY3FWI9fiM5g3z23A/CqzC5P1+0bjJ4lyQhSGWMAPvlv+uabb\n MKdw==", "X-Forwarded-Encrypted": "i=1;\n AJvYcCW55pVH0J8we85WYtlHFsEw/FkoRZQ+nYwfVsdPi/jb00gXrkKEoO7u3BznSBg//R7g1BKTtDWZ@lists.ozlabs.org", "X-Gm-Message-State": "AOJu0YwzfM1YjMoo4yhRA1J4AaYQ8V02imTXk62BhsKQBjwNF5o/TFQr\n\tqkCdJiqSdcrx53vN1bFfRVOYxghLGcbiXJQmqi2sv8I3BWU3Ajnfj7ZJ", "X-Gm-Gg": "ATEYQzw7w1GrsklgSo3XlaM/+lp1Lcm1mg7GUlOUSI4avtsminjfDCSwJYL3h46+cgX\n\tLlg+QLOCAbyg+Wxhm8GmEwMo839MduVoX9sQ4aMZElKV3IU5zJ2NiM0AW+HhBTOhXAA6Sksa4jZ\n\tCubON8jxx+fUP/WdwxegwN7Uc1nueM5wlr1ME4YUGU2Lu1L3nPKuALTPOS/WrTF5p+AFC+GilLE\n\t1YTSnPE4wJ8N5BjXOSDyDaFRxvh0ezJTYq6lUAhlCGJKLHpRwz/0ZQqy4D24Wy4Maza+R90UMnA\n\tRqk0sE/c480EFTnpnHEPIA5A6rXiYpfRerIpUiDglOUrxGvO9x+yyn9IzeXvFaI8sW/oexYrksv\n\tb7aLtZrfl7hMPIabsYt1e0nz3I88s06QUB5F68aqHn01oWE68HYzfc5Y0x0pDRfpR7+5MCe6ZjD\n\t77Ikd+X02elZ0XSzN/AlAGssQ8ctSV8IMEGPPyRAFpusfvxGHP6orPSLg5rUZNhXgoWh0Gdlpo7\n\tyqQ6XaCYmp9", "X-Received": "by 2002:a05:600c:3b95:b0:486:fa35:aef2 with SMTP id\n 5b1f17b1804b1-48727d59448mr106333395e9.4.1774721892211;\n Sat, 28 Mar 2026 11:18:12 -0700 (PDT)", "From": "David Carlier <devnexen@gmail.com>", "To": "kwliu@nuvoton.com,\n\tkflin@nuvoton.com,\n\tmchehab@kernel.org", "Cc": "linux-media@vger.kernel.org,\n\topenbmc@lists.ozlabs.org,\n\tDavid Carlier <devnexen@gmail.com>", "Subject": "[PATCH v3 2/2] media: nuvoton: npcm-video: fix memory leaks in probe\n and remove", "Date": "Sat, 28 Mar 2026 18:18:09 +0000", "Message-ID": "<20260328181809.13988-1-devnexen@gmail.com>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<69c8189a.050a0220.bacd1.a31f@mx.google.com>", "References": "<69c8189a.050a0220.bacd1.a31f@mx.google.com>", "X-Mailing-List": "openbmc@lists.ozlabs.org", "List-Id": "<openbmc.lists.ozlabs.org>", "List-Help": "<mailto:openbmc+help@lists.ozlabs.org>", "List-Owner": "<mailto:openbmc+owner@lists.ozlabs.org>", "List-Post": "<mailto:openbmc@lists.ozlabs.org>", "List-Subscribe": "<mailto:openbmc+subscribe@lists.ozlabs.org>,\n <mailto:openbmc+subscribe-digest@lists.ozlabs.org>,\n <mailto:openbmc+subscribe-nomail@lists.ozlabs.org>", "List-Unsubscribe": "<mailto:openbmc+unsubscribe@lists.ozlabs.org>", "Precedence": "list", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Spam-Status": "No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tDKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,\n\tSPF_HELO_NONE,SPF_PASS autolearn=disabled version=4.0.1", "X-Spam-Checker-Version": "SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org" }, "content": "npcm_video_probe() allocates the npcm_video structure with kzalloc_obj()\nbut never frees it on any probe error path or in npcm_video_remove(),\nleaking the allocation on every failed probe and every normal unbind.\n\nAdditionally, when npcm_video_setup_video() fails, the reserved memory\nassociation established by of_reserved_mem_device_init() in\nnpcm_video_init() is not released, leaking the rmem_assigned_device\nentry on the global list.\n\nFix both by adding kfree(video) to all probe error paths and to\nnpcm_video_remove(), and adding the missing\nof_reserved_mem_device_release() call when npcm_video_setup_video()\nfails.\n\nFixes: 46c15a4ff1f4 (\"media: nuvoton: Add driver for NPCM video capture and encoding engine\")\nSigned-off-by: David Carlier <devnexen@gmail.com>\n---\n drivers/media/platform/nuvoton/npcm-video.c | 32 +++++++++++++++------\n 1 file changed, 23 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/media/platform/nuvoton/npcm-video.c b/drivers/media/platform/nuvoton/npcm-video.c\nindex 5c6bddfe8073..52505af35c08 100644\n--- a/drivers/media/platform/nuvoton/npcm-video.c\n+++ b/drivers/media/platform/nuvoton/npcm-video.c\n@@ -1750,42 +1750,55 @@ static int npcm_video_probe(struct platform_device *pdev)\n \tregs = devm_platform_ioremap_resource(pdev, 0);\n \tif (IS_ERR(regs)) {\n \t\tdev_err(&pdev->dev, \"Failed to parse VCD reg in DTS\\n\");\n-\t\treturn PTR_ERR(regs);\n+\t\trc = PTR_ERR(regs);\n+\t\tgoto err_free;\n \t}\n \n \tvideo->vcd_regmap = devm_regmap_init_mmio(&pdev->dev, regs,\n \t\t\t\t\t\t &npcm_video_regmap_cfg);\n \tif (IS_ERR(video->vcd_regmap)) {\n \t\tdev_err(&pdev->dev, \"Failed to initialize VCD regmap\\n\");\n-\t\treturn PTR_ERR(video->vcd_regmap);\n+\t\trc = PTR_ERR(video->vcd_regmap);\n+\t\tgoto err_free;\n \t}\n \n \tvideo->reset = devm_reset_control_get(&pdev->dev, NULL);\n \tif (IS_ERR(video->reset)) {\n \t\tdev_err(&pdev->dev, \"Failed to get VCD reset control in DTS\\n\");\n-\t\treturn PTR_ERR(video->reset);\n+\t\trc = PTR_ERR(video->reset);\n+\t\tgoto err_free;\n \t}\n \n \tvideo->gcr_regmap = syscon_regmap_lookup_by_phandle(pdev->dev.of_node,\n \t\t\t\t\t\t\t \"nuvoton,sysgcr\");\n-\tif (IS_ERR(video->gcr_regmap))\n-\t\treturn PTR_ERR(video->gcr_regmap);\n+\tif (IS_ERR(video->gcr_regmap)) {\n+\t\trc = PTR_ERR(video->gcr_regmap);\n+\t\tgoto err_free;\n+\t}\n \n \tvideo->gfx_regmap = syscon_regmap_lookup_by_phandle(pdev->dev.of_node,\n \t\t\t\t\t\t\t \"nuvoton,sysgfxi\");\n-\tif (IS_ERR(video->gfx_regmap))\n-\t\treturn PTR_ERR(video->gfx_regmap);\n+\tif (IS_ERR(video->gfx_regmap)) {\n+\t\trc = PTR_ERR(video->gfx_regmap);\n+\t\tgoto err_free;\n+\t}\n \n \trc = npcm_video_init(video);\n \tif (rc)\n-\t\treturn rc;\n+\t\tgoto err_free;\n \n \trc = npcm_video_setup_video(video);\n \tif (rc)\n-\t\treturn rc;\n+\t\tgoto err_release_mem;\n \n \tdev_info(video->dev, \"NPCM video driver probed\\n\");\n \treturn 0;\n+\n+err_release_mem:\n+\tof_reserved_mem_device_release(&pdev->dev);\n+err_free:\n+\tkfree(video);\n+\treturn rc;\n }\n \n static void npcm_video_remove(struct platform_device *pdev)\n@@ -1800,6 +1813,7 @@ static void npcm_video_remove(struct platform_device *pdev)\n \tv4l2_device_unregister(v4l2_dev);\n \tif (video->ece.enable)\n \t\tnpcm_video_ece_stop(video);\n+\tkfree(video);\n \tof_reserved_mem_device_release(dev);\n }\n \n", "prefixes": [ "v3", "2/2" ] }