Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2217915/?format=api
{ "id": 2217915, "url": "http://patchwork.ozlabs.org/api/patches/2217915/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openbmc/patch/20260328144644.67556-1-devnexen@gmail.com/", "project": { "id": 56, "url": "http://patchwork.ozlabs.org/api/projects/56/?format=api", "name": "OpenBMC development", "link_name": "openbmc", "list_id": "openbmc.lists.ozlabs.org", "list_email": "openbmc@lists.ozlabs.org", "web_url": "http://github.com/openbmc/", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260328144644.67556-1-devnexen@gmail.com>", "list_archive_url": null, "date": "2026-03-28T14:46:44", "name": "[v2,1/2] media: nuvoton: npcm-video: fix error handling in npcm_video_init()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "ee6e37587fbee3bf1af140972ded31e18c4ce4e0", "submitter": { "id": 76714, "url": "http://patchwork.ozlabs.org/api/people/76714/?format=api", "name": "David Carlier", "email": "devnexen@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/openbmc/patch/20260328144644.67556-1-devnexen@gmail.com/mbox/", "series": [ { "id": 498109, "url": "http://patchwork.ozlabs.org/api/series/498109/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openbmc/list/?series=498109", "date": "2026-03-28T14:46:44", "name": "[v2,1/2] media: nuvoton: npcm-video: fix error handling in npcm_video_init()", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/498109/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2217915/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2217915/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <openbmc+bounces-1752-incoming=patchwork.ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "openbmc@lists.ozlabs.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=CvFpQZjJ;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=openbmc+bounces-1752-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)", "lists.ozlabs.org;\n arc=none smtp.remote-ip=\"2a00:1450:4864:20::329\"", "lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com", "lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=CvFpQZjJ;\n\tdkim-atps=neutral", "lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com\n (client-ip=2a00:1450:4864:20::329; helo=mail-wm1-x329.google.com;\n envelope-from=devnexen@gmail.com; receiver=lists.ozlabs.org)" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fl5wN3spWz1y1q\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 31 Mar 2026 09:47:00 +1100 (AEDT)", "from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fl5w60gfHz2yhD;\n\tTue, 31 Mar 2026 09:46:46 +1100 (AEDT)", "from mail-wm1-x329.google.com (mail-wm1-x329.google.com\n [IPv6:2a00:1450:4864:20::329])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fjgMN4gLhz2xN8\n\tfor <openbmc@lists.ozlabs.org>; Sun, 29 Mar 2026 01:46:56 +1100 (AEDT)", "by mail-wm1-x329.google.com with SMTP id\n 5b1f17b1804b1-4852b81c73aso26711125e9.3\n for <openbmc@lists.ozlabs.org>; Sat, 28 Mar 2026 07:46:55 -0700 (PDT)", "from dohko.chello.ie (188-141-5-72.dynamic.upc.ie. [188.141.5.72])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48727bfc5ecsm91577275e9.1.2026.03.28.07.46.46\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sat, 28 Mar 2026 07:46:46 -0700 (PDT)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1774709218;\n\tcv=none;\n b=bS+1BowazkbApTm31X5EMiQnYSNMSFtsCrmWWTGHLrAkWz5sa0TNzXGJd6DBn7rClO0zs9elZ/3YUbiZb4k1Ur5aYMz8rhjhEtQkqyStaNtuBDg1nwpi2i+jlDn4PbzDd/lV/4VCrkW6LvN8rguWEfhSEt3ujWWlRyCNvgpesql8yLiEEsqg6eNsXj2oaQ4TvbNWHSwG9nF5dOuP/CTFy3XZRe/rviQgmvWQjuOX5QKbJR07eWOokhpEmHncKeKBVmLgOwUinOakAK+osZ4eF9NNYcU0qko37kblNyGI3oalwgEldmyhsTqrFUf5U6H+yAzt0nCviUOoZetQBnewfQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1774709218; c=relaxed/relaxed;\n\tbh=rprbcKOKh6LbVDBtx1L6evH/A6xyQAWdrHbB0AMy/jA=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=U57s6E8olx+smQepb4Q7qbceqxfc0u1xnznWtU6r0CCxDTPw1ZBTyQQCmAvn1l0nAYkIsrJQ83d82mBXC1AYykmRR7qyO1/HoRDcxP05WW5tKDNyEdgef3iWLaPADD87ihI8uhXRVK/JzGbk3kHuW6eQnPi3atcOLuSRArLoazQBGU5MgQ8dFTar6RprJ4xSV74ZZrUDKG8tEUikBouGOHNyUADwM85pVNCd3oVsal+Axstrn2bMN8CCttVDvdLNYt59z/wiLbk8iu8pVbSikSg8E8ZGge8+PJkJSKbQHPBJq1aNB2sy9N2QHs/brKdbhQv9EQQ9uDT99ISbYNo4ww==", "ARC-Authentication-Results": "i=1; lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com; dkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=CvFpQZjJ; dkim-atps=neutral;\n spf=pass (client-ip=2a00:1450:4864:20::329; helo=mail-wm1-x329.google.com;\n envelope-from=devnexen@gmail.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=gmail.com", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1774709208; x=1775314008;\n darn=lists.ozlabs.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=rprbcKOKh6LbVDBtx1L6evH/A6xyQAWdrHbB0AMy/jA=;\n b=CvFpQZjJyfvhMrEngnn4LNj1tBxjjabKR2TM3hPmJBDABYqgPOjN0WrpAFsNwgmTao\n IWVVGsIOC+GsEmx3SC39HlYt6oIWHKNmWxbW/bWv94BS+QI7GsqlMl4Ap3zSb53c8xxF\n XA1fHXOZMfnsW7AOPt05uUhBxAxOh4LkPFo0be4wqF1iLylypIEO2j5mriEcrRAg3cAs\n uDK9irUEUokYG5KckjepQXgxAjHKflP9FcpydxPYOPjSjVPEJAeIGP7pcpF2RnmB176t\n uDGGQe9SupcM+sCsOXKiTNHnF1t9qmZ62WO0XW+d22QqK3unxTImAIvmDveSFyjRRR9z\n G/Xg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774709208; x=1775314008;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=rprbcKOKh6LbVDBtx1L6evH/A6xyQAWdrHbB0AMy/jA=;\n b=cBa7g18WN9NFlTWKbtQM7ftXaRIYp3iDebSLhIkYVrfwViLXLgdVY2VVWNoNipP8XT\n 0eZkDrpZnaaTMOwG1l6Xu4yUGcNsHmYzD5tXR/ENmSLPl4USaR2E6mNHm+Ie6yitS1bR\n 0J7LHnpSWEtnZwb+zBkbVl6o7xDkLAX6jdp1IMa4oXfXkdyqpIeeVMlJJAVMpAZl7jRK\n oiSmfbGFRie5sNuLk0sJ6mtHjJqHvbjatHj9ZOqYTqJ5GGqVh0NqYuOIVZZ0eEOT37eX\n DvIEFWr6KCVm0av8ucjeTLZuUTANziFlSJNXL53lIiCmDPMwEzJ8AVDYt+e0dzkUSL6H\n 2V3A==", "X-Forwarded-Encrypted": "i=1;\n AJvYcCU0hidQ4tPz16atWGdHfhjhNN5kFlneU2moDr7g26xuRaxvIOJKb7Jw8RbT8D5Ib8hhv/kJuMUL@lists.ozlabs.org", "X-Gm-Message-State": "AOJu0YxuJa6+MmrM+G9HOAuVIWyW0ltf/kTS6GxDpCysiIVSp6HkATMd\n\t8CsZoZu4ODMdkHfI8MF7wvTk2oW+U2nKbjyA7XrKX5315Gy8iDNY0cRy", "X-Gm-Gg": "ATEYQzy7PybrVIJKPN63E3xs9tP7pItompBZJb5/eiGcfA3zZftHVOWQ5niKzKJXD11\n\t7EzCJ9nhfSD4YQVSGNupfP02Jy5UYHiZ8+nLIDuFH/CV/u3EbqY+2sxo4B2e+lvPAuauKAGTUYm\n\tT3na6qpumZHw84dn831tKQzHg6hRXlIOVkAcZ/nZrrLbTNTNO045b1yOp6tQWYkrxWC7ow9MD+3\n\tEW2T+TeTrGopcGIfAOLrPxXbJeZmFffwsB6WqSwrk/P0OB0g+7JaSFkeqUo139aNw6bj97Ee8Hr\n\t/a9MxhkBPdf1P1lGcpH4O+WNmRQumyRhyxgte6L/rK/wR7IjEWBagCchnd/2Ne4Rqr421PhTxja\n\t8YE9pHR9kkWyJ4CHXPBKrvM2mw3BcBp7FdkgnCAYrmOf+6n8jQkqI9vdFHBbW0xyzS/4dajtpD9\n\tItA0ak7F5Mh6JqxoVei33wEkyrOW2KIoCyrV2XFTeFBK3BLXurcJ9CncQpBTDYdGrdLyFINAmPW\n\toD93re+yi1ltt/LBS2tB6M=", "X-Received": "by 2002:a05:600c:1d86:b0:483:7783:537b with SMTP id\n 5b1f17b1804b1-4872807470fmr103447895e9.24.1774709207384;\n Sat, 28 Mar 2026 07:46:47 -0700 (PDT)", "From": "David Carlier <devnexen@gmail.com>", "To": "kwliu@nuvoton.com,\n\tkflin@nuvoton.com,\n\tmchehab@kernel.org", "Cc": "linux-media@vger.kernel.org,\n\topenbmc@lists.ozlabs.org,\n\tlinux-kernel@vger.kernel.org,\n\tDavid Carlier <devnexen@gmail.com>", "Subject": "[PATCH v2 1/2] media: nuvoton: npcm-video: fix error handling in\n npcm_video_init()", "Date": "Sat, 28 Mar 2026 14:46:44 +0000", "Message-ID": "<20260328144644.67556-1-devnexen@gmail.com>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260327221905.267410-1-devnexen@gmail.com>", "References": "<20260327221905.267410-1-devnexen@gmail.com>", "X-Mailing-List": "openbmc@lists.ozlabs.org", "List-Id": "<openbmc.lists.ozlabs.org>", "List-Help": "<mailto:openbmc+help@lists.ozlabs.org>", "List-Owner": "<mailto:openbmc+owner@lists.ozlabs.org>", "List-Post": "<mailto:openbmc@lists.ozlabs.org>", "List-Subscribe": "<mailto:openbmc+subscribe@lists.ozlabs.org>,\n <mailto:openbmc+subscribe-digest@lists.ozlabs.org>,\n <mailto:openbmc+subscribe-nomail@lists.ozlabs.org>", "List-Unsubscribe": "<mailto:openbmc+unsubscribe@lists.ozlabs.org>", "Precedence": "list", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Spam-Status": "No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tDKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,\n\tSPF_HELO_NONE,SPF_PASS autolearn=disabled version=4.0.1", "X-Spam-Checker-Version": "SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org" }, "content": "npcm_video_init() has two error handling issues after\nof_reserved_mem_device_init() is called:\n\nWhen dma_set_mask_and_coherent() fails, the function releases the\nreserved memory but does not return, allowing execution to fall through\ninto npcm_video_ece_init() with a failed DMA configuration.\n\nWhen npcm_video_ece_init() fails, the function returns an error without\ncalling of_reserved_mem_device_release(), leaking the reserved memory\nassociation.\n\nFix both by adding the missing return after the DMA mask failure and\nadding the missing of_reserved_mem_device_release() call on the ECE init\nerror path.\n\nFixes: 46c15a4ff1f4 (\"media: nuvoton: Add driver for NPCM video capture and encoding engine\")\nSigned-off-by: David Carlier <devnexen@gmail.com>\n---\n drivers/media/platform/nuvoton/npcm-video.c | 2 ++\n 1 file changed, 2 insertions(+)", "diff": "diff --git a/drivers/media/platform/nuvoton/npcm-video.c b/drivers/media/platform/nuvoton/npcm-video.c\nindex b2a562e1ee1c..5c6bddfe8073 100644\n--- a/drivers/media/platform/nuvoton/npcm-video.c\n+++ b/drivers/media/platform/nuvoton/npcm-video.c\n@@ -1720,10 +1720,12 @@ static int npcm_video_init(struct npcm_video *video)\n \tif (rc) {\n \t\tdev_err(dev, \"Failed to set DMA mask\\n\");\n \t\tof_reserved_mem_device_release(dev);\n+\t\treturn rc;\n \t}\n \n \trc = npcm_video_ece_init(video);\n \tif (rc) {\n+\t\tof_reserved_mem_device_release(dev);\n \t\tdev_err(dev, \"Failed to initialize ECE\\n\");\n \t\treturn rc;\n \t}\n", "prefixes": [ "v2", "1/2" ] }