Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2217914/?format=api
{ "id": 2217914, "url": "http://patchwork.ozlabs.org/api/patches/2217914/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openbmc/patch/20260328144718.68282-1-devnexen@gmail.com/", "project": { "id": 56, "url": "http://patchwork.ozlabs.org/api/projects/56/?format=api", "name": "OpenBMC development", "link_name": "openbmc", "list_id": "openbmc.lists.ozlabs.org", "list_email": "openbmc@lists.ozlabs.org", "web_url": "http://github.com/openbmc/", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260328144718.68282-1-devnexen@gmail.com>", "list_archive_url": null, "date": "2026-03-28T14:47:17", "name": "[v2,2/2] media: nuvoton: npcm-video: fix memory leaks in probe and remove", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "26f040f9b3e6ca6b70c72affce9880b07e88556c", "submitter": { "id": 76714, "url": "http://patchwork.ozlabs.org/api/people/76714/?format=api", "name": "David Carlier", "email": "devnexen@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/openbmc/patch/20260328144718.68282-1-devnexen@gmail.com/mbox/", "series": [ { "id": 498108, "url": "http://patchwork.ozlabs.org/api/series/498108/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openbmc/list/?series=498108", "date": "2026-03-28T14:47:17", "name": null, "version": 2, "mbox": "http://patchwork.ozlabs.org/series/498108/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2217914/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2217914/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <openbmc+bounces-1750-incoming=patchwork.ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "openbmc@lists.ozlabs.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=XtJqfp+g;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=openbmc+bounces-1750-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)", "lists.ozlabs.org;\n arc=none smtp.remote-ip=\"2a00:1450:4864:20::335\"", "lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com", "lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=XtJqfp+g;\n\tdkim-atps=neutral", "lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com\n (client-ip=2a00:1450:4864:20::335; helo=mail-wm1-x335.google.com;\n envelope-from=devnexen@gmail.com; receiver=lists.ozlabs.org)" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fl5w83qlVz1y1q\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 31 Mar 2026 09:46:47 +1100 (AEDT)", "from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fl5w470v5z2yTK;\n\tTue, 31 Mar 2026 09:46:44 +1100 (AEDT)", "from mail-wm1-x335.google.com (mail-wm1-x335.google.com\n [IPv6:2a00:1450:4864:20::335])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fjgMv5wWqz2xN8\n\tfor <openbmc@lists.ozlabs.org>; Sun, 29 Mar 2026 01:47:23 +1100 (AEDT)", "by mail-wm1-x335.google.com with SMTP id\n 5b1f17b1804b1-48558d6ef83so29449525e9.3\n for <openbmc@lists.ozlabs.org>; Sat, 28 Mar 2026 07:47:23 -0700 (PDT)", "from dohko.chello.ie (188-141-5-72.dynamic.upc.ie. [188.141.5.72])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43cf21f279bsm5077450f8f.16.2026.03.28.07.47.19\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sat, 28 Mar 2026 07:47:20 -0700 (PDT)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1774709244;\n\tcv=none;\n b=AaL/X2/LGeLIwlVhFIncJZNPHOf7Yn40AxVlEw0rUZHWA4lScmFr/wahaX91yh8z++7hRLfk0CAxl4gA6ejiCB9YrltFuI5p+ZOaeZaO5Bjs3wSuYvCciiOCBt94SNUZIZ0rOq3+xZVHrFUAJ58NRRVmY7RpGRcYaQPUY4KuLDkfoDY2Z0RlDkwcxSUz/xCxctaQspWb8wuTO/yA3XR+YdRdfRRHzg2HnfMSAuDeVEqD1rAUNmitYal/21BlIo5gfeu3BP6P890im4QHGK5WZdR6bRnizn9iTq1DCyBzdX6Pkx5YDkZ5ODttRZPsuhVdwKKX1FYXD49MnUBhkMEB9Q==", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1774709244; c=relaxed/relaxed;\n\tbh=MorpkP6r/T60MTiGCUcfsot6ur/wG/ccNFtLOYY+Uxo=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=Vv9GTcCuBIGcwULthHdHbXR8vzgawJyBqBLOo2fpgshpuqcfG6Yvs3FjVnKdVA3HFPqXkntOaYAAQFtEGHQNdCpA+pgNWJzbk7TGCO4IvGG2E0JcySyzFC6jc1ouwYDvtT9lufo9+c5MvglxiXxopvjEF5G2Y8RxqQ9VD8dK6XJHHUWVEv7sRWBOXQRLFsy09Ll6iRNIzb3jMljK2/yKG9xlT/sQX9IYpZkMRZeF95pjq9Mb0EBlmOxcFV06ECvnB85sGcXOJy8/piqZozKIW1gE6HKTCf1nTFqjjzZJhyE5QtDmabYOrweF7a8+5tEpeMvgrI/xvIDu51I81QQKLw==", "ARC-Authentication-Results": "i=1; lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com; dkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=XtJqfp+g; dkim-atps=neutral;\n spf=pass (client-ip=2a00:1450:4864:20::335; helo=mail-wm1-x335.google.com;\n envelope-from=devnexen@gmail.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=gmail.com", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1774709241; x=1775314041;\n darn=lists.ozlabs.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=MorpkP6r/T60MTiGCUcfsot6ur/wG/ccNFtLOYY+Uxo=;\n b=XtJqfp+gyKKNkmTzKrBjb4YA3BYKbZMibXm2RH2vlqLxg8nkCT4WSjHXRiSgghZoyn\n NFY51CYJL1CQHvpvcAehwztsrQrXiAs1homy1Ma0e8MsqxqiSh6OqOpv9rVYTvh026rp\n ts8WNGgLWgYO+JZ7bthDmSaP4NdkFgDsEF5MgcYu+wMX/c1ij3mjXmQ+xAcVL67ae+W6\n ER766cQ0XMUgGuLymEg4LBJ5SMxJ9KNEkqajXLUAeRb9n/tgD536nAj6b/M3jSzXYwOW\n zzkJey1mnR6LzHzS/D3d5g3SidPVHkHbYD/GNr8NihC/1a5Ol/TqyRL9ZBJTDTZH4TcI\n 2Hvw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774709241; x=1775314041;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=MorpkP6r/T60MTiGCUcfsot6ur/wG/ccNFtLOYY+Uxo=;\n b=asDP/FlgfTRwLL6gx7JcRmDESPnfv1DxyJOrQmysJCmjgaBcfGWifIpNq5BL/PeCOf\n leL6Subgglpe9uNbB/saQKflxEnmyEkOoKVLGuZJKmG1at7BFO9fgfXBuObPVID2LDh1\n 2/jzmzst117yvStdth4gFtxnwCjVhY5X0sp8bWYOh+gXj5rcA5u9FcwrkavQAudHKpZ2\n GWOqxHfRndXwpmb5YAuBeJovbiriMp1pdRZrvUPBSJvX+/BSC+awtkD6M47lZ8CdiTC3\n z6yYngnZgnrx88XAi1pwdhbftDQpcHC55qFW8YNBSg/O74W9/Ky5UR64FQv5T9xIfjpb\n uavg==", "X-Forwarded-Encrypted": "i=1;\n AJvYcCUqm7zGZC1Fdt3fnbB/33YF/jFv8IqQM+zTUfFWagLvSA5YlPMn1jtC/qz6irRQeXjSiqSlNAiy@lists.ozlabs.org", "X-Gm-Message-State": "AOJu0YyhkrOxZl2UXba0arGmUZP5jkJGOFa2ioEe3DgRhSoddKJSAuiY\n\tOSInO8g7PpZX254vZTJ3Q64iLy+O9uug4thLd38jjieRDc48xg/E493r64JI/CZZg+w=", "X-Gm-Gg": "ATEYQzyYA3gVLpsUgkwhg/gjjInzRSXk5389lA20SylejAYPB8MbntvUYyXmnXoaAV/\n\ttnAczg1iwh5V/0tmGqpEnju2pSivqLuFnAjVulLyOuRne8rhYEx+wKfWd7CurTxW9GWI09eYnhb\n\tRPyue6zBLJxgjqkEQPD8MlZr//1vcbj77sjAH7Uj4bYsTpfoMuS7CZDByuqYGMlxdaCK2MEqPS9\n\tt+Yj/xeYnKRyAfKMyoty5LQQeiD9VF1RfvM27HlGN8tHdxAtNzx3zPxQDm0k47/oua5gCJIXbkq\n\tTilozKxbAUQCsCixV+gkcfWhaX60nIfUY0Bz43I+1M1Q/A1w5J6a0uHTEBD1zuD5fcdhWR1Dv/9\n\tJwTPFzjWxoDniQ6PfXQYzv96G1NOuu7IfLOhMegVtsk8c9MyjxYC6jms2g+L9wIkY3CsfZlLVNj\n\ttuViwQqPUa1nvYnOWHC93X6L58Jyk5keN9caqjLHF1StrQTkYli2vjxVa0/zuWwjTWUR7befX6/\n\tUOT6I2o1/O+", "X-Received": "by 2002:a05:600c:6287:b0:485:3b5b:eb8 with SMTP id\n 5b1f17b1804b1-48727ef6617mr104982175e9.26.1774709240531;\n Sat, 28 Mar 2026 07:47:20 -0700 (PDT)", "From": "David Carlier <devnexen@gmail.com>", "To": "kwliu@nuvoton.com,\n\tkflin@nuvoton.com,\n\tmchehab@kernel.org", "Cc": "linux-media@vger.kernel.org,\n\topenbmc@lists.ozlabs.org,\n\tlinux-kernel@vger.kernel.org,\n\tDavid Carlier <devnexen@gmail.com>", "Subject": "[PATCH v2 2/2] media: nuvoton: npcm-video: fix memory leaks in probe\n and remove", "Date": "Sat, 28 Mar 2026 14:47:17 +0000", "Message-ID": "<20260328144718.68282-1-devnexen@gmail.com>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260327221905.267410-2-devnexen@gmail.com>", "References": "<20260327221905.267410-2-devnexen@gmail.com>", "X-Mailing-List": "openbmc@lists.ozlabs.org", "List-Id": "<openbmc.lists.ozlabs.org>", "List-Help": "<mailto:openbmc+help@lists.ozlabs.org>", "List-Owner": "<mailto:openbmc+owner@lists.ozlabs.org>", "List-Post": "<mailto:openbmc@lists.ozlabs.org>", "List-Subscribe": "<mailto:openbmc+subscribe@lists.ozlabs.org>,\n <mailto:openbmc+subscribe-digest@lists.ozlabs.org>,\n <mailto:openbmc+subscribe-nomail@lists.ozlabs.org>", "List-Unsubscribe": "<mailto:openbmc+unsubscribe@lists.ozlabs.org>", "Precedence": "list", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Spam-Status": "No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tDKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,\n\tSPF_HELO_NONE,SPF_PASS autolearn=disabled version=4.0.1", "X-Spam-Checker-Version": "SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org" }, "content": "npcm_video_probe() allocates the npcm_video structure with kzalloc_obj()\nbut never frees it on any probe error path or in npcm_video_remove(),\nleaking the allocation on every failed probe and every normal unbind.\n\nAdditionally, when npcm_video_setup_video() fails, the reserved memory\nassociation established by of_reserved_mem_device_init() in\nnpcm_video_init() is not released, leaking the rmem_assigned_device\nentry on the global list.\n\nFix both by adding kfree(video) to all probe error paths and to\nnpcm_video_remove(), and adding the missing\nof_reserved_mem_device_release() call when npcm_video_setup_video()\nfails.\n\nFixes: 46c15a4ff1f4 (\"media: nuvoton: Add driver for NPCM video capture and encoding engine\")\nSigned-off-by: David Carlier <devnexen@gmail.com>\n---\n drivers/media/platform/nuvoton/npcm-video.c | 21 +++++++++++++++++----\n 1 file changed, 17 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/media/platform/nuvoton/npcm-video.c b/drivers/media/platform/nuvoton/npcm-video.c\nindex 5c6bddfe8073..87b09979cc52 100644\n--- a/drivers/media/platform/nuvoton/npcm-video.c\n+++ b/drivers/media/platform/nuvoton/npcm-video.c\n@@ -1749,6 +1749,7 @@ static int npcm_video_probe(struct platform_device *pdev)\n \n \tregs = devm_platform_ioremap_resource(pdev, 0);\n \tif (IS_ERR(regs)) {\n+\t\tkfree(video);\n \t\tdev_err(&pdev->dev, \"Failed to parse VCD reg in DTS\\n\");\n \t\treturn PTR_ERR(regs);\n \t}\n@@ -1756,33 +1757,44 @@ static int npcm_video_probe(struct platform_device *pdev)\n \tvideo->vcd_regmap = devm_regmap_init_mmio(&pdev->dev, regs,\n \t\t\t\t\t\t &npcm_video_regmap_cfg);\n \tif (IS_ERR(video->vcd_regmap)) {\n+\t\tkfree(video);\n \t\tdev_err(&pdev->dev, \"Failed to initialize VCD regmap\\n\");\n \t\treturn PTR_ERR(video->vcd_regmap);\n \t}\n \n \tvideo->reset = devm_reset_control_get(&pdev->dev, NULL);\n \tif (IS_ERR(video->reset)) {\n+\t\tkfree(video);\n \t\tdev_err(&pdev->dev, \"Failed to get VCD reset control in DTS\\n\");\n \t\treturn PTR_ERR(video->reset);\n \t}\n \n \tvideo->gcr_regmap = syscon_regmap_lookup_by_phandle(pdev->dev.of_node,\n \t\t\t\t\t\t\t \"nuvoton,sysgcr\");\n-\tif (IS_ERR(video->gcr_regmap))\n+\tif (IS_ERR(video->gcr_regmap)) {\n+\t\tkfree(video);\n \t\treturn PTR_ERR(video->gcr_regmap);\n+\t}\n \n \tvideo->gfx_regmap = syscon_regmap_lookup_by_phandle(pdev->dev.of_node,\n \t\t\t\t\t\t\t \"nuvoton,sysgfxi\");\n-\tif (IS_ERR(video->gfx_regmap))\n+\tif (IS_ERR(video->gfx_regmap)) {\n+\t\tkfree(video);\n \t\treturn PTR_ERR(video->gfx_regmap);\n+\t}\n \n \trc = npcm_video_init(video);\n-\tif (rc)\n+\tif (rc) {\n+\t\tkfree(video);\n \t\treturn rc;\n+\t}\n \n \trc = npcm_video_setup_video(video);\n-\tif (rc)\n+\tif (rc) {\n+\t\tof_reserved_mem_device_release(&pdev->dev);\n+\t\tkfree(video);\n \t\treturn rc;\n+\t}\n \n \tdev_info(video->dev, \"NPCM video driver probed\\n\");\n \treturn 0;\n@@ -1800,6 +1812,7 @@ static void npcm_video_remove(struct platform_device *pdev)\n \tv4l2_device_unregister(v4l2_dev);\n \tif (video->ece.enable)\n \t\tnpcm_video_ece_stop(video);\n+\tkfree(video);\n \tof_reserved_mem_device_release(dev);\n }\n \n", "prefixes": [ "v2", "2/2" ] }