Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2217911/?format=api
{ "id": 2217911, "url": "http://patchwork.ozlabs.org/api/patches/2217911/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260330-aoa-i2sbus-clear-stale-active-v1-1-47a6c0a3ac9e@gmail.com/", "project": { "id": 2, "url": "http://patchwork.ozlabs.org/api/projects/2/?format=api", "name": "Linux PPC development", "link_name": "linuxppc-dev", "list_id": "linuxppc-dev.lists.ozlabs.org", "list_email": "linuxppc-dev@lists.ozlabs.org", "web_url": "https://github.com/linuxppc/wiki/wiki", "scm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git", "webscm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/", "list_archive_url_format": "https://lore.kernel.org/linuxppc-dev/{}/", "commit_url_format": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}" }, "msgid": "<20260330-aoa-i2sbus-clear-stale-active-v1-1-47a6c0a3ac9e@gmail.com>", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/20260330-aoa-i2sbus-clear-stale-active-v1-1-47a6c0a3ac9e@gmail.com/", "date": "2026-03-30T22:27:28", "name": "ALSA: aoa: i2sbus: clear stale prepared state", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "d12f7cb520faa8433d49a4fb5b541b52216e90ee", "submitter": { "id": 93004, "url": "http://patchwork.ozlabs.org/api/people/93004/?format=api", "name": "Cássio Gabriel", "email": "cassiogabrielcontato@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260330-aoa-i2sbus-clear-stale-active-v1-1-47a6c0a3ac9e@gmail.com/mbox/", "series": [ { "id": 498105, "url": "http://patchwork.ozlabs.org/api/series/498105/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=498105", "date": "2026-03-30T22:27:28", "name": "ALSA: aoa: i2sbus: clear stale prepared state", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/498105/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2217911/comments/", "check": "fail", "checks": "http://patchwork.ozlabs.org/api/patches/2217911/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linuxppc-dev+bounces-19036-incoming=patchwork.ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=IfoBHXy8;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19036-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)", "lists.ozlabs.org;\n arc=none smtp.remote-ip=\"2607:f8b0:4864:20::122a\"", "lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com", "lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=IfoBHXy8;\n\tdkim-atps=neutral", "lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com\n (client-ip=2607:f8b0:4864:20::122a; helo=mail-dl1-x122a.google.com;\n envelope-from=cassiogabrielcontato@gmail.com; receiver=lists.ozlabs.org)" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fl5VK757zz1yCp\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 31 Mar 2026 09:27:52 +1100 (AEDT)", "from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fl5VJ1thmz2yhV;\n\tTue, 31 Mar 2026 09:27:52 +1100 (AEDT)", "from mail-dl1-x122a.google.com (mail-dl1-x122a.google.com\n [IPv6:2607:f8b0:4864:20::122a])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fl5VG4fkMz2xGF\n\tfor <linuxppc-dev@lists.ozlabs.org>; Tue, 31 Mar 2026 09:27:49 +1100 (AEDT)", "by mail-dl1-x122a.google.com with SMTP id\n a92af1059eb24-126ea4e9694so1281557c88.1\n for <linuxppc-dev@lists.ozlabs.org>;\n Mon, 30 Mar 2026 15:27:49 -0700 (PDT)", "from [192.168.1.18] (177-4-161-254.user3p.v-tal.net.br.\n [177.4.161.254])\n by smtp.gmail.com with ESMTPSA id\n a92af1059eb24-12ac09e3872sm10025298c88.13.2026.03.30.15.27.44\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 30 Mar 2026 15:27:46 -0700 (PDT)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1774909672;\n\tcv=none;\n b=W/DBA3smH/8oTly0SKy5JDDWck4rEuAz+0xZ0KMFoEHJdYvBRN3toVsS7EBJIc9+dD1Ffc64ozFKsi5i+1Y9cCNuEdO9J+Cpo4BHum+9XzE0JletGKMK9ONc8kYru6VGC1MlOVOPR2JB6SKHJnoythnP8aKXW+PclXOduT7WidV/JBylfw7iy3eD+p0p7qv0XQRaScbkH3K2UzyzCj6qIvGQMI6ROvQc5bt5g/kcPnp8GRinXqxEjOzujijowDeGwGlZSfJvpfWLuMw/n7wY8aG9ZrOgfqG8pvWvCjJu0OFYvJWHxOW7+j8cTLf0ej6C9wPQ4ZPuF0n87EURGOknPg==", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1774909672; c=relaxed/relaxed;\n\tbh=lzyAsYuDiypzhr0nJOs3r8SDJ+17St3td4xXEfgjRxY=;\n\th=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc;\n b=l8yT4TlP/eGMXZWiUUCo1nNTIpfLbvJzIjLOPpahT6dxdCbVWnhrdYIg2RO32DXocOLRjVgCrckPH3Ti35vX6w1mrLwJ0HVlOdUFpZ4AWf9di+htQfi6agEN6sHy+rxrbxwV+hR7vYXw0Bij5ip71spQ2ik42sDDefY7P8za/Tgk7tbZ4z85TyKlu1hPJ3rTCwl3I9mIW0M3xs5IXEiJwQOfOasVK9szuHTYYLNF1TNVh1SAL/IWnrzJahEya4ChAbdy1WH5e9lkAFfEeZyezoxAN/sL+D2602UpFXELuI+rP4c6/fgHH3gzO5qk46C1PgVKpqv0uE9rZc6f2zB4Sw==", "ARC-Authentication-Results": "i=1; lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com; dkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=IfoBHXy8; dkim-atps=neutral;\n spf=pass (client-ip=2607:f8b0:4864:20::122a; helo=mail-dl1-x122a.google.com;\n envelope-from=cassiogabrielcontato@gmail.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=gmail.com", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1774909667; x=1775514467;\n darn=lists.ozlabs.org;\n h=cc:to:message-id:content-transfer-encoding:mime-version:subject\n :date:from:from:to:cc:subject:date:message-id:reply-to;\n bh=lzyAsYuDiypzhr0nJOs3r8SDJ+17St3td4xXEfgjRxY=;\n b=IfoBHXy8EvdmSSaztHdKpH+Y5l2wC7VWnsnrkGLtacAv/26TXfVyDxIbdxclJFFviq\n 18bG9l0QOc35Ah2215YMaZzPKkHUDdR0kTQg8rivnlz6uhfRKgi1W2uVI+DvOrjeGb88\n NEhja/31RjW2GrM02o/SLGaTc08/eDLa5KPF4KZ59g9Uel1fo3FaGUy50xo6PiyZ0myG\n kSoCbkVHwXlqZ4WU2cmlDM8/U8tkUG7sjvIvCn8/mUpwyKqkymZD2uonsmNWuhK0pdkD\n jsFlbuUyhQDc2kte8vKzVY7Qw1SmgIJ9ctZisjJG3oLLHhoEfqGlObggeK1vnT//xiJE\n q+IQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774909667; x=1775514467;\n h=cc:to:message-id:content-transfer-encoding:mime-version:subject\n :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=lzyAsYuDiypzhr0nJOs3r8SDJ+17St3td4xXEfgjRxY=;\n b=XgefiucHUVNpSqk41PZhnFEbkr7DYMDMT9bDDBd53tcYg+ZiMWOF5vS8q2rPB20h27\n 2c39QJ0t49u2wwqAfdho9jxTUORPuTeJBsWc3RJrTNzC8A8Ntqy0TMV0mCyXAfObVaec\n 3JSykAaSa2apcQuy/tkkB8k+CQlUYsaOY9tTPjimDwDJW27GTZr/O4GH5RAczq9NUIA6\n G2qzMpyBfhpNmLLlqbVuojP2RZBtjrsWZ1x55Vv1BSU+pnxapjj273Gi5AGO0MFAegc+\n Ny2RNWCwILQE9yYqRHtj2hc4luUqAmsYp+sAfxK2Jy6FLzZL6/3nVzsprQDCvHOmEgLs\n R7eQ==", "X-Gm-Message-State": "AOJu0YyaX+iehGYv9NWpMEP4Gi88tWh0oI0wehpGwqwcPSWJUNl+6EhU\n\tiO29XdmSy8AdoLzm4axv5atRVh02cmqT3yC92sb52dRfdlfeLO1gnyj3", "X-Gm-Gg": "ATEYQzy58x1TPT6iuvvm1TenWwc/yL44ez35xqCI9bjb0MkubqzvEjcybVAUu1O/Usx\n\tsRwplmytvNsVW1/kEUPfpOvqMpO0opJ/EdCcxAdQXbV2vyvK4wOTQ7G/wFLEJJ85cGiMZHI0h3L\n\tMGA3qEycrwrJGb7tcBg+v8KZcyKdcNRfgnr2LZxQgd8AcRlbBRta36k3kN5NOPK4w4G+AMHMN+b\n\tt8kkplXNk2zMknwfJ+tl4L3suHY2QL1l0Wh986OQg3YUVL+il/duGZtznhSyWR1PxmEGd7oseEB\n\te1ALO1LSAvV6G+EbeS0nOGRTuZkQgR8/qGnNb9USMBgDIDoIqjAYfsF+Z5iWAxIQWPaKsV0Gxdx\n\tN58ZnJgnMQwXHSnr2bEu0DlusqsQ/ohdozJLVsD1pjMhYXh4q5kW44c6GVnAxkHewiKdDyCPqPH\n\tRQb2ve9cOLAO2abGWeGGRapE6ozNZtFUncLp/Br1kW0IXCGQ4RGZ+4VHOD5YYE5VqWjKHYwVtzg\n\tB5RtxQdAf1UFHQ=", "X-Received": "by 2002:a05:7022:b98:b0:127:33e0:ea33 with SMTP id\n a92af1059eb24-12ab28e4da2mr8360408c88.22.1774909666880;\n Mon, 30 Mar 2026 15:27:46 -0700 (PDT)", "From": "=?utf-8?q?C=C3=A1ssio_Gabriel?= <cassiogabrielcontato@gmail.com>", "Date": "Mon, 30 Mar 2026 19:27:28 -0300", "Subject": "[PATCH] ALSA: aoa: i2sbus: clear stale prepared state", "X-Mailing-List": "linuxppc-dev@lists.ozlabs.org", "List-Id": "<linuxppc-dev.lists.ozlabs.org>", "List-Help": "<mailto:linuxppc-dev+help@lists.ozlabs.org>", "List-Owner": "<mailto:linuxppc-dev+owner@lists.ozlabs.org>", "List-Post": "<mailto:linuxppc-dev@lists.ozlabs.org>", "List-Archive": "<https://lore.kernel.org/linuxppc-dev/>,\n <https://lists.ozlabs.org/pipermail/linuxppc-dev/>", "List-Subscribe": "<mailto:linuxppc-dev+subscribe@lists.ozlabs.org>,\n <mailto:linuxppc-dev+subscribe-digest@lists.ozlabs.org>,\n <mailto:linuxppc-dev+subscribe-nomail@lists.ozlabs.org>", "List-Unsubscribe": "<mailto:linuxppc-dev+unsubscribe@lists.ozlabs.org>", "Precedence": "list", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "\n <20260330-aoa-i2sbus-clear-stale-active-v1-1-47a6c0a3ac9e@gmail.com>", "X-B4-Tracking": "v=1; b=H4sIAAAAAAAC/yXMwQqCQBAG4FeROTewrWHUq0SH2fG3JkRjR0UQ3\n 72tjt/l28iRDU7XaqOMxdzGoeB4qEifMjzA1hZTDLEJdbywjMIWPc3O2kMy+yQ9WHSyBXxq63Q\n OjWpAR+V4Z3S2/v7b/W+f0ws6fVPa9w/IFGDhgQAAAA==", "X-Change-ID": "20260329-aoa-i2sbus-clear-stale-active-4d3b706cc0ef", "To": "Johannes Berg <johannes@sipsolutions.net>,\n Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>", "Cc": "linuxppc-dev@lists.ozlabs.org, linux-sound@vger.kernel.org,\n linux-kernel@vger.kernel.org, stable@vger.kernel.org, =?utf-8?q?C=C3=A1ssi?=\n\t=?utf-8?q?o_Gabriel?= <cassiogabrielcontato@gmail.com>", "X-Mailer": "b4 0.15.1", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=5868;\n i=cassiogabrielcontato@gmail.com; h=from:subject:message-id;\n bh=b41s+FN6uiztHgjfDAeztxkSjquTUWhRy3iOENgs/Tg=;\n b=owGbwMvMwCV2IdZeKur/u2bG02pJDJmnftzW7coz2LdKSCMkoOHoyiO9dRvY1pz01FLj4lq+/\n Lb5kRbmjlIWBjEuBlkxRZbVSYss93Q9uFoft8IDZg4rE8gQBi5OAZhIegXDX/kpFfZ6GZadE9fv\n 8FNZzT3n9Orsnx3/pK4eVmTpqVHbmcjIsNhoe9XiF2ffhTXUZn0Uf+J2ynvS9r3/y6sauGxuS0z\n W4gQA", "X-Developer-Key": "i=cassiogabrielcontato@gmail.com; a=openpgp;\n fpr=AB62A239BC8AE0D57F5EA848D05D3F1A5AFFEE83", "X-Spam-Status": "No, score=-0.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tDKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,\n\tSPF_HELO_NONE,SPF_PASS autolearn=disabled version=4.0.1 OzLabs 8", "X-Spam-Checker-Version": "SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org" }, "content": "The i2sbus PCM code uses pi->active to constrain the sibling stream to\nan already prepared duplex format and rate in i2sbus_pcm_open().\n\nThat state is set from i2sbus_pcm_prepare(), but the current code only\nclears it on close. As a result, the sibling stream can inherit stale\nconstraints after the prepared state has been torn down, or after a new\nprepare attempt fails before completing.\n\nClear pi->active when hw_params() or hw_free() drops the prepared state,\nclear it before starting a new prepare attempt, and set it again only\nafter prepare succeeds.\n\nReplace the stale FIXME in the duplex constraint comment with\na description of the current driver behavior: i2sbus still programs a\nsingle shared transport configuration for both directions, so mixed\nformats are not supported in duplex mode.\n\nFixes: f3d9478b2ce4 (\"[ALSA] snd-aoa: add snd-aoa\")\nCc: stable@vger.kernel.org\nSigned-off-by: Cássio Gabriel <cassiogabrielcontato@gmail.com>\n---\n sound/aoa/soundbus/i2sbus/pcm.c | 53 ++++++++++++++++++++++++++++++++---------\n 1 file changed, 42 insertions(+), 11 deletions(-)\n\n\n---\nbase-commit: 46a6512f4a74dd7b18d9a455669c226843fc49ce\nchange-id: 20260329-aoa-i2sbus-clear-stale-active-4d3b706cc0ef\n\nBest regards,\n-- \nCássio Gabriel <cassiogabrielcontato@gmail.com>", "diff": "diff --git a/sound/aoa/soundbus/i2sbus/pcm.c b/sound/aoa/soundbus/i2sbus/pcm.c\nindex 97c807e67d56..47a89da43cff 100644\n--- a/sound/aoa/soundbus/i2sbus/pcm.c\n+++ b/sound/aoa/soundbus/i2sbus/pcm.c\n@@ -165,17 +165,16 @@ static int i2sbus_pcm_open(struct i2sbus_dev *i2sdev, int in)\n \t * currently in use (if any). */\n \thw->rate_min = 5512;\n \thw->rate_max = 192000;\n-\t/* if the other stream is active, then we can only\n-\t * support what it is currently using.\n-\t * FIXME: I lied. This comment is wrong. We can support\n-\t * anything that works with the same serial format, ie.\n-\t * when recording 24 bit sound we can well play 16 bit\n-\t * sound at the same time iff using the same transfer mode.\n+\t/* If the other stream is already prepared, keep this stream\n+\t * on the same duplex format and rate.\n+\t *\n+\t * i2sbus_pcm_prepare() still programs one shared transport\n+\t * configuration for both directions, so mixed duplex formats\n+\t * are not supported here.\n \t */\n \tif (other->active) {\n-\t\t/* FIXME: is this guaranteed by the alsa api? */\n \t\thw->formats &= pcm_format_to_bits(i2sdev->format);\n-\t\t/* see above, restrict rates to the one we already have */\n+\t\t/* Restrict rates to the one already in use. */\n \t\thw->rate_min = i2sdev->rate;\n \t\thw->rate_max = i2sdev->rate;\n \t}\n@@ -283,6 +282,22 @@ void i2sbus_wait_for_stop_both(struct i2sbus_dev *i2sdev)\n }\n #endif\n \n+static void i2sbus_pcm_clear_active(struct i2sbus_dev *i2sdev, int in)\n+{\n+\tstruct pcm_info *pi;\n+\n+\tguard(mutex)(&i2sdev->lock);\n+\n+\tget_pcm_info(i2sdev, in, &pi, NULL);\n+\tpi->active = 0;\n+}\n+\n+static inline int i2sbus_hw_params(struct snd_pcm_substream *substream, int in)\n+{\n+\ti2sbus_pcm_clear_active(snd_pcm_substream_chip(substream), in);\n+\treturn 0;\n+}\n+\n static inline int i2sbus_hw_free(struct snd_pcm_substream *substream, int in)\n {\n \tstruct i2sbus_dev *i2sdev = snd_pcm_substream_chip(substream);\n@@ -291,14 +306,25 @@ static inline int i2sbus_hw_free(struct snd_pcm_substream *substream, int in)\n \tget_pcm_info(i2sdev, in, &pi, NULL);\n \tif (pi->dbdma_ring.stopping)\n \t\ti2sbus_wait_for_stop(i2sdev, pi);\n+\ti2sbus_pcm_clear_active(i2sdev, in);\n \treturn 0;\n }\n \n+static int i2sbus_playback_hw_params(struct snd_pcm_substream *substream)\n+{\n+\treturn i2sbus_hw_params(substream, 0);\n+}\n+\n static int i2sbus_playback_hw_free(struct snd_pcm_substream *substream)\n {\n \treturn i2sbus_hw_free(substream, 0);\n }\n \n+static int i2sbus_record_hw_params(struct snd_pcm_substream *substream)\n+{\n+\treturn i2sbus_hw_params(substream, 1);\n+}\n+\n static int i2sbus_record_hw_free(struct snd_pcm_substream *substream)\n {\n \treturn i2sbus_hw_free(substream, 1);\n@@ -335,7 +361,7 @@ static int i2sbus_pcm_prepare(struct i2sbus_dev *i2sdev, int in)\n \t\treturn -EINVAL;\n \n \truntime = pi->substream->runtime;\n-\tpi->active = 1;\n+\tpi->active = 0;\n \tif (other->active &&\n \t ((i2sdev->format != runtime->format)\n \t || (i2sdev->rate != runtime->rate)))\n@@ -444,9 +470,11 @@ static int i2sbus_pcm_prepare(struct i2sbus_dev *i2sdev, int in)\n \n \t/* early exit if already programmed correctly */\n \t/* not locking these is fine since we touch them only in this function */\n-\tif (in_le32(&i2sdev->intfregs->serial_format) == sfr\n-\t && in_le32(&i2sdev->intfregs->data_word_sizes) == dws)\n+\tif (in_le32(&i2sdev->intfregs->serial_format) == sfr &&\n+\t in_le32(&i2sdev->intfregs->data_word_sizes) == dws) {\n+\t\tpi->active = 1;\n \t\treturn 0;\n+\t}\n \n \t/* let's notify the codecs about clocks going away.\n \t * For now we only do mastering on the i2s cell... */\n@@ -484,6 +512,7 @@ static int i2sbus_pcm_prepare(struct i2sbus_dev *i2sdev, int in)\n \t\tif (cii->codec->switch_clock)\n \t\t\tcii->codec->switch_clock(cii, CLOCK_SWITCH_SLAVE);\n \n+\tpi->active = 1;\n \treturn 0;\n }\n \n@@ -728,6 +757,7 @@ static snd_pcm_uframes_t i2sbus_playback_pointer(struct snd_pcm_substream\n static const struct snd_pcm_ops i2sbus_playback_ops = {\n \t.open =\t\ti2sbus_playback_open,\n \t.close =\ti2sbus_playback_close,\n+\t.hw_params =\ti2sbus_playback_hw_params,\n \t.hw_free =\ti2sbus_playback_hw_free,\n \t.prepare =\ti2sbus_playback_prepare,\n \t.trigger =\ti2sbus_playback_trigger,\n@@ -796,6 +826,7 @@ static snd_pcm_uframes_t i2sbus_record_pointer(struct snd_pcm_substream\n static const struct snd_pcm_ops i2sbus_record_ops = {\n \t.open =\t\ti2sbus_record_open,\n \t.close =\ti2sbus_record_close,\n+\t.hw_params =\ti2sbus_record_hw_params,\n \t.hw_free =\ti2sbus_record_hw_free,\n \t.prepare =\ti2sbus_record_prepare,\n \t.trigger =\ti2sbus_record_trigger,\n", "prefixes": [] }