Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2217861/?format=api
{ "id": 2217861, "url": "http://patchwork.ozlabs.org/api/patches/2217861/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260330190508.8634-3-farosas@suse.de/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260330190508.8634-3-farosas@suse.de>", "list_archive_url": null, "date": "2026-03-30T19:05:07", "name": "[PULL,2/3] migration: Fix references to parameter names in error messages", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "70253b8ae5aa39182f12456a5888f7ae5ddf8f26", "submitter": { "id": 85343, "url": "http://patchwork.ozlabs.org/api/people/85343/?format=api", "name": "Fabiano Rosas", "email": "farosas@suse.de" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260330190508.8634-3-farosas@suse.de/mbox/", "series": [ { "id": 498081, "url": "http://patchwork.ozlabs.org/api/series/498081/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=498081", "date": "2026-03-30T19:05:06", "name": "[PULL,1/3] migration: Fix up error message for max-cpu-throttle", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/498081/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2217861/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2217861/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=zk/NBMhh;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=f8AtCTnn;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=zk/NBMhh;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=f8AtCTnn;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)", "smtp-out1.suse.de;\n dkim=pass header.d=suse.de header.s=susede2_rsa header.b=\"zk/NBMhh\";\n dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=f8AtCTnn" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fl11Z6RxRz1xtJ\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 31 Mar 2026 06:06:10 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w7Hw2-00046R-AM; Mon, 30 Mar 2026 15:06:02 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <farosas@suse.de>) id 1w7HvX-0003pC-EG\n for qemu-devel@nongnu.org; Mon, 30 Mar 2026 15:05:33 -0400", "from smtp-out1.suse.de ([2a07:de40:b251:101:10:150:64:1])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <farosas@suse.de>) id 1w7HvT-0005DL-BP\n for qemu-devel@nongnu.org; Mon, 30 Mar 2026 15:05:30 -0400", "from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org\n [IPv6:2a07:de40:b281:104:10:150:64:97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out1.suse.de (Postfix) with ESMTPS id B48004D533;\n Mon, 30 Mar 2026 19:05:13 +0000 (UTC)", "from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id BAB1E4A0A2;\n Mon, 30 Mar 2026 19:05:12 +0000 (UTC)", "from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id yPA4ImjJymlGdQAAD6G6ig\n (envelope-from <farosas@suse.de>); Mon, 30 Mar 2026 19:05:12 +0000" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1774897513;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=QbhTYF27d4quzV9aPtNfi9/ss0fDuKO62BO9wUgx+rw=;\n b=zk/NBMhhgaKzGWfe7bCQNushUCuMfWVyG4LC7o7yKGunbXwLHpZBy5PK4/EYT5GHKGTC+G\n 3Qi7nUMl0BLQY3nh6QPgTAuuWZW+0/DuafmAkcLl6DcE7E5S4iDxqjxWZyQkh7edvr2hxd\n lLzj1RPevYcElwGGumWbX1adJAgXcr8=", "v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1774897513;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=QbhTYF27d4quzV9aPtNfi9/ss0fDuKO62BO9wUgx+rw=;\n b=f8AtCTnn8cfFN48OwRgIfvsyzg+Ou687NzQBaFAFp8+DZpSLUCqznZSdbW3LB0g1xbotXq\n gtf93wLu6uXRk9BA==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1774897513;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=QbhTYF27d4quzV9aPtNfi9/ss0fDuKO62BO9wUgx+rw=;\n b=zk/NBMhhgaKzGWfe7bCQNushUCuMfWVyG4LC7o7yKGunbXwLHpZBy5PK4/EYT5GHKGTC+G\n 3Qi7nUMl0BLQY3nh6QPgTAuuWZW+0/DuafmAkcLl6DcE7E5S4iDxqjxWZyQkh7edvr2hxd\n lLzj1RPevYcElwGGumWbX1adJAgXcr8=", "v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1774897513;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=QbhTYF27d4quzV9aPtNfi9/ss0fDuKO62BO9wUgx+rw=;\n b=f8AtCTnn8cfFN48OwRgIfvsyzg+Ou687NzQBaFAFp8+DZpSLUCqznZSdbW3LB0g1xbotXq\n gtf93wLu6uXRk9BA==" ], "From": "Fabiano Rosas <farosas@suse.de>", "To": "qemu-devel@nongnu.org", "Cc": "Peter Xu <peterx@redhat.com>,\n\tMarkus Armbruster <armbru@redhat.com>", "Subject": "[PULL 2/3] migration: Fix references to parameter names in error\n messages", "Date": "Mon, 30 Mar 2026 16:05:07 -0300", "Message-ID": "<20260330190508.8634-3-farosas@suse.de>", "X-Mailer": "git-send-email 2.51.0", "In-Reply-To": "<20260330190508.8634-1-farosas@suse.de>", "References": "<20260330190508.8634-1-farosas@suse.de>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Rspamd-Action": "no action", "X-Rspamd-Server": "rspamd2.dmz-prg2.suse.org", "X-Spamd-Result": "default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[100.00%];\n MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000];\n R_MISSING_CHARSET(0.50)[];\n R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain];\n MX_GOOD(-0.01)[];\n DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.de:dkim,suse.de:mid,suse.de:email];\n FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+];\n SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from];\n TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[];\n RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_EQ_ENVFROM(0.00)[];\n DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_COUNT_TWO(0.00)[2];\n RCVD_TLS_ALL(0.00)[]; RCPT_COUNT_THREE(0.00)[3];\n DKIM_TRACE(0.00)[suse.de:+]", "X-Rspamd-Queue-Id": "B48004D533", "X-Spam-Score": "-3.01", "Received-SPF": "pass client-ip=2a07:de40:b251:101:10:150:64:1;\n envelope-from=farosas@suse.de; helo=smtp-out1.suse.de", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Markus Armbruster <armbru@redhat.com>\n\nMigration parameter names separate words with hyphens. A number of\nerror messages in migrate_params_check() use underscores instead.\nWrong since day one. Fix them.\n\nSigned-off-by: Markus Armbruster <armbru@redhat.com>\nLink: https://lore.kernel.org/qemu-devel/20260326074247.188674-3-armbru@redhat.com\nSigned-off-by: Fabiano Rosas <farosas@suse.de>\n---\n migration/options.c | 36 ++++++++++++++++++------------------\n 1 file changed, 18 insertions(+), 18 deletions(-)", "diff": "diff --git a/migration/options.c b/migration/options.c\nindex 3eb5b39186..7556fbc06b 100644\n--- a/migration/options.c\n+++ b/migration/options.c\n@@ -1133,103 +1133,103 @@ bool migrate_params_check(MigrationParameters *params, Error **errp)\n \n if (params->throttle_trigger_threshold < 1 ||\n params->throttle_trigger_threshold > 100) {\n- error_setg(errp, \"Option throttle_trigger_threshold expects \"\n+ error_setg(errp, \"Option throttle-trigger-threshold expects \"\n \"an integer in the range of 1 to 100\");\n return false;\n }\n \n if (params->cpu_throttle_initial < 1 ||\n params->cpu_throttle_initial > 99) {\n- error_setg(errp, \"Option cpu_throttle_initial expects \"\n+ error_setg(errp, \"Option cpu-throttle-initial expects \"\n \"an integer in the range of 1 to 99\");\n return false;\n }\n \n if (params->cpu_throttle_increment < 1 ||\n params->cpu_throttle_increment > 99) {\n- error_setg(errp, \"Option cpu_throttle_increment expects \"\n+ error_setg(errp, \"Option cpu-throttle-increment expects \"\n \"an integer in the range of 1 to 99\");\n return false;\n }\n \n if (params->max_bandwidth > SIZE_MAX) {\n- error_setg(errp, \"Option max_bandwidth expects \"\n+ error_setg(errp, \"Option max-bandwidth expects \"\n \"an integer in the range of 0 to \"stringify(SIZE_MAX)\n \" bytes/second\");\n return false;\n }\n \n if (params->avail_switchover_bandwidth > SIZE_MAX) {\n- error_setg(errp, \"Option avail_switchover_bandwidth expects \"\n+ error_setg(errp, \"Option avail-switchover-bandwidth expects \"\n \"an integer in the range of 0 to \"stringify(SIZE_MAX)\n \" bytes/second\");\n return false;\n }\n \n if (params->downtime_limit > MAX_MIGRATE_DOWNTIME) {\n- error_setg(errp, \"Option downtime_limit expects \"\n+ error_setg(errp, \"Option downtime-limit expects \"\n \"an integer in the range of 0 to \"\n stringify(MAX_MIGRATE_DOWNTIME)\" ms\");\n return false;\n }\n \n if (params->multifd_channels < 1) {\n- error_setg(errp, \"Option multifd_channels expects \"\n+ error_setg(errp, \"Option multifd-channels expects \"\n \"a value between 1 and 255\");\n return false;\n }\n \n if (params->multifd_zlib_level > 9) {\n- error_setg(errp, \"Option multifd_zlib_level expects \"\n+ error_setg(errp, \"Option multifd-zlib-level expects \"\n \"a value between 0 and 9\");\n return false;\n }\n \n if (params->multifd_qatzip_level > 9 ||\n params->multifd_qatzip_level < 1) {\n- error_setg(errp, \"Option multifd_qatzip_level expects \"\n+ error_setg(errp, \"Option multifd-qatzip-level expects \"\n \"a value between 1 and 9\");\n return false;\n }\n \n if (params->multifd_zstd_level > 20) {\n- error_setg(errp, \"Option multifd_zstd_level expects \"\n+ error_setg(errp, \"Option multifd-zstd-level expects \"\n \"a value between 0 and 20\");\n return false;\n }\n \n if (params->xbzrle_cache_size < qemu_target_page_size() ||\n !is_power_of_2(params->xbzrle_cache_size)) {\n- error_setg(errp, \"Option xbzrle_cache_size expects \"\n+ error_setg(errp, \"Option xbzrle-cache-size expects \"\n \"a power of two no less than the target page size\");\n return false;\n }\n \n if (params->max_cpu_throttle < params->cpu_throttle_initial ||\n params->max_cpu_throttle > 99) {\n- error_setg(errp, \"Option max_cpu_throttle expects \"\n- \"an integer in the range of cpu_throttle_initial to 99\");\n+ error_setg(errp, \"Option max-cpu-throttle expects \"\n+ \"an integer in the range of cpu-throttle-initial to 99\");\n return false;\n }\n \n if (params->announce_initial > 100000) {\n- error_setg(errp, \"Option announce_initial expects \"\n+ error_setg(errp, \"Option announce-initial expects \"\n \"a value between 0 and 100000\");\n return false;\n }\n if (params->announce_max > 100000) {\n- error_setg(errp, \"Option announce_max expects \"\n+ error_setg(errp, \"Option announce-max expects \"\n \"a value between 0 and 100000\");\n return false;\n }\n if (params->announce_rounds > 1000) {\n- error_setg(errp, \"Option announce_rounds expects \"\n+ error_setg(errp, \"Option announce-rounds expects \"\n \"a value between 0 and 1000\");\n return false;\n }\n if (params->announce_step < 1 ||\n params->announce_step > 10000) {\n- error_setg(errp, \"Option announce_step expects \"\n+ error_setg(errp, \"Option announce-step expects \"\n \"a value between 0 and 10000\");\n return false;\n }\n@@ -1264,7 +1264,7 @@ bool migrate_params_check(MigrationParameters *params, Error **errp)\n \n if (params->vcpu_dirty_limit < 1) {\n error_setg(errp,\n- \"Parameter 'vcpu_dirty_limit' must be greater than 1 MB/s\");\n+ \"Parameter 'vcpu-dirty-limit' must be greater than 1 MB/s\");\n return false;\n }\n \n", "prefixes": [ "PULL", "2/3" ] }