Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2217850/?format=api
{ "id": 2217850, "url": "http://patchwork.ozlabs.org/api/patches/2217850/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260330185236.1905636-3-peter.maydell@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260330185236.1905636-3-peter.maydell@linaro.org>", "list_archive_url": null, "date": "2026-03-30T18:52:33", "name": "[PULL,2/5] hw/net/rocker: Avoid double-free of l2_flood.group_ids", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "1d2d3d12dc56ce2933488022700ed58e2a721d7b", "submitter": { "id": 5111, "url": "http://patchwork.ozlabs.org/api/people/5111/?format=api", "name": "Peter Maydell", "email": "peter.maydell@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260330185236.1905636-3-peter.maydell@linaro.org/mbox/", "series": [ { "id": 498079, "url": "http://patchwork.ozlabs.org/api/series/498079/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=498079", "date": "2026-03-30T18:52:33", "name": "[PULL,1/5] target/arm: Don't skip access flag fault for AccessType_AT", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/498079/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2217850/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2217850/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=bzo5q2yD;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fl0kr008Zz1xtJ\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 31 Mar 2026 05:53:23 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w7HjD-0007hX-B5; Mon, 30 Mar 2026 14:52:47 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <peter.maydell@linaro.org>)\n id 1w7HjB-0007h3-Lc\n for qemu-devel@nongnu.org; Mon, 30 Mar 2026 14:52:45 -0400", "from mail-wr1-x429.google.com ([2a00:1450:4864:20::429])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <peter.maydell@linaro.org>)\n id 1w7Hj9-00039C-7J\n for qemu-devel@nongnu.org; Mon, 30 Mar 2026 14:52:44 -0400", "by mail-wr1-x429.google.com with SMTP id\n ffacd0b85a97d-439d8df7620so3447354f8f.0\n for <qemu-devel@nongnu.org>; Mon, 30 Mar 2026 11:52:41 -0700 (PDT)", "from lanath.. (wildly.archaic.org.uk. [81.2.115.145])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43cf21f1749sm21229400f8f.14.2026.03.30.11.52.39\n for <qemu-devel@nongnu.org>\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 30 Mar 2026 11:52:39 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1774896761; x=1775501561; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:from:to:cc:subject:date:message-id\n :reply-to; bh=BF7n0AeribVf5J8IKbflMfLGP0Uet1AjDdCOhZOnHQw=;\n b=bzo5q2yDcGVSZrrZJ21hpzmKIE6m3Kmml/RcDUehKEBzodFZneUQjm3ulFe8XxTtdA\n 7FQMxKRkz9oU7HMYrEMOIoiNMHA7Lr0R5j6l7+D6hUtodxFVIe8PmQKW2MXjtiyI4s/K\n +JDXHl34hVuHsbBaWp8sFg6LcBJAEP6/+bP2Jmdb5z1IcutJX4PeU8HSBMSoGzleBneD\n 0Y3fl9N9EkczZSpCJ2Bcn32oZ9j7B/A5kQwweCYJF2I1s+byGA2nvgKWWyBtvhprh6tf\n ZcGZf3YYicWx3iL5qhFHutEft8m4zmYYwy4CsEEx8I6OQ86BH4zhtVgCRZXK7A/hHKmv\n wDlw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774896761; x=1775501561;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=BF7n0AeribVf5J8IKbflMfLGP0Uet1AjDdCOhZOnHQw=;\n b=ofMwTaIV28HRYPHD1MlQduUdOHveCK1sjO8cd/feMOYvRbASOnqdx0reC2UhmpMOUb\n H8abVUjJOwX0GkcitkmDGCF/wGC4uIYvkTs217A3Srb2oO8+2Eyf0SnbscbkfsYyKRdd\n 9l0ViswrYdi+x4cUnCcetDsMQ1ItKo9BTfQFMJfxCqOW262tyq3ZbPX8/ykHMspa1X4k\n EeKTdKP/hqiAg0/AWLiKCJI7MMZbNMUqd5ptebd81iHfWWTHYow/HFz2fRdGvEbGoc7u\n sKC8aM369jn37u9d5XlEcjYWnn6pDtS3R4lGSj3fcHHM9oVpwBfvtgvixy2+4WzKynPS\n 6eYw==", "X-Gm-Message-State": "AOJu0Yx6pMYl+gMImNFVyFatdQRi3dneyW4yX261x3LbESEedFR+TrgZ\n B7NtBnBxFXU/r9KjdPZiDCo7wRFEPcSyW3vq/H65AkdK6pOltSxaVawPYzzDY8OHLT1VCuByFNX\n oECAr9Ec=", "X-Gm-Gg": "ATEYQzw3SeKqU3mIADQEARvEqlVXkz2oVGDVISTRd41wifwUV8EeKdAZ5+2TU9CQJfo\n 8TI4VApNqiCLfCxPbpnLgDRnE0LORVLbhbid8qHl6FKDm7fSVvaqJ+DcMNnrhH7+FDQNyXahz1T\n cALbOKSf5zYNiOpL66vXl5bvR+TPRpxOUY+MC+pxEHnX7kvtdXjjzVhX5UyaPnGBOej9ZpVeRI/\n JTQSaCR8WWidC9E9d9r7G7hLhrimnKRgOFf7BbFvNAlouvVqzK6TR2iKV5hNclrF5DG2G7KlHX8\n RdVWuIoZcpJzhdGKWUdiuNV4UOWI7vxAB0immSONDRCeqKJ1LamHMJZBM/uRrD2aThanQviu3xH\n LWWOFRp055407SEKUhg5U1sTnJ1GO+PYVFKv07G4HJvOI9YOLxFPa5q0VN0alE2boWKBcXLpu7S\n MfW0Ko0K7fCFxy2SqjfwKsQm8+cj+btz1mHJdA7P/VDr2694usgscY1xp0d2iesa6ZRuDlg9vzp\n JWIb1gN4VJTqK2RLANYSEcV1YAWWp4=", "X-Received": "by 2002:a5d:5d12:0:b0:43d:6e0:9458 with SMTP id\n ffacd0b85a97d-43d06e09528mr3281574f8f.39.1774896760726;\n Mon, 30 Mar 2026 11:52:40 -0700 (PDT)", "From": "Peter Maydell <peter.maydell@linaro.org>", "To": "qemu-devel@nongnu.org", "Subject": "[PULL 2/5] hw/net/rocker: Avoid double-free of l2_flood.group_ids", "Date": "Mon, 30 Mar 2026 19:52:33 +0100", "Message-ID": "<20260330185236.1905636-3-peter.maydell@linaro.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20260330185236.1905636-1-peter.maydell@linaro.org>", "References": "<20260330185236.1905636-1-peter.maydell@linaro.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2a00:1450:4864:20::429;\n envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x429.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "In of_dpa_cmd_add_l2_flood(), we allocate memory for the\ngroup->l2_flood.group_ids array, freeing any previous array.\nHowever, in the error-exit path we free the group_ids memory but do\nnot clear the pointer to NULL. This means that if the guest causes\nus to take the error-exit path and then later call the function\nagain, we will try again to free the memory we already freed.\n\nFix this by clearing the group_ids pointer in the error exit\npath, so we maintain the invariant of \"either it points at\nallocated memory, or it is NULL\" (both being valid to g_free()).\n\nCc: qemu-stable@nongnu.org\nFixes: dc488f88806 (\"rocker: add new rocker switch device\")\nResolves: https://gitlab.com/qemu-project/qemu/-/work_items/3253\nSigned-off-by: Peter Maydell <peter.maydell@linaro.org>\nReviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>\nMessage-id: 20260324193530.375628-1-peter.maydell@linaro.org\n---\n hw/net/rocker/rocker_of_dpa.c | 1 +\n 1 file changed, 1 insertion(+)", "diff": "diff --git a/hw/net/rocker/rocker_of_dpa.c b/hw/net/rocker/rocker_of_dpa.c\nindex 814f19afc5..3190a0e75c 100644\n--- a/hw/net/rocker/rocker_of_dpa.c\n+++ b/hw/net/rocker/rocker_of_dpa.c\n@@ -2059,6 +2059,7 @@ static int of_dpa_cmd_add_l2_flood(OfDpa *of_dpa, OfDpaGroup *group,\n err_out:\n group->l2_flood.group_count = 0;\n g_free(group->l2_flood.group_ids);\n+ group->l2_flood.group_ids = NULL;\n g_free(tlvs);\n \n return err;\n", "prefixes": [ "PULL", "2/5" ] }