Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2217841/?format=api
{ "id": 2217841, "url": "http://patchwork.ozlabs.org/api/patches/2217841/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pci/patch/20260330174011.1161-8-alifm@linux.ibm.com/", "project": { "id": 28, "url": "http://patchwork.ozlabs.org/api/projects/28/?format=api", "name": "Linux PCI development", "link_name": "linux-pci", "list_id": "linux-pci.vger.kernel.org", "list_email": "linux-pci@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260330174011.1161-8-alifm@linux.ibm.com>", "list_archive_url": null, "date": "2026-03-30T17:40:11", "name": "[v12,7/7] vfio/pci: Remove the pcie check for VFIO_PCI_ERR_IRQ_INDEX", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "7edb0e1820a58c686ff3c4e7f6b7837713f55fa8", "submitter": { "id": 73785, "url": "http://patchwork.ozlabs.org/api/people/73785/?format=api", "name": "Farhan Ali", "email": "alifm@linux.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-pci/patch/20260330174011.1161-8-alifm@linux.ibm.com/mbox/", "series": [ { "id": 498071, "url": "http://patchwork.ozlabs.org/api/series/498071/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pci/list/?series=498071", "date": "2026-03-30T17:40:08", "name": "Error recovery for vfio-pci devices on s390x", "version": 12, "mbox": "http://patchwork.ozlabs.org/series/498071/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2217841/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2217841/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-pci+bounces-51487-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-pci@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=th7aPtLr;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-pci+bounces-51487-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com\n header.b=\"th7aPtLr\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=148.163.158.5", "smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=linux.ibm.com" ], "Received": [ "from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fkzCj15yHz1xrn\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 31 Mar 2026 04:44:49 +1100 (AEDT)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id C381530911FF\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 30 Mar 2026 17:40:38 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 075673DEFE8;\n\tMon, 30 Mar 2026 17:40:31 +0000 (UTC)", "from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com\n [148.163.158.5])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A2B83DEACF;\n\tMon, 30 Mar 2026 17:40:29 +0000 (UTC)", "from pps.filterd (m0353725.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 62UFLrct371620;\n\tMon, 30 Mar 2026 17:40:23 GMT", "from ppma21.wdc07v.mail.ibm.com\n (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91])\n\tby mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4d65dc7pvu-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tMon, 30 Mar 2026 17:40:22 +0000 (GMT)", "from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1])\n\tby ppma21.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id\n 62UESON7022227;\n\tMon, 30 Mar 2026 17:40:22 GMT", "from smtprelay01.wdc07v.mail.ibm.com ([172.16.1.68])\n\tby ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4d6tamwups-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tMon, 30 Mar 2026 17:40:22 +0000", "from smtpav04.dal12v.mail.ibm.com (smtpav04.dal12v.mail.ibm.com\n [10.241.53.103])\n\tby smtprelay01.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 62UHeKL17209750\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n\tMon, 30 Mar 2026 17:40:21 GMT", "from smtpav04.dal12v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id B226C58052;\n\tMon, 30 Mar 2026 17:40:20 +0000 (GMT)", "from smtpav04.dal12v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id D96A458056;\n\tMon, 30 Mar 2026 17:40:19 +0000 (GMT)", "from IBM-D32RQW3.ibm.com (unknown [9.61.243.214])\n\tby smtpav04.dal12v.mail.ibm.com (Postfix) with ESMTP;\n\tMon, 30 Mar 2026 17:40:19 +0000 (GMT)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774892430; cv=none;\n b=ChiTLAu2ZOUeAkBXWbwtdJnHbtRTQqSSbSn1WI56+wcwP+1nKw9LC7TQY6KBzisIqokSB+rAngSw9pSqBovozi9Y9BdoIkMFi46iwxAwY/hwFXXWaw9X8yD+Xhlvj9sOt2j+P9nkqe1hnfyGB+9fIlHHeJUACck5UlDAXgN12A8=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774892430; c=relaxed/simple;\n\tbh=vRU3D1yc4J7O0JKYCViE2EsYVKuGDcwFu272wOP/l4M=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=nGwvGwUX8dvL4agtKvjlGwZRC7iMhsY6TpK3F1uFy5Bley3dbPxIULdDC263nZGSQaAsCkJdf0AWGC+WLK8OcCOqGxh64vuJejDpEgl3W6ALm1zY2QkIa/MMnfHZOdrGb8nm0D3LhmUrBOeQJxejvbGDPKeNx0y9wSs8w1Eky5c=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com;\n spf=pass smtp.mailfrom=linux.ibm.com;\n dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com\n header.b=th7aPtLr; arc=none smtp.client-ip=148.163.158.5", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n\t:content-transfer-encoding:date:from:in-reply-to:message-id\n\t:mime-version:references:subject:to; s=pp1; bh=RbF67R4sdld7817hu\n\tl/0b9urpWXCeSzDuBX3kWwxd0w=; b=th7aPtLrotNv3vwXoe84FbYDQjIh2eQY/\n\trfwB2OhJbWor9SebgJ/fPUiAh+4+GQXlQCGRxSoDuT9VKq5kTGjgJXmeK/UUfh+S\n\tdEmx713n0+CaQXF3iU/V1YSQ4gBDBQNMYiF/ICOO5DdH3gmBTrgJlsAEzoh05Evt\n\tUFBGuV4SLz31aUjc7q1ugz6rAylNv19C3DM3tUfNBTfSQaZIaSfYWVdOycYKoHJH\n\tD0zR/LGftRveifC1399WcVaK5IgcVpLCRloP0DAFRbA1+zR1dQp2kA3K5LNQzCtd\n\t2HkzSDrVr7nFy16dQEepc37P1Kg8a71yfQRmSYIF7MX+DGcpReDYg==", "From": "Farhan Ali <alifm@linux.ibm.com>", "To": "linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,\n linux-pci@vger.kernel.org", "Cc": "helgaas@kernel.org, lukas@wunner.de, alex@shazbot.org, clg@redhat.com,\n kbusch@kernel.org, alifm@linux.ibm.com, schnelle@linux.ibm.com,\n mjrosato@linux.ibm.com, Julian Ruess <julianr@linux.ibm.com>", "Subject": "[PATCH v12 7/7] vfio/pci: Remove the pcie check for\n VFIO_PCI_ERR_IRQ_INDEX", "Date": "Mon, 30 Mar 2026 10:40:11 -0700", "Message-ID": "<20260330174011.1161-8-alifm@linux.ibm.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20260330174011.1161-1-alifm@linux.ibm.com>", "References": "<20260330174011.1161-1-alifm@linux.ibm.com>", "Precedence": "bulk", "X-Mailing-List": "linux-pci@vger.kernel.org", "List-Id": "<linux-pci.vger.kernel.org>", "List-Subscribe": "<mailto:linux-pci+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-pci+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-TM-AS-GCONF": "00", "X-Authority-Analysis": "v=2.4 cv=RsjI7SmK c=1 sm=1 tr=0 ts=69cab586 cx=c_pps\n a=GFwsV6G8L6GxiO2Y/PsHdQ==:117 a=GFwsV6G8L6GxiO2Y/PsHdQ==:17\n a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22\n a=V8glGbnc2Ofi9Qvn3v5h:22 a=VnNF1IyMAAAA:8 a=bf5i11FZjm5gBOpVircA:9", "X-Proofpoint-GUID": "tD28TRGDMcX6DK1y_s4etGcoW7PsiZNb", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwMzMwMDE0MSBTYWx0ZWRfX3L9pgkFMQvCL\n GUz1fNbrwy7Q/3RLvRcPny4rb7j1zABzwltsvFuc7XeGmWWOBYlsxblzLVkHUg98FzruLdgJFgA\n 5uSAN/5u9lM+Z6vMmLrGCudotXwbU3OBpmO2vQ7M8We24ChalnuQ/Q9TGEGY3V464nJvjMR21Yf\n 158jMRTFUfkEWxVKrrWCj87KJUOTpX7baSOAU8WI5WgawxHoNa0hPcg7TPQjIAf301xZGa2n7k6\n 7xjheslue77p8Bk74Mc+M/nE0F6zHubbbY4heQLD+mBjG5+7PIdEiYmVi9JMgT6kxbL+Klk6p4o\n 2/LALMzKBImRuqQNrSrlV2jHw1pK2sa86ElX8fEtIC+8RI1lhNn6+VYFm4BFgwaLRZD8El3zPz2\n RRPA7BXklowsnfnRL2dZQMb8uV0rHLVK+HKgS2D107uFA6uqe6r8p04w9d6vP1WR6drxzyTW1Ov\n LbGh4q6GbNQEQzBNNAQ==", "X-Proofpoint-ORIG-GUID": "tD28TRGDMcX6DK1y_s4etGcoW7PsiZNb", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-03-29_05,2026-03-28_01,2025-10-01_01", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n impostorscore=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0\n suspectscore=0 malwarescore=0 spamscore=0 clxscore=1015 phishscore=0\n adultscore=0 classifier=typeunknown authscore=0 authtc= authcc=\n route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001\n definitions=main-2603300141" }, "content": "The error signaling is configured for the vast majority of devices and it's\nextremely rare that it fires anyway. Removing the pcie check will allow\nuserspace to be notified on errors for legacy PCI devices. The Internal\nShared Memory (ISM) device on s390 is one such device. For PCI devices on\nIBM s390 error recovery involves platform firmware and notification to\noperating system is done by architecture specific way. So the ISM device\ncan still be recovered when notified of an error.\n\nReviewed-by: Julian Ruess <julianr@linux.ibm.com>\nReviewed-by: Niklas Schnelle <schnelle@linux.ibm.com>\nSigned-off-by: Farhan Ali <alifm@linux.ibm.com>\n---\n drivers/vfio/pci/vfio_pci_core.c | 8 ++------\n drivers/vfio/pci/vfio_pci_intrs.c | 3 +--\n 2 files changed, 3 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/vfio/pci/vfio_pci_core.c b/drivers/vfio/pci/vfio_pci_core.c\nindex f1bd1266b88f..cfd9a51cd194 100644\n--- a/drivers/vfio/pci/vfio_pci_core.c\n+++ b/drivers/vfio/pci/vfio_pci_core.c\n@@ -786,8 +786,7 @@ static int vfio_pci_get_irq_count(struct vfio_pci_core_device *vdev, int irq_typ\n \t\t\treturn (flags & PCI_MSIX_FLAGS_QSIZE) + 1;\n \t\t}\n \t} else if (irq_type == VFIO_PCI_ERR_IRQ_INDEX) {\n-\t\tif (pci_is_pcie(vdev->pdev))\n-\t\t\treturn 1;\n+\t\treturn 1;\n \t} else if (irq_type == VFIO_PCI_REQ_IRQ_INDEX) {\n \t\treturn 1;\n \t}\n@@ -1163,11 +1162,8 @@ static int vfio_pci_ioctl_get_irq_info(struct vfio_pci_core_device *vdev,\n \tswitch (info.index) {\n \tcase VFIO_PCI_INTX_IRQ_INDEX ... VFIO_PCI_MSIX_IRQ_INDEX:\n \tcase VFIO_PCI_REQ_IRQ_INDEX:\n-\t\tbreak;\n \tcase VFIO_PCI_ERR_IRQ_INDEX:\n-\t\tif (pci_is_pcie(vdev->pdev))\n-\t\t\tbreak;\n-\t\tfallthrough;\n+\t\tbreak;\n \tdefault:\n \t\treturn -EINVAL;\n \t}\ndiff --git a/drivers/vfio/pci/vfio_pci_intrs.c b/drivers/vfio/pci/vfio_pci_intrs.c\nindex 33944d4d9dc4..64f80f64ff57 100644\n--- a/drivers/vfio/pci/vfio_pci_intrs.c\n+++ b/drivers/vfio/pci/vfio_pci_intrs.c\n@@ -859,8 +859,7 @@ int vfio_pci_set_irqs_ioctl(struct vfio_pci_core_device *vdev, uint32_t flags,\n \tcase VFIO_PCI_ERR_IRQ_INDEX:\n \t\tswitch (flags & VFIO_IRQ_SET_ACTION_TYPE_MASK) {\n \t\tcase VFIO_IRQ_SET_ACTION_TRIGGER:\n-\t\t\tif (pci_is_pcie(vdev->pdev))\n-\t\t\t\tfunc = vfio_pci_set_err_trigger;\n+\t\t\tfunc = vfio_pci_set_err_trigger;\n \t\t\tbreak;\n \t\t}\n \t\tbreak;\n", "prefixes": [ "v12", "7/7" ] }