Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2217811/?format=api
{ "id": 2217811, "url": "http://patchwork.ozlabs.org/api/patches/2217811/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20260330-pinctrl-mtk-fix-mt8189-v2-3-05a737ec623d@baylibre.com/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260330-pinctrl-mtk-fix-mt8189-v2-3-05a737ec623d@baylibre.com>", "list_archive_url": null, "date": "2026-03-30T16:00:35", "name": "[v2,3/4] pinctrl: mediatek: print bias info along with pinmux", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "2ef24dc32d121fa2c248146daf7b8abb22db8f5b", "submitter": { "id": 87228, "url": "http://patchwork.ozlabs.org/api/people/87228/?format=api", "name": "David Lechner", "email": "dlechner@baylibre.com" }, "delegate": { "id": 161331, "url": "http://patchwork.ozlabs.org/api/users/161331/?format=api", "username": "dlech", "first_name": "David", "last_name": "Lechner", "email": "dlechner@baylibre.com" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20260330-pinctrl-mtk-fix-mt8189-v2-3-05a737ec623d@baylibre.com/mbox/", "series": [ { "id": 498062, "url": "http://patchwork.ozlabs.org/api/series/498062/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=498062", "date": "2026-03-30T16:00:32", "name": "pinctrl: mediatek: fix mt8189 MSDC and I2C pins", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/498062/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2217811/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2217811/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=baylibre-com.20230601.gappssmtp.com\n header.i=@baylibre-com.20230601.gappssmtp.com header.a=rsa-sha256\n header.s=20230601 header.b=bFtY7GbJ;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=baylibre.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=baylibre-com.20230601.gappssmtp.com\n header.i=@baylibre-com.20230601.gappssmtp.com header.b=\"bFtY7GbJ\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=baylibre.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=dlechner@baylibre.com" ], "Received": [ "from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fkwxB0Sc9z1yG8\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 31 Mar 2026 03:02:06 +1100 (AEDT)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 8E59284020;\n\tMon, 30 Mar 2026 18:01:39 +0200 (CEST)", "by phobos.denx.de (Postfix, from userid 109)\n id 4F8CC83DBF; Mon, 30 Mar 2026 18:01:37 +0200 (CEST)", "from mail-oa1-x33.google.com (mail-oa1-x33.google.com\n [IPv6:2001:4860:4864:20::33])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id EEB0C83D17\n for <u-boot@lists.denx.de>; Mon, 30 Mar 2026 18:01:33 +0200 (CEST)", "by mail-oa1-x33.google.com with SMTP id\n 586e51a60fabf-415c8a4d2e6so1898272fac.0\n for <u-boot@lists.denx.de>; Mon, 30 Mar 2026 09:01:33 -0700 (PDT)", "from [127.0.1.1] ([2600:8803:e7e4:500:a67f:a092:38d7:379e])\n by smtp.gmail.com with ESMTPSA id\n 586e51a60fabf-41d048e1984sm5432952fac.4.2026.03.30.09.01.31\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 30 Mar 2026 09:01:31 -0700 (PDT)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1774886493;\n x=1775491293;\n darn=lists.denx.de;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:from:to:cc:subject:date:message-id\n :reply-to; bh=rd2kA1ylBFH8pDHIzigw3tF6Q9FwVnQOJZggknq3p58=;\n b=bFtY7GbJELi09lsJCLtdiY0S2rb2+M0UdMyhH7FbpR6ZMMWatlhP13mlB/VySq/KUt\n l9c5AJfKyrUySswXNmQvPzgB2zsiBPObQOGHbh7FVUumFi1eBF9MLfbQmdM+Uu5rdlG4\n pz6E7j0c7ACP1/5sSckANOHGfWnaEr74faGKLOBWZbxazJW1abyrv9MfTCLkIJrxaUH9\n WKbyN6NhPYEUfb4o8R7UTgjB0x6hIxddGhPVKEs0UYRebcvYwWGgEQSGLqhBfMaKaZY9\n uQNVXuCdKZM9hSB9zdW9xqk++WFxPDRrgHrjikjijV5pmpJG9R6VT6Y1HckGNj1myyAs\n J8Qw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774886493; x=1775491293;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=rd2kA1ylBFH8pDHIzigw3tF6Q9FwVnQOJZggknq3p58=;\n b=SL3PqWE+XNIN9Rv9wVphSNutYUFxA/AAfQhuuQGNkN4rpPHD7Mpz2CfK8kZ5YrRlBk\n GhrCoFCa3+MtW9NqU4UQI7dMWZMNpTkwhdhkf6oGAWZrzwR8GloGLaxcnlL+wxSJsoEy\n OrWkYeLDTDwFKud+etL9xwJ4MLtB/H1fpDtul7+L5AnWXKXRZnbIC/XXe6giq6W2Eg9n\n O/vvFPHzTf9M0lexcxu5zYO9SplM2z3N0iihiW32CzqTtcO7NS6shpm5guTiVluxKX5F\n 5Ngx4AMWqqMbBH5RyZQUnv27FNyuXJHJ0Jgp8LdbHRP7k9DDYqV3srF8nGKvP2rVlHnF\n xvYA==", "X-Forwarded-Encrypted": "i=1;\n AJvYcCXO2z27hCTw8V1yIJKLs4yvXLO6QfMI6KAq64QvvNLm/ZLfheNaOHPXoCCCkDg9awUaLNOXEo4=@lists.denx.de", "X-Gm-Message-State": "AOJu0YxcTGDG2PDKoLXrj7BcA+R2cyU05RWlIzEdKI/c+KpiBc+O1aja\n Aarzrg18ViJzRaZCA1Myyr/VZfeAJGgfN5GlKJq/o0baQ7mXzTn0HdN0vH3Xvamxyyk=", "X-Gm-Gg": "ATEYQzz61ikDyuNNxIHnS9D1JZjtcPDbQ9XvKNqwTQ/VlDBKQhuvlwUqqS+NppYHwbh\n zL+ckMBBPwcZ88Ds2HsknVmeKReBRMZcFy5KApqAo5KKO/KG+N1WQET8t3xEFe0yqlvrFIEvfuP\n X2DmE60k6Skt0pyhUIjIRnmtTplrTPGWlm0iiiefQeIIFeEuDSrEfw4XEID1bVz2OlYIMPsVBWy\n X7KZd6kSfCzprHYY1qp5jcc+VbfUo0C04wSxm+LprgcJ4Mn0cnWUFImfNvKYnC9RAks/FOPrpqP\n rvwbdbr9unST8UfnvgxuDLmPWqK6fGWhh6xye5GaoMlRKg7vX8JfTDlLH3lCsiaX3fET7qA+wS0\n EXm2ftYHjaKdAeBoNSQCVPMXOvi5xG1OtbPeLp4AN4FgqhYTrCeKMNNbFr/MMuPTJ49wJcdYlha\n VEeytVWA6VUetX/YTDrrN+IEnrWMpI", "X-Received": "by 2002:a05:6870:158e:b0:417:5c29:ace7 with SMTP id\n 586e51a60fabf-41cec091d3amr6734535fac.2.1774886492237;\n Mon, 30 Mar 2026 09:01:32 -0700 (PDT)", "From": "David Lechner <dlechner@baylibre.com>", "Date": "Mon, 30 Mar 2026 11:00:35 -0500", "Subject": "[PATCH v2 3/4] pinctrl: mediatek: print bias info along with\n pinmux", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20260330-pinctrl-mtk-fix-mt8189-v2-3-05a737ec623d@baylibre.com>", "References": "<20260330-pinctrl-mtk-fix-mt8189-v2-0-05a737ec623d@baylibre.com>", "In-Reply-To": "<20260330-pinctrl-mtk-fix-mt8189-v2-0-05a737ec623d@baylibre.com>", "To": "Ryder Lee <ryder.lee@mediatek.com>, Weijie Gao <weijie.gao@mediatek.com>,\n Chunfeng Yun <chunfeng.yun@mediatek.com>,\n Igor Belwon <igor.belwon@mentallysanemainliners.org>,\n GSS_MTK_Uboot_upstream <GSS_MTK_Uboot_upstream@mediatek.com>,\n Tom Rini <trini@konsulko.com>", "Cc": "Julien Stephan <jstephan@baylibre.com>, u-boot@lists.denx.de,\n David Lechner <dlechner@baylibre.com>", "X-Mailer": "b4 0.16-dev", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=4889; i=dlechner@baylibre.com;\n h=from:subject:message-id;\n bh=s6Gh2igH0AAVgVmaruwgGpMOUkAwlafwrW2NZp6Iido=;\n b=owEBhAF7/pANAwAKAcLMIAH/AY/AAcsmYgBpyp5JY7zpFTZlz6J+gTeXMDs1ZHkP+Z6nGgNkj\n PWbJfRs/fiJAUoEAAEKADQWIQTsGNmeYg6D1pzYaJjCzCAB/wGPwAUCacqeSRYcZGxlY2huZXJA\n YmF5bGlicmUuY29tAAoJEMLMIAH/AY/A1O0H/RPVWm7NoMCKl9kD60Xw61eusKNv0x4x3BTS208\n xDkSJoIlvui37cT2zm7LwwPuzbOzuzp2//4QjJ1kSGRK/u/wh5zXUS4D395ihwQC16QfRutX3rR\n QVk3UJ2szICz2LPVO32C2zJTGjrfaqXHYSdHuLXmbpH8JPgxye7oUFi0LkzWOn3XxkiRoyWzyBK\n U5EPehCoX7QiUE2AnqAv9cYwRoVFx590zFrgs9rhbo77rjaBGSDlWLu7MIJeGNNzWD5SzsX8+b2\n IBL3vuQoR/Q6fkBgEK1N0aElFcnX66STIBXHKS/o7fRAOyWpq8pLVrBzQwnM4/PvR56Mr2Lv6MX\n v9Dk=", "X-Developer-Key": "i=dlechner@baylibre.com; a=openpgp;\n fpr=8A73D82A6A1F509907F373881F8AF88C82F77C03", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "Add functionality to be able to print pin bias settings along with the\npinmux setting.\n\nThis can be useful to debug why pins might not be working correctly.\n\nSigned-off-by: David Lechner <dlechner@baylibre.com>\n---\n drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 91 ++++++++++++++++++++++++++-\n drivers/pinctrl/mediatek/pinctrl-mtk-common.h | 4 ++\n 2 files changed, 93 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c\nindex 1028b8a93f5..cfffbaeef84 100644\n--- a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c\n+++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c\n@@ -237,9 +237,39 @@ static int mtk_get_pin_io_type(struct udevice *dev, int pin,\n \tio_type->bias_set = priv->soc->io_type[io_n].bias_set;\n \tio_type->drive_set = priv->soc->io_type[io_n].drive_set;\n \tio_type->input_enable = priv->soc->io_type[io_n].input_enable;\n+\tio_type->get_pinconf = priv->soc->io_type[io_n].get_pinconf;\n \n \treturn 0;\n }\n+\n+static int mtk_pinconf_get(struct udevice *dev, u32 pin, char *buf, size_t size)\n+{\n+\tstruct mtk_io_type_desc io_type;\n+\tint err, pos;\n+\n+\t/* If we fail to get the type, then we just don't add any more info. */\n+\tif (mtk_get_pin_io_type(dev, pin, &io_type))\n+\t\treturn 0;\n+\n+\tpos = snprintf(buf, size, \" (%s)\", io_type.name);\n+\tif (pos >= size)\n+\t\treturn pos;\n+\n+\tif (io_type.get_pinconf) {\n+\t\terr = io_type.get_pinconf(dev, pin, buf + pos, size - pos);\n+\t\tif (err < 0)\n+\t\t\treturn err;\n+\n+\t\tpos += err;\n+\t}\n+\n+\treturn pos;\n+}\n+#else\n+static int mtk_pinconf_get(struct udevice *dev, u32 pin, char *buf, size_t size)\n+{\n+\treturn 0;\n+}\n #endif\n \n static int mtk_get_groups_count(struct udevice *dev)\n@@ -270,12 +300,20 @@ static int mtk_get_pins_count(struct udevice *dev)\n static int mtk_get_pin_muxing(struct udevice *dev, unsigned int selector,\n \t\t\t char *buf, int size)\n {\n-\tint val, err;\n+\tint val, err, pos;\n+\n \terr = mtk_hw_get_value(dev, selector, PINCTRL_PIN_REG_MODE, &val);\n \tif (err)\n \t\treturn err;\n \n-\tsnprintf(buf, size, \"Aux Func.%d\", val);\n+\tpos = snprintf(buf, size, \"Aux Func.%d\", val);\n+\tif (pos >= size)\n+\t\treturn 0;\n+\n+\terr = mtk_pinconf_get(dev, selector, buf + pos, size - pos);\n+\tif (err < 0)\n+\t\treturn err;\n+\n \treturn 0;\n }\n \n@@ -670,6 +708,55 @@ static int mtk_pinconf_group_set(struct udevice *dev,\n \n \treturn 0;\n }\n+\n+int mtk_pinconf_get_pu_pd(struct udevice *dev, u32 pin, char *buf, size_t size)\n+{\n+\tint err, pu, pd;\n+\n+\terr = mtk_hw_get_value(dev, pin, PINCTRL_PIN_REG_PU, &pu);\n+\tif (err)\n+\t\treturn err;\n+\n+\terr = mtk_hw_get_value(dev, pin, PINCTRL_PIN_REG_PD, &pd);\n+\tif (err)\n+\t\treturn err;\n+\n+\treturn snprintf(buf, size, \" PU:%d PD:%d\", pu, pd);\n+}\n+\n+int mtk_pinconf_get_pupd_r1_r0(struct udevice *dev, u32 pin, char *buf, size_t size)\n+{\n+\tint err, r0, r1, pupd;\n+\n+\terr = mtk_hw_get_value(dev, pin, PINCTRL_PIN_REG_PUPD, &pupd);\n+\tif (err)\n+\t\treturn err;\n+\n+\terr = mtk_hw_get_value(dev, pin, PINCTRL_PIN_REG_R1, &r1);\n+\tif (err)\n+\t\treturn err;\n+\n+\terr = mtk_hw_get_value(dev, pin, PINCTRL_PIN_REG_R0, &r0);\n+\tif (err)\n+\t\treturn err;\n+\n+\treturn snprintf(buf, size, \" PUPD:%d R1:%d R0:%d\", pupd, r1, r0);\n+}\n+\n+int mtk_pinconf_get_pu_pd_rsel(struct udevice *dev, u32 pin, char *buf, size_t size)\n+{\n+\tint pos, err, rsel;\n+\n+\tpos = mtk_pinconf_get_pu_pd(dev, pin, buf, size);\n+\tif (pos < 0 || pos >= size)\n+\t\treturn pos;\n+\n+\terr = mtk_hw_get_value(dev, pin, PINCTRL_PIN_REG_RSEL, &rsel);\n+\tif (err)\n+\t\treturn err;\n+\n+\treturn pos + snprintf(buf + pos, size - pos, \" RSEL:%d\", rsel);\n+}\n #endif\n \n static int mtk_pinctrl_pinmux_property_set(struct udevice *dev, u32 pinmux_group)\ndiff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.h b/drivers/pinctrl/mediatek/pinctrl-mtk-common.h\nindex 1215fb7094b..bd17964090a 100644\n--- a/drivers/pinctrl/mediatek/pinctrl-mtk-common.h\n+++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common.h\n@@ -204,6 +204,7 @@ struct mtk_io_type_desc {\n \t\t\tbool pullup, u32 val);\n \tint (*drive_set)(struct udevice *dev, u32 pin, u32 arg);\n \tint (*input_enable)(struct udevice *dev, u32 pin, u32 arg);\n+\tint (*get_pinconf)(struct udevice *dev, u32 pin, char *buf, size_t size);\n #endif\n };\n \n@@ -263,6 +264,9 @@ int mtk_pinconf_bias_set_v1(struct udevice *dev, u32 pin, bool disable,\n int mtk_pinconf_input_enable_v1(struct udevice *dev, u32 pin, u32 arg);\n int mtk_pinconf_drive_set_v0(struct udevice *dev, u32 pin, u32 arg);\n int mtk_pinconf_drive_set_v1(struct udevice *dev, u32 pin, u32 arg);\n+int mtk_pinconf_get_pu_pd(struct udevice *dev, u32 pin, char *buf, size_t size);\n+int mtk_pinconf_get_pupd_r1_r0(struct udevice *dev, u32 pin, char *buf, size_t size);\n+int mtk_pinconf_get_pu_pd_rsel(struct udevice *dev, u32 pin, char *buf, size_t size);\n \n #endif\n \n", "prefixes": [ "v2", "3/4" ] }