Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2217800/?format=api
{ "id": 2217800, "url": "http://patchwork.ozlabs.org/api/patches/2217800/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-ide/patch/a0fbf4ec-cbd8-43e3-b52c-39eaf937052c@gmail.com/", "project": { "id": 13, "url": "http://patchwork.ozlabs.org/api/projects/13/?format=api", "name": "Linux IDE development", "link_name": "linux-ide", "list_id": "linux-ide.vger.kernel.org", "list_email": "linux-ide@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<a0fbf4ec-cbd8-43e3-b52c-39eaf937052c@gmail.com>", "list_archive_url": null, "date": "2026-03-30T15:19:40", "name": "[3/5] ata: libata-transport: use static struct ata_transport_internal to simplify match functions", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "2abeceaeecb5ce6fc7fb1d7f2416f94e287b9b06", "submitter": { "id": 65365, "url": "http://patchwork.ozlabs.org/api/people/65365/?format=api", "name": "Heiner Kallweit", "email": "hkallweit1@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-ide/patch/a0fbf4ec-cbd8-43e3-b52c-39eaf937052c@gmail.com/mbox/", "series": [ { "id": 498055, "url": "http://patchwork.ozlabs.org/api/series/498055/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-ide/list/?series=498055", "date": "2026-03-30T15:17:12", "name": "ata: libata-transport: series with further refactorings", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/498055/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2217800/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2217800/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-ide+bounces-5396-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-ide@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=Uh8MOCdp;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-ide+bounces-5396-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"Uh8MOCdp\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.128.47", "smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com" ], "Received": [ "from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fkwHx27ldz1y1q\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 31 Mar 2026 02:33:17 +1100 (AEDT)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id BD0183059F08\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 30 Mar 2026 15:19:45 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id B9B2A329E46;\n\tMon, 30 Mar 2026 15:19:44 +0000 (UTC)", "from mail-wm1-f47.google.com (mail-wm1-f47.google.com\n [209.85.128.47])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 34D78191F98\n\tfor <linux-ide@vger.kernel.org>; Mon, 30 Mar 2026 15:19:43 +0000 (UTC)", "by mail-wm1-f47.google.com with SMTP id\n 5b1f17b1804b1-48704db565eso60301545e9.1\n for <linux-ide@vger.kernel.org>; Mon, 30 Mar 2026 08:19:42 -0700 (PDT)", "from ?IPV6:2003:ea:8f1a:ba00:c5ab:4ea4:3ed7:a674?\n (p200300ea8f1aba00c5ab4ea43ed7a674.dip0.t-ipconnect.de.\n [2003:ea:8f1a:ba00:c5ab:4ea4:3ed7:a674])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43cf21eb95fsm21789439f8f.12.2026.03.30.08.19.40\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Mon, 30 Mar 2026 08:19:40 -0700 (PDT)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774883984; cv=none;\n b=dPfNHKmO2LspYA4PQ5Np13Poo61Z0XUFSqvhWxxHa6GFmhP3LN0UCgqQL52rdsEFkPC0iq93Yw+cxmTg8NqdrNgusmqYvedbD+MdTeBMVzncTMT9tF0VJEM8mrTXiwqeUnbkg04fWpNh9CwyDaWUIViz/uyz0FjwV3O4pvB66m0=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774883984; c=relaxed/simple;\n\tbh=hu1YP51P/vjX2oOa/P/62qEWO0z3+lJ/6N64oZ27Mbc=;\n\th=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References:\n\t In-Reply-To:Content-Type;\n b=p/CV+3CJchQHgU5fuxY5TsNNraEZ0KSa0w02ke3GbLyeApO0GhP28AdlqGKIZ65KFgbrzVdoyXX6bukBBo9dZkjisnEiBes2SouCf05kdnJHTplcZ7w2PikstD2/3XXfL5avwXZIeUpktwcm5I8vQ0oj4+WMdEcCnKfNA8XMBS4=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=Uh8MOCdp; arc=none smtp.client-ip=209.85.128.47", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1774883981; x=1775488781;\n darn=vger.kernel.org;\n h=content-transfer-encoding:in-reply-to:content-language:references\n :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to\n :cc:subject:date:message-id:reply-to;\n bh=Gy0R9/04fPCu55njiskqJaVF+n5Mwa2jUo8Tkn51Nm4=;\n b=Uh8MOCdppcz2lwsmQ/WxcScyMGlInMDUXg6bpq23F1V1Ieq5aMX3RCDVcpTyH/uMPX\n FzLFGMe15FLmvwVIzRL1TM2ZNY80GIAM8Z/pKUmTHD6AQQXcevj1q9zOvqdJKpyQmW0+\n ozSb0hcDxz+5cXHLEOWIYF3BVmLjM/KZZDqiYGDeoG/cLfcDxCKDQx79l7HjCGXSECWE\n 2mwHHqF/4qE4v9PBXwevY9Rxal5L5TNz1Q88j191fLE0PIr9K8DTaQBMIZGGK0LGjJit\n mmKmX1aYAK+tT1Uk2yicc+5R7c17hXZ9O/0WGZhBkKVo/0Q1TvX7urtTa389FqP5tAgl\n eKQg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774883981; x=1775488781;\n h=content-transfer-encoding:in-reply-to:content-language:references\n :cc:to:from:subject:user-agent:mime-version:date:message-id:x-gm-gg\n :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n bh=Gy0R9/04fPCu55njiskqJaVF+n5Mwa2jUo8Tkn51Nm4=;\n b=iv6bFrnTbrgVeG/MMIBoT3K1m8pMCs5oLPS6DqFrsuYVNBoSf4mhVvkog6dc2KP6Ze\n bRN6BCvwhs5bY2Dg8mlziGwcqazuydKu6f5xK9fep8Y7Pa2HY6TD7L90CRZEXWzwwfUl\n P1mi3eaGsASzyVveUkjKzx/PQKVnDskhAo9vYFqsZEUNHdDRVFA0QzWBhfDpFvO158ZV\n dEvCuirttS+lnKEzDIPZ9cDMu6aDgkvdJQYHllFoAdDgq/lDxXbrVNbaXV0ucefH9Hvz\n DqrQPm1+OdwbDAFr15wWPobfRS64ILKGsDMk1G/k6TVcbKdp8KvhfRNVuYbiqzSu1tBQ\n hhgQ==", "X-Gm-Message-State": "AOJu0Yz50WXIepVMMr83l4OGLdCoFTv6RR2wicYGkH4mx93m53Cmcfum\n\tAeZML6mvSnAiqYTS0SVVVRs3TZ0YIMyoJB1t0Ohc5q3I09c1bjAlkHzZYvVnVw==", "X-Gm-Gg": "ATEYQzwyNRV6GYb0Q8qlTJG2EcL+kc3gld4aULCyxqRWb5xKONVsZSfdN+bK0i8V7gz\n\tFRsfEN6+4D4QaJO1S9/bjkoikxYqjEdSVv+j+bSJ6pm2gtWTB135bkIgjM0aLzEYXbADyp6Mb10\n\trhSWDuTnNDc6EDnZW4Goc8Ck5nz0U4O+pGRtraet59VvPunFA+MrFmQKLySFThmr/GyvUfLkMP6\n\tY1Kgrhpif7nktAGID4GfUZ2HgpjqHdUHz46983EynQ2eBV8tgr7StWAdQFyiW01a4fdCFcunvSo\n\tlnLFsn/Z95dTf5oBNuGADaAQWrXVXKiDRFTUSm5hezR+QzwTQrgEPcmCVrPUX4ubHTZaC7+xULz\n\tSuvEi06ZeYBqg/yq1pNGDK5xG1vBzXiVQLhnknQUVzYkTFTPn/ikH+LchqP0YLNQM8GZqO6jLgi\n\t4x2RCPHFRGlo1ovh6dgtXK5W+UVZGOhX/DAxwPwzoM6Uk/8+yzG1UWFlff+csTVIU7HskXz6kE7\n\tpuVuSZ5aomEbqyPcIL0H81FCGrcBIncDmUyYj+n4tIku+fVtLDoYVcAUlBya0GjUQ==", "X-Received": "by 2002:a05:600d:8449:b0:485:5981:1411 with SMTP id\n 5b1f17b1804b1-48727ecf47dmr169678805e9.23.1774883981322;\n Mon, 30 Mar 2026 08:19:41 -0700 (PDT)", "Message-ID": "<a0fbf4ec-cbd8-43e3-b52c-39eaf937052c@gmail.com>", "Date": "Mon, 30 Mar 2026 17:19:40 +0200", "Precedence": "bulk", "X-Mailing-List": "linux-ide@vger.kernel.org", "List-Id": "<linux-ide.vger.kernel.org>", "List-Subscribe": "<mailto:linux-ide+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-ide+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "User-Agent": "Mozilla Thunderbird", "Subject": "[PATCH 3/5] ata: libata-transport: use static struct\n ata_transport_internal to simplify match functions", "From": "Heiner Kallweit <hkallweit1@gmail.com>", "To": "Damien Le Moal <dlemoal@kernel.org>, Niklas Cassel <cassel@kernel.org>", "Cc": "linux-ide@vger.kernel.org", "References": "<8592ed06-3a6f-45cb-9811-e163f31f7183@gmail.com>", "Content-Language": "en-US", "In-Reply-To": "<8592ed06-3a6f-45cb-9811-e163f31f7183@gmail.com>", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "7bit" }, "content": "Both matching functions can make use of static struct\nata_transport_internal. This eliminates the dependency on static\nvariable ata_scsi_transport_template, and it allows to remove helper\nto_ata_internal(). Small drawback is that a forward declaration of\nboth functions is needed.\n\nSigned-off-by: Heiner Kallweit <hkallweit1@gmail.com>\n---\n drivers/ata/libata-transport.c | 44 ++++++++++++++++++----------------\n 1 file changed, 23 insertions(+), 21 deletions(-)", "diff": "diff --git a/drivers/ata/libata-transport.c b/drivers/ata/libata-transport.c\nindex 9d594562c..68ae57a89 100644\n--- a/drivers/ata/libata-transport.c\n+++ b/drivers/ata/libata-transport.c\n@@ -46,7 +46,11 @@ struct ata_internal {\n \tstruct transport_container link_attr_cont;\n \tstruct transport_container dev_attr_cont;\n };\n-#define to_ata_internal(tmpl)\tcontainer_of(tmpl, struct ata_internal, t)\n+\n+static int ata_tlink_match(struct attribute_container *cont,\n+\t\t\t struct device *dev);\n+static int ata_tdev_match(struct attribute_container *cont,\n+\t\t\t struct device *dev);\n \n #define tdev_to_device(d)\t\t\t\t\t\\\n \tcontainer_of((d), struct ata_device, tdev)\n@@ -519,16 +523,6 @@ static bool ata_is_ata_dev(const struct device *dev)\n \treturn dev->release == ata_tdev_release;\n }\n \n-static int ata_tdev_match(struct attribute_container *cont,\n-\t\t\t struct device *dev)\n-{\n-\tstruct ata_internal *i = to_ata_internal(ata_scsi_transport_template);\n-\n-\tif (!ata_is_ata_dev(dev))\n-\t\treturn 0;\n-\treturn &i->dev_attr_cont.ac == cont;\n-}\n-\n /**\n * ata_tdev_free -- free an ATA transport device\n * @dev:\tstruct ata_device owning the transport device to free\n@@ -660,16 +654,6 @@ static bool ata_is_link(const struct device *dev)\n \treturn dev->release == ata_tlink_release;\n }\n \n-static int ata_tlink_match(struct attribute_container *cont,\n-\t\t\t struct device *dev)\n-{\n-\tstruct ata_internal *i = to_ata_internal(ata_scsi_transport_template);\n-\n-\tif (!ata_is_link(dev))\n-\t\treturn 0;\n-\treturn &i->link_attr_cont.ac == cont;\n-}\n-\n /**\n * ata_tlink_delete -- remove an ATA link transport device\n * @link:\tstruct ata_link owning the link transport device to remove\n@@ -762,6 +746,24 @@ static struct ata_internal ata_transport_internal = {\n \t.dev_attr_cont.ac.match\t= ata_tdev_match,\n };\n \n+static int ata_tlink_match(struct attribute_container *cont,\n+\t\t\t struct device *dev)\n+{\n+\tif (!ata_is_link(dev))\n+\t\treturn 0;\n+\n+\treturn &ata_transport_internal.link_attr_cont.ac == cont;\n+}\n+\n+static int ata_tdev_match(struct attribute_container *cont,\n+\t\t\t struct device *dev)\n+{\n+\tif (!ata_is_ata_dev(dev))\n+\t\treturn 0;\n+\n+\treturn &ata_transport_internal.dev_attr_cont.ac == cont;\n+}\n+\n /*\n * Setup / Teardown code\n */\n", "prefixes": [ "3/5" ] }