Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 2217798,
    "url": "http://patchwork.ozlabs.org/api/patches/2217798/?format=api",
    "web_url": "http://patchwork.ozlabs.org/project/linux-ide/patch/ad6ef45a-1e47-4bc4-b9fd-6ba3ec8ca83e@gmail.com/",
    "project": {
        "id": 13,
        "url": "http://patchwork.ozlabs.org/api/projects/13/?format=api",
        "name": "Linux IDE development",
        "link_name": "linux-ide",
        "list_id": "linux-ide.vger.kernel.org",
        "list_email": "linux-ide@vger.kernel.org",
        "web_url": null,
        "scm_url": null,
        "webscm_url": null,
        "list_archive_url": "",
        "list_archive_url_format": "",
        "commit_url_format": ""
    },
    "msgid": "<ad6ef45a-1e47-4bc4-b9fd-6ba3ec8ca83e@gmail.com>",
    "list_archive_url": null,
    "date": "2026-03-30T15:18:08",
    "name": "[1/5] ata: libata-transport: instantiate struct ata_internal statically",
    "commit_ref": null,
    "pull_url": null,
    "state": "new",
    "archived": false,
    "hash": "f536138d98fe4cac9179792ae4b059d6bed0f835",
    "submitter": {
        "id": 65365,
        "url": "http://patchwork.ozlabs.org/api/people/65365/?format=api",
        "name": "Heiner Kallweit",
        "email": "hkallweit1@gmail.com"
    },
    "delegate": null,
    "mbox": "http://patchwork.ozlabs.org/project/linux-ide/patch/ad6ef45a-1e47-4bc4-b9fd-6ba3ec8ca83e@gmail.com/mbox/",
    "series": [
        {
            "id": 498055,
            "url": "http://patchwork.ozlabs.org/api/series/498055/?format=api",
            "web_url": "http://patchwork.ozlabs.org/project/linux-ide/list/?series=498055",
            "date": "2026-03-30T15:17:12",
            "name": "ata: libata-transport: series with further refactorings",
            "version": 1,
            "mbox": "http://patchwork.ozlabs.org/series/498055/mbox/"
        }
    ],
    "comments": "http://patchwork.ozlabs.org/api/patches/2217798/comments/",
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/2217798/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "\n <linux-ide+bounces-5394-incoming=patchwork.ozlabs.org@vger.kernel.org>",
        "X-Original-To": [
            "incoming@patchwork.ozlabs.org",
            "linux-ide@vger.kernel.org"
        ],
        "Delivered-To": "patchwork-incoming@legolas.ozlabs.org",
        "Authentication-Results": [
            "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=liQpAy4g;\n\tdkim-atps=neutral",
            "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-ide+bounces-5394-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)",
            "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"liQpAy4g\"",
            "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.128.47",
            "smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com",
            "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"
        ],
        "Received": [
            "from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fkwHG4Tr5z1y1q\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 31 Mar 2026 02:32:42 +1100 (AEDT)",
            "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 86E1130305E2\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 30 Mar 2026 15:18:14 +0000 (UTC)",
            "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 8433D324B23;\n\tMon, 30 Mar 2026 15:18:13 +0000 (UTC)",
            "from mail-wm1-f47.google.com (mail-wm1-f47.google.com\n [209.85.128.47])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id EAE3C339872\n\tfor <linux-ide@vger.kernel.org>; Mon, 30 Mar 2026 15:18:11 +0000 (UTC)",
            "by mail-wm1-f47.google.com with SMTP id\n 5b1f17b1804b1-486fd3a577eso41863895e9.1\n        for <linux-ide@vger.kernel.org>; Mon, 30 Mar 2026 08:18:11 -0700 (PDT)",
            "from ?IPV6:2003:ea:8f1a:ba00:c5ab:4ea4:3ed7:a674?\n (p200300ea8f1aba00c5ab4ea43ed7a674.dip0.t-ipconnect.de.\n [2003:ea:8f1a:ba00:c5ab:4ea4:3ed7:a674])\n        by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-487270dd790sm176422465e9.5.2026.03.30.08.18.09\n        (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n        Mon, 30 Mar 2026 08:18:09 -0700 (PDT)"
        ],
        "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774883893; cv=none;\n b=WBv7bmWtsSx0IIPfHJgLWkZwyE9/lCtu//t7REB4MkFqoA/h1q5jBDwmTC8zG86luuWUbcjwZfAnRcZBV/l9Bv4bUzXOmApcuBAxMs85TtgBJRa2EvtDC+eXS/0JQHkgEvVq4FOCqVVIsF3Ago0Hu7/AVYPgrhSMKC9/USqO9Pk=",
        "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774883893; c=relaxed/simple;\n\tbh=AZKSL4ISdPbhB9PotON6/4XM54KEbj/hq2EHSgKhyZs=;\n\th=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References:\n\t In-Reply-To:Content-Type;\n b=hvuhmWfHPwQdd1btz8+rA5a6Mh6nFCTn3eJQxA61MPS8xYGGR54bpvCokPTgcBre0PkUcsPaouchYqo44brkBL/973kcYIJeH6rY8UHllrcqyLNStv8GjuNsi5Qv7QNrHNg/X6uywbdGjZWbh+qC8oMi9Ru7fHC+zceQpD953OE=",
        "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=liQpAy4g; arc=none smtp.client-ip=209.85.128.47",
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n        d=gmail.com; s=20251104; t=1774883890; x=1775488690;\n darn=vger.kernel.org;\n        h=content-transfer-encoding:in-reply-to:content-language:references\n         :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to\n         :cc:subject:date:message-id:reply-to;\n        bh=7L8Y2A7BbK6eroZTnDlarDqLBiqenVGMWKEaxr9od+M=;\n        b=liQpAy4gQQnu64xv/nzod/MdxO2ANnIgU/v96p91RcxPC1hzkHEDVUZArsXd9OiN7x\n         zs/BdQcuT3duit44OzGZb30RuoTcbz1ptCKjAdzLVnxp+sF2l/b3JuZs6Ia53Hm7BqA4\n         aJwM8USgQ8l1ewEm5VSRgyqd/7VyP4kr0Q3fFaKD/up7Aq2DtIzKD+I7snWFNFjsL85n\n         pB+gXZQV/rBW6n66c/WSEQejNiSlSz0FOAltihzQ/SssTCQmrAtaeeEQOyfF69embPPA\n         D2fXeOfS7ZTcNG1y8fuOlpeP6gm8UNv+oiofyXNae+9pLM/MZ8HpFBObHS+P4oq4mNng\n         LTBA==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n        d=1e100.net; s=20251104; t=1774883890; x=1775488690;\n        h=content-transfer-encoding:in-reply-to:content-language:references\n         :cc:to:from:subject:user-agent:mime-version:date:message-id:x-gm-gg\n         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n        bh=7L8Y2A7BbK6eroZTnDlarDqLBiqenVGMWKEaxr9od+M=;\n        b=j2y95/zqGdCX4hx2BtZvNUYxjrhLy4SgndwM6qsmLwWOFjvYLSDfefAgdJ+Tmjs69p\n         SeaA+vHgUGqr/XVXFsQ0fT8/xSBzH4bGeZGg58m0qTemlde8HHMLSaWtmhth24HhzhxV\n         j4HW4fRrsOFWDDUii4MOXK6896qtRbuvPWkvzdIY7vfBXa0vc+SkFVXqLxCD2+gEzo8x\n         tdqNp1dH5YaU+/+wALlMDvVk0okJe0rCE5nDxAGkaCyPKgLPMa/tfDpp6sMD07k580eL\n         rMZi755GA5pmsXVYnQLvsul2B5eWVqvBKXc8Imzp1pCGKd4LQJd/fU7ryZB9xsY9S8zQ\n         TnvA==",
        "X-Gm-Message-State": "AOJu0YyOjuBNQQletDHYWkkoSzaDxvfMVn1wJd76DFVI7cmI5BtUuDtg\n\tNxiYWq6iwvehuIOBCVCcUDcsG6nL3J0CwXP9GJFK9UIJv8Z8rkqI855xSchGjw==",
        "X-Gm-Gg": "ATEYQzxD+y2YMXx8L5OC8ZYiBzuETKy5HX7TETSUEVZkX/+UeqsSjCtUhF4TBMgLa7i\n\tZs8akeuy5Jlk2QNPG+GCUJpq1c+sBmprZ7taaSSLtbhS2eIVpb0A4RSmRhvgnjJbxzKaMxCIZB/\n\toXhO327N/WZPXq5OD2FSi0SA1WeSr4OiS5quW11z0aogRnnPgaWTbq1+Avl9j/ToIgJYIcRXhzf\n\tIaDZIZwoLJqOSZ7v3Cd8TzqpJVabWCyxn+WiXdadFQBe1N1TnCkIj8yrDs4kFX8jkC0pFS1Po/Q\n\tp+PX3rESgt+VGedtHuladfv8IZRLT8Y6kI46XYSeajJbl3F6JZSVePPy7ftWFWE/57IIe2dcZsI\n\tVbzmwXeJiByR+j+ud3DULGFmkEeS8CTm2+04t17x/dyqHFq+Y11HuWKWJI1gVQE1GdXxyckAULD\n\tkRf1n1FbyHZn7wen1x3OP/pPSlcKjAV6OLiyLmIuIT+MjU+Ly/Z3T5rwlAp1TAlEXNAmrMDWAyE\n\tR2Xo6O4C/Bwyq+EHfI72Z9uhKQbUn3MkPl8k5MqDNbehB1Up1KwyyeW9ugpfAeB0A==",
        "X-Received": "by 2002:a05:600c:4e15:b0:485:35ee:f836 with SMTP id\n 5b1f17b1804b1-48727d5a191mr221172245e9.2.1774883890064;\n        Mon, 30 Mar 2026 08:18:10 -0700 (PDT)",
        "Message-ID": "<ad6ef45a-1e47-4bc4-b9fd-6ba3ec8ca83e@gmail.com>",
        "Date": "Mon, 30 Mar 2026 17:18:08 +0200",
        "Precedence": "bulk",
        "X-Mailing-List": "linux-ide@vger.kernel.org",
        "List-Id": "<linux-ide.vger.kernel.org>",
        "List-Subscribe": "<mailto:linux-ide+subscribe@vger.kernel.org>",
        "List-Unsubscribe": "<mailto:linux-ide+unsubscribe@vger.kernel.org>",
        "MIME-Version": "1.0",
        "User-Agent": "Mozilla Thunderbird",
        "Subject": "[PATCH 1/5] ata: libata-transport: instantiate struct ata_internal\n statically",
        "From": "Heiner Kallweit <hkallweit1@gmail.com>",
        "To": "Damien Le Moal <dlemoal@kernel.org>, Niklas Cassel <cassel@kernel.org>",
        "Cc": "linux-ide@vger.kernel.org",
        "References": "<8592ed06-3a6f-45cb-9811-e163f31f7183@gmail.com>",
        "Content-Language": "en-US",
        "In-Reply-To": "<8592ed06-3a6f-45cb-9811-e163f31f7183@gmail.com>",
        "Content-Type": "text/plain; charset=UTF-8",
        "Content-Transfer-Encoding": "7bit"
    },
    "content": "Struct ata_internal is only instantiated once, in module init code.\nSo we can also instantiate it statically, what allows to simplify the\ncode.\n\nSigned-off-by: Heiner Kallweit <hkallweit1@gmail.com>\n---\n drivers/ata/libata-core.c      | 11 ++-----\n drivers/ata/libata-transport.c | 57 +++++++++++++++-------------------\n drivers/ata/libata-transport.h |  2 +-\n 3 files changed, 28 insertions(+), 42 deletions(-)",
    "diff": "diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c\nindex 81479ddb8..ae56567af 100644\n--- a/drivers/ata/libata-core.c\n+++ b/drivers/ata/libata-core.c\n@@ -6779,22 +6779,15 @@ static int __init ata_init(void)\n \n \tlibata_transport_init();\n \tata_scsi_transport_template = ata_attach_transport();\n-\tif (!ata_scsi_transport_template) {\n-\t\tata_sff_exit();\n-\t\trc = -ENOMEM;\n-\t\tgoto err_out;\n-\t}\n \n \tprintk(KERN_DEBUG \"libata version \" DRV_VERSION \" loaded.\\n\");\n-\treturn 0;\n \n-err_out:\n-\treturn rc;\n+\treturn 0;\n }\n \n static void __exit ata_exit(void)\n {\n-\tata_release_transport(ata_scsi_transport_template);\n+\tata_release_transport();\n \tlibata_transport_exit();\n \tata_sff_exit();\n \tata_free_force_param();\ndiff --git a/drivers/ata/libata-transport.c b/drivers/ata/libata-transport.c\nindex 7ad180265..0c7ce278e 100644\n--- a/drivers/ata/libata-transport.c\n+++ b/drivers/ata/libata-transport.c\n@@ -745,6 +745,23 @@ int ata_tlink_add(struct ata_link *link)\n \treturn error;\n }\n \n+static struct ata_internal ata_transport_internal = {\n+\t.t.eh_strategy_handler\t= ata_scsi_error,\n+\t.t.user_scan\t\t= ata_scsi_user_scan,\n+\n+\t.t.host_attrs.ac.class\t= &ata_port_class.class,\n+\t.t.host_attrs.ac.grp\t= &ata_port_attr_group,\n+\t.t.host_attrs.ac.match\t= ata_tport_match,\n+\n+\t.link_attr_cont.ac.class = &ata_link_class.class,\n+\t.link_attr_cont.ac.grp   = &ata_link_attr_group,\n+\t.link_attr_cont.ac.match = ata_tlink_match,\n+\n+\t.dev_attr_cont.ac.class\t= &ata_dev_class.class,\n+\t.dev_attr_cont.ac.grp\t= &ata_device_attr_group,\n+\t.dev_attr_cont.ac.match\t= ata_tdev_match,\n+};\n+\n /*\n  * Setup / Teardown code\n  */\n@@ -754,46 +771,22 @@ int ata_tlink_add(struct ata_link *link)\n  */\n struct scsi_transport_template *ata_attach_transport(void)\n {\n-\tstruct ata_internal *i;\n-\n-\ti = kzalloc_obj(struct ata_internal);\n-\tif (!i)\n-\t\treturn NULL;\n+\ttransport_container_register(&ata_transport_internal.t.host_attrs);\n+\ttransport_container_register(&ata_transport_internal.link_attr_cont);\n+\ttransport_container_register(&ata_transport_internal.dev_attr_cont);\n \n-\ti->t.eh_strategy_handler\t= ata_scsi_error;\n-\ti->t.user_scan\t\t\t= ata_scsi_user_scan;\n-\n-\ti->t.host_attrs.ac.class = &ata_port_class.class;\n-\ti->t.host_attrs.ac.grp   = &ata_port_attr_group;\n-\ti->t.host_attrs.ac.match = ata_tport_match;\n-\ttransport_container_register(&i->t.host_attrs);\n-\n-\ti->link_attr_cont.ac.class = &ata_link_class.class;\n-\ti->link_attr_cont.ac.grp   = &ata_link_attr_group;\n-\ti->link_attr_cont.ac.match = ata_tlink_match;\n-\ttransport_container_register(&i->link_attr_cont);\n-\n-\ti->dev_attr_cont.ac.class = &ata_dev_class.class;\n-\ti->dev_attr_cont.ac.grp   = &ata_device_attr_group;\n-\ti->dev_attr_cont.ac.match = ata_tdev_match;\n-\ttransport_container_register(&i->dev_attr_cont);\n-\n-\treturn &i->t;\n+\treturn &ata_transport_internal.t;\n }\n \n /**\n  * ata_release_transport  --  release ATA transport template instance\n  * @t:\t\ttransport template instance\n  */\n-void ata_release_transport(struct scsi_transport_template *t)\n+void ata_release_transport(void)\n {\n-\tstruct ata_internal *i = to_ata_internal(t);\n-\n-\ttransport_container_unregister(&i->t.host_attrs);\n-\ttransport_container_unregister(&i->link_attr_cont);\n-\ttransport_container_unregister(&i->dev_attr_cont);\n-\n-\tkfree(i);\n+\ttransport_container_unregister(&ata_transport_internal.t.host_attrs);\n+\ttransport_container_unregister(&ata_transport_internal.link_attr_cont);\n+\ttransport_container_unregister(&ata_transport_internal.dev_attr_cont);\n }\n \n __init int libata_transport_init(void)\ndiff --git a/drivers/ata/libata-transport.h b/drivers/ata/libata-transport.h\nindex 50cd2cbe8..a464b8fcd 100644\n--- a/drivers/ata/libata-transport.h\n+++ b/drivers/ata/libata-transport.h\n@@ -9,7 +9,7 @@ int ata_tlink_add(struct ata_link *link);\n void ata_tlink_delete(struct ata_link *link);\n \n struct scsi_transport_template *ata_attach_transport(void);\n-void ata_release_transport(struct scsi_transport_template *t);\n+void ata_release_transport(void);\n \n __init int libata_transport_init(void);\n void __exit libata_transport_exit(void);\n",
    "prefixes": [
        "1/5"
    ]
}