Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2217787/?format=api
{ "id": 2217787, "url": "http://patchwork.ozlabs.org/api/patches/2217787/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260330151437.1787008-1-peter.maydell@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260330151437.1787008-1-peter.maydell@linaro.org>", "list_archive_url": null, "date": "2026-03-30T15:14:37", "name": "target/i386: Treat qtest like TCG for supported-features", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "03504ca837a751254b04e538e9980a57d8832668", "submitter": { "id": 5111, "url": "http://patchwork.ozlabs.org/api/people/5111/?format=api", "name": "Peter Maydell", "email": "peter.maydell@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260330151437.1787008-1-peter.maydell@linaro.org/mbox/", "series": [ { "id": 498049, "url": "http://patchwork.ozlabs.org/api/series/498049/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=498049", "date": "2026-03-30T15:14:37", "name": "target/i386: Treat qtest like TCG for supported-features", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/498049/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2217787/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2217787/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=wfKquJCb;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fkvtr509qz1yG8\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 31 Mar 2026 02:15:00 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w7EKA-0006Hj-VC; Mon, 30 Mar 2026 11:14:42 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <peter.maydell@linaro.org>)\n id 1w7EK9-0006HM-KT\n for qemu-devel@nongnu.org; Mon, 30 Mar 2026 11:14:41 -0400", "from mail-wm1-x331.google.com ([2a00:1450:4864:20::331])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <peter.maydell@linaro.org>)\n id 1w7EK8-0002WL-04\n for qemu-devel@nongnu.org; Mon, 30 Mar 2026 11:14:41 -0400", "by mail-wm1-x331.google.com with SMTP id\n 5b1f17b1804b1-487012ce896so28358785e9.0\n for <qemu-devel@nongnu.org>; Mon, 30 Mar 2026 08:14:39 -0700 (PDT)", "from lanath.. (wildly.archaic.org.uk. [81.2.115.145])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48722c9506dsm274817715e9.7.2026.03.30.08.14.37\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 30 Mar 2026 08:14:37 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1774883678; x=1775488478; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=rDe9mceskDtU6tRQQCH8dZM09+QgHTJN3mHBBgRHyng=;\n b=wfKquJCbg2qe/HUNfbJiJycMyk1eHfNL8YWcmftMq1pi5gHs1E8aqmkP2V54XO/ZqX\n ow9p41nmcdTOYJzkVj0zHx99cwcx8FBO359qExGRZHdEBG66pNTmrB5P/uNzsHi/vlCy\n s6LTwSA8ZlSj5Op2Z/8T4StTwmor3mBJd4Fce8WnjZayS2gINLnXDCqkl5un6jF5xmE4\n ml2wVPyNJwRy7d8l9IvEv6+28cJ/6Q8J6AfBpdqo8WxMuNwvuergSs7boYGRFh5tjetr\n CDz5ox9Ep5aF7vh9HPnMP1QSpznngH4io+hUkEnP/2z9g5YNOa5nSToMDPHdjY1Za76Z\n BwZw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774883678; x=1775488478;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=rDe9mceskDtU6tRQQCH8dZM09+QgHTJN3mHBBgRHyng=;\n b=feX+UEnK3PSjRZYucbbLMmaAcL44ecqO7XpHZFSFaCb133BNeD6Pjvs1WNgd47liGU\n kln2nKsm2qpxlBTbjoxiEjyXFHrgRs7GO6vYrgMktUn7JO3ZevXbthMUHI/0rH1LXDKv\n SAX5cmi0BUefWM/8PSxWPbyfzxrIGkWhR6c0h1wUx9O7c/FUaC3wRDGmQu+PclVPFbkt\n I06h4kZw0vVA8Un1/lNVJdGMO7lxocKcx2FfFG97GDITjpI4MI62J3YAqPMx5+IC4Wy2\n gU9XZWGLdbxZRXWbNUI7Hyc2Y7EtCMxVz1FpuvZndMWbi77NSlGMRMCUuauh8GCVJZ7B\n +a9Q==", "X-Gm-Message-State": "AOJu0YzhYZHz25VJExqgfgTwIjqfAIOfQhHf5RFVgKc6BKJR/7XqRg7c\n C9CpZSd5dlqrt9HDlu/v6T9QtRJpNKDOKmWUA32WXkT5mga1OWRe93yz8jDE0sc3f1yd2XTioE5\n zIQWztxQ=", "X-Gm-Gg": "ATEYQzyo0q3RTCDjQx7/V+cOiTOMp8t70hTR6+lZo4rdDx+sPC6b5v/VAVEXnk22rxx\n YapVwftj+Yog+h3A5kUXMWEXgj3jSEXt57BP3koJjhssyq8kqKNBltj33gmGk100Lo2NwlJQgct\n LAUgxA69G/oicKCIOEAJAFyesJ+Bf/ftHHI9Zvcr1MSZ/JkWuHsn0hNkAMeCjw6aFHYKTvPoEMK\n bf59aFnuinzeTbPSggjrIIzfWPGp2e8G23BEg7BAS7w3X57DIacaPWFLyoSGdfLXRPh0TanCBCZ\n lP3HUxql1Y7w/zSmif9DDJD+DEvmZqCJ3IaqwiPbGdlzbj2EwGBgPe0GW6J8zeGZ5Hmv5A4gfcQ\n u1GQcF1ZMk9Njnz5kdQVnRJnklawQlKuJzwyLzSdp79AaxR0fW5v/9woKe6/+cgS99UUpSlVZXD\n CVCWas4HecpXd4li3YJhq5/Bx11YMpMpIsocq78ozj/ga05NRcYiMKRtdSk02Q8f2ctQgbt2qQv\n ALxdad14nM4vvnHId4VZpjMkwEOZnU=", "X-Received": "by 2002:a05:600c:c178:b0:487:59c:2bb8 with SMTP id\n 5b1f17b1804b1-48727ef16bamr220414415e9.27.1774883678453;\n Mon, 30 Mar 2026 08:14:38 -0700 (PDT)", "From": "Peter Maydell <peter.maydell@linaro.org>", "To": "qemu-devel@nongnu.org", "Cc": "Paolo Bonzini <pbonzini@redhat.com>,\n\tZhao Liu <zhao1.liu@intel.com>", "Subject": "[PATCH] target/i386: Treat qtest like TCG for supported-features", "Date": "Mon, 30 Mar 2026 16:14:37 +0100", "Message-ID": "<20260330151437.1787008-1-peter.maydell@linaro.org>", "X-Mailer": "git-send-email 2.43.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2a00:1450:4864:20::331;\n envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x331.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "In x86_cpu_get_supported_feature_word() we figure out the supported\nfeatures differently for each accelerator. The default case is\n\"set all feature bits\"; however this triggers a warning because\nit enables two features which conflict with each other:\n\n$ ./build/x86/qemu-system-x86_64 -cpu max -accel qtest -S\nqemu-system-x86_64: warning: this feature conflicts with APX: CPUID[eax=07h,ecx=00h].EBX.mpx [bit 14]\nqemu-system-x86_64: warning: this feature conflicts with MPX: CPUID[eax=07h,ecx=01h].EDX.apxf [bit 21]\n\nTreat qtest like TCG here, to avoid the complaint.\n\nSigned-off-by: Peter Maydell <peter.maydell@linaro.org>\n---\nThis suggests to me that the default case is not something\nwe ever want to be in, and we should instead be exhaustively\nenumerating the accelerators and asserting if we don't know\nhow to handle this for the accelerator in use. But there are\nseveral accelerators that we don't have code for here...\n---\n target/i386/cpu.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/target/i386/cpu.c b/target/i386/cpu.c\nindex 3b0a7c7363..c6fd1dc00e 100644\n--- a/target/i386/cpu.c\n+++ b/target/i386/cpu.c\n@@ -8087,7 +8087,7 @@ uint64_t x86_cpu_get_supported_feature_word(X86CPU *cpu, FeatureWord w)\n r = hvf_get_supported_cpuid(wi->cpuid.eax,\n wi->cpuid.ecx,\n wi->cpuid.reg);\n- } else if (tcg_enabled()) {\n+ } else if (tcg_enabled() || qtest_enabled()) {\n r = wi->tcg_features;\n } else {\n return ~0;\n", "prefixes": [] }