Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2217763/?format=api
{ "id": 2217763, "url": "http://patchwork.ozlabs.org/api/patches/2217763/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260330143123.1685142-2-peter.maydell@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260330143123.1685142-2-peter.maydell@linaro.org>", "list_archive_url": null, "date": "2026-03-30T14:31:22", "name": "[1/2] include: Don't include guest-host.h in cpu-ldst.h", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "c5c298910a6f94e72184a76da5506e226e799c25", "submitter": { "id": 5111, "url": "http://patchwork.ozlabs.org/api/people/5111/?format=api", "name": "Peter Maydell", "email": "peter.maydell@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260330143123.1685142-2-peter.maydell@linaro.org/mbox/", "series": [ { "id": 498040, "url": "http://patchwork.ozlabs.org/api/series/498040/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=498040", "date": "2026-03-30T14:31:22", "name": "linux-user: Fix incorrect sign-extension of guest addresses", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/498040/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2217763/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2217763/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=X1+l1hPi;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fktxX0hyjz1yG8\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 31 Mar 2026 01:32:16 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w7DeW-00015P-3l; Mon, 30 Mar 2026 10:31:45 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <peter.maydell@linaro.org>)\n id 1w7DeO-00014x-TV\n for qemu-devel@nongnu.org; Mon, 30 Mar 2026 10:31:33 -0400", "from mail-wm1-x331.google.com ([2a00:1450:4864:20::331])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <peter.maydell@linaro.org>)\n id 1w7DeK-0002d6-Ac\n for qemu-devel@nongnu.org; Mon, 30 Mar 2026 10:31:30 -0400", "by mail-wm1-x331.google.com with SMTP id\n 5b1f17b1804b1-486fda2a389so37033205e9.1\n for <qemu-devel@nongnu.org>; Mon, 30 Mar 2026 07:31:27 -0700 (PDT)", "from lanath.. (wildly.archaic.org.uk. [81.2.115.145])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48722d49c18sm279767145e9.14.2026.03.30.07.31.25\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 30 Mar 2026 07:31:25 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1774881087; x=1775485887; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=FPfexUg//huq83MvV9fAvc/hO7xuXpj/vqxDNr67Au8=;\n b=X1+l1hPiC5RKz6MBxFBtoSHQzz2SnaZHslNO2ZVrV5RoBDLUKBMZxzTyTyexFi/cfs\n MBHo5Wmu683OH22SW0YwqdVG/1t3s4tLGw++MktrIcl52HhRApDoy34+a2M/8SPiri7y\n kPrv134oqhBmk5D9zOKbYefzEN3imGpolx+eCS9eNLoaQQdiDDM8K6p4MttF0dRZ8Efy\n t1WnJS0Gdd5wNgAb8WasTi45sFxW/20KE3gDADYofBosyIJHQsCro6JYJtopGOLLX75l\n 9TV0VUtaFnk9gwWCbm95UB2hN1QOoE3RxHaEudG1BLZsJ1G9KtOdWfn7XPm9Y8eLDIzH\n bDiQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774881087; x=1775485887;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=FPfexUg//huq83MvV9fAvc/hO7xuXpj/vqxDNr67Au8=;\n b=YSHLQGs+xOnCAAxOSCbOVYEJTmK/53Wwujl09qiAvEtNyRCWnxTUB8dKXy9FnGHrqj\n 0wBUReq93VHHBUPf140fozdCn3EikkJq2LKfppghZc3ol8gDXk8aokDa5J2sLHsnhdgI\n zUplQ1itblRQeMU2AlBxYWCWm5ZwlEkNNzDCA2Kh2jqbiGKspPusl+grH2kojdYHNh4A\n 9VX23kwNRT75b84mfTe5IZcsqDkLr812+iYIEWv6t82bJuqts6bhhGhWmH6Al+3zxQcX\n NTjTOy88ob1xbcDG2mkWMTBWDeWItSTP8YikBO+0NaZFTIxrqJvyDPZvyEo7cxw8ya5q\n FRXw==", "X-Gm-Message-State": "AOJu0YzO3YoQkKvtf3TdrlcDzRAop4gygM9wYeXy/aB/Mt72IJaieGgI\n GhXWWNNC/sNZvxE4IVFE88uKm7VhUnhmsh2/WW+jqGn337jSTRArzwg4bRceimFQo4DdW3dVqEK\n 0G7ezvoA=", "X-Gm-Gg": "ATEYQzzke5zUa5cDr4uPs3H8jHSoJzPx5qsw724ocQNlsCqYbIB+Ket7jjV280sdcE6\n dldCSXa7SYMULGaX34y3l0lvmx6GDPcgczH/0u6iICeeH69TBA5rXX53XQ0963A7XX7JQXOjSb7\n scQSMu0MRpOKAFoBPAnxxo4bb6VeX6kji3LYz8cRLSPp7J+CtbR11W3nvd0IPLodBdSe9XbWAex\n BmI7s1ZN04Z+EoohLmsD3yC28kyrljBRyK8mH63C/JdOnTzIRVjpEAAAjhlXhchs+6QXq10LUUI\n pI0YzL7z3101aNA5Bd7yZX39Q8rX6k0dJ0kF6x9QmfnJ7vY+TtorHk/x82IpSdxm56RvhD//cRX\n HtGjyc/qqv18WcUcBeMbf+6pT42l5d2KEUWRiqjU+k3HbTMT9DNuz5kgGx8786wqNwGMprurF0R\n KakPStG0HPkmr+6/Hz8X73lb7L9iffcmxoqnoBBiXrlS9/sT9T53fGCjtJR5BIjUPnXCxNBSFh8\n 7VRy+htOR/plJ3+KxuFSkASPRBBMEhFhXO334PA3A==", "X-Received": "by 2002:a05:600c:4e15:b0:485:2ce2:4c8a with SMTP id\n 5b1f17b1804b1-48727d67a21mr203850625e9.1.1774881086527;\n Mon, 30 Mar 2026 07:31:26 -0700 (PDT)", "From": "Peter Maydell <peter.maydell@linaro.org>", "To": "qemu-devel@nongnu.org", "Cc": "qemu-stable@nongnu.org, Richard Henderson <richard.henderson@linaro.org>,\n Warner Losh <imp@bsdimp.com>, Kyle Evans <kevans@freebsd.org>,\n Laurent Vivier <laurent@vivier.eu>,\n Pierrick Bouvier <pierrick.bouvier@linaro.org>", "Subject": "[PATCH 1/2] include: Don't include guest-host.h in cpu-ldst.h", "Date": "Mon, 30 Mar 2026 15:31:22 +0100", "Message-ID": "<20260330143123.1685142-2-peter.maydell@linaro.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20260330143123.1685142-1-peter.maydell@linaro.org>", "References": "<20260330143123.1685142-1-peter.maydell@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2a00:1450:4864:20::331;\n envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x331.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "We currently include user/guest-host.h from accel/tcg/cpu-ldst.h.\nHowever that file doesn't need anything from guest-host.h, since we\nremoved the uses of g2h() in commit 9b74d403b30e (\"accel/tcg: Move\nuser-only tlb_vaddr_to_host out of line\").\n\nMove the include of guest-host.h to where it's actually needed.\n\nSigned-off-by: Peter Maydell <peter.maydell@linaro.org>\n---\nThis isn't needed for the following bugfix patch, but it made\nit a bit easier for me to understand where we're actually using\nthe functions.\n---\n bsd-user/qemu.h | 1 +\n include/accel/tcg/cpu-ldst.h | 4 ----\n linux-user/qemu.h | 1 +\n 3 files changed, 2 insertions(+), 4 deletions(-)", "diff": "diff --git a/bsd-user/qemu.h b/bsd-user/qemu.h\nindex 2c586e546f..b0b2c249fb 100644\n--- a/bsd-user/qemu.h\n+++ b/bsd-user/qemu.h\n@@ -27,6 +27,7 @@\n #include \"user/abitypes.h\"\n #include \"user/cpu_loop.h\"\n #include \"user/page-protection.h\"\n+#include \"user/guest-host.h\"\n \n extern char **environ;\n \ndiff --git a/include/accel/tcg/cpu-ldst.h b/include/accel/tcg/cpu-ldst.h\nindex a5711bc15a..ea2cbf40fe 100644\n--- a/include/accel/tcg/cpu-ldst.h\n+++ b/include/accel/tcg/cpu-ldst.h\n@@ -71,10 +71,6 @@\n #include \"accel/tcg/cpu-mmu-index.h\"\n #include \"exec/abi_ptr.h\"\n \n-#if defined(CONFIG_USER_ONLY)\n-#include \"user/guest-host.h\"\n-#endif /* CONFIG_USER_ONLY */\n-\n static inline uint32_t\n cpu_ldub_mmuidx_ra(CPUArchState *env, abi_ptr addr, int mmu_idx, uintptr_t ra)\n {\ndiff --git a/linux-user/qemu.h b/linux-user/qemu.h\nindex 85e68eff7b..cfe5f45fc4 100644\n--- a/linux-user/qemu.h\n+++ b/linux-user/qemu.h\n@@ -10,6 +10,7 @@\n #include \"syscall_defs.h\"\n #include \"target_syscall.h\"\n #include \"accel/tcg/vcpu-state.h\"\n+#include \"user/guest-host.h\"\n \n /*\n * This is the size of the host kernel's sigset_t, needed where we make\n", "prefixes": [ "1/2" ] }