Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2217762/?format=api
{ "id": 2217762, "url": "http://patchwork.ozlabs.org/api/patches/2217762/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260330141818.286412-1-pbonzini@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260330141818.286412-1-pbonzini@redhat.com>", "list_archive_url": null, "date": "2026-03-30T14:18:18", "name": "thread-win32: replace CRITICAL_SECTION with SRWLOCK", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "093f2386490bb3c8216d1c234461ffc39f8f2bf7", "submitter": { "id": 2701, "url": "http://patchwork.ozlabs.org/api/people/2701/?format=api", "name": "Paolo Bonzini", "email": "pbonzini@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260330141818.286412-1-pbonzini@redhat.com/mbox/", "series": [ { "id": 498039, "url": "http://patchwork.ozlabs.org/api/series/498039/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=498039", "date": "2026-03-30T14:18:18", "name": "thread-win32: replace CRITICAL_SECTION with SRWLOCK", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/498039/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2217762/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2217762/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=OccxEV4r;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=OQj6j2NK;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fktfC6rctz1yG8\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 31 Mar 2026 01:18:59 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w7DRo-00043O-2B; Mon, 30 Mar 2026 10:18:32 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <pbonzini@redhat.com>)\n id 1w7DRl-000431-Ep\n for qemu-devel@nongnu.org; Mon, 30 Mar 2026 10:18:29 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <pbonzini@redhat.com>)\n id 1w7DRi-0000cq-G0\n for qemu-devel@nongnu.org; Mon, 30 Mar 2026 10:18:29 -0400", "from mail-wr1-f69.google.com (mail-wr1-f69.google.com\n [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-215-GTVJAfxsO96rMOw2mQczWw-1; Mon, 30 Mar 2026 10:18:22 -0400", "by mail-wr1-f69.google.com with SMTP id\n ffacd0b85a97d-43cfb72377bso858414f8f.2\n for <qemu-devel@nongnu.org>; Mon, 30 Mar 2026 07:18:22 -0700 (PDT)", "from [192.168.10.48] ([151.49.85.67])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48730688605sm297329635e9.10.2026.03.30.07.18.18\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 30 Mar 2026 07:18:19 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1774880304;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding;\n bh=yXY+tUsnoMaN/Ux1syF3v+VajHKWT9WhN4BtA+Pwhqk=;\n b=OccxEV4rysqSyv/IyP+RIb8tOB1raebvq3XR8ZM2P81GhdPh6eSf3FTBJsNMCnkp69yKA9\n b6+5puZv3/NLLBPfpS2CCh2IPCjLtHMpuqp1nUH6liTXjQS+DQK6uz+oPpsGzbgNrBuGEp\n LkKiThoqRG6tGjV+bbOUFyT++wGNdVE=", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1774880301; x=1775485101; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=yXY+tUsnoMaN/Ux1syF3v+VajHKWT9WhN4BtA+Pwhqk=;\n b=OQj6j2NKjXYWJFaJxgmy53en4yenQDt1dAgmSa4bj4JQ+sHZ4aGtceiC2ORpN5Iptw\n NjrFJFZ68l5Vlmfj6Z3hGbFRi3hO/USPVcwVBYaHKQwQ+LRMsNTAGns67fM5nWa4f6Qn\n wvICwXA5QiMdIZNH/nv/Smda3QErtMwM/zfh6+YDhC54nAJ4daKbiPcTjrnjR0D4vphp\n fQQubMUZ3w/5sscARzrRyRif55TukTFydwiEtDRT1dPzYfzXCcb9iziNrI7gbhX+cgWn\n vmixc8dqZUiPHGO4l3U2fnePNZnxzzqFIapilA9Sn4yQsj3T7uFlsr/IHxAPtFXqfvUK\n oUgA==" ], "X-MC-Unique": "GTVJAfxsO96rMOw2mQczWw-1", "X-Mimecast-MFC-AGG-ID": "GTVJAfxsO96rMOw2mQczWw_1774880301", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774880301; x=1775485101;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=yXY+tUsnoMaN/Ux1syF3v+VajHKWT9WhN4BtA+Pwhqk=;\n b=dsuY5myhd42LHeltcXAdFMmP3Gn2FIHwo8KCDWXxWA8mjKtkhbrSp2WwRrM/GcVPiY\n 9qRRKJyCmfA30Ba8gFbUkAjgFbzoay+sP7Gjsjb8zQPz7Q+icucfrxAh+h3GmACYrqpm\n 7NVHs43eShkhHF77Hv3/Skzj75kHGTN82td7uMjwZVSsOv063+wkOjL8Q1cgF2WMGN0F\n JSq/bbednRdGdUMgGRjWsmme0OhrK+JdFFigwA263Z/oUsSBQGlTLOKRORlcQoyDfrmz\n zgWUiiWlSmmQt3rF1Dcaa7c/EccTmduDk/rAl1/7URYnEBVdprxCJolzaz5I7b7v/mRx\n jFyw==", "X-Gm-Message-State": "AOJu0Yy+B/XKo9mH3nYoXRd2hYlnH0Umtpm5Pq4164FpAFvs/QocLbxI\n VEjNRCjSzzUXpEBmFFTQFWU8gfCp7shGnES6uUEJQdIjNiHHLKfHo07PQrrYT+aH/Go8n1bvSTl\n 6+JTZg/4Qb4pI4t1EMGAadDV+e85kbaHTzTR8OZfdMT/xvXCHaFlpvl5PVd3fSm8fOi2TLXOxoB\n s6DJjbMAjkP5EBj65JmyNg0yOUAHza0y2W3zKLN66F", "X-Gm-Gg": "ATEYQzyacTSn+R9YXN05GyMlLq/p9vxZnZYEEDP7d6LNz4ibQAIz5+MqKtTw/gg1iSp\n cteLN3tWJGipHmA5qh2RjNsBP5kArdRjzviLarBVG3Dxnv/meI6uEox3mMUseTlXXv4iVaOk9SG\n zwhs6zBowSo0uvY0jQgadCFkrPelqjIlTQLVdWOQJorz8IgBX84fBjTIUpIW/djWvbuuYiC8ys8\n lVA2XfogmWJGz21fhXzbMX4OPEzVcHxjfPtsM0zn9PT1VOQmiMlqPD+ypMVosx6eT/3/b6VuNfk\n jmkNsx+A7DOohNqYwLwslaUJxm7/EabjZvfU+lP0uC1j1Qqh87CnzxgasQE+MP4Tipb94j2iUVF\n 0LnZdB9cS/ozEVTBesejyOYztPPGzH2tZm2qxixHwpsqpR6y9Pc43eklB1I3pCvzQ0OiAAdqIai\n nR/p/W6lr2maSllIQ7M9vv0KnY", "X-Received": [ "by 2002:a05:600c:c102:b0:485:3812:36f6 with SMTP id\n 5b1f17b1804b1-48727f7bd61mr151249405e9.21.1774880300502;\n Mon, 30 Mar 2026 07:18:20 -0700 (PDT)", "by 2002:a05:600c:c102:b0:485:3812:36f6 with SMTP id\n 5b1f17b1804b1-48727f7bd61mr151248775e9.21.1774880299792;\n Mon, 30 Mar 2026 07:18:19 -0700 (PDT)" ], "From": "Paolo Bonzini <pbonzini@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "kkostiuk@redhat.com", "Subject": "[PATCH] thread-win32: replace CRITICAL_SECTION with SRWLOCK", "Date": "Mon, 30 Mar 2026 16:18:18 +0200", "Message-ID": "<20260330141818.286412-1-pbonzini@redhat.com>", "X-Mailer": "git-send-email 2.53.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=170.10.129.124;\n envelope-from=pbonzini@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-5", "X-Spam_score": "-0.6", "X-Spam_bar": "/", "X-Spam_report": "(-0.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=1,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=1, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "SRWLOCK is a much cheaper primitive than CRITICAL_SECTION, which\nbasically exists only as a legacy API. The SRWLOCK is a single word\nin memory and it is cheaper to just initialize it always.\n\nSigned-off-by: Paolo Bonzini <pbonzini@redhat.com>\n---\n util/qemu-thread-win32.c | 16 ++++++----------\n 1 file changed, 6 insertions(+), 10 deletions(-)", "diff": "diff --git a/util/qemu-thread-win32.c b/util/qemu-thread-win32.c\nindex 272afc33856..3037732a6fe 100644\n--- a/util/qemu-thread-win32.c\n+++ b/util/qemu-thread-win32.c\n@@ -242,7 +242,7 @@ struct QemuThreadData {\n /* Only used for joinable threads. */\n bool exited;\n void *ret;\n- CRITICAL_SECTION cs;\n+ SRWLOCK lock;\n };\n \n static bool atexit_registered;\n@@ -295,9 +295,9 @@ void qemu_thread_exit(void *arg)\n notifier_list_notify(&data->exit, NULL);\n if (data->mode == QEMU_THREAD_JOINABLE) {\n data->ret = arg;\n- EnterCriticalSection(&data->cs);\n+ AcquireSRWLockExclusive(&data->lock);\n data->exited = true;\n- LeaveCriticalSection(&data->cs);\n+ ReleaseSRWLockExclusive(&data->lock);\n } else {\n g_free(data);\n }\n@@ -328,7 +328,6 @@ void *qemu_thread_join(QemuThread *thread)\n CloseHandle(handle);\n }\n ret = data->ret;\n- DeleteCriticalSection(&data->cs);\n g_free(data);\n return ret;\n }\n@@ -357,6 +356,7 @@ void qemu_thread_create(QemuThread *thread, const char *name,\n struct QemuThreadData *data;\n \n data = g_malloc(sizeof *data);\n+ InitializeSRWLock(&data->lock);\n data->start_routine = start_routine;\n data->arg = arg;\n data->mode = mode;\n@@ -364,10 +364,6 @@ void qemu_thread_create(QemuThread *thread, const char *name,\n data->name = g_strdup(name);\n notifier_list_init(&data->exit);\n \n- if (data->mode != QEMU_THREAD_DETACHED) {\n- InitializeCriticalSection(&data->cs);\n- }\n-\n hThread = (HANDLE) _beginthreadex(NULL, 0, win32_start_routine,\n data, 0, &thread->tid);\n if (!hThread) {\n@@ -406,14 +402,14 @@ HANDLE qemu_thread_get_handle(QemuThread *thread)\n return NULL;\n }\n \n- EnterCriticalSection(&data->cs);\n+ AcquireSRWLockExclusive(&data->lock);\n if (!data->exited) {\n handle = OpenThread(SYNCHRONIZE | THREAD_SUSPEND_RESUME |\n THREAD_SET_CONTEXT, FALSE, thread->tid);\n } else {\n handle = NULL;\n }\n- LeaveCriticalSection(&data->cs);\n+ ReleaseSRWLockExclusive(&data->lock);\n return handle;\n }\n \n", "prefixes": [] }