Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2217746/?format=api
{ "id": 2217746, "url": "http://patchwork.ozlabs.org/api/patches/2217746/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260330130104.85200-1-Stepan.Popov@kaspersky.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260330130104.85200-1-Stepan.Popov@kaspersky.com>", "list_archive_url": null, "date": "2026-03-30T13:01:04", "name": "thread-pool: signal condition variable while holding lock", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "f4c01bf97448a7a604c09a614899d29c8273434b", "submitter": { "id": 93008, "url": "http://patchwork.ozlabs.org/api/people/93008/?format=api", "name": "Stepan Popov", "email": "Stepan.Popov@kaspersky.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260330130104.85200-1-Stepan.Popov@kaspersky.com/mbox/", "series": [ { "id": 498028, "url": "http://patchwork.ozlabs.org/api/series/498028/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=498028", "date": "2026-03-30T13:01:04", "name": "thread-pool: signal condition variable while holding lock", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/498028/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2217746/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2217746/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kaspersky.com header.i=@kaspersky.com\n header.a=rsa-sha256 header.s=mail202505 header.b=qJhTgkZZ;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fksVg1Py0z1yGW\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 31 Mar 2026 00:27:23 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w7Cdd-0005rU-Kd; Mon, 30 Mar 2026 09:26:41 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <Stepan.Popov@kaspersky.com>)\n id 1w7CFN-0008GJ-Aw; Mon, 30 Mar 2026 09:01:40 -0400", "from mx9.kaspersky-labs.com ([195.122.169.44])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <Stepan.Popov@kaspersky.com>)\n id 1w7CFL-0002H3-Fk; Mon, 30 Mar 2026 09:01:37 -0400", "from relay9.kaspersky-labs.com (localhost [127.0.0.1])\n by relay9.kaspersky-labs.com (Postfix) with ESMTP id B0D488A07DF;\n Mon, 30 Mar 2026 16:01:21 +0300 (MSK)", "from mail-hq2.kaspersky.com (unknown [91.103.66.208])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (Client CN \"mail-hq2.kaspersky.com\",\n Issuer \"Kaspersky MailRelays CA G3\" (verified OK))\n by mailhub9.kaspersky-labs.com (Postfix) with ESMTPS id 85F4F8A32BB;\n Mon, 30 Mar 2026 16:01:21 +0300 (MSK)", "from stepan-vm.localdomain (10.16.90.37) by HQMAILSRV1.avp.ru\n (10.64.57.51) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Mon, 30 Mar\n 2026 16:01:14 +0300" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=kaspersky.com;\n s=mail202505; t=1774875681;\n bh=z/RHKpSmPkqQxuqWYQaF/0vmieLwibbWTvsHIKsi/GE=;\n h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type;\n b=qJhTgkZZA3F9rVKyahnmRJ9/rS6yjWL5Tt0m4ZO14Gxf2kfvyj4eHOs+s+7YEwsMN\n aZak8k5zHvlY5izw3+juanAEGKYib+uc7wG6E0DFA0L2zTmjcF1A54rr3hwDvHJOFK\n QCj/7L8vXydjwBIC07X8OtPjUVN/Z7m36STiwGQPve0R5UOxiamE9CWmNIyIaUORMW\n msJseSdk1yuQMJZh3fnfDO4szh+u2/3H6j4/wqcomx5MZWIEe1DuoVu2E0WsanL2qO\n /+GGN5y3TYOkkg873FOlMQkJEHRM0xC05SEBtJGLiLoGNDmCS8tbsXIZ6blRYR4gBh\n p2xu73IrjC+vQ==", "From": "Stepan Popov <Stepan.Popov@kaspersky.com>", "To": "<qemu-devel@nongnu.org>", "CC": "<qemu-trivial@nongnu.org>, Paolo Bonzini <pbonzini@redhat.com>, Stepan\n Popov <Stepan.Popov@kaspersky.com>", "Subject": "[PATCH] thread-pool: signal condition variable while holding lock", "Date": "Mon, 30 Mar 2026 16:01:04 +0300", "Message-ID": "<20260330130104.85200-1-Stepan.Popov@kaspersky.com>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.16.90.37]", "X-ClientProxiedBy": "HQMAILSRV4.avp.ru (10.64.57.54) To HQMAILSRV1.avp.ru\n (10.64.57.51)", "X-KSE-ServerInfo": "HQMAILSRV1.avp.ru, 9", "X-KSE-AntiSpam-Interceptor-Info": "scan successful", "X-KSE-AntiSpam-Version": "6.1.1, Database issued on: 03/30/2026 12:38:29", "X-KSE-AntiSpam-Status": "KAS_STATUS_NOT_DETECTED", "X-KSE-AntiSpam-Method": "none", "X-KSE-AntiSpam-Rate": "0", "X-KSE-AntiSpam-Info": [ "Lua profiles 201777 [Mar 30 2026]", "Version: 6.1.1.22", "Envelope from: Stepan.Popov@kaspersky.com", "LuaCore: 95 0.3.95\n 0e4b6d4f1992c354ebd6a5cc3c5624a3b0aa8cbc", "{Tracking_cluster_exceptions}", "{Tracking_real_kaspersky_domains}", "{Tracking_black_eng_exceptions}", "{Tracking_from_domain_doesnt_match_to}", "kaspersky.com:7.1.1,5.0.1;\n d41d8cd98f00b204e9800998ecf8427e.com:7.1.1; 127.0.0.199:7.1.2", "{Tracking_white_helo}", "FromAlignment: s", "Rate: 0", "Status: not_detected", "Method: none" ], "X-KSE-Antiphishing-Info": "Clean", "X-KSE-Antiphishing-ScanningType": "Deterministic", "X-KSE-Antiphishing-Method": "None", "X-KSE-Antiphishing-Bases": "03/30/2026 12:39:00", "X-KSE-AttachmentFiltering-Interceptor-Info": [ "no applicable attachment filtering\n rules found", "no applicable attachment filtering\n rules found" ], "X-KSE-Antivirus-Interceptor-Info": "scan successful", "X-KSE-Antivirus-Info": "Clean, bases: 3/30/2026 12:28:00 PM", "X-KSE-BulkMessagesFiltering-Scan-Result": [ "InTheLimit", "InTheLimit" ], "X-KSMG-AntiPhishing": "NotDetected", "X-KSMG-AntiSpam-Interceptor-Info": "not scanned", "X-KSMG-AntiSpam-Status": "not scanned, disabled by settings", "X-KSMG-AntiVirus": "Kaspersky Secure Mail Gateway, version 2.1.1.8310,\n bases: 2026/03/30 05:24:00 #28352470", "X-KSMG-AntiVirus-Status": "NotDetected, skipped", "X-KSMG-LinksScanning": "NotDetected", "X-KSMG-Message-Action": "skipped", "X-KSMG-Rule-ID": "52", "Received-SPF": "pass client-ip=195.122.169.44;\n envelope-from=Stepan.Popov@kaspersky.com; helo=mx9.kaspersky-labs.com", "X-Spam_score_int": "-29", "X-Spam_score": "-3.0", "X-Spam_bar": "---", "X-Spam_report": "(-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=1, RCVD_IN_VALIDITY_RPBL_BLOCKED=1,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-Mailman-Approved-At": "Mon, 30 Mar 2026 09:26:41 -0400", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Move qemu_cond_signal() inside the critical section protected by pool->lock.\nSignaling while holding the lock imposes more predictable scheduling behavior.\n\nSigned-off-by: Stepan Popov <Stepan.Popov@kaspersky.com>\n---\n util/thread-pool.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/util/thread-pool.c b/util/thread-pool.c\nindex 8f8cb38d5c..8e55aefd07 100644\n--- a/util/thread-pool.c\n+++ b/util/thread-pool.c\n@@ -265,8 +265,8 @@ BlockAIOCB *thread_pool_submit_aio(ThreadPoolFunc *func, void *arg,\n spawn_thread(pool);\n }\n QTAILQ_INSERT_TAIL(&pool->request_list, req, reqs);\n- qemu_mutex_unlock(&pool->lock);\n qemu_cond_signal(&pool->request_cond);\n+ qemu_mutex_unlock(&pool->lock);\n return &req->common;\n }\n \n", "prefixes": [] }