Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2217745/?format=api
{ "id": 2217745, "url": "http://patchwork.ozlabs.org/api/patches/2217745/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pci/patch/20260330-fix_pciatops-v7-2-f601818417e8@linux.ibm.com/", "project": { "id": 28, "url": "http://patchwork.ozlabs.org/api/projects/28/?format=api", "name": "Linux PCI development", "link_name": "linux-pci", "list_id": "linux-pci.vger.kernel.org", "list_email": "linux-pci@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260330-fix_pciatops-v7-2-f601818417e8@linux.ibm.com>", "list_archive_url": null, "date": "2026-03-30T13:09:45", "name": "[v7,2/3] PCI: AtomicOps: Do not enable without support in root port", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "e1792fb4cd5a30407c504278042c44984eea07b1", "submitter": { "id": 85804, "url": "http://patchwork.ozlabs.org/api/people/85804/?format=api", "name": "Gerd Bayer", "email": "gbayer@linux.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-pci/patch/20260330-fix_pciatops-v7-2-f601818417e8@linux.ibm.com/mbox/", "series": [ { "id": 498027, "url": "http://patchwork.ozlabs.org/api/series/498027/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pci/list/?series=498027", "date": "2026-03-30T13:09:44", "name": "PCI: AtomicOps: Fix pci_enable_atomic_ops_to_root()", "version": 7, "mbox": "http://patchwork.ozlabs.org/series/498027/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2217745/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2217745/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-pci+bounces-51452-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-pci@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=aIoIb2ae;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-pci+bounces-51452-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com\n header.b=\"aIoIb2ae\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=148.163.158.5", "smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=linux.ibm.com" ], "Received": [ "from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fksDM0MC4z1yG8\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 31 Mar 2026 00:14:59 +1100 (AEDT)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id A7984307078D\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 30 Mar 2026 13:10:31 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 608E43D47CE;\n\tMon, 30 Mar 2026 13:10:15 +0000 (UTC)", "from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com\n [148.163.158.5])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 891883D3CE5;\n\tMon, 30 Mar 2026 13:10:13 +0000 (UTC)", "from pps.filterd (m0360072.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 62TJKd4X4032815;\n\tMon, 30 Mar 2026 13:10:08 GMT", "from ppma12.dal12v.mail.ibm.com\n (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220])\n\tby mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4d66mrxhsj-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tMon, 30 Mar 2026 13:10:07 +0000 (GMT)", "from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1])\n\tby ppma12.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id\n 62U9VCDR021722;\n\tMon, 30 Mar 2026 13:10:06 GMT", "from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230])\n\tby ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 4d6sasd44t-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tMon, 30 Mar 2026 13:10:06 +0000", "from smtpav05.fra02v.mail.ibm.com (smtpav05.fra02v.mail.ibm.com\n [10.20.54.104])\n\tby smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 62UDA35O25952556\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n\tMon, 30 Mar 2026 13:10:03 GMT", "from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id E6DB72004B;\n\tMon, 30 Mar 2026 13:10:02 +0000 (GMT)", "from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id AA60B2004E;\n\tMon, 30 Mar 2026 13:10:02 +0000 (GMT)", "from tuxmaker.boeblingen.de.ibm.com (unknown [9.87.85.9])\n\tby smtpav05.fra02v.mail.ibm.com (Postfix) with ESMTP;\n\tMon, 30 Mar 2026 13:10:02 +0000 (GMT)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774876215; cv=none;\n b=XYx3dCy/UKIQBr8Lk3OZgy9DPtqRp4EzOhqMbwYDPSY43+jN/68DOva22aCdCY+ObSI6g8smyqIAZaldNn/OTtHa3UFoewZbUr41jNnYrapcJkx0TfPaG7phyBnd1Ngoyt+QvzTKF+y72D0DfgpDxKqGhTTpU1vJuIo2A8jT4Jo=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774876215; c=relaxed/simple;\n\tbh=pEzu946U0T2iItoXe0YjWLg8MJNt4vqOxymBFtXMGZs=;\n\th=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References:\n\t In-Reply-To:To:Cc;\n b=hL8H9ewn2F3m471xZrfYH+rY4qeVice7sgrlJeIzlbFomWkrIV7b+OhzwuabKisILWcE6eHJgzjnfiOe7qLrlint8f5W1cITPlD3R0+eznNOG+Qm3uOcL4UMlao4BtIzpBUufyFo/DgagWfbhbvqLvvR/PFEm+8M9tFoTuyg/28=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com;\n spf=pass smtp.mailfrom=linux.ibm.com;\n dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com\n header.b=aIoIb2ae; arc=none smtp.client-ip=148.163.158.5", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n\t:content-transfer-encoding:content-type:date:from:in-reply-to\n\t:message-id:mime-version:references:subject:to; s=pp1; bh=2qsAr6\n\tzDUNL29w2hCtlM13yliWWfgwr21psCtOIf3VQ=; b=aIoIb2aebt9HopI3FdM6O0\n\tFvpmXtoQklRYT6NxvLWNpXbNSvVMKbfhB3duSWxWS/nRHM04em5fGuB6oHq/01Ad\n\tXejgG0nlGCJJf3+ODmFC8RZC14nJSl1mPbhihVOdL1rJW3+ghVRdNlyS+0ty+bI3\n\tF7TYivq5EHNsaxf2Dfkllhij1xf/BWk1lDxdO2s//v/lnTRGRNoCq5WTaUTRR/MZ\n\tyOZS4DMGXIO0w+hipaOepaXgLfol3BEvsrQ3iMWGPnVTwG606geS8If1fVsnAUfC\n\tGWa3J5lxWUfzJkHFoZ8Qay1xIzb05Ceh7Ch+2GKAj2JCnFmEvWRYofqxC0h3h5bQ\n\t==", "From": "Gerd Bayer <gbayer@linux.ibm.com>", "Date": "Mon, 30 Mar 2026 15:09:45 +0200", "Subject": "[PATCH v7 2/3] PCI: AtomicOps: Do not enable without support in\n root port", "Precedence": "bulk", "X-Mailing-List": "linux-pci@vger.kernel.org", "List-Id": "<linux-pci.vger.kernel.org>", "List-Subscribe": "<mailto:linux-pci+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-pci+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20260330-fix_pciatops-v7-2-f601818417e8@linux.ibm.com>", "References": "<20260330-fix_pciatops-v7-0-f601818417e8@linux.ibm.com>", "In-Reply-To": "<20260330-fix_pciatops-v7-0-f601818417e8@linux.ibm.com>", "To": "Bjorn Helgaas <bhelgaas@google.com>, Jay Cornwall <Jay.Cornwall@amd.com>,\n Felix Kuehling <Felix.Kuehling@amd.com>,\n =?utf-8?q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,\n Christian Borntraeger <borntraeger@linux.ibm.com>,\n Niklas Schnelle <schnelle@linux.ibm.com>", "Cc": "Gerald Schaefer <gerald.schaefer@linux.ibm.com>,\n Heiko Carstens <hca@linux.ibm.com>, Vasily Gorbik <gor@linux.ibm.com>,\n Alexander Gordeev <agordeev@linux.ibm.com>,\n Sven Schnelle <svens@linux.ibm.com>,\n Leon Romanovsky <leon@kernel.org>,\n Alexander Schmidt <alexs@linux.ibm.com>, linux-s390@vger.kernel.org,\n linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,\n netdev@vger.kernel.org, linux-rdma@vger.kernel.org,\n Gerd Bayer <gbayer@linux.ibm.com>, stable@vger.kernel.org", "X-Mailer": "b4 0.14.2", "X-TM-AS-GCONF": "00", "X-Proofpoint-Reinject": "loops=2 maxloops=12", "X-Authority-Analysis": "v=2.4 cv=J6enLQnS c=1 sm=1 tr=0 ts=69ca762f cx=c_pps\n a=bLidbwmWQ0KltjZqbj+ezA==:117 a=bLidbwmWQ0KltjZqbj+ezA==:17\n a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=RnoormkPH1_aCDwRdu11:22 a=RzCfie-kr_QcCd8fBx8p:22 a=VnNF1IyMAAAA:8\n a=VwQbUJbxAAAA:8 a=_mftJHerZaGdetTijZQA:9 a=QEXdDO2ut3YA:10", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwMzMwMDEwMCBTYWx0ZWRfX1mbUbnKn2x+v\n MHZwBxBfsyIcPD8VR2ULzTm2hS0Cz17WGF920ac5GzufgVv+NAHaLuUXXDPdHj5thVgyXdKbFRw\n Q0wlwVSScsHoTFabp6ndj2ViKtDmwX7T1QHOlSEjYY6XyfU123kdaAfTab+uRIjAAXwdMH0ea52\n ygIpEGQUaNkSM+Zubz/G9Uo+i7l+3ap7cJJg3Dv1E6ROdrpgQPjrRlHLvajVjCX8BNoXYMzrRDn\n pXjnZl1rkLf+eOQucEFfwBGHeBqwgYX2JeLt/W69bh5Zz//FHHQIm1B9a5g73EfJoLv0RaMbcZE\n BEES2gzETQV+Kl7KZihCux6juWrzWUqtubLkhJHEdCDmCu38elFHE7+4G9z6eB45h9PF2LNzB1q\n 9taUlqMJhV3erENURstKX0lCNj9aEyMihjAJl7A/1+xqVK5ubsWuAWpJmVdRgmWj6RTb52ET2op\n lADjQUE3LeM68FD8fjg==", "X-Proofpoint-GUID": "B_4ybmFZb-ydMJRx7ujbF-JVpktvhKZS", "X-Proofpoint-ORIG-GUID": "CXzppuWT8MI_Pcw6JBvY2DWShiLK31Zh", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-03-29_05,2026-03-28_01,2025-10-01_01", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n suspectscore=0 clxscore=1015 adultscore=0 priorityscore=1501 bulkscore=0\n phishscore=0 malwarescore=0 lowpriorityscore=0 spamscore=0 impostorscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603300100" }, "content": "When inspecting the config space of a Connect-X physical function in an\ns390 system after it was initialized by the mlx5_core device driver, we\nfound the function to be enabled to request AtomicOps despite the\nsystem's root-complex lacking support for completing them:\n\n1ed0:00:00.1 Ethernet controller: Mellanox Technologies MT2894 Family [ConnectX-6 Lx]\n\tSubsystem: Mellanox Technologies Device 0002\n [...]\n\tDevCtl2: Completion Timeout: 50us to 50ms, TimeoutDis-\n\t\t AtomicOpsCtl: ReqEn+\n\t\t IDOReq- IDOCompl- LTR- EmergencyPowerReductionReq-\n\t\t 10BitTagReq- OBFF Disabled, EETLPPrefixBlk-\n\nTurns out the device driver calls pci_enable_atomic_ops_to_root() which\ndefaulted to enable AtomicOps requests even if it had no information\nabout the root port that the PCIe device is attached to.\n\nChange the logic of pci_enable_atomic_ops_to_root() to fully traverse the\nPCIe tree upwards, check that the bridge devices support delivering\nAtomicOps transactions, and finally check that there is a root port at\nthe end that does support completing AtomicOps.\n\nReported-by: Alexander Schmidt <alexs@linux.ibm.com>\nCc: stable@vger.kernel.org\nFixes: 430a23689dea (\"PCI: Add pci_enable_atomic_ops_to_root()\")\nSigned-off-by: Gerd Bayer <gbayer@linux.ibm.com>\n---\n drivers/pci/pci.c | 39 ++++++++++++++++++++++-----------------\n 1 file changed, 22 insertions(+), 17 deletions(-)", "diff": "diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c\nindex 135e5b591df405e87e7f520a618d7e2ccba55ce1..57af00ecdc97086a32c063ff86f8a39087ad1f5e 100644\n--- a/drivers/pci/pci.c\n+++ b/drivers/pci/pci.c\n@@ -3660,6 +3660,14 @@ void pci_acs_init(struct pci_dev *dev)\n \tpci_disable_broken_acs_cap(dev);\n }\n \n+static bool pci_is_atomicops_capable_rp(struct pci_dev *dev, u32 cap, u32 cap_mask)\n+{\n+\tif (!dev || !(pci_pcie_type(dev) == PCI_EXP_TYPE_ROOT_PORT))\n+\t\treturn false;\n+\n+\treturn (cap & cap_mask) == cap_mask;\n+}\n+\n /**\n * pci_enable_atomic_ops_to_root - enable AtomicOp requests to root port\n * @dev: the PCI device\n@@ -3676,8 +3684,9 @@ void pci_acs_init(struct pci_dev *dev)\n int pci_enable_atomic_ops_to_root(struct pci_dev *dev, u32 cap_mask)\n {\n \tstruct pci_bus *bus = dev->bus;\n-\tstruct pci_dev *bridge;\n-\tu32 cap, ctl2;\n+\tstruct pci_dev *bridge = NULL;\n+\tu32 cap = 0;\n+\tu32 ctl2;\n \n \t/*\n \t * Per PCIe r5.0, sec 9.3.5.10, the AtomicOp Requester Enable bit\n@@ -3713,29 +3722,25 @@ int pci_enable_atomic_ops_to_root(struct pci_dev *dev, u32 cap_mask)\n \t\tswitch (pci_pcie_type(bridge)) {\n \t\t/* Ensure switch ports support AtomicOp routing */\n \t\tcase PCI_EXP_TYPE_UPSTREAM:\n-\t\tcase PCI_EXP_TYPE_DOWNSTREAM:\n-\t\t\tif (!(cap & PCI_EXP_DEVCAP2_ATOMIC_ROUTE))\n-\t\t\t\treturn -EINVAL;\n-\t\t\tbreak;\n-\n-\t\t/* Ensure root port supports all the sizes we care about */\n-\t\tcase PCI_EXP_TYPE_ROOT_PORT:\n-\t\t\tif ((cap & cap_mask) != cap_mask)\n-\t\t\t\treturn -EINVAL;\n-\t\t\tbreak;\n-\t\t}\n-\n-\t\t/* Ensure upstream ports don't block AtomicOps on egress */\n-\t\tif (pci_pcie_type(bridge) == PCI_EXP_TYPE_UPSTREAM) {\n+\t\t\t/* Upstream ports must not block AtomicOps on egress */\n \t\t\tpcie_capability_read_dword(bridge, PCI_EXP_DEVCTL2,\n \t\t\t\t\t\t &ctl2);\n \t\t\tif (ctl2 & PCI_EXP_DEVCTL2_ATOMIC_EGRESS_BLOCK)\n \t\t\t\treturn -EINVAL;\n+\t\t\tfallthrough;\n+\t\t/* All switch ports need to route AtomicOps */\n+\t\tcase PCI_EXP_TYPE_DOWNSTREAM:\n+\t\t\tif (!(cap & PCI_EXP_DEVCAP2_ATOMIC_ROUTE))\n+\t\t\t\treturn -EINVAL;\n+\t\t\tbreak;\n \t\t}\n-\n \t\tbus = bus->parent;\n \t}\n \n+\t/* Finally, last bridge must be root port and support requested sizes */\n+\tif (!(pci_is_atomicops_capable_rp(bridge, cap, cap_mask)))\n+\t\treturn -EINVAL;\n+\n \tpcie_capability_set_word(dev, PCI_EXP_DEVCTL2,\n \t\t\t\t PCI_EXP_DEVCTL2_ATOMIC_REQ);\n \treturn 0;\n", "prefixes": [ "v7", "2/3" ] }