Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2217741/?format=api
{ "id": 2217741, "url": "http://patchwork.ozlabs.org/api/patches/2217741/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-tegra/patch/20260330125200.820693-1-sebasjosue84@gmail.com/", "project": { "id": 21, "url": "http://patchwork.ozlabs.org/api/projects/21/?format=api", "name": "Linux Tegra Development", "link_name": "linux-tegra", "list_id": "linux-tegra.vger.kernel.org", "list_email": "linux-tegra@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260330125200.820693-1-sebasjosue84@gmail.com>", "list_archive_url": null, "date": "2026-03-30T12:52:00", "name": "[v3] staging: nvec: validate battery response length before memcpy", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "451f834e5c52b372b9b8fc2fb77d909abe69a754", "submitter": { "id": 92955, "url": "http://patchwork.ozlabs.org/api/people/92955/?format=api", "name": "Sebastián Alba Vives", "email": "sebasjosue84@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-tegra/patch/20260330125200.820693-1-sebasjosue84@gmail.com/mbox/", "series": [ { "id": 498026, "url": "http://patchwork.ozlabs.org/api/series/498026/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-tegra/list/?series=498026", "date": "2026-03-30T12:52:00", "name": "[v3] staging: nvec: validate battery response length before memcpy", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/498026/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2217741/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2217741/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-tegra+bounces-13417-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-tegra@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=QJ20CY/V;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=104.64.211.4; helo=sin.lore.kernel.org;\n envelope-from=linux-tegra+bounces-13417-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"QJ20CY/V\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.217.50", "smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com" ], "Received": [ "from sin.lore.kernel.org (sin.lore.kernel.org [104.64.211.4])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fkryL45kGz1y1q\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 31 Mar 2026 00:02:50 +1100 (AEDT)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id 4F4B53052D67\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 30 Mar 2026 12:52:20 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id EF3D03D0923;\n\tMon, 30 Mar 2026 12:52:19 +0000 (UTC)", "from mail-vs1-f50.google.com (mail-vs1-f50.google.com\n [209.85.217.50])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 10C303D1716\n\tfor <linux-tegra@vger.kernel.org>; Mon, 30 Mar 2026 12:52:17 +0000 (UTC)", "by mail-vs1-f50.google.com with SMTP id\n ada2fe7eead31-60328e74517so1327196137.1\n for <linux-tegra@vger.kernel.org>;\n Mon, 30 Mar 2026 05:52:17 -0700 (PDT)", "from localhost.localdomain ([2a09:bac6:d6da:aa::11:1d6])\n by smtp.gmail.com with ESMTPSA id\n a1e0cc1a2514c-9539e4420d9sm6888389241.8.2026.03.30.05.52.14\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 30 Mar 2026 05:52:15 -0700 (PDT)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774875139; cv=none;\n b=BlNz3QyxdKyzYdaPMRFNJBeC2fQ9aKD9ULPJ7+QvhU4Dc4+sW1bwD7+74PiAqZ0oB3Gr6ArUb3PpHiO79HqYB1VP9BHW13Lt1zqbc11WrGmmoUHkR+wB19zKABJth0JUOZItYTD62iz65BVklTzGhOuE8rJYx8Rz3pHjeHhVQQw=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774875139; c=relaxed/simple;\n\tbh=X0XeqVk1okPDExPdxveHKfJoDl26uOIaeLMRZyIoG0U=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type;\n b=hA2CddFRCTDz6ARhiRa0C9qs+uMxh90842FhKng+MQpDIu8rlIAsBp8UVvIHz48nVrcvZrxJst6oyjgX8NOe44o0Nut/RRIi7wNPkTKDiH9hdME/42R7ZkpWPtK0YYEnTkElDb+Rt9Fvpwn8FlCGa5uPniTaZ0Us4HVf/2UDcw0=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=QJ20CY/V; arc=none smtp.client-ip=209.85.217.50", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1774875137; x=1775479937;\n darn=vger.kernel.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=2T5sC1X4d4lvAdzHYW3GejS6hGTQduK0sRiN708dk4s=;\n b=QJ20CY/VupWwefOFzUflZGWD7YDVGN0rsW0a6JkR5HOAnCeXOqlbx7Ia7qZ42J5OiY\n z7FaZ/ZiDUAM53+CIjxKEprQlT0U9VocUzppHlBHyE7D9k9YcuuZuIixL2DKow9uzt7n\n rrG6lHOq7osTr3ITC4ORahVEVInVkn4+INIih0Sk/z0juCRmpU1Hjd5dE/IpR9hcFNDr\n fDaPVsCCqkyPLpLaR9320C0BATVMLpVCLfKONUANa8oWNz65GOp6/f8cjCCZhRlxKnAn\n f2bMgmA139VLFAeU5WqpiVJSltC1VKcM3n7WMxi8jdySXOOG5E+BA34XUEIjrnkAkrOO\n lZ7A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774875137; x=1775479937;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=2T5sC1X4d4lvAdzHYW3GejS6hGTQduK0sRiN708dk4s=;\n b=g7uh6syAmv09fC2FQVLGpGRw6BdNK0HaqRw221x+Rztg0Wk0tgrC4lEBJkyhOEgXsL\n 0wGXXm03lfblOZ/tbGsNTLudpWOfVU5uX2NIZ1swUiptLiXYA9kcExNhjsteGNi6cgtW\n mijj6pP1rM82oSQrUtOPKhECJJMPrTAQhcOKeVFej0iNQOE1MAoGqNCHtjm0Z6WmGMMR\n U6y+GXbmsw8WEA1HD4+XH7QGc38AoCU5i7rSzOxm9xOCGrWX7TFRZ94wsW37mSihT7W6\n yS/XCW8nCo7mEwEk+Mjbb9co8hQ5oLaPNDHAl1gIDdpGu2YP3Xuk6pclHb2B53RNf80t\n SVeQ==", "X-Forwarded-Encrypted": "i=1;\n AJvYcCWG3N7XAJbcst4OgieVHIYGao5dbmGDuKbmednfGETR0ZftWizUmgebpN2blmW8e7HOo2Vrbqs44bjB2Q==@vger.kernel.org", "X-Gm-Message-State": "AOJu0YycueSdcmLrKZEnzitFpmmf9QkbKQqHg0qeNrhNG/e8PRMK+jYh\n\tn9cwSASji5RHfHfDzjvUT2h4Qg2R7W/cOLkGdEKhy7kKO8n3loiPW87N1KISOS6tP58=", "X-Gm-Gg": "ATEYQzxp/yrBfxOvubUpiYmGIRRp5K7aRtrfdH7RzH5qo36x6zUjnAUNK1GeROZ72px\n\tVUArH+jM5XDC5mq+BujNAToxazIjufZimacIQbiZr0F830K52giLECNzfdrGiewoOpiQ+H/qpho\n\t+JZnhGalp8H+9IwrVjOQgU2rVCSh2hjPI2sgUCB/JtYa0WGBGghDSS+STZESWdEE34dw65HwCX+\n\twuSvsSNzAYKB8eNmN24mYGghPsDDjjyq4lILApzYyaBgxxNqBKiCcR4+fj/MKd2BoPVQCIn78GU\n\tEtVwL6f6pi27P4GK9IokFV7o2/1D04wJ4tC5vuNRCctWKveHI81rw/w80043d/0MAaDRbDrBZ92\n\t9/jg58pQuISrIPVgvwob7WhCPEmdyr1wiQyCPfGByDjGRtUj6FAaUd9icjSDkxxPZ6jSCTQLQgW\n\tvVExLSKIDp6/8qMBSg1bcSBPhK", "X-Received": "by 2002:a05:6102:26d5:b0:602:87b9:89ba with SMTP id\n ada2fe7eead31-604f925ae38mr3523377137.19.1774875136516;\n Mon, 30 Mar 2026 05:52:16 -0700 (PDT)", "From": "Sebastian Josue Alba Vives <sebasjosue84@gmail.com>", "To": "gregkh@linuxfoundation.org", "Cc": "marvin24@gmx.de, linux-staging@lists.linux.dev,\n linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,\n stable@vger.kernel.org,\n =?utf-8?q?Sebasti=C3=A1n_Alba_Vives?= <sebasjosue84@gmail.com>,\n kernel test robot <lkp@intel.com>", "Subject": "[PATCH v3] staging: nvec: validate battery response length before\n memcpy", "Date": "Mon, 30 Mar 2026 06:52:00 -0600", "Message-ID": "<20260330125200.820693-1-sebasjosue84@gmail.com>", "X-Mailer": "git-send-email 2.43.0", "Precedence": "bulk", "X-Mailing-List": "linux-tegra@vger.kernel.org", "List-Id": "<linux-tegra.vger.kernel.org>", "List-Subscribe": "<mailto:linux-tegra+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-tegra+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit" }, "content": "From: Sebastián Alba Vives <sebasjosue84@gmail.com>\n\nIn nvec_power_notifier(), the response length from the embedded\ncontroller is used directly as the size argument to memcpy() when\ncopying battery manufacturer, model, and type strings. The\ndestination buffers (bat_manu, bat_model, bat_type) are fixed at\n30 bytes, but res->length is a u8 that can be up to 255, allowing\na heap buffer overflow.\n\nAdditionally, if res->length is less than 2, the subtraction\nres->length - 2 wraps around as an unsigned value, resulting in a\nlarge copy that corrupts kernel heap memory.\n\nIntroduce NVEC_BAT_STRING_SIZE to replace the hardcoded buffer\nsize, store res->length - 2 in a local copy_len variable for\nclarity, and add bounds checks before each memcpy to ensure the\ncopy length does not exceed the destination buffer and that\nres->length is at least 2 to prevent unsigned integer underflow.\n\nReported-by: kernel test robot <lkp@intel.com>\nCloses: https://lore.kernel.org/oe-kbuild-all/202603301722.axpoITcy-lkp@intel.com/\nTested-by: Marc Dietrich <marvin24@gmx.de>\nCc: stable@vger.kernel.org\nSigned-off-by: Sebastián Alba Vives <sebasjosue84@gmail.com>\n---\nv3:\n - Fix build error: add missing closing brace for TYPE case\n compound statement (kernel test robot)\nv2:\n - Introduce NVEC_BAT_STRING_SIZE constant (Marc Dietrich)\n - Store res->length - 2 in local copy_len variable (Marc Dietrich)\n - Use NVEC_BAT_STRING_SIZE in strncmp call for consistency\n drivers/staging/nvec/nvec_power.c | 42 +++++++++++++++++++++----------\n 1 file changed, 29 insertions(+), 13 deletions(-)", "diff": "diff --git a/drivers/staging/nvec/nvec_power.c b/drivers/staging/nvec/nvec_power.c\nindex 2faab9fde..30719e142 100644\n--- a/drivers/staging/nvec/nvec_power.c\n+++ b/drivers/staging/nvec/nvec_power.c\n@@ -19,6 +19,7 @@\n #include \"nvec.h\"\n \n #define GET_SYSTEM_STATUS 0x00\n+#define NVEC_BAT_STRING_SIZE 30\n \n struct nvec_power {\n \tstruct notifier_block notifier;\n@@ -38,9 +39,9 @@ struct nvec_power {\n \tint bat_temperature;\n \tint bat_cap;\n \tint bat_type_enum;\n-\tchar bat_manu[30];\n-\tchar bat_model[30];\n-\tchar bat_type[30];\n+\tchar bat_manu[NVEC_BAT_STRING_SIZE];\n+\tchar bat_model[NVEC_BAT_STRING_SIZE];\n+\tchar bat_type[NVEC_BAT_STRING_SIZE];\n };\n \n enum {\n@@ -192,26 +193,41 @@ static int nvec_power_bat_notifier(struct notifier_block *nb,\n \tcase TEMPERATURE:\n \t\tpower->bat_temperature = res->plu - 2732;\n \t\tbreak;\n-\tcase MANUFACTURER:\n-\t\tmemcpy(power->bat_manu, &res->plc, res->length - 2);\n-\t\tpower->bat_manu[res->length - 2] = '\\0';\n+\tcase MANUFACTURER: {\n+\t\tsize_t copy_len = res->length - 2;\n+\n+\t\tif (res->length < 2 || copy_len > NVEC_BAT_STRING_SIZE - 1)\n+\t\t\tbreak;\n+\t\tmemcpy(power->bat_manu, &res->plc, copy_len);\n+\t\tpower->bat_manu[copy_len] = '\\0';\n \t\tbreak;\n-\tcase MODEL:\n-\t\tmemcpy(power->bat_model, &res->plc, res->length - 2);\n-\t\tpower->bat_model[res->length - 2] = '\\0';\n+\t}\n+\tcase MODEL: {\n+\t\tsize_t copy_len = res->length - 2;\n+\n+\t\tif (res->length < 2 || copy_len > NVEC_BAT_STRING_SIZE - 1)\n+\t\t\tbreak;\n+\t\tmemcpy(power->bat_model, &res->plc, copy_len);\n+\t\tpower->bat_model[copy_len] = '\\0';\n \t\tbreak;\n-\tcase TYPE:\n-\t\tmemcpy(power->bat_type, &res->plc, res->length - 2);\n-\t\tpower->bat_type[res->length - 2] = '\\0';\n+\t}\n+\tcase TYPE: {\n+\t\tsize_t copy_len = res->length - 2;\n+\n+\t\tif (res->length < 2 || copy_len > NVEC_BAT_STRING_SIZE - 1)\n+\t\t\tbreak;\n+\t\tmemcpy(power->bat_type, &res->plc, copy_len);\n+\t\tpower->bat_type[copy_len] = '\\0';\n \t\t/*\n \t\t * This differs a little from the spec fill in more if you find\n \t\t * some.\n \t\t */\n-\t\tif (!strncmp(power->bat_type, \"Li\", 30))\n+\t\tif (!strncmp(power->bat_type, \"Li\", NVEC_BAT_STRING_SIZE))\n \t\t\tpower->bat_type_enum = POWER_SUPPLY_TECHNOLOGY_LION;\n \t\telse\n \t\t\tpower->bat_type_enum = POWER_SUPPLY_TECHNOLOGY_UNKNOWN;\n \t\tbreak;\n+\t}\n \tdefault:\n \t\treturn NOTIFY_STOP;\n \t}\n", "prefixes": [ "v3" ] }