Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2217734/?format=api
{ "id": 2217734, "url": "http://patchwork.ozlabs.org/api/patches/2217734/?format=api", "web_url": "http://patchwork.ozlabs.org/project/glibc/patch/mvm7bqtiivh.fsf@suse.de/", "project": { "id": 41, "url": "http://patchwork.ozlabs.org/api/projects/41/?format=api", "name": "GNU C Library", "link_name": "glibc", "list_id": "libc-alpha.sourceware.org", "list_email": "libc-alpha@sourceware.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<mvm7bqtiivh.fsf@suse.de>", "list_archive_url": null, "date": "2026-03-30T12:47:46", "name": "Discard any push-back from a memory stream before finishing it (bug 34020)", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "c0b2e5e2d8ef659f300c0b6ea513e8df563b9d27", "submitter": { "id": 37, "url": "http://patchwork.ozlabs.org/api/people/37/?format=api", "name": "Andreas Schwab", "email": "schwab@suse.de" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/glibc/patch/mvm7bqtiivh.fsf@suse.de/mbox/", "series": [ { "id": 498023, "url": "http://patchwork.ozlabs.org/api/series/498023/?format=api", "web_url": "http://patchwork.ozlabs.org/project/glibc/list/?series=498023", "date": "2026-03-30T12:47:46", "name": "Discard any push-back from a memory stream before finishing it (bug 34020)", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/498023/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2217734/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2217734/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<libc-alpha-bounces~incoming=patchwork.ozlabs.org@sourceware.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "libc-alpha@sourceware.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "libc-alpha@sourceware.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=Smj8zkmi;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=jXhHYwaZ;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=Smj8zkmi;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=jXhHYwaZ;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=sourceware.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=libc-alpha-bounces~incoming=patchwork.ozlabs.org@sourceware.org;\n receiver=patchwork.ozlabs.org)", "sourceware.org;\n\tdkim=pass (1024-bit key,\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=Smj8zkmi;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=jXhHYwaZ;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=Smj8zkmi;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=jXhHYwaZ", "sourceware.org;\n dmarc=pass (p=none dis=none) header.from=suse.de", "sourceware.org; spf=pass smtp.mailfrom=suse.de", "server2.sourceware.org;\n arc=none smtp.remote-ip=195.135.223.130", "smtp-out1.suse.de;\n dkim=pass header.d=suse.de header.s=susede2_rsa header.b=Smj8zkmi;\n dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=jXhHYwaZ" ], "Received": [ "from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fkrdp68pDz1y1q\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 30 Mar 2026 23:48:30 +1100 (AEDT)", "from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 9FF574B92099\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 30 Mar 2026 12:48:28 +0000 (GMT)", "from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130])\n by sourceware.org (Postfix) with ESMTPS id 6C0494BA9001\n for <libc-alpha@sourceware.org>; Mon, 30 Mar 2026 12:47:48 +0000 (GMT)", "from hawking.suse.de (unknown\n [IPv6:2a07:de40:a101:3:92b1:1cff:fe69:ddc])\n by smtp-out1.suse.de (Postfix) with ESMTP id 432E94D5A7\n for <libc-alpha@sourceware.org>; Mon, 30 Mar 2026 12:47:47 +0000 (UTC)", "by hawking.suse.de (Postfix, from userid 17005)\n id F06644A04D9; Mon, 30 Mar 2026 14:47:46 +0200 (CEST)" ], "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 sourceware.org 9FF574B92099", "OpenDKIM Filter v2.11.0 sourceware.org 6C0494BA9001" ], "DMARC-Filter": "OpenDMARC Filter v1.4.2 sourceware.org 6C0494BA9001", "ARC-Filter": "OpenARC Filter v1.0.0 sourceware.org 6C0494BA9001", "ARC-Seal": "i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1774874868; cv=none;\n b=mdg5cX8r4Cbf2cW/xbuUIjIdUp2cLNe5QRgSBuG1uMOVuIbcheDH2S64h1gpm4XVS5VjgwdgGDxQmmMWCBk3ney269UIp+tfODOA1bvrwpwIPp9u9Ywe/2ABRCih5RdBockaKAkFql1nJ64t4vjqNaHYA7vdnudGl65NUYpzfog=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1774874868; c=relaxed/simple;\n bh=k3rSJuO+VQbK/kWE4WyDAPWevcyTmUYUFkUB0Ujjjf8=;\n h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From:\n To:Subject:Date:Message-ID:MIME-Version;\n b=Sw0E62Xu4hMuw4VuCD4Zp5vvXYnP4wNTbR93bz+bpdnWsNDmooYuH/tbTvgz58XLKLuwbnt170MGSg4od8Yetxdcw3oaxdUYqWCWp0fQIiWjuAT4XFHzmPlfvOdA4Vl91DtmbnF2sbLuJ6NtugRfoM/s9+ibVdICPY2mDGW1ocE=", "ARC-Authentication-Results": "i=1; server2.sourceware.org", "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1774874867; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:\n mime-version:mime-version:content-type:content-type;\n bh=u6TJHiS+Pk1v1dTdJdlwyXLcP0PHIVHFN8oV5O3D2Ew=;\n b=Smj8zkmikXwFMM5/LrcK40KqawVON5Ki4QdI9shQWPz5mh6Zoo0gJVwFOFekRSWykz+6sC\n CQ386o4O7a7U7gEv4lVnEU+t8bE7d6i35U8dVLCEpV8b1lPlp4dXoHSAMFee3bW7ObCBAe\n 1NdM0b8ukZ9ZCOxFkjpcIjNtH8GaegE=", "v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1774874867;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:\n mime-version:mime-version:content-type:content-type;\n bh=u6TJHiS+Pk1v1dTdJdlwyXLcP0PHIVHFN8oV5O3D2Ew=;\n b=jXhHYwaZujZEiz/T9wPdi7J3c3B1W3M3i4uq7OeZIwHx9+cXNS2riaqKGzcuDeJscSMtJY\n xupNx75pV8CzzjAQ==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1774874867; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:\n mime-version:mime-version:content-type:content-type;\n bh=u6TJHiS+Pk1v1dTdJdlwyXLcP0PHIVHFN8oV5O3D2Ew=;\n b=Smj8zkmikXwFMM5/LrcK40KqawVON5Ki4QdI9shQWPz5mh6Zoo0gJVwFOFekRSWykz+6sC\n CQ386o4O7a7U7gEv4lVnEU+t8bE7d6i35U8dVLCEpV8b1lPlp4dXoHSAMFee3bW7ObCBAe\n 1NdM0b8ukZ9ZCOxFkjpcIjNtH8GaegE=", "v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1774874867;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:\n mime-version:mime-version:content-type:content-type;\n bh=u6TJHiS+Pk1v1dTdJdlwyXLcP0PHIVHFN8oV5O3D2Ew=;\n b=jXhHYwaZujZEiz/T9wPdi7J3c3B1W3M3i4uq7OeZIwHx9+cXNS2riaqKGzcuDeJscSMtJY\n xupNx75pV8CzzjAQ==" ], "From": "Andreas Schwab <schwab@suse.de>", "To": "libc-alpha@sourceware.org", "Subject": "[PATCH] Discard any push-back from a memory stream before finishing\n it (bug 34020)", "Date": "Mon, 30 Mar 2026 14:47:46 +0200", "Message-ID": "<mvm7bqtiivh.fsf@suse.de>", "User-Agent": "Gnus/5.13 (Gnus v5.13)", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Spamd-Bar": "+++++++++++++++", "X-Rspamd-Queue-Id": "432E94D5A7", "X-Rspamd-Action": "add header", "X-Rspamd-Server": "rspamd1.dmz-prg2.suse.org", "X-Spamd-Result": "default: False [15.28 / 50.00]; SPAM_FLAG(5.00)[];\n NEURAL_SPAM_LONG(3.50)[1.000]; BAYES_HAM(-3.00)[100.00%];\n NEURAL_SPAM_SHORT(2.99)[0.995];\n HFILTER_HOSTNAME_UNKNOWN(2.50)[]; RDNS_NONE(2.00)[];\n ONCE_RECEIVED(1.20)[];\n HFILTER_HELO_IP_A(1.00)[hawking.suse.de];\n HFILTER_HELO_NORES_A_OR_MX(0.30)[hawking.suse.de];\n R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n MIME_GOOD(-0.10)[text/plain]; RCVD_NO_TLS_LAST(0.10)[];\n MX_GOOD(-0.01)[]; FROM_HAS_DN(0.00)[];\n DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n RCPT_COUNT_ONE(0.00)[1]; ARC_NA(0.00)[];\n DIRECT_TO_MX(0.00)[Gnus/5.13 (Gnus v5.13)];\n FUZZY_RATELIMITED(0.00)[rspamd.com];\n TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[];\n RCVD_COUNT_ONE(0.00)[1]; MID_RHS_MATCH_FROM(0.00)[];\n DNSWL_BLOCKED(0.00)[2a07:de40:a101:3:92b1:1cff:fe69:ddc:from];\n DKIM_TRACE(0.00)[suse.de:+]; MIME_TRACE(0.00)[0:+];\n TO_DN_NONE(0.00)[];\n DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid, suse.de:dkim, suse.de:email,\n sourceware.org:url]", "X-Spam": "Yes", "X-BeenThere": "libc-alpha@sourceware.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Libc-alpha mailing list <libc-alpha.sourceware.org>", "List-Unsubscribe": "<https://sourceware.org/mailman/options/libc-alpha>,\n <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>", "List-Archive": "<https://sourceware.org/pipermail/libc-alpha/>", "List-Post": "<mailto:libc-alpha@sourceware.org>", "List-Help": "<mailto:libc-alpha-request@sourceware.org?subject=help>", "List-Subscribe": "<https://sourceware.org/mailman/listinfo/libc-alpha>,\n <mailto:libc-alpha-request@sourceware.org?subject=subscribe>", "Errors-To": "libc-alpha-bounces~incoming=patchwork.ozlabs.org@sourceware.org" }, "content": "This makes sure that the write base is pointing to the main area, not the\nbackup area.\n---\nThe wide char test requires\nhttps://patchwork.sourceware.org/project/glibc/patch/20260323171742.1039768-1-marocketbd@gmail.com/\nto pass.\n---\n libio/Makefile | 2 +\n libio/memstream.c | 3 ++\n libio/tst-memstream.h | 4 ++\n libio/tst-memstream6.c | 81 +++++++++++++++++++++++++++++++++++++++++\n libio/tst-wmemstream6.c | 20 ++++++++++\n libio/wmemstream.c | 3 ++\n 6 files changed, 113 insertions(+)\n create mode 100644 libio/tst-memstream6.c\n create mode 100644 libio/tst-wmemstream6.c", "diff": "diff --git a/libio/Makefile b/libio/Makefile\nindex da838cdecc..4582291b24 100644\n--- a/libio/Makefile\n+++ b/libio/Makefile\n@@ -121,6 +121,7 @@ tests = \\\n tst-memstream2 \\\n tst-memstream3 \\\n tst-memstream4 \\\n+ tst-memstream6 \\\n tst-mmap-eofsync \\\n tst-mmap-fflushsync \\\n tst-mmap-offend \\\n@@ -144,6 +145,7 @@ tests = \\\n tst-wmemstream3 \\\n tst-wmemstream4 \\\n tst-wmemstream5 \\\n+ tst-wmemstream6 \\\n tst_getwc \\\n tst_putwc \\\n tst_swprintf \\\ndiff --git a/libio/memstream.c b/libio/memstream.c\nindex 0456adb92f..fcc925df87 100644\n--- a/libio/memstream.c\n+++ b/libio/memstream.c\n@@ -100,6 +100,9 @@ _IO_mem_finish (FILE *fp, int dummy)\n {\n struct _IO_FILE_memstream *mp = (struct _IO_FILE_memstream *) fp;\n \n+ if (_IO_in_backup (fp))\n+ _IO_switch_to_main_get_area (fp);\n+\n *mp->bufloc = (char *) realloc (fp->_IO_write_base,\n \t\t\t\t fp->_IO_write_ptr - fp->_IO_write_base + 1);\n if (*mp->bufloc != NULL)\ndiff --git a/libio/tst-memstream.h b/libio/tst-memstream.h\nindex b420e32e66..581cfd2cc3 100644\n--- a/libio/tst-memstream.h\n+++ b/libio/tst-memstream.h\n@@ -50,6 +50,8 @@ fwwrite (const void *ptr, size_t size, size_t nmemb, FILE *arq)\n # define FWRITE fwwrite\n # define FPUTC fputwc\n # define FPUTS fputws\n+# define FGETC fgetwc\n+# define UNGETC\tungetwc\n # define STRCMP wcscmp\n # define STRLEN wcslen\n #else\n@@ -60,6 +62,8 @@ fwwrite (const void *ptr, size_t size, size_t nmemb, FILE *arq)\n # define FWRITE fwrite\n # define FPUTC fputc\n # define FPUTS fputs\n+# define FGETC fgetc\n+# define UNGETC\tungetc\n # define STRCMP strcmp\n # define STRLEN strlen\n #endif\ndiff --git a/libio/tst-memstream6.c b/libio/tst-memstream6.c\nnew file mode 100644\nindex 0000000000..128e733b98\n--- /dev/null\n+++ b/libio/tst-memstream6.c\n@@ -0,0 +1,81 @@\n+/* Test for open_memstream BZ #34020.\n+ Copyright (C) 2018-2026 Free Software Foundation, Inc.\n+ This file is part of the GNU C Library.\n+\n+ The GNU C Library is free software; you can redistribute it and/or\n+ modify it under the terms of the GNU Lesser General Public\n+ License as published by the Free Software Foundation; either\n+ version 2.1 of the License, or (at your option) any later version.\n+\n+ The GNU C Library is distributed in the hope that it will be useful,\n+ but WITHOUT ANY WARRANTY; without even the implied warranty of\n+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU\n+ Lesser General Public License for more details.\n+\n+ You should have received a copy of the GNU Lesser General Public\n+ License along with the GNU C Library; if not, see\n+ <https://www.gnu.org/licenses/>. */\n+\n+#include \"tst-memstream.h\"\n+\n+static void\n+mcheck_abort (enum mcheck_status ev)\n+{\n+ printf (\"mecheck failed with status %d\\n\", (int) ev);\n+ exit (1);\n+}\n+\n+\n+void\n+do_test_ungetc_1 (void)\n+{\n+ CHAR_T *buf;\n+ size_t size;\n+\n+ FILE *fp = OPEN_MEMSTREAM (&buf, &size);\n+ TEST_VERIFY_EXIT (fp != NULL);\n+\n+ FPUTC (W('A'), fp);\n+ fflush (fp);\n+\n+ TEST_COMPARE (FGETC (fp), W('A'));\n+ TEST_COMPARE (UNGETC (W('B'), fp), W('B'));\n+\n+ TEST_COMPARE (fclose (fp), 0);\n+\n+ TEST_COMPARE (buf[0], W('A'));\n+\n+ free (buf);\n+}\n+\n+\n+void\n+do_test_ungetc_2 (void)\n+{\n+ CHAR_T *buf;\n+ size_t size;\n+\n+ FILE *fp = OPEN_MEMSTREAM (&buf, &size);\n+ TEST_VERIFY_EXIT (fp != NULL);\n+\n+ TEST_COMPARE (UNGETC (W('A'), fp), W('A'));\n+\n+ TEST_COMPARE (fclose (fp), 0);\n+\n+ TEST_COMPARE (buf[0], 0);\n+\n+ free (buf);\n+}\n+\n+static int\n+do_test (void)\n+{\n+ mcheck_pedantic (mcheck_abort);\n+\n+ do_test_ungetc_1 ();\n+ do_test_ungetc_2 ();\n+\n+ return 0;\n+}\n+\n+#include <support/test-driver.c>\ndiff --git a/libio/tst-wmemstream6.c b/libio/tst-wmemstream6.c\nnew file mode 100644\nindex 0000000000..23c50197cf\n--- /dev/null\n+++ b/libio/tst-wmemstream6.c\n@@ -0,0 +1,20 @@\n+/* Test for open_wmemstream BZ #34020.\n+ Copyright (C) 2026 Free Software Foundation, Inc.\n+ This file is part of the GNU C Library.\n+\n+ The GNU C Library is free software; you can redistribute it and/or\n+ modify it under the terms of the GNU Lesser General Public\n+ License as published by the Free Software Foundation; either\n+ version 2.1 of the License, or (at your option) any later version.\n+\n+ The GNU C Library is distributed in the hope that it will be useful,\n+ but WITHOUT ANY WARRANTY; without even the implied warranty of\n+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU\n+ Lesser General Public License for more details.\n+\n+ You should have received a copy of the GNU Lesser General Public\n+ License along with the GNU C Library; if not, see\n+ <https://www.gnu.org/licenses/>. */\n+\n+#define TEST_WCHAR\n+#include <libio/tst-memstream6.c>\ndiff --git a/libio/wmemstream.c b/libio/wmemstream.c\nindex d0c639be70..a0c61a627f 100644\n--- a/libio/wmemstream.c\n+++ b/libio/wmemstream.c\n@@ -101,6 +101,9 @@ _IO_wmem_finish (FILE *fp, int dummy)\n {\n struct _IO_FILE_wmemstream *mp = (struct _IO_FILE_wmemstream *) fp;\n \n+ if (_IO_in_backup (fp))\n+ _IO_switch_to_main_wget_area (fp);\n+\n *mp->bufloc = (wchar_t *) realloc (fp->_wide_data->_IO_write_base,\n \t\t\t\t (fp->_wide_data->_IO_write_ptr\n \t\t\t\t - fp->_wide_data->_IO_write_base + 1)\n", "prefixes": [] }