Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2217720/?format=api
{ "id": 2217720, "url": "http://patchwork.ozlabs.org/api/patches/2217720/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260330121638.10642-1-fw@strlen.de/", "project": { "id": 26, "url": "http://patchwork.ozlabs.org/api/projects/26/?format=api", "name": "Netfilter Development", "link_name": "netfilter-devel", "list_id": "netfilter-devel.vger.kernel.org", "list_email": "netfilter-devel@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260330121638.10642-1-fw@strlen.de>", "list_archive_url": null, "date": "2026-03-30T12:16:34", "name": "[nf] netfilter: ipset: use nla_strcmp for IPSET_ATTR_NAME attr", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "daa08902df39ba0a02ac39c5e5827eb41284dee2", "submitter": { "id": 1025, "url": "http://patchwork.ozlabs.org/api/people/1025/?format=api", "name": "Florian Westphal", "email": "fw@strlen.de" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260330121638.10642-1-fw@strlen.de/mbox/", "series": [ { "id": 498016, "url": "http://patchwork.ozlabs.org/api/series/498016/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netfilter-devel/list/?series=498016", "date": "2026-03-30T12:16:34", "name": "[nf] netfilter: ipset: use nla_strcmp for IPSET_ATTR_NAME attr", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/498016/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2217720/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2217720/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <netfilter-devel+bounces-11493-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "netfilter-devel@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-11493-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=91.216.245.30", "smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=strlen.de", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=Chamillionaire.breakpoint.cc" ], "Received": [ "from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fkr2v4X39z1xrn\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 30 Mar 2026 23:21:43 +1100 (AEDT)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 38CD5302305D\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 30 Mar 2026 12:16:56 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id AF8053C3BE4;\n\tMon, 30 Mar 2026 12:16:54 +0000 (UTC)", "from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc\n [91.216.245.30])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id C7CEA3002A9\n\tfor <netfilter-devel@vger.kernel.org>; Mon, 30 Mar 2026 12:16:52 +0000 (UTC)", "by Chamillionaire.breakpoint.cc (Postfix, from userid 1003)\n\tid 448CF60A55; Mon, 30 Mar 2026 14:16:44 +0200 (CEST)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774873014; cv=none;\n b=bDttDUtDIiyRzJ6OQJ4xOcSqP84WVb2CLCiysCXutyA05EqldxB2rUO2/0KAqN/0so45z0TuX6+k11VD2jjLZyVvnLYbrnATSwAu99hukEJXTjbNLgSXHQpRf4M272DGmuIP2o5HiUjV8JCI5sjbZOiYpTGZumYSJ8z1r/llZmQ=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774873014; c=relaxed/simple;\n\tbh=FSb+oVJ4eoWERg3+9if1GJVzTyOL/8x9QK+Vx7sTneQ=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=a8ZP8MxLICtIfoRjY1ECCXtZbkq20y4emrOeM+CFYxn/D9H7upjpByNIZTVGzsGJmTIUuYfHqg01HqZOImHkhOM1OpUu8tHGnjkZ5gHuAx0Uc+TxlGYtZnTASEsl69A/SNFN2Z9iCg7pJ1YQA/liNav2wJDCRRmToHQsNDlDgec=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=strlen.de;\n spf=pass smtp.mailfrom=Chamillionaire.breakpoint.cc;\n arc=none smtp.client-ip=91.216.245.30", "From": "Florian Westphal <fw@strlen.de>", "To": "kadlec@netfilter.org", "Cc": "<netfilter-devel@vger.kernel.org>,\n\tFlorian Westphal <fw@strlen.de>", "Subject": "[PATCH nf] netfilter: ipset: use nla_strcmp for IPSET_ATTR_NAME attr", "Date": "Mon, 30 Mar 2026 14:16:34 +0200", "Message-ID": "<20260330121638.10642-1-fw@strlen.de>", "X-Mailer": "git-send-email 2.52.0", "Precedence": "bulk", "X-Mailing-List": "netfilter-devel@vger.kernel.org", "List-Id": "<netfilter-devel.vger.kernel.org>", "List-Subscribe": "<mailto:netfilter-devel+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:netfilter-devel+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit" }, "content": "IPSET_ATTR_NAME and IPSET_ATTR_NAMEREF are of NLA_STRING type, they\ncannot be treated like a c-string.\n\nThey either have to be switched to NLA_NUL_STRING, or the compare\noperations need to use the nla functions.\n\nFixes: f830837f0eed (\"netfilter: ipset: list:set set type support\")\nSigned-off-by: Florian Westphal <fw@strlen.de>\n---\n include/linux/netfilter/ipset/ip_set.h | 2 +-\n net/netfilter/ipset/ip_set_core.c | 4 ++--\n net/netfilter/ipset/ip_set_list_set.c | 4 ++--\n 3 files changed, 5 insertions(+), 5 deletions(-)", "diff": "diff --git a/include/linux/netfilter/ipset/ip_set.h b/include/linux/netfilter/ipset/ip_set.h\nindex e9f4f845d760..b98331572ad2 100644\n--- a/include/linux/netfilter/ipset/ip_set.h\n+++ b/include/linux/netfilter/ipset/ip_set.h\n@@ -309,7 +309,7 @@ enum {\n \n /* register and unregister set references */\n extern ip_set_id_t ip_set_get_byname(struct net *net,\n-\t\t\t\t const char *name, struct ip_set **set);\n+\t\t\t\t const struct nlattr *name, struct ip_set **set);\n extern void ip_set_put_byindex(struct net *net, ip_set_id_t index);\n extern void ip_set_name_byindex(struct net *net, ip_set_id_t index, char *name);\n extern ip_set_id_t ip_set_nfnl_get_byindex(struct net *net, ip_set_id_t index);\ndiff --git a/net/netfilter/ipset/ip_set_core.c b/net/netfilter/ipset/ip_set_core.c\nindex 2cc04da95afd..e6a8b3acc556 100644\n--- a/net/netfilter/ipset/ip_set_core.c\n+++ b/net/netfilter/ipset/ip_set_core.c\n@@ -821,7 +821,7 @@ EXPORT_SYMBOL_GPL(ip_set_del);\n *\n */\n ip_set_id_t\n-ip_set_get_byname(struct net *net, const char *name, struct ip_set **set)\n+ip_set_get_byname(struct net *net, const struct nlattr *name, struct ip_set **set)\n {\n \tip_set_id_t i, index = IPSET_INVALID_ID;\n \tstruct ip_set *s;\n@@ -830,7 +830,7 @@ ip_set_get_byname(struct net *net, const char *name, struct ip_set **set)\n \trcu_read_lock();\n \tfor (i = 0; i < inst->ip_set_max; i++) {\n \t\ts = rcu_dereference(inst->ip_set_list)[i];\n-\t\tif (s && STRNCMP(s->name, name)) {\n+\t\tif (s && nla_strcmp(name, s->name) == 0) {\n \t\t\t__ip_set_get(s);\n \t\t\tindex = i;\n \t\t\t*set = s;\ndiff --git a/net/netfilter/ipset/ip_set_list_set.c b/net/netfilter/ipset/ip_set_list_set.c\nindex 98b91b34c314..1cef84f15e8c 100644\n--- a/net/netfilter/ipset/ip_set_list_set.c\n+++ b/net/netfilter/ipset/ip_set_list_set.c\n@@ -367,7 +367,7 @@ list_set_uadt(struct ip_set *set, struct nlattr *tb[],\n \tret = ip_set_get_extensions(set, tb, &ext);\n \tif (ret)\n \t\treturn ret;\n-\te.id = ip_set_get_byname(map->net, nla_data(tb[IPSET_ATTR_NAME]), &s);\n+\te.id = ip_set_get_byname(map->net, tb[IPSET_ATTR_NAME], &s);\n \tif (e.id == IPSET_INVALID_ID)\n \t\treturn -IPSET_ERR_NAME;\n \t/* \"Loop detection\" */\n@@ -389,7 +389,7 @@ list_set_uadt(struct ip_set *set, struct nlattr *tb[],\n \n \tif (tb[IPSET_ATTR_NAMEREF]) {\n \t\te.refid = ip_set_get_byname(map->net,\n-\t\t\t\t\t nla_data(tb[IPSET_ATTR_NAMEREF]),\n+\t\t\t\t\t tb[IPSET_ATTR_NAMEREF],\n \t\t\t\t\t &s);\n \t\tif (e.refid == IPSET_INVALID_ID) {\n \t\t\tret = -IPSET_ERR_NAMEREF;\n", "prefixes": [ "nf" ] }