Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2217715/?format=api
{ "id": 2217715, "url": "http://patchwork.ozlabs.org/api/patches/2217715/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/patch/acpn1XntsMs040St@tucnak/", "project": { "id": 17, "url": "http://patchwork.ozlabs.org/api/projects/17/?format=api", "name": "GNU Compiler Collection", "link_name": "gcc", "list_id": "gcc-patches.gcc.gnu.org", "list_email": "gcc-patches@gcc.gnu.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<acpn1XntsMs040St@tucnak>", "list_archive_url": null, "date": "2026-03-30T12:08:53", "name": "c++: Fix up eval_data_member_spec", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "5a10ebc120d7b75448264ef3b0f90309c028fb27", "submitter": { "id": 671, "url": "http://patchwork.ozlabs.org/api/people/671/?format=api", "name": "Jakub Jelinek", "email": "jakub@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/gcc/patch/acpn1XntsMs040St@tucnak/mbox/", "series": [ { "id": 498011, "url": "http://patchwork.ozlabs.org/api/series/498011/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/list/?series=498011", "date": "2026-03-30T12:08:53", "name": "c++: Fix up eval_data_member_spec", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/498011/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2217715/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2217715/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=Dhm9u1xV;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)", "sourceware.org;\n\tdkim=pass (1024-bit key,\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=Dhm9u1xV", "sourceware.org; dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com", "sourceware.org; spf=pass smtp.mailfrom=redhat.com", "server2.sourceware.org;\n arc=none smtp.remote-ip=170.10.129.124" ], "Received": [ "from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fkqmr4BXHz1xrn\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 30 Mar 2026 23:09:32 +1100 (AEDT)", "from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 42C434BA23C1\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 30 Mar 2026 12:09:30 +0000 (GMT)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by sourceware.org (Postfix) with ESMTP id 25A804BA2E26\n for <gcc-patches@gcc.gnu.org>; Mon, 30 Mar 2026 12:09:00 +0000 (GMT)", "from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-397-oNP8WEpENvCudAGKukQlCw-1; Mon,\n 30 Mar 2026 08:08:58 -0400", "from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 9A9A81800464\n for <gcc-patches@gcc.gnu.org>; Mon, 30 Mar 2026 12:08:57 +0000 (UTC)", "from tucnak.zalov.cz (unknown [10.44.32.9])\n by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with\n ESMTPS\n id C42E219560B1; Mon, 30 Mar 2026 12:08:56 +0000 (UTC)", "from tucnak.zalov.cz (localhost [127.0.0.1])\n by tucnak.zalov.cz (8.18.1/8.18.1) with ESMTPS id 62UC8rFM534047\n (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT);\n Mon, 30 Mar 2026 14:08:54 +0200", "(from jakub@localhost)\n by tucnak.zalov.cz (8.18.1/8.18.1/Submit) id 62UC8rBB534046;\n Mon, 30 Mar 2026 14:08:53 +0200" ], "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 sourceware.org 42C434BA23C1", "OpenDKIM Filter v2.11.0 sourceware.org 25A804BA2E26" ], "DMARC-Filter": "OpenDMARC Filter v1.4.2 sourceware.org 25A804BA2E26", "ARC-Filter": "OpenARC Filter v1.0.0 sourceware.org 25A804BA2E26", "ARC-Seal": "i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1774872540; cv=none;\n b=MyXhmroYkBdYUSA+Nqhhp8Z/DU00U5OEjzRJ3WYEH1VMCzmF8n3eg/zVJFx788C5zEK/NzAL73NQkw618aI2lAr0a+vMTDEbtrNwa2ziVGxWDi7Q3+88dB27wCBr4USaJccQtqHZgnkHdlbb4y4C4TmfpNfdXbJUD103K9W2KH4=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1774872540; c=relaxed/simple;\n bh=0yoWX81E2IM8cv7KAzPdyFA30dFjVh1l1GllGsDGyo8=;\n h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version;\n b=ZlcoHNgAX8OnLqJbAX8Eup2z33IoYau5Et2VKZuL+MRDq3x1WuyerpUJonB6/mNGqh6KCfr+Nk2TNyBsYSSEYo6jOVywSkp0moy3nbPpQ4QHvyTeH1QJZVJrry5haV7SxXuHw2G9VkKkAjhUWMlrGZcUgoYzWgMe2f+Kcsp8ugg=", "ARC-Authentication-Results": "i=1; server2.sourceware.org", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1774872539;\n h=from:from:reply-to:reply-to:subject:subject:date:date:\n message-id:message-id:to:to:cc:cc:mime-version:mime-version:\n content-type:content-type; bh=XenDv6yYsuwCPow4UbEeghbWIWPXUFB4Ob1pLk9mTF8=;\n b=Dhm9u1xVveCzth1ouvmnotbxoTlBVemzk0ju/Ky07NMoU3n7Jw8fsF9tiTOwd6CHDixHgw\n OCygQKJMqwJlHZJK1DhcRug670FUkVgrPg7dK2Bo+FdqCS3LSl9XxSt3Ckvju/N8c4l/4R\n R3WC/71zdYsxghy1Au8M1/K7HzPuEAI=", "X-MC-Unique": "oNP8WEpENvCudAGKukQlCw-1", "X-Mimecast-MFC-AGG-ID": "oNP8WEpENvCudAGKukQlCw_1774872537", "Date": "Mon, 30 Mar 2026 14:08:53 +0200", "From": "Jakub Jelinek <jakub@redhat.com>", "To": "Jason Merrill <jason@redhat.com>, Marek Polacek <polacek@redhat.com>", "Cc": "gcc-patches@gcc.gnu.org", "Subject": "[PATCH] c++: Fix up eval_data_member_spec", "Message-ID": "<acpn1XntsMs040St@tucnak>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.12", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "9LK7AWGLc0pbFFok9ImC3qWbF6FtUjYO8TgKgNS1a44_1774872537", "X-Mimecast-Originator": "redhat.com", "Content-Type": "text/plain; charset=us-ascii", "Content-Disposition": "inline", "X-BeenThere": "gcc-patches@gcc.gnu.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Gcc-patches mailing list <gcc-patches.gcc.gnu.org>", "List-Unsubscribe": "<https://gcc.gnu.org/mailman/options/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>", "List-Archive": "<https://gcc.gnu.org/pipermail/gcc-patches/>", "List-Post": "<mailto:gcc-patches@gcc.gnu.org>", "List-Help": "<mailto:gcc-patches-request@gcc.gnu.org?subject=help>", "List-Subscribe": "<https://gcc.gnu.org/mailman/listinfo/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>", "Reply-To": "Jakub Jelinek <jakub@redhat.com>", "Errors-To": "gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org" }, "content": "Hi!\n\nIvan Lazaric reported privately a bug in eval_data_member_spec,\nwhich I think can't be easily tested.\n\nThis is preceded by\n if (!cpp_translate_string (parse_in, &istr, &ostr,\n j == 2 ? CPP_STRING : CPP_UTF8STRING,\n true))\nso for j == 2 it does reverse conversion from -fnarrow-character-set= to\nSOURCE_CHARSET (typically UTF-8) and otherwise (j == 1) from\nUTF-8 to SOURCE_CHARSET, but the messages of exceptions were reversed.\n\nNow, unless SOURCE_CHARSET is UTF-EBCDIC on s390x-tpf (dunno if that works\nat all, but in theory could) and there is some character only in UTF-8 and\nnot in UTF-EBCDIC, or there is some narrow character set supported by iconv\nwhich has characters not represented in UTF-8 (am not aware of those),\nthen cpp_translate_string shouldn't fail, so the code in there is just\nfor a theoretical case.\n\nOk for trunk?\n\n2026-03-30 Jakub Jelinek <jakub@redhat.com>\n\n\t* reflect.cc (eval_data_member_spec): Fix up check for diagnostics\n\twhen reverse conversion fails.\n\n\n\tJakub", "diff": "--- gcc/cp/reflect.cc.jj\t2026-03-30 12:57:50.288580938 +0200\n+++ gcc/cp/reflect.cc\t2026-03-30 13:15:35.847428373 +0200\n@@ -5799,7 +5799,7 @@ eval_data_member_spec (location_t loc, c\n \t {\n \t if (len >= 64)\n \t\tXDELETEVEC (namep);\n-\t if (j == 1)\n+\t if (j == 2)\n \t\treturn throw_exception (loc, ctx,\n \t\t\t\t\t\"conversion from ordinary literal \"\n \t\t\t\t\t\"encoding to source charset \"\n", "prefixes": [] }